Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Tao Zhou]

That's great!

Thanks!
Tao

On Mon, Jan 28, 2013 at 5:13 PM, Christian Hammond wrote:

> Okay. It's not related to the issue manager, but I suspect I know what's
> causing it. It was a change that fixed a security problem, but apparently
> caused another bug when using \ in filenames.
>
> We just did a 1.7.3 release, which didn't include a fix for this, but I'll
> try to get you a patch soon once I've done some testing, and see about
> doing another release.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
>
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Mon, Jan 28, 2013 at 12:29 AM, Tao Zhou  wrote:
>
>> Below is the error I got from Chrome, if need any further information,
>> plz tell me how to, Thanks!
>>
>> Uncaught SyntaxError: Unexpected token ILLEGAL 
>> 172.21.78.85:856
>>  isshow:false loader.js:14
>>
>>1. Uncaught SyntaxError: Unexpected token ILLEGAL
>>
>>
>> 

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Christian Hammond]

Okay. It's not related to the issue manager, but I suspect I know what's
causing it. It was a change that fixed a security problem, but apparently
caused another bug when using \ in filenames.

We just did a 1.7.3 release, which didn't include a fix for this, but I'll
try to get you a patch soon once I've done some testing, and see about
doing another release.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Jan 28, 2013 at 12:29 AM, Tao Zhou  wrote:

> Below is the error I got from Chrome, if need any further information, plz
> tell me how to, Thanks!
>
> Uncaught SyntaxError: Unexpected token ILLEGAL 
> 172.21.78.85:856
>  isshow:false loader.js:14
>
>1. Uncaught SyntaxError: Unexpected token ILLEGAL
>
>
> 

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Tao Zhou]

Below is the error I got from Chrome, if need any further information, plz 
tell me how to, Thanks!

Uncaught SyntaxError: Unexpected token ILLEGAL 
172.21.78.85:856
isshow:false 
loader.js:14

   1. Uncaught SyntaxError: Unexpected token ILLEGAL 

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Tao Zhou]

New to reviewboard, I am not quite familiar with the system and bug fix 
process,

I have submitted a codereview: http://reviews.reviewboard.org/r/3804/

Regards,
Tao

On Sunday, January 27, 2013 4:29:26 AM UTC+8, Christian Hammond wrote:
>
> Hi Tao,
>
> Can you post the fix up on http://reviews.reviewboard.org? All patches 
> must go through a review process there.
>
> Thanks!
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Sat, Jan 26, 2013 at 5:41 AM, Tao Zhou  >wrote:
>
>> Hi, Christian:
>>
>> Thanks for your update, I will have a test after the new release, and see 
>> if the issue being resolved.
>> And if possible, could you plz also add the fix to avoid prompting many 
>> cleartool console window when doing post-review and viewing diff? 
>> (see 
>> https://groups.google.com/forum/?fromgroups=#!topic/reviewboard/R1kiku5tIqQ
>> )
>>
>> Thanks,
>> Tao
>>
>>
>> On Saturday, January 26, 2013 5:05:07 PM UTC+8, Christian Hammond wrote:
>>
>>> Hi Tao,
>>>
>>> I'll look into this and see what I can do. We'll be putting out a new 
>>> release this week.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>>
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com
>>>  
>>>
>>> On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou  wrote:
>>>
  Hi, 

 I am using Review Board 1.7.2 on Windows 7 with repository on 
 Clearcase, and found the view diff page doesn't render correctly.
 if I upload several changed files in one diff by post-review, say more 
 than 2 files, only 2 files' diff could display, and only can add comment 
 for the first one diff.

 after some diagnose, I found the cause is in Line 15 of reviews.js, 
 'new RB.CommentIssueManager({' will cause Uncaught TypeError
  var gCommentIssueManager = new RB.CommentIssueManager({

 Seems like the refactor of reviews.js in 1.7.2 by moving related code 
 to commentIssueManagerModel.js caused this problem, while 1.7.1 works just 
 fine. 
 As not so familiar with javascript, I can only find out the cause, 
 don't know how to fix.
 Hope this also could be fixed in next Review Board release.

 Thanks!

 Tao Zhou

  -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/**donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to reviewboard...@**
 googlegroups.com

 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=en
  
  

>>>
>>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Christian Hammond]

I haven't been able to reproduce this. Can you get me a stack trace from
the JavaScript console, showing what's calling what?

I also need to know which page you're hitting this on, and a repro case.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou  wrote:

> Hi,
>
> I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase,
> and found the view diff page doesn't render correctly.
> if I upload several changed files in one diff by post-review, say more
> than 2 files, only 2 files' diff could display, and only can add comment
> for the first one diff.
>
> after some diagnose, I found the cause is in Line 15 of reviews.js, 'new
> RB.CommentIssueManager({' will cause Uncaught TypeError
>  var gCommentIssueManager = new RB.CommentIssueManager({
>
> Seems like the refactor of reviews.js in 1.7.2 by moving related code to
> commentIssueManagerModel.js caused this problem, while 1.7.1 works just
> fine.
> As not so familiar with javascript, I can only find out the cause, don't
> know how to fix.
> Hope this also could be fixed in next Review Board release.
>
> Thanks!
> Tao Zhou
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Christian Hammond]

Hi Tao,

Can you post the fix up on http://reviews.reviewboard.org? All patches must
go through a review process there.

Thanks!

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sat, Jan 26, 2013 at 5:41 AM, Tao Zhou  wrote:

> Hi, Christian:
>
> Thanks for your update, I will have a test after the new release, and see
> if the issue being resolved.
> And if possible, could you plz also add the fix to avoid prompting many
> cleartool console window when doing post-review and viewing diff?
> (see
> https://groups.google.com/forum/?fromgroups=#!topic/reviewboard/R1kiku5tIqQ
> )
>
> Thanks,
> Tao
>
>
> On Saturday, January 26, 2013 5:05:07 PM UTC+8, Christian Hammond wrote:
>
>> Hi Tao,
>>
>> I'll look into this and see what I can do. We'll be putting out a new
>> release this week.
>>
>> Christian
>>
>> --
>> Christian Hammond - chi...@chipx86.com
>>
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou  wrote:
>>
>>>  Hi,
>>>
>>> I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase,
>>> and found the view diff page doesn't render correctly.
>>> if I upload several changed files in one diff by post-review, say more
>>> than 2 files, only 2 files' diff could display, and only can add comment
>>> for the first one diff.
>>>
>>> after some diagnose, I found the cause is in Line 15 of reviews.js, 'new
>>> RB.CommentIssueManager({' will cause Uncaught TypeError
>>>  var gCommentIssueManager = new RB.CommentIssueManager({
>>>
>>> Seems like the refactor of reviews.js in 1.7.2 by moving related code to
>>> commentIssueManagerModel.js caused this problem, while 1.7.1 works just
>>> fine.
>>> As not so familiar with javascript, I can only find out the cause, don't
>>> know how to fix.
>>> Hope this also could be fixed in next Review Board release.
>>>
>>> Thanks!
>>>
>>> Tao Zhou
>>>
>>>  --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/**donate/
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/**users/
>>> -~--~~~~--**~~--~--~---
>>> To unsubscribe from this group, send email to reviewboard...@**
>>> googlegroups.com
>>>
>>> For more options, visit this group at http://groups.google.com/**
>>> group/reviewboard?hl=en
>>>
>>>
>>>
>>
>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Tao Zhou]

Hi, Christian:

Thanks for your update, I will have a test after the new release, and see 
if the issue being resolved.
And if possible, could you plz also add the fix to avoid prompting many 
cleartool console window when doing post-review and viewing diff? 
(see 
https://groups.google.com/forum/?fromgroups=#!topic/reviewboard/R1kiku5tIqQ)

Thanks,
Tao

On Saturday, January 26, 2013 5:05:07 PM UTC+8, Christian Hammond wrote:
>
> Hi Tao,
>
> I'll look into this and see what I can do. We'll be putting out a new 
> release this week.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou 
> > wrote:
>
>> Hi, 
>>
>> I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase, 
>> and found the view diff page doesn't render correctly.
>> if I upload several changed files in one diff by post-review, say more 
>> than 2 files, only 2 files' diff could display, and only can add comment 
>> for the first one diff.
>>
>> after some diagnose, I found the cause is in Line 15 of reviews.js, 'new 
>> RB.CommentIssueManager({' will cause Uncaught TypeError
>>  var gCommentIssueManager = new RB.CommentIssueManager({
>>
>> Seems like the refactor of reviews.js in 1.7.2 by moving related code to 
>> commentIssueManagerModel.js caused this problem, while 1.7.1 works just 
>> fine. 
>> As not so familiar with javascript, I can only find out the cause, don't 
>> know how to fix.
>> Hope this also could be fixed in next Review Board release.
>>
>> Thanks!
>> Tao Zhou
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

[Christian Hammond]

Hi Tao,

I'll look into this and see what I can do. We'll be putting out a new
release this week.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou  wrote:

> Hi,
>
> I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase,
> and found the view diff page doesn't render correctly.
> if I upload several changed files in one diff by post-review, say more
> than 2 files, only 2 files' diff could display, and only can add comment
> for the first one diff.
>
> after some diagnose, I found the cause is in Line 15 of reviews.js, 'new
> RB.CommentIssueManager({' will cause Uncaught TypeError
>  var gCommentIssueManager = new RB.CommentIssueManager({
>
> Seems like the refactor of reviews.js in 1.7.2 by moving related code to
> commentIssueManagerModel.js caused this problem, while 1.7.1 works just
> fine.
> As not so familiar with javascript, I can only find out the cause, don't
> know how to fix.
> Hope this also could be fixed in next Review Board release.
>
> Thanks!
> Tao Zhou
>
>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

View Diff has issue in 1.7.2, and fine in 1.7.1

[Tao Zhou]

Hi, 

I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase, 
and found the view diff page doesn't render correctly.
if I upload several changed files in one diff by post-review, say more than 
2 files, only 2 files' diff could display, and only can add comment for the 
first one diff.

after some diagnose, I found the cause is in Line 15 of reviews.js, 'new RB.
CommentIssueManager({' will cause Uncaught TypeError
var gCommentIssueManager = new RB.CommentIssueManager({

Seems like the refactor of reviews.js in 1.7.2 by moving related code to 
commentIssueManagerModel.js caused this problem, while 1.7.1 works just 
fine. 
As not so familiar with javascript, I can only find out the cause, don't 
know how to fix.
Hope this also could be fixed in next Review Board release.

Thanks!
Tao Zhou

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en