Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

> On April 8, 2016, 3:36 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java, > > line 745 > > > > > > Why this change? For compiler optimization??? Leftover d

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127729 --- Ship it! LGTM, but lets get some more eyes on the code. - Sumi

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/#review127728 --- ambari-server/src/main/java/org/apache/ambari/server/orm/dao/Aler

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45792/ --- (Updated April 7, 2016, 7:39 p.m.) Review request for Ambari, Jaimin Jetly, Ric

Re: Review Request 45878: Remove PHD references from HAWQ

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45878/#review127717 --- Ship it! Ship It! - Matt On April 7, 2016, 9:48 a.m., Lav Ja

Review Request 45914: Kerberos: Allow multiple KDC hosts to be set while enabling Kerberos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45914/ --- Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Oliver Szabo, and Sand

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/#review127709 --- Ship it! Ship It! - Yusaku Sako On April 8, 2016, 12:36 a.m.

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/ --- (Updated April 8, 2016, 12:36 a.m.) Review request for Ambari, Alexandr Antonen

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/#review127707 --- ambari-admin/src/main/resources/ui/admin-web/app/scripts/controll

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/ --- (Updated April 8, 2016, 12:19 a.m.) Review request for Ambari, Alexandr Antonen

Re: Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45899/#review127701 --- Ship it! Ship It! - Lav Jain On April 7, 2016, 10:26 p.m., G

Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45713/ --- Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, and

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127697 --- Very nice pythonic changes to reduce verbosity (y) Why are we not

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45845/#review127695 --- Ship it! Ship It! - Sid Wagle On April 7, 2016, 8:21 p.m., A

Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/#review127694 --- Ship it! Ship It! - Sid Wagle On April 7, 2016, 11:38 p.m.,

Re: Review Request 45906: HAWQ fails to connect to YARN in HA+SEC mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45906/#review127693 --- Ship it! Ship It! - Lav Jain On April 7, 2016, 11 p.m., Alex

Re: Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/ --- (Updated April 7, 2016, 11:38 p.m.) Review request for Ambari, Dmytro Sen, Sumi

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- (Updated April 7, 2016, 11:34 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- (Updated April 7, 2016, 11:01 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 45906: HAWQ fails to connect to YARN in HA+SEC mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45906/ --- Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi,

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- (Updated April 7, 2016, 10:54 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45904/ --- Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit Moh

Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg Nec

Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45899/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, and

Re: Review Request 45857: RU/EU PreCheck to ensure dfs.client.retry.policy.enable is set to false

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45857/ --- (Updated April 7, 2016, 9:47 p.m.) Review request for Ambari, Dmytro Grinenko,

Review Request 45896: Atlas Integration : Support Atlas HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45896/ --- Review request for Ambari, John Speidel and Nate Cole. Bugs: AMBARI-15733 h

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127661 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 5:55 p.m

Re: Review Request 45893: Password must not by displayed by UpgradeItem and Stage resources in the API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45893/ --- (Updated April 7, 2016, 9:11 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 45893: Password must not by displayed by UpgradeItem and Stage resources in the API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45893/#review127659 --- Ship it! Ship It! ambari-server/src/main/java/org/apache/amba

Review Request 45846: AMBARI-15749 : Add AMS post processing function to show the metrics 'diff' over time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45846/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 45893: Password must not by displayed by UpgradeItem and Stage resources in the API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45893/#review127654 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 45893: Password must not by displayed by UpgradeItem and Stage resources in the API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45893/#review127653 --- Fix it, then Ship it! No way to intercept these at the level in

Review Request 45893: Password must not by displayed by UpgradeItem and Stage resources in the API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45893/ --- Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and Sumi

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127652 --- Ship it! Ship It! - Jonathan Hurley On April 7, 2016, 1:55 p

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45845/ --- (Updated April 7, 2016, 8:21 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/#review127647 --- Ping - Nate Cole On April 7, 2016, 1:55 p.m., Nate Cole wrote:

Re: Review Request 45877: Add "services" element to compatible_repository_versions endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/ --- (Updated April 7, 2016, 1:55 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45835/ --- (Updated April 7, 2016, 5:54 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45778/ --- (Updated April 7, 2016, 5:45 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45835/#review127629 --- ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/

Re: Review Request 45834: Create Alert For Reporting Potential Issues With Slow REST Responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45834/#review127627 --- Ship it! Ship It! - Alejandro Fernandez On April 7, 2016, 4

Re: Review Request 45867: Add shiro.ini in Ambari Zeppelin service config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45867/#review127625 --- Ship it! Ship It! - Alejandro Fernandez On April 7, 2016, 1:

Re: Review Request 45857: RU/EU PreCheck to ensure dfs.client.retry.policy.enable is set to false

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45857/#review127622 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 1:46 a.m

Re: Review Request 45867: Add shiro.ini in Ambari Zeppelin service config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45867/#review127620 --- Ship it! Ship It! - Jayush Luniya On April 7, 2016, 1:17 p.m

Re: Review Request 45878: Remove PHD references from HAWQ

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45878/#review127619 --- Ship it! Ship It! ambari-server/src/main/resources/common-ser

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45835/#review127617 --- Ship it! Ship It! - Jayush Luniya On April 6, 2016, 9:12 p.m

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

> On April 6, 2016, 9:28 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml, > > line 61 > > > > > > Shouldnt we update these values during amb

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

> On April 6, 2016, 9:28 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml, > > line 61 > > > > > > Shouldnt we update these values during amb

Review Request 45878: Remove PHD references from HAWQ

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45878/ --- Review request for Ambari. Bugs: AMBARI-15741 https://issues.apache.org/jir

Review Request 45877: Add "services" element to compatible_repository_versions endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45877/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 45834: Create Alert For Reporting Potential Issues With Slow REST Responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45834/#review127610 --- Ship it! Ship It! - Nate Cole On April 7, 2016, noon, Jonath

Re: Review Request 45834: Create Alert For Reporting Potential Issues With Slow REST Responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45834/ --- (Updated April 7, 2016, 11:53 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 45875: Ambari should report about slow sudo hosts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45875/#review127603 --- Ship it! Ship It! - Vitalyi Brodetskyi On April 7, 2016, 3:4

Review Request 45875: Ambari should report about slow sudo hosts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45875/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15767 https:

Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle. B

Re: Review Request 45872: Component install post processing can not be run in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review127602 --- Ship it! Ship It! - Vitalyi Brodetskyi On April 7, 2016, 2:5

Re: Review Request 45538: Audit Log Code Cleanup & Safety

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/ --- (Updated ápr. 7, 2016, 3 du) Review request for Ambari, Jonathan Hurley, Nate C

Review Request 45872: Component install post processing can not be run in parallel

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15762 https:

Re: Review Request 45871: While creating WEB URLs for Alerts, if we add http/https then we should not drop the URL path past port number

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45871/#review127600 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 7, 2016, 2

Review Request 45871: While creating WEB URLs for Alerts, if we add http/https then we should not drop the URL path past port number

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45871/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15761 https:

Re: Review Request 45864: Hive view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45864/#review127593 --- Ship it! Ship It! - Gaurav Nagar On April 7, 2016, 11:15 a.m

Review Request 45867: Add shiro.ini in Ambari Zeppelin service config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45867/ --- Review request for Ambari, Alejandro Fernandez, Rohit Choudhary, Sumit Mohanty,

Re: Review Request 45866: File browser view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45866/#review127594 --- Ship it! Ship It! - Nitiraj Rathore On April 7, 2016, 11:58

Re: Review Request 45866: File browser view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45866/#review127592 --- Ship it! Ship It! - Gaurav Nagar On April 7, 2016, 11:58 a.m

Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45865/#review127591 --- Ship it! Ship It! - Gaurav Nagar On April 7, 2016, 11:20 a.m

Re: Review Request 45866: File browser view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45866/#review127590 --- Ship it! Ship It! - Rohit Choudhary On April 7, 2016, 11:58

Re: Review Request 45864: Hive view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45864/#review127589 --- Ship it! Ship It! - Rohit Choudhary On April 7, 2016, 11:15

Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45865/#review127588 --- Ship it! Ship It! - Rohit Choudhary On April 7, 2016, 11:20

Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45865/#review127587 --- Ship it! Ship It! - Pallav Kulshreshtha On April 7, 2016, 11

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/#review127586 --- Ship it! Ship It! - Andrew Onischuk On April 7, 2016, 12:55

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/ --- (Updated April 7, 2016, 2:55 p.m.) Review request for Ambari, Andrew Onischuk a

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/ --- (Updated April 7, 2016, 2:54 p.m.) Review request for Ambari, Andrew Onischuk a

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/#review127584 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Review Request 45866: File browser view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45866/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 45538: Audit Log Code Cleanup & Safety

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/#review127582 --- Ship it! Ship It! - Sebastian Toader On April 7, 2016, 1:47

Re: Review Request 45538: Audit Log Code Cleanup & Safety

> On ápr. 7, 2016, 7:30 de, Sebastian Toader wrote: > > ambari-server/src/test/java/org/apache/ambari/server/audit/ActionDBAAccessorAuditlogTest.java, > > line 29 > > > > > > Can't we just access RequestDetails.Compo

Re: Review Request 45538: Audit Log Code Cleanup & Safety

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/ --- (Updated ápr. 7, 2016, 11:47 de) Review request for Ambari, Jonathan Hurley, Na

Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45865/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Review Request 45864: Hive view should have some checks before starting similar to pig view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45864/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 45538: Audit Log Code Cleanup & Safety

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45538/#review127569 --- ambari-server/src/main/java/org/apache/ambari/server/actionmanage

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45845/#review127571 --- Ship it! Since it's a 2.4.0 ticket, please add unit tests befor

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/#review127570 --- Ship it! Ship It! - Dmytro Sen On Апрель 6, 2016, 8:21 п.п.,