Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53914/#review156380 --- Ship it! Ship It! - Sumit Mohanty On Nov. 19, 2016, 12:12 a.

Review Request 53922: AMBARI-18942 - Auto-start services: Avoid full page reload after "Save" / "Discard"

2016-11-18 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53922/ --- Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. Bugs: AMBARI

Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53914/#review156373 --- Ship it! Ship It! - Sid Wagle On Nov. 19, 2016, 12:12 a.m.,

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/ --- (Updated Nov. 19, 2016, 12:49 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Swapan Shridhar
> On Nov. 18, 2016, 11:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 294 > > > > > > If the property doesn't exist still need t

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/ --- (Updated Nov. 19, 2016, 12:45 a.m.) Review request for Ambari, Alejandro Fernan

Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53914/ --- Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid Wa

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/#review156356 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Jonathan Hurley
> On Nov. 18, 2016, 6:21 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java, > > line 402 > > > > > > private modifier will not allow Transaction a

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/ --- (Updated Nov. 18, 2016, 6:37 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/#review156352 --- ambari-server/src/main/java/org/apache/ambari/server/state/config

Re: Review Request 53907: Add Service wizard: Allow adding slave components from different service conditionally

2016-11-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53907/#review156351 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 18, 2016, 11:

Re: Review Request 53907: Add Service wizard: Allow adding slave components from different service conditionally

2016-11-18 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53907/#review156350 --- Ship it! Ship It! - Andriy Babiichuk On Лис. 18, 2016, 11:04

Review Request 53907: Add Service wizard: Allow adding slave components from different service conditionally

2016-11-18 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53907/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, and Yusaku Sako. B

Review Request 53904: Implement Create Alerts: step 1 select alert type

2016-11-18 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53904/ --- Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku

Re: Review Request 53901: Allow generic Service Upgrade Packs for all targets

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53901/#review156346 --- Ship it! Ship It! - Jonathan Hurley On Nov. 18, 2016, 4:12 p

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/ --- (Updated Nov. 18, 2016, 10:20 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/#review156345 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 18, 2016, 8:

Re: Review Request 53901: Allow generic Service Upgrade Packs for all targets

2016-11-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53901/#review156344 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 18, 2016, 9:

Re: Review Request 53901: Allow generic Service Upgrade Packs for all targets

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53901/#review156342 --- ambari-server/src/main/java/org/apache/ambari/server/stack/StackM

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/#review156340 --- Ship it! Ship It! - Nate Cole On Nov. 18, 2016, 3:50 p.m., J

Review Request 53901: Allow generic Service Upgrade Packs for all targets

2016-11-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53901/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luni

Re: Review Request 53871: Perf: Add Hadoop Core services to PERF stack

2016-11-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53871/#review156339 --- Ship it! Great, pretty much a self contained change. - Sumit M

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/#review156338 --- ambari-server/src/main/java/org/apache/ambari/server/state/config

Re: Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/ --- (Updated Nov. 18, 2016, 3:50 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/ --- (Updated Nov. 18, 2016, 8:20 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53880: Can't change capacity-scheduler's queue capacity from the YARN config page, even though its shown as text box

2016-11-18 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53880/#review156334 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 18, 2016, 4:5

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

2016-11-18 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/#review156328 --- Ship it! +1 for the stack_advisor computations. - Siddharth Se

Re: Review Request 53883: 'HAWQ segments unregistered' shows incorrect alert

2016-11-18 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53883/#review156325 --- Ship it! Ship It! - Lav Jain On Nov. 18, 2016, 6:28 p.m., Ma

Review Request 53883: 'HAWQ segments unregistered' shows incorrect alert

2016-11-18 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53883/ --- Review request for Ambari and Lav Jain. Bugs: AMBARI-18935 https://issues.a

Re: Review Request 53854: Agent Auto Restart Doesn't Release Ping Port

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53854/#review156318 --- Fix it, then Ship it! ambari-agent/src/main/python/ambari_agen

Review Request 53881: Remove Unnecessary Locks Inside Of ConfigGroup Business Object Implementations

2016-11-18 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53881/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and Sid

Review Request 53880: Can't change capacity-scheduler's queue capacity from the YARN config page, even though its shown as text box

2016-11-18 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53880/ --- Review request for Ambari, Andrii Tkach and Oleg Nechiporenko. Bugs: AMBARI-189

Re: Review Request 53854: Agent Auto Restart Doesn't Release Ping Port

2016-11-18 Thread Dmytro Sen
> On Ноя. 18, 2016, 1:08 п.п., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/AmbariAgent.py, line 59 > > > > > > This will most likely kill child processes started by agent like > > datanode/na

Re: Review Request 53854: Agent Auto Restart Doesn't Release Ping Port

2016-11-18 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53854/#review156296 --- Fix it, then Ship it! ambari-agent/src/main/python/ambari_agen

Re: Review Request 53854: Agent Auto Restart Doesn't Release Ping Port

2016-11-18 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53854/ --- (Updated Ноя. 18, 2016, 1:05 п.п.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 53855: keytab settings in kerberos.json for SPARK are at the wrong place

2016-11-18 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53855/#review156290 --- Ship it! Ship It! - Robert Levas On Nov. 18, 2016, 5:42 a.m.

Re: Review Request 53855: keytab settings in kerberos.json for SPARK are at the wrong place

2016-11-18 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53855/ --- (Updated Nov. 18, 2016, 10:42 a.m.) Review request for Ambari, Attila Doroszlai

Re: Review Request 53855: keytab settings in kerberos.json for SPARK are at the wrong place

2016-11-18 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53855/#review156289 --- Ship it! Ship It! - Sebastian Toader On Nov. 18, 2016, 10:06

Review Request 53855: keytab settings in kerberos.json for SPARK are at the wrong place

2016-11-18 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53855/ --- Review request for Ambari, Attila Doroszlai, Laszlo Puskas, and Sebastian Toader