Review Request 54474: Metrics Monitor start failed: ERROR: Cannot write pid /grid/0/pid/metric_monitor/ambari-metrics-monitor.pid

2016-12-07 Thread Andrew Onischuk
t always be the case. So I would prefer leaving the default behavior similar to default linux behavior following the umask. Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py feabdb2 Diff: https://reviews.apache.org/r/54474/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Andrew Onischuk
bari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e Diff: https://reviews.apache.org/r/54378/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Andrew Onischuk
g/r/54378/#review158004 --- On Dec. 6, 2016, 11:56 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Andrew Onischuk
bari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e Diff: https://reviews.apache.org/r/54378/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-05 Thread Andrew Onischuk
up or user named '*'. Also Ambari cannot correctly create groups if there are multiple spaces instead of one. Diffs - ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py 320872e Diff: https://reviews.apache.org/r/54378/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 54374: After ambari only upgrade Enable security(Configure Ambari Identity) was failed because could not run "ambari-sudo.sh"

2016-12-05 Thread Andrew Onischuk
do.sh". Diffs - ambari-server/src/main/python/ambari_server_main.py 9e04a5d Diff: https://reviews.apache.org/r/54374/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 54303: Ambari-server restart command not working. if any parameters are changed and reset to default.

2016-12-02 Thread Andrew Onischuk
5.If you Restart the Ambari server again. It gets restarted successfully. Diffs - ambari-server/src/main/python/ambari_server/utils.py 62c93ae Diff: https://reviews.apache.org/r/54303/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 54131: Ambari-server fails to restart with --debug if it is already running

2016-11-28 Thread Andrew Onischuk
/main/python/ambari_server/serverUtils.py 3af233c Diff: https://reviews.apache.org/r/54131/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 54131: Ambari-server fails to restart with --debug if it is already running

2016-11-28 Thread Andrew Onischuk
e.org/r/54131/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 54118: HBASE service check fails if run with tty=true

2016-11-28 Thread Andrew Onischuk
60, value=id1fac 6fc8_date512616 1 row(s) in 0.2410 seconds hbase(main):002:0> Looking for id1fac6fc8_date512616 Diffs - ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/files/hbaseSmokeVerify.sh 5c320c0 Diff: https://reviews.apache.org/r/54118/diff/ Testing --- Thanks, Andrew Onischuk

Review Request 54055: Failures due to timeout don't report any reason

2016-11-24 Thread Andrew Onischuk
/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 7a84536 Diff: https://reviews.apache.org/r/54055/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53951: Refactor hive() function in HIVE service

2016-11-21 Thread Andrew Onischuk
-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 35d2144 ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py b398ac8 Diff: https://reviews.apache.org/r/53951/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53947: hive metrics : support hs2 with remote metastore

2016-11-21 Thread Andrew Onischuk
n/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-interactive-site.xml 89bf43c ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-site.xml e120ac2 Diff: https://reviews.apache.org/r/53947/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 53854: Agent Auto Restart Doesn't Release Ping Port

2016-11-18 Thread Andrew Onischuk
/ambari_agent/AmbariAgent.py (line 59) <https://reviews.apache.org/r/53854/#comment226517> This will most likely kill child processes started by agent like datanode/namenode etc. I think they are in the same process group. Can you please check? - Andrew Onischuk On Nov. 18, 2016, 1:

Review Request 53844: Oozie Server fails to start due to timeout

2016-11-17 Thread Andrew Onischuk
/metainfo.xml 96ac9ce Diff: https://reviews.apache.org/r/53844/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

2016-11-10 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53651/#review155606 --- Ship it! Ship It! - Andrew Onischuk On Nov. 10, 2016, 4:23

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-10 Thread Andrew Onischuk
clean test Thanks, Andrew Onischuk

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-09 Thread Andrew Onischuk
> On Nov. 10, 2016, 7:33 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py, > > line 79 > > <https://reviews.apache.org/r/53629/diff/1/?file=1559712#file1559712line79> > > > > C

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-09 Thread Andrew Onischuk
/package/scripts/webhcat.py <https://reviews.apache.org/r/53629/#comment225542> Can you try to do "kdestroy" for webhcat user. And than start Webhcat if that works +1. - Andrew Onischuk On Nov. 10, 2016, 6:49 a.m.

Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Andrew Onischuk
/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py b7735f4 ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 4cfa2b2 Diff: https://reviews.apache.org/r/53602/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 53544: Deployment failing at creating principal

2016-11-09 Thread Andrew Onischuk
action/kerberos/MITKerberosOperationHandlerTest.java 6fd30ee Diff: https://reviews.apache.org/r/53544/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53544: Deployment failing at creating principal

2016-11-07 Thread Andrew Onischuk
t.java 6fd30ee Diff: https://reviews.apache.org/r/53544/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53523: Ambari-agent user home directory permissions changed to accumulo:accumulo in non-root

2016-11-07 Thread Andrew Onischuk
://reviews.apache.org/r/53523/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-11-07 Thread Andrew Onischuk
/StatusCommandsExecutor.py (line 91) <https://reviews.apache.org/r/52420/#comment224966> The fix for the recent. HB lost issue. - Andrew Onischuk On Nov. 7, 2016, 9:40 a.m., Andrew Onischuk wrote: > > --- > This is an automatically gener

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-11-07 Thread Andrew Onischuk
/ambari_agent/TestActionQueue.py 7d04d42 ambari-agent/src/test/python/ambari_agent/TestController.py 59b41cd ambari-agent/src/test/python/ambari_agent/TestMain.py 01028ec Diff: https://reviews.apache.org/r/52420/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 53263: During cluster install, Components get timed out icon while starting

2016-10-28 Thread Andrew Onischuk
/python/ambari_agent/StatusCommandsExecutor.py 20acee4 Diff: https://reviews.apache.org/r/53263/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53263: During cluster install, Components get timed out icon while starting

2016-10-28 Thread Andrew Onischuk
20acee4 Diff: https://reviews.apache.org/r/53263/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53225: Python UT fail on trunk

2016-10-27 Thread Andrew Onischuk
ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :ambari-server Diffs - ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 9ec3b51 Diff: https://reviews.apache.org/r/53225/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53222: Move HDFS, HBASE YARN, GANGLIA, OOZIE RCO from stack to service level

2016-10-27 Thread Andrew Onischuk
--- mvn clean test Thanks, Andrew Onischuk

Review Request 53221: Move ZOOKEEPER, KAFKA, STORM, RANGER, RANGER_KMS, AMS, KERBEROS role command orders from stack to service definition

2016-10-27 Thread Andrew Onischuk
-services/ZOOKEEPER/3.4.5/role_command_order.json PRE-CREATION Diff: https://reviews.apache.org/r/53221/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53220: Move HIVE, PIG, SPARK, SPARK2, SLIDER, SQOOP, ACCUMULO, FALCON, KNOX, , MAHOUT, TEZ role command orders from stack to service definitions

2016-10-27 Thread Andrew Onischuk
/common-services/SQOOP/1.4.4.2.0/role_command_order.json PRE-CREATION ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/role_command_order.json PRE-CREATION Diff: https://reviews.apache.org/r/53220/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Andrew Onischuk
ls.py f2a462b ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 Diff: https://reviews.apache.org/r/53194/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Andrew Onischuk
to interrupt process and execute > > arbitrary python code from console? > > Andrew Onischuk wrote: > This doesn't interrupt the process and not able to anyhow change it's > context. It's readonly view of it's state. > Also this is there for a long ti

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Andrew Onischuk
long time, I have just moved it to other place. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53194/#review153890 --- On Oct. 26, 2016, 4:25 p.m., Andrew Onischuk wrote: > > ---

Review Request 53194: Add code to improve debugging of ambari-agent related problems.

2016-10-26 Thread Andrew Onischuk
ython/ambari_agent/StatusCommandsExecutor.py 8959640 Diff: https://reviews.apache.org/r/53194/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-24 Thread Andrew Onischuk
/TestActionQueue.py 7d04d42 ambari-agent/src/test/python/ambari_agent/TestController.py 59b41cd ambari-agent/src/test/python/ambari_agent/TestMain.py 23cdb13 Diff: https://reviews.apache.org/r/52420/diff/ Testing (updated) --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-24 Thread Andrew Onischuk
Thanks, Andrew Onischuk

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

2016-10-21 Thread Andrew Onischuk
/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Andrew Onischuk
> On Oct. 20, 2016, 6:11 p.m., Andrew Onischuk wrote: > > The blacklisting logic we previously were implementing is not needed now > > (as disscussed with Sid). > > > > Reasons for that: > > 1. If command takes more than 5 seconds, the executor will just re

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Andrew Onischuk
outed commands, can make heartbeat hang, the results will just come back with the next heartbeat. - Andrew Onischuk On Oct. 20, 2016, 3:54 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Andrew Onischuk
/python/ambari_agent/StatusCommandsExecutor.py PRE-CREATION Diff: https://reviews.apache.org/r/52420/diff/ Testing --- unit tests are pending to be added. Patch is not final Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Andrew Onischuk
concept reviewed. Still have to add unit tests and do more testing. - Andrew Onischuk On Oct. 20, 2016, 3:51 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Andrew Onischuk
/ambari_agent/StatusCommandsExecutor.py PRE-CREATION Diff: https://reviews.apache.org/r/52420/diff/ Testing (updated) --- unit tests are pending to be added. Patch is not final Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-20 Thread Andrew Onischuk
/python/ambari_agent/StatusCommandsExecutor.py PRE-CREATION Diff: https://reviews.apache.org/r/52420/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52979: NPE when a non-existent host is provided as part of the host filter

2016-10-20 Thread Andrew Onischuk
server.controller.AmbariManagementControllerImpl.createAction(AmbariManagementControllerImpl.java:3818) Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java faa21cb Diff: https://reviews.apache.org/r/52979/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

2016-10-20 Thread Andrew Onischuk
PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_INFRA/role_command_order.json 7246e9e Diff: https://reviews.apache.org/r/53054/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53052: Move ATLAS role command order to common-services/ATLAS

2016-10-20 Thread Andrew Onischuk
/role_command_order.json PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json edd6d64 ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 0e1319a Diff: https://reviews.apache.org/r/53052/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

2016-10-20 Thread Andrew Onischuk
-CREATION ambari-server/src/main/resources/stacks/HDP/2.2/services/LOGSEARCH/role_command_order.json e294e1b Diff: https://reviews.apache.org/r/53051/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 53050: Move ZEPPELIN role command order to common-services/ZEPPELIN

2016-10-20 Thread Andrew Onischuk
Thanks, Andrew Onischuk

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Andrew Onischuk
n be called from the parent ? > > Andrew Onischuk wrote: > 1. Sure this is what will go as the second patch (already talked with > Sumit) > 2. We cannot do that. Since we need to interrupt external commands like > subprocess etc. also this won't interrupt loops, sl

Re: Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Andrew Onischuk
iews.apache.org/r/52989/#review153113 --- On Oct. 18, 2016, 3:09 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To repl

Review Request 52989: HDFS goes down after installing cluster

2016-10-18 Thread Andrew Onischuk
Thanks, Andrew Onischuk

Review Request 52979: NPE when a non-existent host is provided as part of the host filter

2016-10-18 Thread Andrew Onischuk
er.AmbariManagementControllerImpl.createAction(AmbariManagementControllerImpl.java:3818) Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java a671f0c Diff: https://reviews.apache.org/r/52979/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52928: Give a reasonable error message when oozie service_check fails due to nodocs docker option

2016-10-17 Thread Andrew Onischuk
/OOZIE/4.0.0.2.0/package/scripts/service_check.py 3710117 Diff: https://reviews.apache.org/r/52928/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52826: Increase forkCount for Ambari Server Unit Tests

2016-10-13 Thread Andrew Onischuk
--- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52826: Increase forkCount for Ambari Server Unit Tests

2016-10-13 Thread Andrew Onischuk
ase forkCount for Ambari Server Unit Tests > > > Diffs > - > > ambari-project/pom.xml c0fd7bf > > Diff: https://reviews.apache.org/r/52826/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >

Re: Review Request 52826: Increase forkCount for Ambari Server Unit Tests

2016-10-13 Thread Andrew Onischuk
ives 5 processes and leverages all CPU cores. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52826/#review152494 --------

Review Request 52829: HCat client install during Ambari install wizard

2016-10-13 Thread Andrew Onischuk
ari-common/src/main/python/resource_management/core/shell.py 94933bd ambari-common/src/main/python/resource_management/libraries/functions/get_user_call_output.py 4b11614 Diff: https://reviews.apache.org/r/52829/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52826: Increase forkCount for Ambari Server Unit Tests

2016-10-13 Thread Andrew Onischuk
://issues.apache.org/jira/browse/AMBARI-18586 Repository: ambari Description --- Increase forkCount for Ambari Server Unit Tests Diffs - ambari-project/pom.xml c0fd7bf Diff: https://reviews.apache.org/r/52826/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52788: Grafana fails to start after deployment

2016-10-12 Thread Andrew Onischuk
2e24d82 ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json ceedb67 Diff: https://reviews.apache.org/r/52788/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52692: Ambari startup script doesn't work on SUSE and potentially other OS's.

2016-10-10 Thread Andrew Onischuk
directory structure of /etc/init.d/rc3.d to populate $ROOT. Diffs - ambari-server/conf/unix/install-helper.sh 229e146 ambari-server/sbin/ambari-server 64f1c8c Diff: https://reviews.apache.org/r/52692/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52607: oozie server start fails post upgrade to Ambari 2.4.1

2016-10-06 Thread Andrew Onischuk
ozied.sh stop Diffs - ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py eabaea3 ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py b0cc2e9 Diff: https://reviews.apache.org/r/52607/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52482: Optimize ClustersDeadlockTest

2016-10-05 Thread Andrew Onischuk
Diffs - ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java a0a6444 Diff: https://reviews.apache.org/r/52482/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52549: Components can't be started because of failed webhdfs request

2016-10-05 Thread Andrew Onischuk
")\n File \"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\", line 460, in action_delayed\n self.get_hdfs_resource_executor().action_delayed(action_name, self)\n File \"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\", line 250, in action_delayed\nself._assert_valid()\n File \"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\", line 234, in _assert_valid\nself.target_status = self._get_file_status(target)\n File \"/usr/lib/pytho n2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\", line 295, in _get_file_status\nlist_status = self.util.run_command(target, 'GETFILESTATUS', method='GET', ignore_status_codes=['404'], assertable_result=False)\n File \"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py\", line 182, in run_command\n_, out, err = get_user_call_output(cmd, user=self.run_user, logoutput=self.logoutput, quiet=False)\n File \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/get_user_call_output.py\", line 61, in get_user_call_output\nraise Fail(err_msg)\nresource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w '%{http_code}' -X GET --negotiate -u : 'http://nat-r6-tzrs-ambari-alerts-1.openstacklocal:50070/webhdfs/v1/user/cstm-spark?op=GETFILESTATUS&user.name=cstm-hdfs' 1>/tmp/tmpL8hR95 2>/tmp/tmpwE5KZf' returned 7. curl: (7) couldn't connect to host\n000 Diffs - ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py ee41195 Diff: https://reviews.apache.org/r/52549/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52483: Write unittests for configs.py

2016-10-03 Thread Andrew Onischuk
/resources/TestConfigs-content.xml PRE-CREATION Diff: https://reviews.apache.org/r/52483/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52482: Analyze and Optimize Ambari Server Unit Tests - Group 7

2016-10-03 Thread Andrew Onischuk
Diff: https://reviews.apache.org/r/52482/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52481: Ambari-Server restart causes all host components to go in Heartbeat Lost state indefinitely.

2016-10-03 Thread Andrew Onischuk
clean test Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-03 Thread Andrew Onischuk
/python/ambari_agent/PythonReflectiveExecutor.py 655b2fc ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 Diff: https://reviews.apache.org/r/52420/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-10-03 Thread Andrew Onischuk
/PythonReflectiveExecutor.py 655b2fc ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 Diff: https://reviews.apache.org/r/52420/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

2016-09-30 Thread Andrew Onischuk
://reviews.apache.org/r/52420/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52380: Spark user principal name is not always lowercase in HDP 2.5

2016-09-29 Thread Andrew Onischuk
Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 2d52fb3 Diff: https://reviews.apache.org/r/52380/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52335: Alert unit tests failing on trunk

2016-09-27 Thread Andrew Onischuk
a f5ce11e Diff: https://reviews.apache.org/r/52335/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

2016-09-27 Thread Andrew Onischuk
-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py dc11ba9 ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py abfe756 Diff: https://reviews.apache.org/r/52298/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

2016-09-27 Thread Andrew Onischuk
/params_linux.py 4d42861 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py a3a3a06 Diff: https://reviews.apache.org/r/52298/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52298: Refactor yarn() function in YARN service. Part 1.

2016-09-27 Thread Andrew Onischuk
-services/YARN/2.1.0.2.0/package/scripts/yarn.py a3a3a06 Diff: https://reviews.apache.org/r/52298/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52261: Provide Warnings When ulimit Is High To Prevent Heartbeat Lost Issues

2016-09-26 Thread Andrew Onischuk
on 9c5 ambari-server/src/main/resources/host_scripts/alert_ulimit.py PRE-CREATION ambari-server/src/test/python/host_scripts/TestAlertUlimit.py PRE-CREATION Diff: https://reviews.apache.org/r/52261/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52262: Log results from shell commands run as user

2016-09-26 Thread Andrew Onischuk
/main/python/resource_management/libraries/functions/get_user_call_output.py 4b11614 Diff: https://reviews.apache.org/r/52262/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52261: Provide Warnings When ulimit Is High To Prevent Heartbeat Lost Issues

2016-09-26 Thread Andrew Onischuk
sources/host_scripts/alert_ulimit.py PRE-CREATION Diff: https://reviews.apache.org/r/52261/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52218: Fix ambari-server python test TestAmbariServer.py

2016-09-23 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52218/#review150171 --- Ship it! Ship It! - Andrew Onischuk On Sept. 23, 2016, 12

Review Request 52160: Review necessity of xmllint and remove libxml2-utils package from Oozie manifest

2016-09-22 Thread Andrew Onischuk
IE/metainfo.xml 8de041a ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_service_check.py 22d7d63 ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py c96faff Diff: https://reviews.apache.org/r/52160/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52161: Fix typographical error in hive-mysql dependency

2016-09-22 Thread Andrew Onischuk
://reviews.apache.org/r/52161/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52159: SmartSense error during host assignment

2016-09-22 Thread Andrew Onischuk
/stacks/2.0.6/common/test_stack_advisor.py a70922f ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 0ed1761 Diff: https://reviews.apache.org/r/52159/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52158: On restarting service using APIs in Ambari, Ambari still says that service needs to be restarted on the UI

2016-09-22 Thread Andrew Onischuk
STER to restart nifi, ambari still shows that the service needs to be restarted. Diffs - ambari-agent/src/main/python/ambari_agent/ActionQueue.py 064e4f0 ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 1805c9a Diff: https://reviews.apache.org/r/52158/diff/ Test

Review Request 52156: Python UT fail on trunk

2016-09-22 Thread Andrew Onischuk
OR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :ambari-server Diffs - ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py b9dd736 Diff: https://reviews.apache.org/r/52156/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52114: Atlas service check never fails

2016-09-22 Thread Andrew Onischuk
ly, visit: https://reviews.apache.org/r/52114/#review149850 ------- On Sept. 21, 2016, 9:11 a.m., Andrew Onischuk wrote: > > --- > This is an automatically gen

Review Request 52114: Atlas service check never fails

2016-09-21 Thread Andrew Onischuk
/service_check.py 61b3ac0 Diff: https://reviews.apache.org/r/52114/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 52044: Analyze and Optimize Ambari Server Unit Tests - Group 6

2016-09-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52044/#review149663 --- Ship it! Ship It! - Andrew Onischuk On Sept. 20, 2016, 2:16

Review Request 52035: Improve agent logging to add more relevant message

2016-09-19 Thread Andrew Onischuk
w', '/grid/0']] {'sudo': True, 'timeout': 5} INFO 2016-09-16 15:52:49,813 logger.py:71 - call returned (0, '') INFO 2016-09-16 15:52:49,813 logger.py:71 - call[['test', '-w', '/tmp']] {'sudo': True, 'timeout': 5} INFO 2016-09-16 15:52:49,826 logger.py:71 - call returned (0, '') Can we * Add the heartbeat id to the log * Remove the logs about **call** or change them to DEBUG Diffs - ambari-agent/src/main/python/ambari_agent/Controller.py 7100656 ambari-agent/src/main/python/ambari_agent/Hardware.py 17acdf2 Diff: https://reviews.apache.org/r/52035/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52032: Optimize stack manager initialization for Ambari Server Unit Tests

2016-09-19 Thread Andrew Onischuk
/apache/ambari/server/state/UpgradeHelperTest.java 34bac2a Diff: https://reviews.apache.org/r/52032/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 52027: Stack definition: service component 'cardinality' inheritance not working properly

2016-09-19 Thread Andrew Onischuk
7/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 51330: Certain configuration files cannot be modified through Ambari api.

2016-09-19 Thread Andrew Onischuk
-START/scripts/params.py 49a14d0 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py ba9c8fb Diff: https://reviews.apache.org/r/51330/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 51898: AMBARI-18392 : Cluster failure due to APP_TIMELINE_SERVER and RESOURCEMANAGER failed to start

2016-09-15 Thread Andrew Onischuk
(line 344) <https://reviews.apache.org/r/51898/#comment216583> Why did you change Directory into mkdir. Directory is basically much more flexible in terms of some special cases, error handling etc. - Andrew Onischuk On Sept. 14, 2016, 8:11 p.m., Aravindan Vijayan

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/#review148686 --- Ship it! Ship It! - Andrew Onischuk On Sept. 13, 2016, 7:56

Review Request 51837: Make Execute timeout to be able to kill process trees which doesn't respond to SIGTERM

2016-09-13 Thread Andrew Onischuk
-CREATION ambari-common/src/main/python/resource_management/core/utils.py dc771d1 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py e02ed5a Diff: https://reviews.apache.org/r/51837/diff/ Testing --- mvn clean test Thanks, Andrew

Review Request 51806: ambari-agent check for unset variables (AMBARI-18317)

2016-09-12 Thread Andrew Onischuk
https://reviews.apache.org/r/51806/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 51796: Ambari fails to start nodemanager due to unexpected return code from sudo su command on the pid file

2016-09-12 Thread Andrew Onischuk
--- mvn clean test Thanks, Andrew Onischuk

Review Request 51795: ZEPPELIN user won't get created in ZEPPELIN group

2016-09-12 Thread Andrew Onischuk
> Diffs - ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py 5544085 Diff: https://reviews.apache.org/r/51795/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 51745: Setting fetch_nonlocal_groups to false Can Prevent Services From Starting

2016-09-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51745/#review148320 --- Ship it! Ship It! - Andrew Onischuk On Sept. 8, 2016, 8:46

Re: Review Request 51745: Setting fetch_nonlocal_groups to false Can Prevent Services From Starting

2016-09-09 Thread Andrew Onischuk
/accounts.py (line 112) <https://reviews.apache.org/r/51745/#comment215797> "in case the line is valid" I think that what you meant to say. - Andrew Onischuk On Sept. 8, 2016, 8:46 p.m., Jonathan Hurley wrote: > > --

Review Request 51739: Ambari server start fails after upgrade due to missing krb5JAASLogin.conf file on WireEncrypted cluster

2016-09-08 Thread Andrew Onischuk
possibly a regression Diffs - ambari-server/src/main/package/rpm/preinstall.sh 28878bb Diff: https://reviews.apache.org/r/51739/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

<    1   2   3   4   5   6   7   8   9   >