://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute for the
new process.
- Nate Cole
On March 7, 2018, 10:26 p.m., wang jianfei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
jira.
- Nate Cole
On Jan. 8, 2018, 8:05 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194954
---
Ship it!
Ship It!
- Nate Cole
On Jan. 8, 2018, 8:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64974/#review194869
---
Ship it!
Ship It!
- Nate Cole
On Jan. 5, 2018, 5:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64956/#review194787
---
Ship it!
Ship It!
- Nate Cole
On Jan. 4, 2018, 3:16 p.m
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this
-
>
> (Updated Jan. 3, 2018, 2:03 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22403
> https://issues.apache.org/jira/browse/AMBARI-22403
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/#review194763
---
Ship it!
Ship It!
- Nate Cole
On Jan. 3, 2018, 2:03 a.m
> On Jan. 2, 2018, 11:51 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java
> > Line 633 (original)
> > <https://reviews.apache.org/r/64887/diff/1/?file=1929460#file1929460line633>
> >
> > It's much m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64950/#review194759
---
Ship it!
Ship It!
- Nate Cole
On Jan. 4, 2018, 9:44 a.m
JIRA.
- Nate Cole
On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Dec. 22, 2017, 10:12 a.m., Nate Cole wrote:
> > ambari-server/src/main/python/bootstrap.py
> > Lines 762-763 (patched)
> > <https://reviews.apache.org/r/64775/diff/1/?file=1926153#file1926153line762>
> >
> > Use "".format() syntax here.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194636
---
Ship it!
Ship It!
- Nate Cole
On Dec. 23, 2017, 2:16 a.m
here we have to remember to set
JAVA_HOME. Can you pass in the os type or OS (the object0 here instead?
- Nate Cole
On Jan. 2, 2018, 9:54 a.m., Yussuf Shaikh wrote:
>
> ---
> This is an automatically generated e-mail. To
> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > <https://reviews.apache.org/r/64769/diff/2/?file=1925966#file1925966line863>
> >
> > I'm no UI expert, but this
-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml
5b27fafe54
Diff: https://reviews.apache.org/r/64815/diff/2/
Changes: https://reviews.apache.org/r/64815/diff/1-2/
Testing
---
No automated tests.
Thanks,
Nate Cole
Diff: https://reviews.apache.org/r/64815/diff/1/
Testing
---
No automated tests.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64571/#review194439
---
Ship it!
Ship It!
- Nate Cole
On Dec. 15, 2017, 7:23 a.m
the outstanding Livy issues?
- Nate Cole
On Dec. 16, 2017, 10:53 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
(patched)
<https://reviews.apache.org/r/64775/#comment273203>
Use "".format() syntax here.
Should we give more information here? How will we tell the user what to
do? How do they get the os_type into ambari.properties?
- Nate Cole
On Dec. 21, 2017, 10:25 a.m., Sne
ne to be only http or https.
- Nate Cole
On Dec. 21, 2017, 11:41 p.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64785/#review194365
---
Ship it!
Ship It!
- Nate Cole
On Dec. 21, 2017, 4 p.m., Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64772/#review194357
---
Ship it!
Ship It!
- Nate Cole
On Dec. 21, 2017, 9:46 a.m
> On Dec. 13, 2017, 10:37 a.m., Nate Cole wrote:
> > Has this been pushed? If so, please close the review.
Ping
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64751/#review194353
---
Ship it!
Ship It!
- Nate Cole
On Dec. 21, 2017, 8:25 a.m
/diff/1/
Testing
---
No new tests for json change.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review194085
---
Ship it!
Ship It!
- Nate Cole
On Dec. 13, 2017, 5:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193962
---
Ship it!
Ship It!
- Nate Cole
On Dec. 15, 2017, noon
> On Dec. 15, 2017, 2:01 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1357-1364 (patched)
> > <https://reviews.apache.org/r/64652/diff/1/?file=1918447#file1918447line1357>
> >
/cluster/ClusterImpl.java
Lines 1357-1364 (patched)
<https://reviews.apache.org/r/64652/#comment272627>
These records should just be straight up deleted, not marked this way.
- Nate Cole
On Dec. 15, 2017, noon, Myroslav Papirkovskyy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64637/#review193918
---
Ship it!
Ship It!
- Nate Cole
On Dec. 14, 2017, 10:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193791
---
Ship it!
Ship It!
- Nate Cole
On Dec. 14, 2017, 6:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64579/#review193703
---
Ship it!
Ship It!
- Nate Cole
On Dec. 13, 2017, 12:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64554/#review193702
---
Ship it!
Ship It!
- Nate Cole
On Dec. 13, 2017, 10:46 a.m
.org/r/63955/
> ---
>
> (Updated Nov. 20, 2017, 12:06 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole,
> Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
&
.org/r/63957/
> ---
>
> (Updated Nov. 22, 2017, 1:09 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and
> Sid Wagle.
>
>
> Bugs: AMBARI-22484
> https://issues.apache.org/jira/browse/AMBARI-22484
>
>
> Repository: amba
/0.96.0.2.0/package/scripts/hbase.py
Lines 29-31 (original), 41-47 (patched)
<https://reviews.apache.org/r/64554/#comment272285>
Only in WINSRV?
- Nate Cole
On Dec. 13, 2017, 9:02 a.m., Jonathan Hurley wrote:
>
> ---
> This is a
write
"java.home.redhat7". No option means we maintain current behavior.
I would prefer the 2nd option as it's likely easier to document. If we
start asking "hard choices" the everyday user will get confused.
- Nate Cole
On Dec. 13, 2017, 4:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review193553
---
Ship it!
Ship It!
- Nate Cole
On Dec. 12, 2017, 9:35 a.m
/kerberos/step1_controller.js
Lines 45-47 (patched)
<https://reviews.apache.org/r/64542/#comment272119>
Is this, or can this be made to show conditionally if isilon is chosen?
- Nate Cole
On Dec. 12, 2017, 10:38 a.m., Attila Magyar
JIRA.
- Nate Cole
On Dec. 1, 2017, 2:47 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
JIRA.
- Nate Cole
On Dec. 8, 2017, 5:57 a.m., Sneha Kanekar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
be cleaned up, and
(hopefully) doesn't need to be a json structure.
- Nate Cole
On Dec. 1, 2017, 2:47 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193547
---
Ship it!
Ship It!
- Nate Cole
On Dec. 8, 2017, 5:57 a.m
> On Dec. 4, 2017, 11:20 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> > Lines 130-132 (patched)
> > <https://reviews.apache.org/r/64242/diff/1/?file=1905504#file1905504line130>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64502/#review193416
---
Ship it!
Ship It!
- Nate Cole
On Dec. 11, 2017, 12:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64419/#review193165
---
Ship it!
Ship It!
- Nate Cole
On Dec. 7, 2017, 3:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64419/#review193135
---
Ship it!
Ship It!
- Nate Cole
On Dec. 7, 2017, 11:55 a.m
> On Dec. 4, 2017, 11:20 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> > Lines 130-132 (patched)
> > <https://reviews.apache.org/r/64242/diff/1/?file=1905504#file1905504line130>
> >
> >
g/r/64407/#comment271622>
nit: formatting (odd space)
- Nate Cole
On Dec. 7, 2017, 4:35 a.m., Sneha Kanekar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On Dec. 4, 2017, 11:20 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java
> > Lines 130-132 (patched)
> > <https://reviews.apache.org/r/64242/diff/1/?file=1905504#file1905504line130>
> >
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64340/#review192871
---
Ship it!
Ship It!
- Nate Cole
On Dec. 5, 2017, 10:04 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64316/#review192866
---
Ship it!
Ship It!
- Nate Cole
On Dec. 4, 2017, 5:13 p.m
-
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
1783655e8e
Diff: https://reviews.apache.org/r/64310/diff/1/
Testing
---
Manual.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64308/#review192739
---
Ship it!
Ship It!
- Nate Cole
On Dec. 4, 2017, 12:57 p.m
/configuration/Configuration.java
Lines 701-702 (original), 701-702 (patched)
<https://reviews.apache.org/r/64261/#comment270959>
This property seems important enough to add @Markdown
- Nate Cole
On Dec. 1, 2017, 4:53 p.m., Robert Levas
94-106 (patched)
<https://reviews.apache.org/r/64204/#comment270958>
Strange that this isn't getting covered in the above block. I'm not a UI
engineer, but seems like special casing ZKFC isn't a good idea and that any
SLAVE-type should be presenting it's alert data?
- Nate Cole
che.org/r/64242/#comment270957>
Then what? What is SharedState doing with this information/how is it
processed?
- Nate Cole
On Dec. 1, 2017, 2:47 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review192704
---
Ship it!
Ship It!
- Nate Cole
On Dec. 4, 2017, 10:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64205/#review192370
---
Ship it!
Ship It!
- Nate Cole
On Nov. 30, 2017, 4:20 p.m
> On Nov. 30, 2017, 4:12 p.m., Nate Cole wrote:
> > This is making the agent-side do the logic. Shouldn't we check these
> > things and not include GPL repos in the command to the agent?
>
> Sid Wagle wrote:
> We would still need to make sure existing hosts
these things
and not include GPL repos in the command to the agent?
- Nate Cole
On Nov. 30, 2017, 8:28 a.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192364
---
Ship it!
Ship It!
- Nate Cole
On Nov. 30, 2017, 3:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64205/#review192320
---
Ship it!
Ship It!
- Nate Cole
On Nov. 30, 2017, 10:04 a.m
JIRA.
- Nate Cole
On Nov. 20, 2017, 9:25 a.m., Sonia Garudi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63945/#review192168
---
Ship it!
Ship It!
- Nate Cole
On Nov. 20, 2017, 9:25 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64173/#review192166
---
Ship it!
Ship It!
- Nate Cole
On Nov. 29, 2017, 3 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64166/#review192165
---
Ship it!
Ship It!
- Nate Cole
On Nov. 29, 2017, 11:55 a.m
/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
a169eacc61
Diff: https://reviews.apache.org/r/64164/diff/1/
Testing
---
Manual testing. No new unit tests.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64161/#review192126
---
Ship it!
Ship It!
- Nate Cole
On Nov. 29, 2017, 9:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64050/#review192059
---
Ship it!
Ship It!
- Nate Cole
On Nov. 23, 2017, 10:31 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64127/#review192058
---
Ship it!
Ship It!
- Nate Cole
On Nov. 28, 2017, 1:54 p.m
/api/services/RootServiceComponentConfigurationService.java
Lines 97-99 (patched)
<https://reviews.apache.org/r/64089/#comment270019>
Nit: we've recently been using various builders for these:
Sets.newHashSet(...), Map builders and the like.
- Nate Cole
On Nov. 27, 2017, 3:52 p.m.,
To reply, visit:
> https://reviews.apache.org/r/64089/
> ---
>
> (Updated Nov. 27, 2017, 3:52 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene
> Chekanskiy, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert Nettleton, and
> Swapan Shridh
(patched)
<https://reviews.apache.org/r/64050/#comment269833>
HDFS should also have its type as HCFS, no? meaning, can we only EVER
check for service_type === HCFS?
- Nate Cole
On Nov. 23, 2017, 10:31 a.m., Attila Magyar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64043/#review191895
---
Ship it!
Ship It!
- Nate Cole
On Nov. 22, 2017, 7:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/#review191756
---
Ship it!
Ship It!
- Nate Cole
On Nov. 22, 2017, 1:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64030/#review191741
---
Ship it!
Ship It!
- Nate Cole
On Nov. 22, 2017, 9 a.m
/upgrade/UpgradeCatalog260.java
Line 365 (original), 368 (patched)
<https://reviews.apache.org/r/63961/#comment269497>
If things are working, then I'm ok with this.
- Nate Cole
On Nov. 21, 2017, 12:56 p.m., Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63982/#review191646
---
Ship it!
Ship It!
- Nate Cole
On Nov. 21, 2017, 5:58 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63962/#review191645
---
Ship it!
Ship It!
- Nate Cole
On Nov. 20, 2017, 2:27 p.m
/services/stack_advisor.py
Lines 531 (patched)
<https://reviews.apache.org/r/63957/#comment269375>
nit: "Please refer to the documentation..."
- Nate Cole
On Nov. 20, 2017, 12:06 p.m., Myroslav Pa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review191531
---
Ship it!
Ship It!
- Nate Cole
On Nov. 20, 2017, 12:06 p.m
by this change. If that
is the case, then a separate JIRA should be opened to address that.
- Nate Cole
On Nov. 17, 2017, 9:40 a.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
in/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
Lines 308-311 (original), 309-310 (patched)
<https://reviews.apache.org/r/63916/#comment269134>
This will happen only for Oozie servers, not the client
- Nate Cole
On Nov. 17, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63440/#review191246
---
Ship it!
Ship It!
- Nate Cole
On Nov. 6, 2017, 4:48 a.m
ent268884>
By saying no, ...
- Nate Cole
On Nov. 16, 2017, 8:27 a.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/version_builder.py 5bf54303ed
Diff: https://reviews.apache.org/r/63880/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63805/#review191028
---
Ship it!
Ship It!
- Nate Cole
On Nov. 14, 2017, 2:47 p.m
to confirm results.
No automated tests, as they exist already.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63807/#review191022
---
Ship it!
Ship It!
- Nate Cole
On Nov. 14, 2017, 4:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62656/#review190836
---
What is the status of this review?
- Nate Cole
On Sept. 28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63749/#review190834
---
Ship it!
Ship It!
- Nate Cole
On Nov. 13, 2017, 3:56 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63707/#review190832
---
Ship it!
Ship It!
- Nate Cole
On Nov. 10, 2017, 6:24 a.m
the review and
associated JIRA.
- Nate Cole
On Nov. 8, 2017, 9:27 a.m., Yussuf Shaikh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
pending.
Thanks,
Nate Cole
-2.5 to -2.6 as well?
- Nate Cole
On Nov. 8, 2017, 4:22 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Nov. 2, 2017, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 69-72 (patched)
> > <https://reviews.apache.org/r/63516/diff/1/?file=1879216#file1879216line71>
> &
;
We should check that one first as it's more consistent with the other
checks.
ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java
Lines 76 (patched)
<https://reviews.apache.org/r/63695/#comment268057>
Not service-specific
- Nate
1 - 100 of 891 matches
Mail list logo
