Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review127144 --- I dont think we should go down the route of breaking up the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review127148 ---

Re: Review Request 45753: AMBARI-15470: List of decommission-allowed components should be stack driven

2016-04-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45753/#review127152 --- Ship it! Thanks for adding this! - Alejandro Fernandez On

Review Request 45751: Alert definitions: Percentage params should be the percentage number instead of fraction number

2016-04-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45751/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15718

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45705/#review127127 --- Ship it! Ship It! - Jayush Luniya On April 4, 2016, 9:48

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-04-05 Thread Jayush Luniya
> On March 29, 2016, 12:49 p.m., Nate Cole wrote: > > I think you need a more concrete way of ordering here. What if two > > services are marked as YARN? Which one takes precedence? You may > > want to introduce an in order to > > specifically state how it happens. Order would be a

Review Request 45772: AMBARI-15638 [AMS] Sum Calculation Incorrect (Patch 2)

2016-04-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45772/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

2016-04-05 Thread Sid Wagle
> On April 5, 2016, 2:08 p.m., Dmytro Sen wrote: > > ambari-server/src/main/resources/scripts/export_ams_metrics.py, line 58 > > > > > > Can be https:// Since this is masking AMS endpoint it should be ok to not

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

2016-04-05 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45739/#review127114 --- Ship it! Ship It! - Dmytro Sen On Апрель 5, 2016, 11:09

Re: Review Request 45751: Alert definitions: Percentage params should be the percentage number instead of fraction number

2016-04-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45751/#review127128 --- Merge with https://reviews.apache.org/r/45705/ changes - Jayush

Re: Review Request 45719: Alert to notify if a HAWQ Segment is unregistered with HAWQ Master

2016-04-05 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45719/ --- (Updated April 5, 2016, 4:01 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-05 Thread Jayush Luniya
> On March 2, 2016, 6:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/default_stack_advisor.py, line 35 > > > > > > Please include Srimanth Gunturi in the code review, thanks! +1 on

Re: Review Request 45774: AMBARI-15720 AGGREGATE Alerts Should Not Expose Repeat Tolerance or Tolerance Enabled Settings

2016-04-05 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45774/#review127208 --- Ship it! Ship It! - Richard Zang On April 5, 2016, 8:46

Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-05 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45778/ --- Review request for Ambari and Jayush Luniya. Bugs: AMBARI-15577

Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite option out of experimental

2016-04-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45781/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg

Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-05 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45792/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. Bugs:

Re: Review Request 45786: Lifecycle for restarting LLAP on HiveServer Interactive via Custom Command

2016-04-05 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45786/#review127263 --- Ship it! Ship It! - Swapan Shridhar On April 6, 2016, 12:14

Re: Review Request 45785: Removing unknown host from cluster throws NPE

2016-04-05 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45785/#review127282 --- Ship it! Ship It! - Sumit Mohanty On April 6, 2016, 4 a.m.,

Review Request 45735: Dev Deploy: Unexpected error, database check failed

2016-04-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45735/ --- Review request for Ambari, Andrew Onischuk and Dmytro Sen. Bugs: AMBARI-15707

Re: Review Request 45736: "Wrong metrics path " exceptions for JMX metrics

2016-04-05 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45736/ --- (Updated Апрель 5, 2016, 10:06 д.п.) Review request for Ambari, Andrew

Re: Review Request 45735: Dev Deploy: Unexpected error, database check failed

2016-04-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45735/#review127074 --- Ship it! Ship It! - Andrew Onischuk On April 5, 2016, 9:27

Re: Review Request 45741: Exception thrown when host with unsupported OS is to be mapped to cluster is silently swallowed

2016-04-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45741/#review127084 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 5, 2016,

Re: Review Request 45742: Flume Handler Start fails while installing without HDFS

2016-04-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45742/#review127083 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 5, 2016,

Review Request 45743: Add visibility attribute into SCRIPT params

2016-04-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45743/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15666

Re: Review Request 45743: Add visibility attribute into SCRIPT params

2016-04-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45743/#review127085 --- Ship it! Ship It! - Vitalyi Brodetskyi On April 5, 2016,

Review Request 45744: AMBARI-15696: BulkCommand stop NodeManagers stops the wrong component

2016-04-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45744/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-15696

Review Request 45745: Starting MapR History Server Fails When NameNode is SSL

2016-04-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45745/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15713

Re: Review Request 45703: Allow skipping creation of repo files

2016-04-05 Thread Nate Cole
> On April 4, 2016, 10:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, > > lines 121-122 > > > > > > Is this really a warning? Kind of odd to warn on

Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

2016-04-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45739/ --- Review request for Ambari and Sid Wagle. Bugs: AMBARI-15710

Review Request 45741: Exception thrown when host with unsupported OS is to be mapped to cluster is silently swallowed

2016-04-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45741/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15711