Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Jayush Luniya]

> On March 23, 2016, 6:34 a.m., Jayush Luniya wrote:
> > Ship It!
> 
> Jayush Luniya wrote:
> Verified on live cluster

Committed to trunk. Thanks Juanjo!


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/#review124969
---


On March 22, 2016, 11:13 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45141/
> ---
> 
> (Updated March 22, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype detailed on AMBARI-13364 to 
> ZOOKEEPER service plus the comments and reviews received on:
> https://reviews.apache.org/r/44933/
> 
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> 
> stack_features is now a property in .json format in 
> HDP/2.0.6/properties/stack_features.json
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> 
> The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
> added to in a new StackFeature in 
> resource_management/libraries/functions/constants.py
> 
> It is added as part of the HDP stack configurations on 
> /HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
> property
> 
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> The stack version used in params_linux.py comparison is  
> stack_version_formatted = hostLevelParams\stack_version
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  0adaef9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  9ae8440 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  5f77f48 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45141/diff/
> 
> 
> Testing
> ---
> 
> Zookeeper fresh installation on top of latest trunk
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/#review124969
---


Ship it!




Ship It!

- Jayush Luniya


On March 22, 2016, 11:13 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45141/
> ---
> 
> (Updated March 22, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype detailed on AMBARI-13364 to 
> ZOOKEEPER service plus the comments and reviews received on:
> https://reviews.apache.org/r/44933/
> 
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> 
> stack_features is now a property in .json format in 
> HDP/2.0.6/properties/stack_features.json
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> 
> The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
> added to in a new StackFeature in 
> resource_management/libraries/functions/constants.py
> 
> It is added as part of the HDP stack configurations on 
> /HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
> property
> 
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> The stack version used in params_linux.py comparison is  
> stack_version_formatted = hostLevelParams\stack_version
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  0adaef9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  9ae8440 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  5f77f48 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45141/diff/
> 
> 
> Testing
> ---
> 
> Zookeeper fresh installation on top of latest trunk
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Jayush Luniya]

> On March 23, 2016, 6:34 a.m., Jayush Luniya wrote:
> > Ship It!

Verified on live cluster


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/#review124969
---


On March 22, 2016, 11:13 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45141/
> ---
> 
> (Updated March 22, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype detailed on AMBARI-13364 to 
> ZOOKEEPER service plus the comments and reviews received on:
> https://reviews.apache.org/r/44933/
> 
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> 
> stack_features is now a property in .json format in 
> HDP/2.0.6/properties/stack_features.json
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> 
> The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
> added to in a new StackFeature in 
> resource_management/libraries/functions/constants.py
> 
> It is added as part of the HDP stack configurations on 
> /HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
> property
> 
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> The stack version used in params_linux.py comparison is  
> stack_version_formatted = hostLevelParams\stack_version
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  0adaef9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  9ae8440 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  5f77f48 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45141/diff/
> 
> 
> Testing
> ---
> 
> Zookeeper fresh installation on top of latest trunk
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45188: update pxf-profile template with new fields and description

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45188/#review124949
---


Ship it!




Ship It!

- Matt


On March 22, 2016, 4:43 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45188/
> ---
> 
> (Updated March 22, 2016, 4:43 p.m.)
> 
> 
> Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, Lav Jain, and 
> Matt.
> 
> 
> Bugs: AMBARI-15522
> https://issues.apache.org/jira/browse/AMBARI-15522
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> update pxf-profile template with new fields and description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  7ce0f71 
> 
> Diff: https://reviews.apache.org/r/45188/diff/
> 
> 
> Testing
> ---
> 
> manual
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44972/
---

(Updated March 23, 2016, 12:56 a.m.)


Review request for Ambari, Di Li and Sid Wagle.


Bugs: AMBARI-15412
https://issues.apache.org/jira/browse/AMBARI-15412


Repository: ambari


Description
---

Improve error logging for install errors during blueprint deployments. 

Currently a severe error during install of a service component gets logged as a 
WARNing

E.g.:

09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - 
Operation failed - may be retried. Service component host: KAFKA_BROKER, host: 
hdtest159.svl.ibm.com Action id12-0


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 24fea22 

Diff: https://reviews.apache.org/r/44972/diff/


Testing
---

There are no JUnit test cases, but attached the screenshot which shows modified 
output.


File Attachments (updated)


Patch
  
https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch
Output
  
https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png
AMBARI-15412_branch-2.2.patch
  
https://reviews.apache.org/media/uploaded/files/2016/03/23/80355c33-2d5e-45f0-8f3d-1640f4386f05__AMBARI-15412_branch-2.2.patch


Thanks,

Amruta Borkar

Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44972/
---

(Updated March 23, 2016, 12:55 a.m.)


Review request for Ambari, Di Li and Sid Wagle.


Changes
---

It is correct that, as the trunk code has been refactored it wouldn’t be 
applied to trunk. I wanted to explore if the patch can be applied to any 
branch-2.x, so that it goes into next releases.


Bugs: AMBARI-15412
https://issues.apache.org/jira/browse/AMBARI-15412


Repository: ambari


Description
---

Improve error logging for install errors during blueprint deployments. 

Currently a severe error during install of a service component gets logged as a 
WARNing

E.g.:

09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - 
Operation failed - may be retried. Service component host: KAFKA_BROKER, host: 
hdtest159.svl.ibm.com Action id12-0


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 24fea22 

Diff: https://reviews.apache.org/r/44972/diff/


Testing
---

There are no JUnit test cases, but attached the screenshot which shows modified 
output.


File Attachments


Patch
  
https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch
Output
  
https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png


Thanks,

Amruta Borkar

Re: Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45187/#review124932
---


Fix it, then Ship it!





ambari-web/app/messages.js (line 1595)


Remove the last "should."


- Alejandro Fernandez


On March 23, 2016, 12:06 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45187/
> ---
> 
> (Updated March 23, 2016, 12:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, 
> Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15520
> https://issues.apache.org/jira/browse/AMBARI-15520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add more warning on Pause button saying no topology changes.
> 
> Really need to warn folks on not making any add hosts/RM HA/others.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 433834c 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> f1189a3 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 
> 6ec273c 
> 
> Diff: https://reviews.apache.org/r/45187/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 10488 tests complete (10 seconds)
> 121 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Jayush Luniya]

> On March 23, 2016, 12:18 a.m., Jayush Luniya wrote:
> > Thanks @Juanjo
> > 
> > Overall looks like. I will validate the patch sometime today and commit it. 
> > Can you also attach the patch to the JIRA and hit "Submit patch" button on 
> > the Apache JIRA so as to kickoff Hadoop QA build against the patch. 
> > Alternatively, if you have verified unit tests on the patch paste the outut 
> > of "mvn clean test" in the review under the "testing" section.

Nevermind looks like you already attached the patch to the JIRA.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/#review124930
---


On March 22, 2016, 11:13 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45141/
> ---
> 
> (Updated March 22, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype detailed on AMBARI-13364 to 
> ZOOKEEPER service plus the comments and reviews received on:
> https://reviews.apache.org/r/44933/
> 
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> 
> stack_features is now a property in .json format in 
> HDP/2.0.6/properties/stack_features.json
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> 
> The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
> added to in a new StackFeature in 
> resource_management/libraries/functions/constants.py
> 
> It is added as part of the HDP stack configurations on 
> /HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
> property
> 
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> The stack version used in params_linux.py comparison is  
> stack_version_formatted = hostLevelParams\stack_version
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  0adaef9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  9ae8440 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  5f77f48 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45141/diff/
> 
> 
> Testing
> ---
> 
> Zookeeper fresh installation on top of latest trunk
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/#review124930
---



Thanks @Juanjo

Overall looks like. I will validate the patch sometime today and commit it. Can 
you also attach the patch to the JIRA and hit "Submit patch" button on the 
Apache JIRA so as to kickoff Hadoop QA build against the patch. Alternatively, 
if you have verified unit tests on the patch paste the outut of "mvn clean 
test" in the review under the "testing" section.

- Jayush Luniya


On March 22, 2016, 11:13 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45141/
> ---
> 
> (Updated March 22, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype detailed on AMBARI-13364 to 
> ZOOKEEPER service plus the comments and reviews received on:
> https://reviews.apache.org/r/44933/
> 
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> 
> stack_features is now a property in .json format in 
> HDP/2.0.6/properties/stack_features.json
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> 
> The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
> added to in a new StackFeature in 
> resource_management/libraries/functions/constants.py
> 
> It is added as part of the HDP stack configurations on 
> /HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
> property
> 
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> The stack version used in params_linux.py comparison is  
> stack_version_formatted = hostLevelParams\stack_version
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  0adaef9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  9ae8440 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  5f77f48 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45141/diff/
> 
> 
> Testing
> ---
> 
> Zookeeper fresh installation on top of latest trunk
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45187/
---

(Updated March 23, 2016, 12:06 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, 
Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15520
https://issues.apache.org/jira/browse/AMBARI-15520


Repository: ambari


Description
---

Add more warning on Pause button saying no topology changes.

Really need to warn folks on not making any add hosts/RM HA/others.


Diffs (updated)
-

  ambari-web/app/messages.js 433834c 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
f1189a3 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 6ec273c 

Diff: https://reviews.apache.org/r/45187/diff/


Testing
---

Local ambari-web test passed.
10488 tests complete (10 seconds)
121 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45187/#review124923
---


Ship it!




Ship It!

- Richard Zang


On March 22, 2016, 11:42 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45187/
> ---
> 
> (Updated March 22, 2016, 11:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, 
> Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15520
> https://issues.apache.org/jira/browse/AMBARI-15520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add more warning on Pause button saying no topology changes.
> 
> Really need to warn folks on not making any add hosts/RM HA/others.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 1aaa112 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> 35c3617 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 
> 08f86f3 
> 
> Diff: https://reviews.apache.org/r/45187/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 10488 tests complete (10 seconds)
> 121 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45188: update pxf-profile template with new fields and description

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45188/#review124920
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On March 22, 2016, 11:43 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45188/
> ---
> 
> (Updated March 22, 2016, 11:43 p.m.)
> 
> 
> Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, Lav Jain, and 
> Matt.
> 
> 
> Bugs: AMBARI-15522
> https://issues.apache.org/jira/browse/AMBARI-15522
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> update pxf-profile template with new fields and description
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  7ce0f71 
> 
> Diff: https://reviews.apache.org/r/45188/diff/
> 
> 
> Testing
> ---
> 
> manual
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Review Request 45188: update pxf-profile template with new fields and description

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45188/
---

Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, Lav Jain, and Matt.


Bugs: AMBARI-15522
https://issues.apache.org/jira/browse/AMBARI-15522


Repository: ambari


Description
---

update pxf-profile template with new fields and description


Diffs
-

  
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
 7ce0f71 

Diff: https://reviews.apache.org/r/45188/diff/


Testing
---

manual


Thanks,

Alexander Denissov

Review Request 45187: AMBARI-15520 Add more warning on Pause button saying no topology changes.

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45187/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, 
Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15520
https://issues.apache.org/jira/browse/AMBARI-15520


Repository: ambari


Description
---

Add more warning on Pause button saying no topology changes.

Really need to warn folks on not making any add hosts/RM HA/others.


Diffs
-

  ambari-web/app/messages.js 1aaa112 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
35c3617 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 08f86f3 

Diff: https://reviews.apache.org/r/45187/diff/


Testing
---

Local ambari-web test passed.
10488 tests complete (10 seconds)
121 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py,
> >  line 32
> > 
> >
> > Use default function instead? 
> > 
> >   from resource_management.libraries.functions.default import default
> >   stack_features_config = 
> > default("/configurations/cluster-env/stack_tools", None)
> >   data = _DEFAULT_STACK_FEATURES
> >   if stack_features_config:
> > data = json.loads(stack_features_config)

It uses now default method and set the DEFAULT_STACK_FEATURES as value by 
default


> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py,
> >  line 35
> > 
> >
> > Add:-
> > 
> > stack_root = Script.get_stack_root()

stack_root is defined in status_params.py, since is needed there, and imported 
in params_linux.py:
stack_root = status_params.stack_root


> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py,
> >  line 55
> > 
> >
> > Replace "/usr/hdp" with "{stack_root}"

"/usr/hdp" paths have been replaced using stack_root  parameter in 
params_linux, status_params, zookeeper_service , zookeeper  python scripts.


> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py,
> >  line 58
> > 
> >
> > Leave config_dir logic as is as noted in my comment on status_params.py

I keept it as it was before. config_dir definition is in status_params and 
imported in params_linux
config_dir = status_params.config_dir


> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py,
> >  line 50
> > 
> >
> > We need to define config_dir in status_params as it will cause issue 
> > during zookeeper_server::security_status checks as only status_params is 
> > imported in security_status()
> > 
> >   def security_status(self, env):
> > import status_params
> > env.set_params(status_params)
> > if status_params.security_enabled:   
> > ...
> >   security_params = 
> > get_params_from_filesystem(status_params.config_dir,
> >
> > {'zookeeper_jaas.conf': FILE_TYPE_JAAS_CONF})
> 
> Juanjo  Marron wrote:
> Yes, thats true. My idea was to keep the version comparison at 
> params_linux.py level
> 
> To  maintain the logic I would need something like this in status_params:
> 
> config_dir = "/etc/zookeeper/conf"
> if stack_version_formatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_formatted):
>  config_dir = 
> format("{stack_root}/current/{component_directory}/conf")
> 
> stack_version_formatted , check_stack_feature , constants and stack_root 
> would need to be imported here at status_params.py level and they are 
> currently also imported at params_linux.py level. 
> 
> Due to import status_params in param_linux, it would be enought to 
> declare them in status_params: 
> Should I remove them from params_linux.py? 
> Should I keep them duplicated?
> 
> I couldnt find a good example in other services
> 
> Jayush Luniya wrote:
> Either works as far as it works. If you can avoid duplication and ensure 
> everything works well and good.

The needed parameters are defined  in status_params and imported in 
params_linux. For example:
stack_version_formatted = status_params.stack_version_formatted
stack_root = status_params.stack_root


> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py,
> >  line 132
> > 
> >
> > We are not importing params, only status_params (See line#115). Lets 
> > keep this as is.

I put config_dir back to status_params


> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 3
> > 
> >
> > I believe max_version for snappy should be 2.2.0.0?

It is corrected


- Juanjo


---
This is an automaticall

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/
---

(Updated March 22, 2016, 11:13 p.m.)


Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Changes
---

Uploaded new patch solving last set of comments


Bugs: AMBARI-14435
https://issues.apache.org/jira/browse/AMBARI-14435


Repository: ambari


Description
---

Apply the  stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER 
service plus the comments and reviews received on:
https://reviews.apache.org/r/44933/

This patch removes the hardcoded stack versions in ZK common-services code 
(centralized version and parameterized stack configurations will be faced in 
other JIRAS)

stack_features is now a property in .json format in 
HDP/2.0.6/properties/stack_features.json
With the structure:
{
"stack_features": [
{ "name": "feature1", "description" : "Feature1 support", "min_version" : 
"Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
, 
...
]
}
where min_version/max_version are optional constraints.

The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
added to in a new StackFeature in 
resource_management/libraries/functions/constants.py

It is added as part of the HDP stack configurations on 
/HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
property

New resource_management/libraries/functions/stack_fetaures.py has been 
introduced to parse the json file and called from service code to check if the 
stack supports the required feature.

The stack version used in params_linux.py comparison is  
stack_version_formatted = hostLevelParams\stack_version


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 0adaef9 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
 9ff9125 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
 9ae8440 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
 5712ce4 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 25ace24 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 d5b6898 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
 6fe0772 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
5f77f48 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45141/diff/


Testing
---

Zookeeper fresh installation on top of latest trunk


Thanks,

Juanjo  Marron

Re: Review Request 45143: AMBARI-15504. Host filter: minor UX edits

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45143/#review124892
---


Ship it!




Ship It!

- Xi Wang


On March 22, 2016, 2:09 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45143/
> ---
> 
> (Updated March 22, 2016, 2:09 p.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-15504
> https://issues.apache.org/jira/browse/AMBARI-15504
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Various UI fixes for combo search box.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 52e3b8e 
>   ambari-web/app/styles/application.less 7bf94e2 
>   ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4 
>   ambari-web/app/views/main/host/combo_search_box.js 2f86485 
>   ambari-web/test/views/main/host/combo_search_box_test.js 9c2e7b6 
> 
> Diff: https://reviews.apache.org/r/45143/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. All unit tests passed.
>   24635 tests complete (22 seconds)
>   145 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

[Swapan Shridhar]

> On March 22, 2016, 8:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml,
> >  line 390
> > 
> >
> > Why is this not a multiple of 8 or even 64?
> 
> Swapan Shridhar wrote:
> This value is in MB. So will still stay aligned on 8 byte boundary.
> 
> Swapan Shridhar wrote:
> 682 is generally taken default. But our YARN setting Scheduler -> 
> yarn.scheduler.capacity.root.default.maximum-capacity is not proper. Default 
> is 0.2 GB.. Thus, when LLAP shows up creating 2 instances and at the same 
> time some Service check creating YRAN app comes up. Everything hangs. and 
> times out.
> 
> Currently, I  modify 
> yarn.scheduler.capacity.root.default.maximum-capacity value (=1 (1 GB) 
> helps). Because LLAP creates 2 instance (341 *2) and Hive Interactive creates 
> 1 (341 *2 + 341) stays in 1024 MB limit.

"yarn.scheduler.capacity.maximum-am-resource-percent" instead of "" 
yarn.scheduler.capacity.root.default.maximum-capacity


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45175/#review124878
---


On March 22, 2016, 7:29 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45175/
> ---
> 
> (Updated March 22, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15518
> https://issues.apache.org/jira/browse/AMBARI-15518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of 
> existing props, added description.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
>  c4dee3e 
> 
> Diff: https://reviews.apache.org/r/45175/diff/
> 
> 
> Testing
> ---
> 
> Yes. Said props value enable LLAP and Hive Interactive to come up properly.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45143: AMBARI-15504. Host filter: minor UX edits

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45143/
---

(Updated March 22, 2016, 9:09 p.m.)


Review request for Ambari and Xi Wang.


Changes
---

Fix unit test


Bugs: AMBARI-15504
https://issues.apache.org/jira/browse/AMBARI-15504


Repository: ambari


Description
---

Various UI fixes for combo search box.


Diffs (updated)
-

  ambari-web/app/messages.js 52e3b8e 
  ambari-web/app/styles/application.less 7bf94e2 
  ambari-web/app/templates/main/host/combo_search_box.hbs ea6e2b4 
  ambari-web/app/views/main/host/combo_search_box.js 2f86485 
  ambari-web/test/views/main/host/combo_search_box_test.js 9c2e7b6 

Diff: https://reviews.apache.org/r/45143/diff/


Testing
---

Manually tested on live cluster. All unit tests passed.
  24635 tests complete (22 seconds)
  145 tests pending


Thanks,

Richard Zang

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

[Swapan Shridhar]

> On March 22, 2016, 8:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml,
> >  line 390
> > 
> >
> > Why is this not a multiple of 8 or even 64?
> 
> Swapan Shridhar wrote:
> This value is in MB. So will still stay aligned on 8 byte boundary.

682 is generally taken default. But our YARN setting Scheduler -> 
yarn.scheduler.capacity.root.default.maximum-capacity is not proper. Default is 
0.2 GB.. Thus, when LLAP shows up creating 2 instances and at the same time 
some Service check creating YRAN app comes up. Everything hangs. and times out.

Currently, I  modify yarn.scheduler.capacity.root.default.maximum-capacity 
value (=1 (1 GB) helps). Because LLAP creates 2 instance (341 *2) and Hive 
Interactive creates 1 (341 *2 + 341) stays in 1024 MB limit.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45175/#review124878
---


On March 22, 2016, 7:29 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45175/
> ---
> 
> (Updated March 22, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15518
> https://issues.apache.org/jira/browse/AMBARI-15518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of 
> existing props, added description.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
>  c4dee3e 
> 
> Diff: https://reviews.apache.org/r/45175/diff/
> 
> 
> Testing
> ---
> 
> Yes. Said props value enable LLAP and Hive Interactive to come up properly.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

[Swapan Shridhar]

> On March 22, 2016, 8:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml,
> >  line 390
> > 
> >
> > Why is this not a multiple of 8 or even 64?

This value is in MB. So will still stay aligned on 8 byte boundary.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45175/#review124878
---


On March 22, 2016, 7:29 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45175/
> ---
> 
> (Updated March 22, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15518
> https://issues.apache.org/jira/browse/AMBARI-15518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of 
> existing props, added description.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
>  c4dee3e 
> 
> Diff: https://reviews.apache.org/r/45175/diff/
> 
> 
> Testing
> ---
> 
> Yes. Said props value enable LLAP and Hive Interactive to come up properly.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45175/#review124878
---




ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
 (line 390)


Why is this not a multiple of 8 or even 64?


- Alejandro Fernandez


On March 22, 2016, 7:29 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45175/
> ---
> 
> (Updated March 22, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15518
> https://issues.apache.org/jira/browse/AMBARI-15518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of 
> existing props, added description.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
>  c4dee3e 
> 
> Diff: https://reviews.apache.org/r/45175/diff/
> 
> 
> Testing
> ---
> 
> Yes. Said props value enable LLAP and Hive Interactive to come up properly.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44725/#review124874
---


Ship it!




Ship It!

- Robert Nettleton


On March 22, 2016, 6:41 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44725/
> ---
> 
> (Updated March 22, 2016, 6:41 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15338
> https://issues.apache.org/jira/browse/AMBARI-15338
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After exporting blueprint from ranger enabled cluster 
> ranger.service.https.attrib.keystore.pass is exported.
> Which needs to be removed before using the same blueprint to create another 
> cluster
> Error Show when used same blueprint:
> { "status" : 400, "message" : "Blueprint configuration validation failed: 
> Secret references are not allowed in blueprints, replace following properties 
> with real passwords:\n Config:ranger-admin-site 
> Property:ranger.service.https.attrib.keystore.pass\n" }
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  4230862 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  0f62b2c 
> 
> Diff: https://reviews.apache.org/r/44725/diff/
> 
> 
> Testing
> ---
> 
> Modified test cases to test for if the properties that end with "pass" are 
> getting filtered. Other properties which have 'pass' else where in the name 
> will not get filtered.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45175/#review124869
---


Ship it!




Ship It!

- Jaimin Jetly


On March 22, 2016, 7:29 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45175/
> ---
> 
> (Updated March 22, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15518
> https://issues.apache.org/jira/browse/AMBARI-15518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of 
> existing props, added description.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
>  c4dee3e 
> 
> Diff: https://reviews.apache.org/r/45175/diff/
> 
> 
> Testing
> ---
> 
> Yes. Said props value enable LLAP and Hive Interactive to come up properly.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45150/#review124866
---


Ship it!




Ship It!

- Sid Wagle


On March 22, 2016, 7:44 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45150/
> ---
> 
> (Updated March 22, 2016, 7:44 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15476
> https://issues.apache.org/jira/browse/AMBARI-15476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix TimelineMetricAggregatorSecond such that time slices with no datapoints 
> for a series are given interpolated values based on nearby values.
> 
> Change METRIC_RECORD TTL to 2 days in distributed mode.
> 
> Add stack advisor recommendation for AMS HBase log directory based on AMS log 
> directory.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  aa12735 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  e8e16a7 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  6c8d153 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  b99d1f9 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  7a8984a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 61aa2ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  599ac3e 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 41da868 
> 
> Diff: https://reviews.apache.org/r/45150/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

[Aravindan Vijayan]

> On March 22, 2016, 7:01 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java,
> >  line 32
> > 
> >
> > Why create a new TreeMap?

Ignoring this since this method is not used currently.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45150/#review124856
---


On March 22, 2016, 7:44 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45150/
> ---
> 
> (Updated March 22, 2016, 7:44 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15476
> https://issues.apache.org/jira/browse/AMBARI-15476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix TimelineMetricAggregatorSecond such that time slices with no datapoints 
> for a series are given interpolated values based on nearby values.
> 
> Change METRIC_RECORD TTL to 2 days in distributed mode.
> 
> Add stack advisor recommendation for AMS HBase log directory based on AMS log 
> directory.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  aa12735 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  e8e16a7 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  6c8d153 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  b99d1f9 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  7a8984a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 61aa2ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  599ac3e 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 41da868 
> 
> Diff: https://reviews.apache.org/r/45150/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45150/
---

(Updated March 22, 2016, 7:44 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
---

Addressed review comments


Bugs: AMBARI-15476
https://issues.apache.org/jira/browse/AMBARI-15476


Repository: ambari


Description
---

Fix TimelineMetricAggregatorSecond such that time slices with no datapoints for 
a series are given interpolated values based on nearby values.

Change METRIC_RECORD TTL to 2 days in distributed mode.

Add stack advisor recommendation for AMS HBase log directory based on AMS log 
directory.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 aa12735 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 e8e16a7 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 6c8d153 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 b99d1f9 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 7a8984a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
61aa2ba 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
 599ac3e 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 41da868 

Diff: https://reviews.apache.org/r/45150/diff/


Testing
---

Manual testing done.

Added unit tests.


Thanks,

Aravindan Vijayan

Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45175/
---

Review request for Ambari, Jaimin Jetly and Sumit Mohanty.


Bugs: AMBARI-15518
https://issues.apache.org/jira/browse/AMBARI-15518


Repository: ambari


Description
---

Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of 
existing props, added description.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml
 c4dee3e 

Diff: https://reviews.apache.org/r/45175/diff/


Testing
---

Yes. Said props value enable LLAP and Hive Interactive to come up properly.


Thanks,

Swapan Shridhar

Re: Review Request 45150: AMBARI-15476 : [AMS / Grafana] Rate calculation with sum() is wrong

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45150/#review124856
---




ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
 (line 32)


Why create a new TreeMap?



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 81)


Add comment why this is changed this way.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 112)


Make this package private instead for visiblity to tests.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 190)


Same



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 234)


Braces.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 235)


formatting



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 259)


format



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 (line 315)


I think 72 hours makes sense since it goes past a 2 day weekend.


Add a config to disable interpolation all together.

- Sid Wagle


On March 22, 2016, 5:08 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45150/
> ---
> 
> (Updated March 22, 2016, 5:08 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15476
> https://issues.apache.org/jira/browse/AMBARI-15476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix TimelineMetricAggregatorSecond such that time slices with no datapoints 
> for a series are given interpolated values based on nearby values.
> 
> Change METRIC_RECORD TTL to 2 days in distributed mode.
> 
> Add stack advisor recommendation for AMS HBase log directory based on AMS log 
> directory.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  e8e16a7 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  6c8d153 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  b99d1f9 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  7a8984a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> d33e081 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  599ac3e 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 41da868 
> 
> Diff: https://reviews.apache.org/r/45150/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 44725: After exporting blueprint from ranger enabled cluster ranger.service.https.attrib.keystore.pass is exported

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44725/
---

(Updated March 22, 2016, 6:41 p.m.)


Review request for Ambari, Di Li and Robert Nettleton.


Changes
---

Uploading new patch with suggested changes. Created a new filter class to 
filter properties based on property_type present in Stack. Added test cases for 
the same.


Bugs: AMBARI-15338
https://issues.apache.org/jira/browse/AMBARI-15338


Repository: ambari


Description
---

After exporting blueprint from ranger enabled cluster 
ranger.service.https.attrib.keystore.pass is exported.
Which needs to be removed before using the same blueprint to create another 
cluster
Error Show when used same blueprint:
{ "status" : 400, "message" : "Blueprint configuration validation failed: 
Secret references are not allowed in blueprints, replace following properties 
with real passwords:\n Config:ranger-admin-site 
Property:ranger.service.https.attrib.keystore.pass\n" }


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 4230862 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 0f62b2c 

Diff: https://reviews.apache.org/r/44725/diff/


Testing
---

Modified test cases to test for if the properties that end with "pass" are 
getting filtered. Other properties which have 'pass' else where in the name 
will not get filtered.


Thanks,

Amruta Borkar

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/
---

(Updated March 22, 2016, 6:40 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-15388
https://issues.apache.org/jira/browse/AMBARI-15388


Repository: ambari


Description
---

Currently the upgrade is defined as a series of xml files specific to the 
current stack version and the target stack version. Each upgrade xml defines 
the overall sequence of the upgrade and what needs to be done for each service. 
It would both easier to maintain and easier to add new services, if the 
services themselves could specify what should be done during their upgrade.

There are two ways to make these changes, the alternate approach would be to 
only make the java changes and not split the upgrade xml files.  This would 
still allow new services to add themselves into the upgrade.  The benefit of 
this is that for the stack services you only have one upgrade xml file.  The 
problem with that is it is easier for a particular service to have 
unintentional changes between upgrade xml files.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
 9e2f997 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
c552e41 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 b860731 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 67d7fdb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 5cda422 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
440bd50 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
 430114b 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/slider.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/spark.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/sqoop.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/storm.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/tez.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/yarn.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/zookeeper.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 1b6cb8b 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3/accumulo.

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Tim Thorpe]

> On March 22, 2016, 6:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java,
> >  line 31
> > 
> >
> > Please give me some time to go through the design review and code 
> > review.
> > 
> > Thank you,
> > Alejandro

No rush.  Thanks for looking into it.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review124850
---


On March 22, 2016, 6:18 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated March 22, 2016, 6:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java
>  9e2f997 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  c552e41 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 440bd50 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/falcon.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hbase.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hdfs.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/hive.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/kafka.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/knox.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/oozie.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/ranger.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/storm.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/tez.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/configs/yarn.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  430114b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/falcon.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/flume.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hbase.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hdfs.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/hive.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/kafka.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/knox.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/oozie.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/pig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2/ranger.xml
>  PRE-CREATION 
>   
> a

Re: Review Request 43049: Oozie should update war after adding Falcon

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review124829
---




ambari-server/src/main/resources/scripts/Ambaripreupload.py (line 338)


This should be in a function to avoid duplicating code.
Or at a minimum, include a comment in both places indicating the other 
location to change.


- Alejandro Fernandez


On March 22, 2016, 2:57 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 22, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  c503a38 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 407bb2f 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 45160: 'ambari-server check database' failed

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45160/#review124809
---


Ship it!




Ship It!

- Andrew Onischuk


On March 22, 2016, 12:30 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45160/
> ---
> 
> (Updated March 22, 2016, 12:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
> 
> 
> Bugs: AMBARI-15514
> https://issues.apache.org/jira/browse/AMBARI-15514
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> 1) Install and setup Ambari with ORACLE_JDK_8
> 2) Stop ambari-server
> 3) reset ambari-server
> 4) remove ambari-server from host
> 5) install ambari-server
> 6) setup ambari with ORACLE_JDK_7
> 7) start ambari-server
> 8) Stop ambari-server
> 9) reset ambari-server
> 10) remove ambari-server from host
> 11) install ambari-server
> 12) setup ambari with custom jdk (set wrong JDK location)
> 13) execute ambari-server check-database
> 
> Result: 
> {code}
> Using python  /usr/bin/python
> Checking database
> Looking for available JDKs at /usr/jdk64
> Found: ['/usr/jdk64/jdk1.8.0_60', '/usr/jdk64/jdk1.7.0_67']
> Trying to use JDK /usr/jdk64/jdk1.8.0_60
> Selected JDK /usr/jdk64/jdk1.8.0_60
> ERROR: Unexpected ValueError: '' is not in list
> For more info run ambari-server with -v or --verbose option
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/checkDatabase.py 80eecc2 
> 
> Diff: https://reviews.apache.org/r/45160/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 44724: AMBARI-12906: Alert notifications are created even if credential fields are left empty

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44724/#review124805
---


Ship it!




Any unit tests to cover this?

- Jonathan Hurley


On March 20, 2016, 1:50 a.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44724/
> ---
> 
> (Updated March 20, 2016, 1:50 a.m.)
> 
> 
> Review request for Ambari, Di Li and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-12906
> https://issues.apache.org/jira/browse/AMBARI-12906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should not be allowed to save changes if the credential fields are left 
> empty when creating new Alert Notifications.
> 
> Steps to reproduce:
> 1. Create New Alert Notification
> 2. Enter Name = test
> 3. Tick the checkbox for 'Use Authentication'
> 4. Keep username and password empty
> 5. Click on Save
> 6. New alert notifications is created.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  79e524e 
>   ambari-web/app/messages.js 421143a 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs 0a83f63 
>   ambari-web/app/utils/validator.js 6426163 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  f16bf4d 
> 
> Diff: https://reviews.apache.org/r/44724/diff/
> 
> 
> Testing
> ---
> 
> FIX:
> 1. With the fix, user won't be allowd to to save changes if Email is selected 
> for alert notification and Use authentication is chosen and the credential 
> fields are left empty when creating new Alert Notifications or editing 
> existing Alert Notifications.
> 2. The error message "Username is required" will be shown if the Username is 
> empty.
> 3. The error message "Password is required" will be shown if the password is 
> empty. 
> The fix here uses a similar approach that was used for the Password 
> Confirmation error handling.
> 
> TESTS:
> The fix has been tested with HDP UI.
> manage_alert_notifications_controller_test.js has also been modified to test 
> changes.
> 
> The following is the result of running ambari-web tests:
> 
> 24957 tests complete (31 seconds)
> 145 tests pending
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 43049: Oozie should update war after adding Falcon

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review124803
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 22, 2016, 4:57 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 22, 2016, 4:57 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  c503a38 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 407bb2f 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 43049: Oozie should update war after adding Falcon

[Andrew Onischuk]

> On Feb. 2, 2016, 12:14 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py,
> >  line 269
> > 
> >
> > The ls command will only list the file names. This  should also contain 
> > the size in bytes and date modified, remove blank lines, and should be 
> > sorted.
> > 
> > ls -l {oozie_libext_dir} | awk '{print $9, $5, $6, $7, $8}' | awk 'NF > 
> > 0' | sort

nice one will do that, except for sort as ls already sorts entries 
alphabetically according to the 'man ls'


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/#review117314
---


On March 22, 2016, 2:57 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43049/
> ---
> 
> (Updated March 22, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14863
> https://issues.apache.org/jira/browse/AMBARI-14863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
> server/libext  
> Oozie war should be updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  c503a38 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 407bb2f 
> 
> Diff: https://reviews.apache.org/r/43049/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 43049: Oozie should update war after adding Falcon

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43049/
---

(Updated March 22, 2016, 2:57 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-14863
https://issues.apache.org/jira/browse/AMBARI-14863


Repository: ambari


Description
---

After adding Falcon, falcon-oozie-el-extension-*.jar is added to oozie-
server/libext  
Oozie war should be updated.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 c503a38 
  ambari-server/src/main/resources/scripts/Ambaripreupload.py 941539c 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 407bb2f 

Diff: https://reviews.apache.org/r/43049/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 44986: AMBARI-15474: Listen for changes to auto-start configuration and send them to the agent during heartbeats

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44986/
---

(Updated March 22, 2016, 7:19 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Changes
---

1. isConfigStale() - throw exception if cluster name or host name is null.
2. Added comments.


Bugs: AMBARI-15474
https://issues.apache.org/jira/browse/AMBARI-15474


Repository: ambari


Description
---

AMBARI-15474: Listen for changes to auto-start configuration and send them to 
the agent during heartbeats.

In HeartbeatHandler::handleHeartBeat(), send the recovery configuration to the 
agent. Instead of pulling the recovery configuration from the application 
cache, implement change events and get notified whenever there are changes to 
the recovery configuration.

**Changes**:
1. Instead of sending the recovery configuration to the agent during every 
heartbeat (10 seconds interval), send the configuration only when changes are 
detected.
2. Used AmbariEventPublisher to publish the changes. RecoveryConfigHelper is 
the subscriber which listens to changes to the configuration.
3. RecoveryConfigHelper maintains a map of Cluster-->Host-->Timestamp which is 
the last updated timestamp of the recovery configuration. This timestamp is 
used as a token and is sent to the agent with the configuration. The agent 
provides this timestamp during each heartbeat. If the timestamp from the 
heartbeat is the same as the one on the server side, no configuration is sent 
to the agent.
4. Whenever changes are detected, the timestamp is invalidated. During the next 
heartbeat, the recovery configuration is read from the DB and sent to the agent 
along with the latest timestamp.
5. Added new unit tests to test each configuration change event.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/Controller.py 
c1c16ac97cca0d2677da2e26eee7b4949a4bf15c 
  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 
b28644c834a2387d2fb0ad17d104224e830a0245 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 
ed537ca6928ce376c5f3e906f7a47c3f1919e309 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java 
1430aa20cf68db071be85c4ad2ebb9acdaccecc0 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 3a80803724bcb6ca9e4ec875aa17c9ac1c66fbe8 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java
 617b04b5b8768ba28a3c8ecb6e5e00601f153396 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfig.java 
c2c18462c586292caaf40bdb6a25a8fe9a39d76c 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java
 92a622117c71ddfc3bd2562c04ee525491bd6ffd 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
78731854fe80c3d6087a73ebf00b0ffe9e287354 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java
 2ce01236b3bb1ab4934fe456e5669fa474987426 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentRecoveryChangedEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
 19712cdb18592816f82898cd7aa08a3600c7e1f4 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
2cc3d0013140c9c7d3453d7c5e05c3aa02bc5794 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 4be1c21bf41416681be836716ce38305cc3f287e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 3a0075e3a3c90088ca6bd2d9eca48ef50db9fdb3 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 b1f94e38f97550123dd366984438b0bbf9c2826c 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
 c86b95a7cd10b0720f0a3b9676f65a8bd68dd6c9 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
 1bf9d8336533bc677384314f998f10aa2f10504e 

Diff: https://reviews.apache.org/r/44986/diff/


Testing
---

**1. mvn clean install **


[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [5.864s]
[INFO] Apache Ambari Project POM . SUCCESS [0.037s]
[INFO] Ambari Web  SUCCESS [23.683s]
[INFO] Ambari Views .. SUCCESS [1.069s]
[INFO] Ambari Admin View . SUCCESS [5.949s]
[INFO] ambari-metrics 

Re: Review Request 45145: Atlas alert present when WE is enabled

[Tom Beerbower]

> On March 22, 2016, 1:37 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py,
> >  line 117
> > 
> >
> > Have you seen the `curl_krb_request` stuff. This may come in handy. It 
> > helps with managing the credential cache and setting the cache so that it 
> > doesn't mess with the user's interactive cache. 
> > 
> > Take a look, you might want to incorporrate it.

Thanks for the review!

I didn't know about curl_krb_request.  I'll look into it and open a separate 
Jira to make use of it.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45145/#review124789
---


On March 22, 2016, 1:27 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45145/
> ---
> 
> (Updated March 22, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-15500
> https://issues.apache.org/jira/browse/AMBARI-15500
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Two alerts are critical: Atlas Metadata Server Process, Metadata Server Web 
> UI.
> 
> Atlas alerts are checking wrong port (http not https) when wire encryption is 
> enabled.
> 
> In the file "common-services/ATLAS/0.1.0.2.3/package/scripts/params.py" there 
> is code that sets the curl command that is used to connect to the atlas 
> service during the smoke test. It appears that this code has "http" hard 
> coded.
> 
> if security_enabled:
> smoke_cmd = format('curl --negotiate -u : -b ~/cookiejar.txt -c 
> ~/cookiejar.txt -s -o /dev/null -w "%{{http_code}}" 
> http://{metadata_host}:{metadata_port}/')
> else:
> smoke_cmd = format('curl -s -o /dev/null -w "%{{http_code}}" 
> http://{metadata_host}:{metadata_port}/')
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c5059dd 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json b48ae97 
> 
> Diff: https://reviews.apache.org/r/45145/diff/
> 
> 
> Testing
> ---
> 
> Manual test Ambari / Atlas service check.
> 
> mvn clean test
> 
> all pass
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 45145: Atlas alert present when WE is enabled

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45145/#review124789
---


Ship it!





ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 117)


Have you seen the `curl_krb_request` stuff. This may come in handy. It 
helps with managing the credential cache and setting the cache so that it 
doesn't mess with the user's interactive cache. 

Take a look, you might want to incorporrate it.


- Robert Levas


On March 21, 2016, 9:27 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45145/
> ---
> 
> (Updated March 21, 2016, 9:27 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-15500
> https://issues.apache.org/jira/browse/AMBARI-15500
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Two alerts are critical: Atlas Metadata Server Process, Metadata Server Web 
> UI.
> 
> Atlas alerts are checking wrong port (http not https) when wire encryption is 
> enabled.
> 
> In the file "common-services/ATLAS/0.1.0.2.3/package/scripts/params.py" there 
> is code that sets the curl command that is used to connect to the atlas 
> service during the smoke test. It appears that this code has "http" hard 
> coded.
> 
> if security_enabled:
> smoke_cmd = format('curl --negotiate -u : -b ~/cookiejar.txt -c 
> ~/cookiejar.txt -s -o /dev/null -w "%{{http_code}}" 
> http://{metadata_host}:{metadata_port}/')
> else:
> smoke_cmd = format('curl -s -o /dev/null -w "%{{http_code}}" 
> http://{metadata_host}:{metadata_port}/')
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c5059dd 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_service_check.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json b48ae97 
> 
> Diff: https://reviews.apache.org/r/45145/diff/
> 
> 
> Testing
> ---
> 
> Manual test Ambari / Atlas service check.
> 
> mvn clean test
> 
> all pass
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
---

(Updated March 22, 2016, 1:03 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and 
Yusaku Sako.


Changes
---

added proper indentation in the apache licence comments as per the standards.


Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
---

Earlier : 
logs of all the views used to go into ambari-server.log which caused problem in 
debugging views.

In this Patch:
ViewRegistry now looks for file
 view.log4j.properties using the view archive classloader and loads all the
 log4j properties in it using PropertyConfigurator. Separate log4j
 configuraiton files added to all core views.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
6a01351 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
144926a 
  contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
  contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
  contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
  contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
  contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
  contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
  contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 

Diff: https://reviews.apache.org/r/44700/diff/


Testing
---

Manual Testing Done.
separate log files for each view was properly generated. Also the log level was 
getting properly set.


Thanks,

Nitiraj Rathore

Review Request 45160: 'ambari-server check database' failed

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45160/
---

Review request for Ambari, Andrew Onischuk and Dmytro Sen.


Bugs: AMBARI-15514
https://issues.apache.org/jira/browse/AMBARI-15514


Repository: ambari


Description
---

*STR:*
1) Install and setup Ambari with ORACLE_JDK_8
2) Stop ambari-server
3) reset ambari-server
4) remove ambari-server from host
5) install ambari-server
6) setup ambari with ORACLE_JDK_7
7) start ambari-server
8) Stop ambari-server
9) reset ambari-server
10) remove ambari-server from host
11) install ambari-server
12) setup ambari with custom jdk (set wrong JDK location)
13) execute ambari-server check-database

Result: 
{code}
Using python  /usr/bin/python
Checking database
Looking for available JDKs at /usr/jdk64
Found: ['/usr/jdk64/jdk1.8.0_60', '/usr/jdk64/jdk1.7.0_67']
Trying to use JDK /usr/jdk64/jdk1.8.0_60
Selected JDK /usr/jdk64/jdk1.8.0_60
ERROR: Unexpected ValueError: '' is not in list
For more info run ambari-server with -v or --verbose option
{code}


Diffs
-

  ambari-server/src/main/python/ambari_server/checkDatabase.py 80eecc2 

Diff: https://reviews.apache.org/r/45160/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/#review124774
---




contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 
8)


Try to give a space after #. Just from the conventions point of view.


- DIPAYAN BHOWMICK


On March 22, 2016, 10:20 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44700/
> ---
> 
> (Updated March 22, 2016, 10:20 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14084
> https://issues.apache.org/jira/browse/AMBARI-14084
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> logs of all the views used to go into ambari-server.log which caused problem 
> in debugging views.
> 
> In this Patch:
> ViewRegistry now looks for file
>  view.log4j.properties using the view archive classloader and loads all the
>  log4j properties in it using PropertyConfigurator. Separate log4j
>  configuraiton files added to all core views.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 6a01351 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 144926a 
>   contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
>   contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
>   contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
>   contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
>   contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
>   contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
>   contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 
> 
> Diff: https://reviews.apache.org/r/44700/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> separate log files for each view was properly generated. Also the log level 
> was getting properly set.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 44700: Ambari Views : each view should have separate log file for better troubleshooting

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44700/
---

(Updated March 22, 2016, 10:20 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, and 
Yusaku Sako.


Changes
---

added apache licence and incorporated review comments


Bugs: AMBARI-14084
https://issues.apache.org/jira/browse/AMBARI-14084


Repository: ambari


Description
---

Earlier : 
logs of all the views used to go into ambari-server.log which caused problem in 
debugging views.

In this Patch:
ViewRegistry now looks for file
 view.log4j.properties using the view archive classloader and loads all the
 log4j properties in it using PropertyConfigurator. Separate log4j
 configuraiton files added to all core views.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
6a01351 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
144926a 
  contrib/views/files/src/main/resources/view.log4j.properties b47fd80 
  contrib/views/hive/src/main/resources/view.log4j.properties 3e9454b 
  contrib/views/jobs/src/main/resources/view.log4j.properties da54ebf 
  contrib/views/pig/src/main/resources/view.log4j.properties fcd57eb 
  contrib/views/slider/src/main/resources/view.log4j.properties 68541af 
  contrib/views/storm/src/main/resources/view.log4j.properties 3383137 
  contrib/views/tez/src/main/resources/view.log4j.properties ae1f5ce 

Diff: https://reviews.apache.org/r/44700/diff/


Testing
---

Manual Testing Done.
separate log files for each view was properly generated. Also the log level was 
getting properly set.


Thanks,

Nitiraj Rathore

Re: Review Request 44859: Cannot specify ZooKeeper heap size via UI

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44859/#review124764
---


Ship it!




Ship It!

- Dmytro Sen


On Март 21, 2016, 8:42 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44859/
> ---
> 
> (Updated Март 21, 2016, 8:42 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-15429
> https://issues.apache.org/jira/browse/AMBARI-15429
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> zookeeper-env template has the following:
> export SERVER_JVMFLAGS=zk_server_heapsize
> However, we don't have any heap size property that is exposed via the UI, so 
> 1GB heapsize is always used.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  fec325c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zookeeper-env.xml
>  7ef62bc 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
> 
> Diff: https://reviews.apache.org/r/44859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 44859: Cannot specify ZooKeeper heap size via UI

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44859/#review124756
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On March 21, 2016, 10:42 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44859/
> ---
> 
> (Updated March 21, 2016, 10:42 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-15429
> https://issues.apache.org/jira/browse/AMBARI-15429
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> zookeeper-env template has the following:
> export SERVER_JVMFLAGS=zk_server_heapsize
> However, we don't have any heap size property that is exposed via the UI, so 
> 1GB heapsize is always used.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  fec325c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zookeeper-env.xml
>  7ef62bc 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
> 
> Diff: https://reviews.apache.org/r/44859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Jayush Luniya]

> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py,
> >  line 50
> > 
> >
> > We need to define config_dir in status_params as it will cause issue 
> > during zookeeper_server::security_status checks as only status_params is 
> > imported in security_status()
> > 
> >   def security_status(self, env):
> > import status_params
> > env.set_params(status_params)
> > if status_params.security_enabled:   
> > ...
> >   security_params = 
> > get_params_from_filesystem(status_params.config_dir,
> >
> > {'zookeeper_jaas.conf': FILE_TYPE_JAAS_CONF})
> 
> Juanjo  Marron wrote:
> Yes, thats true. My idea was to keep the version comparison at 
> params_linux.py level
> 
> To  maintain the logic I would need something like this in status_params:
> 
> config_dir = "/etc/zookeeper/conf"
> if stack_version_formatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_formatted):
>  config_dir = 
> format("{stack_root}/current/{component_directory}/conf")
> 
> stack_version_formatted , check_stack_feature , constants and stack_root 
> would need to be imported here at status_params.py level and they are 
> currently also imported at params_linux.py level. 
> 
> Due to import status_params in param_linux, it would be enought to 
> declare them in status_params: 
> Should I remove them from params_linux.py? 
> Should I keep them duplicated?
> 
> I couldnt find a good example in other services

Either works as far as it works. If you can avoid duplication and ensure 
everything works well and good.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/#review124702
---


On March 22, 2016, 1:50 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45141/
> ---
> 
> (Updated March 22, 2016, 1:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype detailed on AMBARI-13364 to 
> ZOOKEEPER service plus the comments and reviews received on:
> https://reviews.apache.org/r/44933/
> 
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> 
> stack_features is now a property in .json format in 
> HDP/2.0.6/properties/stack_features.json
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> 
> The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
> added to in a new StackFeature in 
> resource_management/libraries/functions/constants.py
> 
> It is added as part of the HDP stack configurations on 
> /HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
> property
> 
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> The stack version used in params_linux.py comparison is  
> stack_version_formatted = hostLevelParams\stack_version
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  0adaef9 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  9ae8440 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main