Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47941/
---

Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-16920
https://issues.apache.org/jira/browse/AMBARI-16920


Repository: ambari


Description
---

This a followup ticket for add spark2 stack definition. There's serveral issues:
1.  Spark2 thrift server can not started due to miss of 
spark-thrift-fairscheduler.xml
2.  Miss of add spark2 cache file in copy_barball.py
3.  Miss the role_commnad_order of spark2


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
 286df8d 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 ded9959 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 2eae3e7 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
4a7c1d2 

Diff: https://reviews.apache.org/r/47941/diff/


Testing
---

Manually verified.


Thanks,

Jeff Zhang

Re: Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47914/#review135141
---


Ship it!




Ship It!

- Sumit Mohanty


On May 27, 2016, 12:49 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47914/
> ---
> 
> (Updated May 27, 2016, 12:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16910
> https://issues.apache.org/jira/browse/AMBARI-16910
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Right now the timeout is 15 secs for LLAP alert.
> - **Reason to  increase:** Right now the command timeouts, because 15 secs is 
> less for it to complete depending on the cluster.
> - 
> - - Further, modified the messages displayed as part of alert.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
> 0fad732 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  b18c366 
> 
> Diff: https://reviews.apache.org/r/47914/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> 
> 
> File Attachments
> 
> 
> NOT RUNNING state
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/27/3579b990-22fd-41cc-8d3b-1c9d10d79a23__Screen_Shot_2016-05-26_at_5.34.45_PM.png
> RUNNING state
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/27/b9c22854-8c5f-463c-bc3d-e1b38ea7c351__Screen_Shot_2016-05-26_at_5.32.15_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47939: AMBARI-16919. Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations'][capacity-scheduler][properties][capacit

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47939/#review135142
---


Ship it!




Ship It!

- Sumit Mohanty


On May 27, 2016, 2:03 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47939/
> ---
> 
> (Updated May 27, 2016, 2:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16919
> https://issues.apache.org/jira/browse/AMBARI-16919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16888 handled the scenario when capacity-scheduler is passed in as 
> dictionary and 
> services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"]
>  set as value = "null".
> 
> --
> "capacity-scheduler" : {
>   "properties" : {
> "capacity-scheduler" : "null",
> "yarn.scheduler.capacity.root.accessible-node-labels" : "*",
> "yarn.scheduler.capacity.maximum-am-resource-percent" : "1",
> "yarn.scheduler.capacity.root.acl_administer_queue" : "*",
> "yarn.scheduler.capacity.queue-mappings-override.enable" : 
> 'false',
> "yarn.scheduler.capacity.root.default.capacity" : "100",
> "yarn.scheduler.capacity.root.default.user-limit-factor" : "1",
> "yarn.scheduler.capacity.root.queues" : "default",
> "yarn.scheduler.capacity.root.capacity" : "100",
> "yarn.scheduler.capacity.root.default.acl_submit_applications" : 
> "*",
> "yarn.scheduler.capacity.root.default.maximum-capacity" : "100",
> "yarn.scheduler.capacity.node-locality-delay" : "40",
> "yarn.scheduler.capacity.maximum-applications" : "1",
> "yarn.scheduler.capacity.root.default.state" : "RUNNING"
>   }
> },
> --
> 
> 
> But. there can be another scenario where passed-in 'capacity-scheduler' is 
> like :
> 
> --
> "capacity-scheduler" : {
>   "properties" : {
> "capacity-scheduler" : null,
> "yarn.scheduler.capacity.root.accessible-node-labels" : "*",
> "yarn.scheduler.capacity.maximum-am-resource-percent" : "1",
> "yarn.scheduler.capacity.root.acl_administer_queue" : "*",
> "yarn.scheduler.capacity.queue-mappings-override.enable" : 
> 'false',
> "yarn.scheduler.capacity.root.default.capacity" : "100",
> "yarn.scheduler.capacity.root.default.user-limit-factor" : "1",
> "yarn.scheduler.capacity.root.queues" : "default",
> "yarn.scheduler.capacity.root.capacity" : "100",
> "yarn.scheduler.capacity.root.default.acl_submit_applications" : 
> "*",
> "yarn.scheduler.capacity.root.default.maximum-capacity" : "100",
> "yarn.scheduler.capacity.node-locality-delay" : "40",
> "yarn.scheduler.capacity.maximum-applications" : "1",
> "yarn.scheduler.capacity.root.default.state" : "RUNNING"
>   }
> },
> --
> 
> Here, 
> services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"]
>  is itself 'null'. 
> 
> We get into reading capacity-scheduler configs as key-value only if we dont 
> find configs passed in as singl e'\n' string at level 
> services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"].
> 
> 
> - Also, added loggiong for Blueprint Strategy used.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  4e404bc 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 44407ca 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 01064a6 
> 
> Diff: https://reviews.apache.org/r/47939/diff/
> 
> 
> Testing
> ---
> 
> Added the Python UT.
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On May 18, 2016, 11:53 p.m., Jayush Luniya wrote:
> > @Jeff 
> > Can you verify that blueprint deployment of the cluster without Livy Server 
> > works? 
> > 
> > Guide on Blueprints
> > https://cwiki.apache.org/confluence/display/AMBARI/Blueprints
> 
> Jayush Luniya wrote:
> @Jeff whats the latest on this? Did you get the blueprint scenario 
> verified? Also can you update the patch with latest in trunk?
> 
> Jeff Zhang wrote:
> @Jayush, I have some issues when verifying blueprint, also ask for help 
> to ambari mail list, but still not progress yet, could you help on that ? 
> http://mail-archives.apache.org/mod_mbox/ambari-user/201605.mbox/%3CCAADy7x7ha6amOjmNFCQN2bKpMACGbLJr3uDxKjPCn=jph_7...@mail.gmail.com%3E

Ping @Jayush


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review133841
---


On May 26, 2016, 3:22 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 26, 2016, 3:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  775e7eb 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  aa64528 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3cae192 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 6e506a0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 4013835 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47914/
---

(Updated May 27, 2016, 12:49 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated description.


Bugs: AMBARI-16910
https://issues.apache.org/jira/browse/AMBARI-16910


Repository: ambari


Description (updated)
---

- Right now the timeout is 15 secs for LLAP alert.
- **Reason to  increase:** Right now the command timeouts, because 15 secs is 
less for it to complete depending on the cluster.
- 
- - Further, modified the messages displayed as part of alert.


Diffs
-

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
0fad732 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 b18c366 

Diff: https://reviews.apache.org/r/47914/diff/


Testing
---

- Python UT passes.


File Attachments


NOT RUNNING state
  
https://reviews.apache.org/media/uploaded/files/2016/05/27/3579b990-22fd-41cc-8d3b-1c9d10d79a23__Screen_Shot_2016-05-26_at_5.34.45_PM.png
RUNNING state
  
https://reviews.apache.org/media/uploaded/files/2016/05/27/b9c22854-8c5f-463c-bc3d-e1b38ea7c351__Screen_Shot_2016-05-26_at_5.32.15_PM.png


Thanks,

Swapan Shridhar

Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47914/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-16910
https://issues.apache.org/jira/browse/AMBARI-16910


Repository: ambari


Description
---

- Right now the timeout is 15 secs for LLAP alert.
- **Reason to  increase:** Right now the command timeouts, because 15 secs is 
less for it to complete depending on the cluster.


Diffs
-

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
0fad732 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 b18c366 

Diff: https://reviews.apache.org/r/47914/diff/


Testing
---

- Python UT passes.


File Attachments


NOT RUNNING state
  
https://reviews.apache.org/media/uploaded/files/2016/05/27/3579b990-22fd-41cc-8d3b-1c9d10d79a23__Screen_Shot_2016-05-26_at_5.34.45_PM.png
RUNNING state
  
https://reviews.apache.org/media/uploaded/files/2016/05/27/b9c22854-8c5f-463c-bc3d-e1b38ea7c351__Screen_Shot_2016-05-26_at_5.32.15_PM.png


Thanks,

Swapan Shridhar

Review Request 47934: clean up import * for SLIDER service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47934/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16744
https://issues.apache.org/jira/browse/AMBARI-16744


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for SLIDER service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_windows.py
 fdb8160 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py
 91e4959 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py
 8d80700 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
 13f7848 

Diff: https://reviews.apache.org/r/47934/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
SLIDER fresh installation and service check

Hadoop QA added a comment - 18 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12805250/AMBARI-16744.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6988//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6988//console
This message is automatically generated.
Reply


Thanks,

Juanjo  Marron

Re: Review Request 47920: Enable HS2 Interactive > Select Hosts does not have Cancel and close

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47920/#review135117
---


Ship it!




Ship It!

- Yusaku Sako


On May 26, 2016, 10:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47920/
> ---
> 
> (Updated May 26, 2016, 10:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-16911
> https://issues.apache.org/jira/browse/AMBARI-16911
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change the primary button text from "save" to "select" as at this point we 
> are not saving the selection. It gets saved when "save configurations" 
> happens for Hive service.
> 2. We can show close/cancel button but on clicking those buttons we need to 
> show another popup with the warning message that "Interactive query cannot be 
> enabled without "Not selecting HiveServer2 Interactive host will disable 
> interactive query". If user acknowledge that, we need to dismiss this warning 
> popup, "Select hosts" popup and revert the changed config "Enable interactive 
> query" from "yes" to "no". As I said "Enabling interactive query and 
> selecting HSI host are atomic operations." If we are rolling back from 
> selecting HSI host then we need to disable interactive query as well.
> 3. Change HiveServer2 endpoint label to HiveServer2 JDBC URL label
> 4. Change class span-6 to span-12 for summary info section of Hive Service
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/summary.js eb0e850 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 7a610da 
>   ambari-web/app/messages.js 8763721 
>   ambari-web/app/templates/common/assign_master_components.hbs 893d1e6 
>   ambari-web/app/views/common/assign_master_components_view.js 95ba766 
>   ambari-web/app/views/main/service/services/hive.js d306433 
>   ambari-web/app/views/wizard/step7/assign_master_view.js d6a456f 
> 
> Diff: https://reviews.apache.org/r/47920/diff/
> 
> 
> Testing
> ---
> 
> Verified that the patch addresses the issue manually. attached snpashot of 
> the changes to the Jira.
> 
> Verified that the patch passes all ambari-web unit tests:
> 27856 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 47926: Use postgres database instead of template1 during service check in HAWQ

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47926/#review135116
---


Ship it!




Ship It!

- Lav Jain


On May 26, 2016, 11:24 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47926/
> ---
> 
> (Updated May 26, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16917
> https://issues.apache.org/jira/browse/AMBARI-16917
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Use postgres database instead of template1 during service check in HAWQ. 
> template1 database is used as a default template while creating new 
> databases, so anything in template1 gets carried over to the new database.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
>  17724bc 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
>  e916f07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  4a75a78 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  f37b13f 
> 
> Diff: https://reviews.apache.org/r/47926/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 47933: Add conditional constraints for Kerberos identities to control when they are created

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, and Sandor 
Magyari.


Bugs: AMBARI-16437
https://issues.apache.org/jira/browse/AMBARI-16437


Repository: ambari


Description
---

Add conditional constraints for Kerberos identities to control when they are 
created. For example if Kerberos Identity should only be created (and 
distributed) for a component when some other component or service is installed. 

An example of this would be
```
{
  "name": "/HIVE/HIVE_SERVER/hive_server_hive",
  "principal": {
"configuration": "hive-interactive-site/hive.llap.daemon.service.principal"
  },
  "keytab": {
"configuration": "hive-interactive-site/hive.llap.daemon.keytab.file"
  },
  "when" : {
  "contains" : ["services", "HIVE"]
  }
}
```

Note the "`when`" clause. This indicates that this identity should only be 
processed when the set of services contains "HIVE".  An alternative to this 
would be to test the set of components for a certain component.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 c67c55d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 0dbd357 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 bb2ed1c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 d31dd21 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/AndPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/ContainsPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/ContextTransformer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/DelegatedMultiplePredicateContainer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/DelegatedSinglePredicateContainer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/EqualsPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/NotPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/OperationPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/OrPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/Predicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/PredicateClassFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/eval/PredicateUtils.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 5393fd6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 d80d7cc 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
 0ea7b26 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/AndPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/ContainsPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/ContextTransformerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/EqualsPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/NotPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/OrPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/eval/PredicateUtilsTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47933/diff/


Testing
---

Manually tested 

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Review Request 47926: Use postgres database instead of template1 during service check in HAWQ

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47926/
---

Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.


Bugs: AMBARI-16917
https://issues.apache.org/jira/browse/AMBARI-16917


Repository: ambari


Description
---

Use postgres database instead of template1 during service check in HAWQ. 
template1 database is used as a default template while creating new databases, 
so anything in template1 gets carried over to the new database.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
 17724bc 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py
 e916f07 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
 4a75a78 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 f37b13f 

Diff: https://reviews.apache.org/r/47926/diff/


Testing
---

yes.


Thanks,

bhuvnesh chaudhary

Review Request 47923: clean up import * for SPARK service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16797
https://issues.apache.org/jira/browse/AMBARI-16797


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for SPARK service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
 bccd714 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
 eca8534 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
 3838061 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
 9311454 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 

Diff: https://reviews.apache.org/r/47923/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
PIG fresh installation and service check

Hadoop QA added a comment - 1 hour ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47922: clean up import * for KNOX service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47922/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16669
https://issues.apache.org/jira/browse/AMBARI-16669


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for KNOX service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
 fbd879f 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 1917369 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py
 dee0154 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 5d454de 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
 e7a3747 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py
 5e9b89e 

Diff: https://reviews.apache.org/r/47922/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
KNOX fresh installation and service check

Hadoop QA added a comment - 7 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12805363/AMBARI-16669.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6985//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6985//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47920: Enable HS2 Interactive > Select Hosts does not have Cancel and close

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47920/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku 
Sako.


Bugs: AMBARI-16911
https://issues.apache.org/jira/browse/AMBARI-16911


Repository: ambari


Description
---

1. Change the primary button text from "save" to "select" as at this point we 
are not saving the selection. It gets saved when "save configurations" happens 
for Hive service.
2. We can show close/cancel button but on clicking those buttons we need to 
show another popup with the warning message that "Interactive query cannot be 
enabled without "Not selecting HiveServer2 Interactive host will disable 
interactive query". If user acknowledge that, we need to dismiss this warning 
popup, "Select hosts" popup and revert the changed config "Enable interactive 
query" from "yes" to "no". As I said "Enabling interactive query and selecting 
HSI host are atomic operations." If we are rolling back from selecting HSI host 
then we need to disable interactive query as well.
3. Change HiveServer2 endpoint label to HiveServer2 JDBC URL label
4. Change class span-6 to span-12 for summary info section of Hive Service


Diffs
-

  ambari-web/app/controllers/main/service/info/summary.js eb0e850 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 7a610da 
  ambari-web/app/messages.js 8763721 
  ambari-web/app/templates/common/assign_master_components.hbs 893d1e6 
  ambari-web/app/views/common/assign_master_components_view.js 95ba766 
  ambari-web/app/views/main/service/services/hive.js d306433 
  ambari-web/app/views/wizard/step7/assign_master_view.js d6a456f 

Diff: https://reviews.apache.org/r/47920/diff/


Testing
---

Verified that the patch addresses the issue manually. attached snpashot of the 
changes to the Jira.

Verified that the patch passes all ambari-web unit tests:
27856 tests complete (28 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Review Request 47915: Oozie and Hive Server start fail during EU with missing DB class exception

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47915/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sumit 
Mohanty.


Bugs: AMBARI-16912
https://issues.apache.org/jira/browse/AMBARI-16912


Repository: ambari


Description
---

Steps
Deploy HDP 2.4.0.0 cluster with Ambari 2.2.1.1 (Secure, HA cluster, mysql DB)
Upgrade Ambari to 2.4.0.0
Perform Express Upgrade to HDP-2.5.0.0-555
Result
Errors seen during start of Hive Server and Oozie


Diffs
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py c92e580 
  ambari-server/src/main/python/ambari_server/serverSetup.py f01465d 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py cdcce1c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 a1ffc5e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 716b612 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 2f091a5 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 0a39219 

Diff: https://reviews.apache.org/r/47915/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135055
---


Ship it!




Ship It!

- Jonathan Hurley


On May 26, 2016, 4:03 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 26, 2016, 4:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Verified EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/
---

(Updated May 26, 2016, 8:03 p.m.)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Swapan Shridhar.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

HDP 2.5 is introducing breaking changes for Storm, so must apply config changes 
and delete all local storm data plus data on Zookeeper.
EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following

Apply config changes
Delete Storm data on ZK only once
Delete Storm local data on all Storm hosts


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 dd033b8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
525a356 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
9ee3e88 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 625b851 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
58aa95f 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
cdb8634 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
5211276 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
d90d76d 

Diff: https://reviews.apache.org/r/47871/diff/


Testing (updated)
---

Verified EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm


Thanks,

Alejandro Fernandez

Re: Review Request 47913: VDF builder script and XSD should be updated for package-version changes

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47913/#review135052
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 26, 2016, 7:46 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47913/
> ---
> 
> (Updated May 26, 2016, 7:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16909
> https://issues.apache.org/jira/browse/AMBARI-16909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{package-version}} element should belong with the {{os}} element such 
> that we can send that information to agents effectively when multiple OS are 
> defined in the XML.  This will allow us to use specific build numbers when 
> installing packages without using wildcards.
> 
> This patch only covers builder + XSD.  Ambari code to send this data to 
> agents is another JIRA.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/version_definition.xsd 8c20c06 
>   contrib/version-builder/example.py dd719bc 
>   contrib/version-builder/example.sh ce60318 
>   contrib/version-builder/version_builder.py 2e3fc7f 
> 
> Diff: https://reviews.apache.org/r/47913/diff/
> 
> 
> Testing
> ---
> 
> No new tests as majority of testing is in {{contrib}}.  Automated testing 
> enough to verify existing XML still worked:
> 
> mvn test -Dtest=VersionDefinition*
> 
> ---
>  T E S T S
> ---
> Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
> Running 
> org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.244 sec - 
> in 
> org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
> Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
> Running org.apache.ambari.server.state.repository.VersionDefinitionTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - 
> in org.apache.ambari.server.state.repository.VersionDefinitionTest
> 
> Results :
> 
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47913: VDF builder script and XSD should be updated for package-version changes

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47913/#review135051
---


Ship it!





contrib/version-builder/example.sh (lines 39 - 40)


Maybe explain that it must be before, otherwise the XSD validation will 
fail.


- Jonathan Hurley


On May 26, 2016, 3:46 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47913/
> ---
> 
> (Updated May 26, 2016, 3:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16909
> https://issues.apache.org/jira/browse/AMBARI-16909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{package-version}} element should belong with the {{os}} element such 
> that we can send that information to agents effectively when multiple OS are 
> defined in the XML.  This will allow us to use specific build numbers when 
> installing packages without using wildcards.
> 
> This patch only covers builder + XSD.  Ambari code to send this data to 
> agents is another JIRA.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/version_definition.xsd 8c20c06 
>   contrib/version-builder/example.py dd719bc 
>   contrib/version-builder/example.sh ce60318 
>   contrib/version-builder/version_builder.py 2e3fc7f 
> 
> Diff: https://reviews.apache.org/r/47913/diff/
> 
> 
> Testing
> ---
> 
> No new tests as majority of testing is in {{contrib}}.  Automated testing 
> enough to verify existing XML still worked:
> 
> mvn test -Dtest=VersionDefinition*
> 
> ---
>  T E S T S
> ---
> Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
> Running 
> org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.244 sec - 
> in 
> org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
> Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
> Running org.apache.ambari.server.state.repository.VersionDefinitionTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - 
> in org.apache.ambari.server.state.repository.VersionDefinitionTest
> 
> Results :
> 
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 47913: VDF builder script and XSD should be updated for package-version changes

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47913/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16909
https://issues.apache.org/jira/browse/AMBARI-16909


Repository: ambari


Description
---

The {{package-version}} element should belong with the {{os}} element such that 
we can send that information to agents effectively when multiple OS are defined 
in the XML.  This will allow us to use specific build numbers when installing 
packages without using wildcards.

This patch only covers builder + XSD.  Ambari code to send this data to agents 
is another JIRA.


Diffs
-

  ambari-server/src/main/resources/version_definition.xsd 8c20c06 
  contrib/version-builder/example.py dd719bc 
  contrib/version-builder/example.sh ce60318 
  contrib/version-builder/version_builder.py 2e3fc7f 

Diff: https://reviews.apache.org/r/47913/diff/


Testing
---

No new tests as majority of testing is in {{contrib}}.  Automated testing 
enough to verify existing XML still worked:

mvn test -Dtest=VersionDefinition*

---
 T E S T S
---
Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
Running 
org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.244 sec - in 
org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
Running org.apache.ambari.server.state.repository.VersionDefinitionTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - in 
org.apache.ambari.server.state.repository.VersionDefinitionTest

Results :

Tests run: 13, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Nate Cole

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47856/
---

(Updated May 26, 2016, 7:16 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16887
https://issues.apache.org/jira/browse/AMBARI-16887


Repository: ambari


Description
---

PROBLEM

For counter based metrics, the timestamp tracking is lost and end up aggregated 
into 30sec data for a 2-minute interval to have the same value. Then when we 
want to see this value as a rate metric, during these multi-minute intervals, 
the rate is reported as 0, since it did not change. However, looking at the raw 
data, it is always increasing within 5-10 second intervals. So it is not the 
raw data that is not changing, it is our tracking of values that is wrong.


BUG
Within the 2 min window, we do only interpolation (Required timestamp value is 
within range of the set of values used for interpolation) and not extrapolation 
(Required timestamp outside range of the set of values used for interpolation).

FIX

Use all values within the 2 minute window for constructing the linear function 
and then use that for interpolation / extrapolation. In the case that only 1 
value is present in the 2 min window, we use that value for interpolating all 
required 30sec timestamps in the window.

Before fix
(),2,3,(),5,() became -> (2),2,3,(4),5,(5)

After fix,
(),2,3,(),5,() became -> (1),2,3,(4),5,(6)

where (x) -> an interpolated value


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml e043404 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
 ab890ec 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
 1ec71d0 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 a8d3086 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
 d2d478c 

Diff: https://reviews.apache.org/r/47856/diff/


Testing
---

Manually tested on cluster.

Added unit tests.


Thanks,

Aravindan Vijayan

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47858/#review135049
---


Ship it!




Ship It!

- Tim Thorpe


On May 26, 2016, 6:50 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47858/
> ---
> 
> (Updated May 26, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Matt, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-16665
> https://issues.apache.org/jira/browse/AMBARI-16665
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the current implementation, service advisors for the same service are 
> loaded multiple times in the stack advisor.
> 
> The service advisors should be cached when the stack advisor is loaded and 
> used where necessary.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47858/diff/
> 
> 
> Testing
> ---
> 
> Lavs-MacBook-Pro:common ljain$ python -m discover -v
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
> for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ServiceAdvisor implementation for service PXF 
> was loaded
> ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ServiceAdvisor implementation for service 
> PXF was loaded
> ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ServiceAdvisor implementation for 
> service PXF was loaded
> ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... 
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... 
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ServiceAdvisor implementation for service PXF was loaded
> ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ServiceAdvisor implementation for 

Review Request 47858: Cache service advisors when stack advisor is loaded

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47858/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
Luniya, Matt, and Tim Thorpe.


Bugs: AMBARI-16665
https://issues.apache.org/jira/browse/AMBARI-16665


Repository: ambari


Description (updated)
---

With the current implementation, service advisors for the same service are 
loaded multiple times in the stack advisor.

The service advisors should be cached when the stack advisor is loaded and used 
where necessary.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 53c5574 

Diff: https://reviews.apache.org/r/47858/diff/


Testing (updated)
---

Lavs-MacBook-Pro:common ljain$ python -m discover -v
test_createComponentLayoutRecommendations_hawq_1_Host 
(test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
implementation for service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when 
HAWQ has already been installed ... ServiceAdvisor implementation for service 
HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
when HAWQ is selected for installation ... ServiceAdvisor implementation for 
service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, 
when HAWQ is selected for installation ... ServiceAdvisor implementation for 
service HAWQ was loaded
ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has 
already been installed ... ServiceAdvisor implementation for service PXF was 
loaded
ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is 
selected for installation ... ServiceAdvisor implementation for service PXF was 
loaded
ok
test_createComponentLayoutRecommendations_pxf_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when 
PXF is selected for installation ... ServiceAdvisor implementation for service 
PXF was loaded
ok
test_getComponentLayoutValidations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... 
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... 
ServiceAdvisor implementation for service HAWQ was loaded
ok
test_getComponentLayoutValidations_nohawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE 
... ServiceAdvisor implementation for service PXF was loaded
ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE 
... ServiceAdvisor implementation for service PXF was loaded
ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... 
ServiceAdvisor implementation for service PXF was loaded
ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE 
... ServiceAdvisor implementation for service PXF was loaded
ok

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

[Alejandro Fernandez]

> On May 26, 2016, 4:42 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, 
> > lines 860-863
> > 
> >
> > The Jira says:
> > ```
> > Delete Storm data on ZK only once
> > Delete Storm local data on all Storm hosts
> > ```
> > 
> > Nimbus's cardinality is 1, right? If so, then that's fine - I just want 
> > to make sure we can't possible be deleting ZK data more than once.
> 
> Alejandro Fernandez wrote:
> Yes, cardinality is 1. The command to delete storm data from ZK is 
> idempotent (rmr still works if the znode does not exist).

Actually, there can be multiple Nimbus hosts.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135001
---


On May 26, 2016, 1:54 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 26, 2016, 1:54 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

[Aravindan Vijayan]

> On May 26, 2016, 3:10 p.m., Dmytro Sen wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java,
> >  line 279
> > 
> >
> > I didn't get why there is a special handling for 
> > regionserver.Server.Get_num_ops ?

Thanks DS. I added that INFO log line for a specific metric that I was trying 
to track and test interpolation. I will remove it.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47856/#review134988
---


On May 25, 2016, 10:04 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47856/
> ---
> 
> (Updated May 25, 2016, 10:04 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16887
> https://issues.apache.org/jira/browse/AMBARI-16887
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> 
> For counter based metrics, the timestamp tracking is lost and end up 
> aggregated into 30sec data for a 2-minute interval to have the same value. 
> Then when we want to see this value as a rate metric, during these 
> multi-minute intervals, the rate is reported as 0, since it did not change. 
> However, looking at the raw data, it is always increasing within 5-10 second 
> intervals. So it is not the raw data that is not changing, it is our tracking 
> of values that is wrong.
> 
> 
> BUG
> Within the 2 min window, we do only interpolation (Required timestamp value 
> is within range of the set of values used for interpolation) and not 
> extrapolation (Required timestamp outside range of the set of values used for 
> interpolation).
> 
> FIX
> 
> Use all values within the 2 minute window for constructing the linear 
> function and then use that for interpolation / extrapolation. In the case 
> that only 1 value is present in the 2 min window, we use that value for 
> interpolating all required 30sec timestamps in the window.
> 
> Before fix
> (),2,3,(),5,() became -> (2),2,3,(4),5,(5)
> 
> After fix,
> (),2,3,(),5,() became -> (1),2,3,(4),5,(6)
> 
> where (x) -> an interpolated value
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml e043404 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
>  ab890ec 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
>  1ec71d0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  a8d3086 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
>  d2d478c 
> 
> Diff: https://reviews.apache.org/r/47856/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on cluster.
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/#review135014
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 (line 300)


Why default hdfs and hive users? If they are missing, that's a serious 
problem



ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
596)


Will this always be https?



ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
(line 124)


This config definition is not needed since it already exists in the 2.5 
config pack.


- Alejandro Fernandez


On May 26, 2016, 11:50 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47880/
> ---
> 
> (Updated May 26, 2016, 11:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16890
> https://issues.apache.org/jira/browse/AMBARI-16890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 
> - Enable Ranger SSO property as a checkbox
> - Populate query param originalUrl
> 
> - Deleted below properties from ranger-admin-site.xml latest stack and also 
> during upgrade.
>   ranger.sso.cookiename
>   ranger.sso.query.param.originalurl
> 
> - Adding below new properties to ranger-admin-site.xml:
>   ranger.kms.service.user.hdfs – default value "hdfs"
>   ranger.kms.service.user.hive – default value "hive"
> 
> - Updating default value for below properties in latest stack:
>   ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
>   ranger.ldap.user.searchfilter(uid={0})
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
>  daab4ec 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  539a57c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  b358f27 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  91d8093 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
>  c1ffeb6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 79314f5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 1287d57 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> dd0e456 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 093c819 
>   ambari-web/app/data/HDP2.3/site_properties.js e04d060 
> 
> Diff: https://reviews.apache.org/r/47880/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47884: Ambari install failure due to zeppelin service install bug

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47884/#review135012
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 40)


May want to use os.path.join(params.service_packagedir, 
"scripts/setup_snapshot.sh") since it's safer.


- Alejandro Fernandez


On May 26, 2016, 12:55 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47884/
> ---
> 
> (Updated May 26, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16893
> https://issues.apache.org/jira/browse/AMBARI-16893
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Service install fails on CentOS 6.6 due to zeppelin permission bug. Only 
> reproducible on 6.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  7d365ec 
> 
> Diff: https://reviews.apache.org/r/47884/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS 6.6 and 6.4
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 47836: User/Group with no Cluster Role assigned but having View Permissions of "VIEW.USER" are shown as not editable in the List View

[Keta Patel]

> On May 25, 2016, 10:50 p.m., Richard Zang wrote:
> > Ship It!

Thank you Richard!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47836/#review134858
---


On May 25, 2016, 5:48 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47836/
> ---
> 
> (Updated May 25, 2016, 5:48 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-16861
> https://issues.apache.org/jira/browse/AMBARI-16861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce this issue:
> 1. Create a few local users. I have created users "aaa", "bbb", "ccc" in my 
> case.
> 2. Create a view instance of your choice and assign one of the local users to 
> this view instance. I have assigned user "aaa" to the a Jobs view instance.
> 3. Go to Manage Ambari -> Roles -> List View
> 4. You see the user "aaa" showing Cluster Role of "View User" and is not 
> editable from this page. (attachment "view_user_for_user.tiff" on the JIRA)
> 
> I had recreated this issue using group also. Please find attachment 
> "view_user_for_group.tiff" on JIRA showing the List View for the case of 
> group assigned with View User permission alone.
> 
> Since View Permissions must not be mixed with the Cluster Permissions, the 
> proposed fix should show Cluster Permission of "None" for users who have only 
> "View User" permissions and no Cluster Permissions. This would allow the 
> ambari user to edit the Cluster Permissions of the local users from the List 
> View page.
> Note: A workaround found to edit such users' Cluster Permissions is to go to 
> the Block View and assign some Cluster Permission. Then the List View shows 
> the Cluster Permission and is editable.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
>  19fb971 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
>  fb327c7 
> 
> Diff: https://reviews.apache.org/r/47836/diff/
> 
> 
> Testing
> ---
> 
> I have added a test case for the function "pickEffectivePrivilege" which 
> checks if the effective privilege of a user/group is "VIEW.USER". If it is, 
> then the privilege returned is "CLUSTER.NONE", otherwise the calculated 
> effective privilege is returned.
> 
> I have attached the result of tests run for ambari-admin in the attachments 
> "ambari_admin_test_cases_before_fix.tiff" and 
> "ambari_admin_test_cases_after_fix.tiff" on the JIRA.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135001
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (lines 
860 - 863)


The Jira says:
```
Delete Storm data on ZK only once
Delete Storm local data on all Storm hosts
```

Nimbus's cardinality is 1, right? If so, then that's fine - I just want to 
make sure we can't possible be deleting ZK data more than once.


- Jonathan Hurley


On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 25, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47867/#review134997
---


Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 (lines 1222 - 1224)


Nice catch on this one


- Jonathan Hurley


On May 26, 2016, 6:47 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47867/
> ---
> 
> (Updated May 26, 2016, 6:47 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16889
> https://issues.apache.org/jira/browse/AMBARI-16889
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Throw an error when POSTing to /api/v1/clusters//stack_versions when 
> an upgrade/downgrade is in-progress
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  05ee6c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  4a214e1 
>   ambari-server/src/main/resources/version_definition.xsd b6360ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  8347a7b 
> 
> Diff: https://reviews.apache.org/r/47867/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4360, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 38:01.727s
> [INFO] Finished at: Wed May 25 21:30:01 EDT 2016
> [INFO] Final Memory: 34M/709M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47018: "ambari-server upgrade" shouldn't automatically add stack configs

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/
---

(Updated May 26, 2016, 7:15 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

Uploaded patch that is going to be final. Did not include into review 
auto-generated changes to all 600 existing config xmls to avoid review becoming 
unviewable, will include them into commit.


Summary (updated)
-

"ambari-server upgrade" shouldn't automatically add stack configs


Bugs: AMBARI-16272
https://issues.apache.org/jira/browse/AMBARI-16272


Repository: ambari


Description (updated)
---

Today, "ambari-server upgrade" will automatically add stack configs.
However, it also causes problems when default properties or properties with 
default value such as "localhost" end up being added.

This led to many bugs. E.g., cluster with NameNode HA shouldn't automatically 
add dfs.namenode.secondary.http-address

This logic today will even add new config types. E.g., add ranger-env even 
though Ranger is not installed. If the customer then upgrades the stack from 
HDP 2.2 to 2.3, and then adds Ranger, they can get the wrong configs.
If we change this behavior, it's good to do so in a major release such as 2.4

We add required xml tags/attributes to properties:

  prop_name
  prop_val
  
  


we are going to enforce developers to explicitly specify what to do during 
ambari/stack upgrade when adding any new config property
If any of stack configuration files does not pass XSD schema validation (that 
contains this enforcement), then ambari-server unit tests will fail.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 fb3ae69 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
8a352bd 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
a36df7b 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34b3ba1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 2e857ed 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
 260fe65 
  ambari-server/src/main/resources/configuration-schema.xsd PRE-CREATION 
  
ambari-server/src/main/resources/scripts/configurations-set-default-update-policy.sh
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
 a4a3108 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 8f53f6a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
 b11c5d8 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServicePropertiesTest.java
 PRE-CREATION 
  script.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/47018/diff/


Testing (updated)
---

Ran unit tests. Tried ambari-upgrade and stack upgrade, seems to work well.


Thanks,

Dmitro Lisnichenko

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

[Qin Liu]

> On May 26, 2016, 3:11 p.m., Dmytro Sen wrote:
> > Ship It!

Thank you so much Dmytro!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47879/#review134989
---


On May 26, 2016, 10:27 a.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47879/
> ---
> 
> (Updated May 26, 2016, 10:27 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16807
> https://issues.apache.org/jira/browse/AMBARI-16807
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After enabling HTTPS for HDFS, "DataNode Garbage Collection Time", "DataNode 
> JVM Heap Memory Used ", and "DataNode JVM Heap Memory Committed" widgets on 
> HDFS Heatmaps show NA. The root cause is that dfs.datanode.http.address 
> rather than dfs.datanode.https.address is used to get JMX metrics. 
> 
> Steps to reproduce:
> 1. install a cluster with default from Ambari Web UI.
> 2. configuring SSL for HDFS, YARN, and MapReduce.
> 3. enable HTTPS for HDFS
> Set the following properties in Advanced hdfs-site from Ambari Web UI:
> dfs.http.policy=HTTPS_ONLY
> dfs.datanode.http.address=0.0.0.0:50075
> dfs.datanode.https.address=0.0.0.0:50475
> 4. "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
> "DataNode JVM Heap Memory Committed" widgets on HDFS Heatmaps will show NA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  30ce19a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  8ef6f0c 
> 
> Diff: https://reviews.apache.org/r/47879/diff/
> 
> 
> Testing
> ---
> 
> 1. The fix has been tested with HDP UI
> "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
> "DataNode JVM Heap Memory Committed" metrics show up after apply the fix.
> 
> 2. A new testcase is added in JMXHostProviderTest.java to verify JMX protocol 
> and port for DataNode.
> Test set: org.apache.ambari.server.controller.internal.JMXHostProviderTest
> ---
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.192 sec 
> - in org.apache.ambari.server.controller.internal.JMXHostProviderTest
> 
> 3. The ambari-server tests:
> The following tests had issues in Hadoop QA testing but they passed in my 
> testing:
> Failed tests: 
>   
> ConfigHelperTest$RunWithInMemoryDefaultTestModule.testCalculateIsStaleConfigsParallel:880
>  null
> Tests in error: 
>   HostResourceProviderTest.testUpdateResourcesAsServiceAdministrator »  
> Unexpect...
> 
> Here are my testing results for above tests:
> Test set: org.apache.ambari.server.state.ConfigHelperTest
> ---
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 160.88 sec - 
> in org.apache.ambari.server.state.ConfigHelperTest
> 
> Test set: 
> org.apache.ambari.server.controller.internal.HostResourceProviderTest
> ---
> Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.209 sec - 
> in org.apache.ambari.server.controller.internal.HostResourceProviderTest
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47879/#review134989
---


Ship it!




Ship It!

- Dmytro Sen


On Май 26, 2016, 10:27 д.п., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47879/
> ---
> 
> (Updated Май 26, 2016, 10:27 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16807
> https://issues.apache.org/jira/browse/AMBARI-16807
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After enabling HTTPS for HDFS, "DataNode Garbage Collection Time", "DataNode 
> JVM Heap Memory Used ", and "DataNode JVM Heap Memory Committed" widgets on 
> HDFS Heatmaps show NA. The root cause is that dfs.datanode.http.address 
> rather than dfs.datanode.https.address is used to get JMX metrics. 
> 
> Steps to reproduce:
> 1. install a cluster with default from Ambari Web UI.
> 2. configuring SSL for HDFS, YARN, and MapReduce.
> 3. enable HTTPS for HDFS
> Set the following properties in Advanced hdfs-site from Ambari Web UI:
> dfs.http.policy=HTTPS_ONLY
> dfs.datanode.http.address=0.0.0.0:50075
> dfs.datanode.https.address=0.0.0.0:50475
> 4. "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
> "DataNode JVM Heap Memory Committed" widgets on HDFS Heatmaps will show NA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  30ce19a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  8ef6f0c 
> 
> Diff: https://reviews.apache.org/r/47879/diff/
> 
> 
> Testing
> ---
> 
> 1. The fix has been tested with HDP UI
> "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
> "DataNode JVM Heap Memory Committed" metrics show up after apply the fix.
> 
> 2. A new testcase is added in JMXHostProviderTest.java to verify JMX protocol 
> and port for DataNode.
> Test set: org.apache.ambari.server.controller.internal.JMXHostProviderTest
> ---
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.192 sec 
> - in org.apache.ambari.server.controller.internal.JMXHostProviderTest
> 
> 3. The ambari-server tests:
> The following tests had issues in Hadoop QA testing but they passed in my 
> testing:
> Failed tests: 
>   
> ConfigHelperTest$RunWithInMemoryDefaultTestModule.testCalculateIsStaleConfigsParallel:880
>  null
> Tests in error: 
>   HostResourceProviderTest.testUpdateResourcesAsServiceAdministrator »  
> Unexpect...
> 
> Here are my testing results for above tests:
> Test set: org.apache.ambari.server.state.ConfigHelperTest
> ---
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 160.88 sec - 
> in org.apache.ambari.server.state.ConfigHelperTest
> 
> Test set: 
> org.apache.ambari.server.controller.internal.HostResourceProviderTest
> ---
> Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.209 sec - 
> in org.apache.ambari.server.controller.internal.HostResourceProviderTest
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47856/#review134988
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
 (line 278)


I didn't get why there is a special handling for 
regionserver.Server.Get_num_ops ?


- Dmytro Sen


On Май 25, 2016, 10:04 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47856/
> ---
> 
> (Updated Май 25, 2016, 10:04 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16887
> https://issues.apache.org/jira/browse/AMBARI-16887
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> 
> For counter based metrics, the timestamp tracking is lost and end up 
> aggregated into 30sec data for a 2-minute interval to have the same value. 
> Then when we want to see this value as a rate metric, during these 
> multi-minute intervals, the rate is reported as 0, since it did not change. 
> However, looking at the raw data, it is always increasing within 5-10 second 
> intervals. So it is not the raw data that is not changing, it is our tracking 
> of values that is wrong.
> 
> 
> BUG
> Within the 2 min window, we do only interpolation (Required timestamp value 
> is within range of the set of values used for interpolation) and not 
> extrapolation (Required timestamp outside range of the set of values used for 
> interpolation).
> 
> FIX
> 
> Use all values within the 2 minute window for constructing the linear 
> function and then use that for interpolation / extrapolation. In the case 
> that only 1 value is present in the 2 min window, we use that value for 
> interpolating all required 30sec timestamps in the window.
> 
> Before fix
> (),2,3,(),5,() became -> (2),2,3,(4),5,(5)
> 
> After fix,
> (),2,3,(),5,() became -> (1),2,3,(4),5,(6)
> 
> where (x) -> an interpolated value
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml e043404 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/PostProcessingUtil.java
>  ab890ec 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/PostProcessingUtilTest.java
>  1ec71d0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java
>  a8d3086 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
>  d2d478c 
> 
> Diff: https://reviews.apache.org/r/47856/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on cluster.
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 47882: HBase backups fail if there is no /user/hbase directory in HDFS

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47882/#review134982
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 26, 2016, 12:19 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47882/
> ---
> 
> (Updated Травень 26, 2016, 12:19 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16844
> https://issues.apache.org/jira/browse/AMBARI-16844
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  775e7eb 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  aa64528 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  b9b49e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3cae192 
> 
> Diff: https://reviews.apache.org/r/47882/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47785: Ambari install of Atlas should use external HBase and Logsearch SOLR

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47785/#review134975
---


Ship it!




Ship It!

- Nate Cole


On May 25, 2016, 6:06 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47785/
> ---
> 
> (Updated May 25, 2016, 6:06 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16853 and ATLAS-823
> https://issues.apache.org/jira/browse/AMBARI-16853
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To support this, add dependency from Atlas to LogSearch SOLR.  Also remove 
> references to embedded SOLR and embedded HBase.
> 
> Use solr_cloud_util to create indexes for Atlas install.
> 
> See AMBARI-15865.
> See Atlas-823.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  bf0467e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  dd4b3e2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
>  3c4826d 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> f4115f7 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  6b045ca 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  e305138 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f172b79 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  0631b7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  2a5f777 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 15daeea 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> af812fe 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 98fc678 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json c8b418b 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 7ebcedf 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 9d0f00c 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 51c0d0c 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json e4a97f6 
> 
> Diff: https://reviews.apache.org/r/47785/diff/
> 
> 
> Testing
> ---
> 
> Manual test of Atlas install.
> 
> Updated unit tests.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review134974
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (lines 
897 - 899)


Why does downgrade get this message but not upgrade?


- Nate Cole


On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 25, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47785: Ambari install of Atlas should use external HBase and Logsearch SOLR

[Nate Cole]

> On May 25, 2016, 7:30 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py,
> >  line 150
> > 
> >
> > Just wanted to make sure if this always be true?
> 
> Nate Cole wrote:
> I think this assumption should be ok - we are already doing the symlink 
> magic to point to the right spot.
> 
> Tom Beerbower wrote:
> Thanks for the review Srimanth and Nate.
> 
> Looking in the HBase status_params.py, I see this ...
> 
> hbase_conf_dir = "/etc/hbase/conf"
> if stack_version_formatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_formatted):
>   hbase_conf_dir = 
> format("{stack_root}/current/{component_directory}/conf")
> 
> Do, I need to add the same logic?

That's probably outside the scope of this fix, but that code you pointed out is 
used such that when doing an upgrade, you are looking at the right place for 
configs.  I don't fully understand the relationship between Atlas and HBase (is 
the dependence only on the client?), so that can probably be a different patch.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47785/#review134876
---


On May 25, 2016, 6:06 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47785/
> ---
> 
> (Updated May 25, 2016, 6:06 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16853 and ATLAS-823
> https://issues.apache.org/jira/browse/AMBARI-16853
> https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To support this, add dependency from Atlas to LogSearch SOLR.  Also remove 
> references to embedded SOLR and embedded HBase.
> 
> Use solr_cloud_util to create indexes for Atlas install.
> 
> See AMBARI-15865.
> See Atlas-823.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  bf0467e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  dd4b3e2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
>  3c4826d 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> f4115f7 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  6b045ca 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  e305138 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f172b79 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  0631b7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  2a5f777 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 15daeea 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> af812fe 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 98fc678 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json c8b418b 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 7ebcedf 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 9d0f00c 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 51c0d0c 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json e4a97f6 
> 
> Diff: https://reviews.apache.org/r/47785/diff/
> 
> 
> Testing
> ---
> 
> Manual test of Atlas install.
> 
> Updated unit tests.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47886: Log Search Server start failed with KeeperException

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47886/
---

(Updated May 26, 2016, 1:47 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Changes
---

add same fix for ranger


Bugs: AMBARI-16892
https://issues.apache.org/jira/browse/AMBARI-16892


Repository: ambari


Description
---

It seems now command.json not contains zookeeper ports in the zookeeper hosts 
list, so we need to use strictly the zookeeper quorum for solr client (as input)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 2828ca9 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 f06f58a 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f1e5efd 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 7379082 

Diff: https://reviews.apache.org/r/47886/diff/


Testing
---

Total run:1042
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 47882: HBase backups fail if there is no /user/hbase directory in HDFS

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47882/#review134971
---


Ship it!




Ship It!

- Sumit Mohanty


On May 26, 2016, 12:19 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47882/
> ---
> 
> (Updated May 26, 2016, 12:19 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16844
> https://issues.apache.org/jira/browse/AMBARI-16844
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  775e7eb 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  aa64528 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  b9b49e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3cae192 
> 
> Diff: https://reviews.apache.org/r/47882/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47886: Log Search Server start failed with KeeperException

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47886/#review134970
---


Ship it!




Ship It!

- Miklos Gergely


On May 26, 2016, 1:11 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47886/
> ---
> 
> (Updated May 26, 2016, 1:11 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16892
> https://issues.apache.org/jira/browse/AMBARI-16892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It seems now command.json not contains zookeeper ports in the zookeeper hosts 
> list, so we need to use strictly the zookeeper quorum for solr client (as 
> input)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  2828ca9 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> f1e5efd 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 7379082 
> 
> Diff: https://reviews.apache.org/r/47886/diff/
> 
> 
> Testing
> ---
> 
> Total run:1042
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47886: Log Search Server start failed with KeeperException

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47886/#review134967
---


Ship it!




Ship It!

- Robert Nettleton


On May 26, 2016, 1:11 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47886/
> ---
> 
> (Updated May 26, 2016, 1:11 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16892
> https://issues.apache.org/jira/browse/AMBARI-16892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It seems now command.json not contains zookeeper ports in the zookeeper hosts 
> list, so we need to use strictly the zookeeper quorum for solr client (as 
> input)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  2828ca9 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> f1e5efd 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 7379082 
> 
> Diff: https://reviews.apache.org/r/47886/diff/
> 
> 
> Testing
> ---
> 
> Total run:1042
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 47886: Log Search Server start failed with KeeperException

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47886/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16892
https://issues.apache.org/jira/browse/AMBARI-16892


Repository: ambari


Description
---

It seems now command.json not contains zookeeper ports in the zookeeper hosts 
list, so we need to use strictly the zookeeper quorum for solr client (as input)


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 2828ca9 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f1e5efd 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 7379082 

Diff: https://reviews.apache.org/r/47886/diff/


Testing
---

Total run:1042
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Review Request 47885: AMBARI-16894: Default Ranger repos for some services are not getting created

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47885/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, 
Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-16894
https://issues.apache.org/jira/browse/AMBARI-16894


Repository: ambari


Description
---

Fixed the logic of default repo creation that was broken due to previous 
commits.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 efb0819 

Diff: https://reviews.apache.org/r/47885/diff/


Testing
---

Tested on a local instance with different services.


Thanks,

Gautam Borad

Review Request 47884: Ambari install failure due to zeppelin service install bug

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47884/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-16893
https://issues.apache.org/jira/browse/AMBARI-16893


Repository: ambari


Description
---

Service install fails on CentOS 6.6 due to zeppelin permission bug. Only 
reproducible on 6.6


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 7d365ec 

Diff: https://reviews.apache.org/r/47884/diff/


Testing
---

manually tested on CentOS 6.6 and 6.4


Thanks,

Renjith Kamath

Review Request 47882: HBase backups fail if there is no /user/hbase directory in HDFS

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47882/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16844
https://issues.apache.org/jira/browse/AMBARI-16844


Repository: ambari


Description
---


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 775e7eb 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 aa64528 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 d2f28f5 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 b9b49e9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3cae192 

Diff: https://reviews.apache.org/r/47882/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/
---

(Updated May 26, 2016, 11:50 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-16890
https://issues.apache.org/jira/browse/AMBARI-16890


Repository: ambari


Description
---

Changes include:

- Enable Ranger SSO property as a checkbox
- Populate query param originalUrl

- Deleted below properties from ranger-admin-site.xml latest stack and also 
during upgrade.
  ranger.sso.cookiename
  ranger.sso.query.param.originalurl

- Adding below new properties to ranger-admin-site.xml:
  ranger.kms.service.user.hdfs – default value "hdfs"
  ranger.kms.service.user.hive – default value "hive"

- Updating default value for below properties in latest stack:
  ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
  ranger.ldap.user.searchfilter(uid={0})


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
 daab4ec 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 539a57c 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 b358f27 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 91d8093 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
 c1ffeb6 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
79314f5 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
1287d57 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 dd033b8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
9ee3e88 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
dd0e456 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 625b851 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
cdb8634 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
093c819 
  ambari-web/app/data/HDP2.3/site_properties.js e04d060 

Diff: https://reviews.apache.org/r/47880/diff/


Testing
---

Tested Ranger installation on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

[Robert Levas]

> On May 25, 2016, 4:21 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java,
> >  lines 190-194
> > 
> >
> > This is a little odd - string compares? We don't have anything more 
> > contractual for "check host" permissions?

Not really. Essentually the (custom) commands sent to the Reqeust endpoint are 
strings that (I think) get interpreted on the agent side.  As @ncole pointed 
out, there is a file at 
`custom_action_definitions/system_action_definitions.xml` that defines these 
(or at least some of them) but the definitions are lacking.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47783/#review134823
---


On May 24, 2016, 1:48 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47783/
> ---
> 
> (Updated May 24, 2016, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-16851
> https://issues.apache.org/jira/browse/AMBARI-16851
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster operator and the cluster admin must be allowed to add/delete hosts 
> but install of agents using /bootstrap fails with 403
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  5b318af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  5c74f07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f4f614e 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2c2d743 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ee87cc5 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql a65df9c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6f38ec8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> ca57de5 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bd2e6d6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9269b13 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  65efc63 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
>  69b4b08 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  6511cb4 
> 
> Diff: https://reviews.apache.org/r/47783/diff/
> 
> 
> Testing
> ---
> 
> Manually tested, newly created cluster and upgrade 
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:15:22.164s
> [INFO] Finished at: Tue May 24 13:28:21 EDT 2016
> [INFO] Final Memory: 59M/1807M
> [INFO] 
> 
> 
> #Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47783: Cluster operator and cluster admin not allowed to install ambari agent

[Robert Levas]

> On May 25, 2016, 4:21 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 1296
> > 
> >
> > The description says that both the cluster operator and the admin need 
> > this permission, but I only see if for the operator. Does the admin have it 
> > by default already?

The CLUSTER.ADMINISTRATOR and AMBARI.ADMINISTRATOR already have this privilege.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47783/#review134823
---


On May 24, 2016, 1:48 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47783/
> ---
> 
> (Updated May 24, 2016, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-16851
> https://issues.apache.org/jira/browse/AMBARI-16851
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster operator and the cluster admin must be allowed to add/delete hosts 
> but install of agents using /bootstrap fails with 403
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  5b318af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  5c74f07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f4f614e 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2c2d743 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ee87cc5 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql a65df9c 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6f38ec8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> ca57de5 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bd2e6d6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9269b13 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  65efc63 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
>  69b4b08 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  6511cb4 
> 
> Diff: https://reviews.apache.org/r/47783/diff/
> 
> 
> Testing
> ---
> 
> Manually tested, newly created cluster and upgrade 
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:15:22.164s
> [INFO] Finished at: Tue May 24 13:28:21 EDT 2016
> [INFO] Final Memory: 59M/1807M
> [INFO] 
> 
> 
> #Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47867/
---

(Updated May 26, 2016, 6:47 a.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16889
https://issues.apache.org/jira/browse/AMBARI-16889


Repository: ambari


Description (updated)
---

Throw an error when POSTing to /api/v1/clusters//stack_versions when 
an upgrade/downgrade is in-progress


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 05ee6c9 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 4a214e1 
  ambari-server/src/main/resources/version_definition.xsd b6360ee 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 8347a7b 

Diff: https://reviews.apache.org/r/47867/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4360, Failures: 0, Errors: 0, Skipped: 34

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 38:01.727s
[INFO] Finished at: Wed May 25 21:30:01 EDT 2016
[INFO] Final Memory: 34M/709M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 47867: RU: install version should be blocked while upgrade in progress

[Nate Cole]

> On May 25, 2016, 10:02 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java,
> >  line 287
> > 
> >
> > Nitpicking here, but should check size > 1

:)  I had noticed this check was in an odd spot, so had only moved it.  But 
you're right, a check of >1 is appropriate.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47867/#review134902
---


On May 25, 2016, 8:54 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47867/
> ---
> 
> (Updated May 25, 2016, 8:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16889
> https://issues.apache.org/jira/browse/AMBARI-16889
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Throw an error when POSTing to /api/v1/clusters//stack_versions
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  05ee6c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  4a214e1 
>   ambari-server/src/main/resources/version_definition.xsd b6360ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  8347a7b 
> 
> Diff: https://reviews.apache.org/r/47867/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

[Qin Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47879/
---

Review request for Ambari, Dmytro Sen and Sid Wagle.


Bugs: AMBARI-16807
https://issues.apache.org/jira/browse/AMBARI-16807


Repository: ambari


Description
---

After enabling HTTPS for HDFS, "DataNode Garbage Collection Time", "DataNode 
JVM Heap Memory Used ", and "DataNode JVM Heap Memory Committed" widgets on 
HDFS Heatmaps show NA. The root cause is that dfs.datanode.http.address rather 
than dfs.datanode.https.address is used to get JMX metrics. 

Steps to reproduce:
1. install a cluster with default from Ambari Web UI.
2. configuring SSL for HDFS, YARN, and MapReduce.
3. enable HTTPS for HDFS
Set the following properties in Advanced hdfs-site from Ambari Web UI:
dfs.http.policy=HTTPS_ONLY
dfs.datanode.http.address=0.0.0.0:50075
dfs.datanode.https.address=0.0.0.0:50475
4. "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
"DataNode JVM Heap Memory Committed" widgets on HDFS Heatmaps will show NA.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 30ce19a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
 8ef6f0c 

Diff: https://reviews.apache.org/r/47879/diff/


Testing
---

1. The fix has been tested with HDP UI
"DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
"DataNode JVM Heap Memory Committed" metrics show up after apply the fix.

2. A new testcase is added in JMXHostProviderTest.java to verify JMX protocol 
and port for DataNode.
Test set: org.apache.ambari.server.controller.internal.JMXHostProviderTest
---
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.192 sec - 
in org.apache.ambari.server.controller.internal.JMXHostProviderTest

3. The ambari-server tests:
The following tests had issues in Hadoop QA testing but they passed in my 
testing:
Failed tests: 
  
ConfigHelperTest$RunWithInMemoryDefaultTestModule.testCalculateIsStaleConfigsParallel:880
 null
Tests in error: 
  HostResourceProviderTest.testUpdateResourcesAsServiceAdministrator »  
Unexpect...

Here are my testing results for above tests:
Test set: org.apache.ambari.server.state.ConfigHelperTest
---
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 160.88 sec - 
in org.apache.ambari.server.state.ConfigHelperTest

Test set: org.apache.ambari.server.controller.internal.HostResourceProviderTest
---
Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.209 sec - in 
org.apache.ambari.server.controller.internal.HostResourceProviderTest


Thanks,

Qin Liu

Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-16890
https://issues.apache.org/jira/browse/AMBARI-16890


Repository: ambari


Description
---

Changes include:

- Enable Ranger SSO property as a checkbox
- Populate query param originalUrl

- Deleted below properties from ranger-admin-site.xml latest stack and also 
during upgrade.
  ranger.sso.cookiename
  ranger.sso.query.param.originalurl

- Adding below new properties to ranger-admin-site.xml:
  ranger.kms.service.user.hdfs – default value "hdfs"
  ranger.kms.service.user.hive – default value "hive"

- Updating default value for below properties in latest stack:
  ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
  ranger.ldap.user.searchfilter(uid={0})


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
 daab4ec 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 539a57c 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 b358f27 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 91d8093 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
 c1ffeb6 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
79314f5 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
1287d57 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 dd033b8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
9ee3e88 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
dd0e456 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 625b851 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
cdb8634 
  ambari-web/app/data/HDP2.3/site_properties.js e04d060 

Diff: https://reviews.apache.org/r/47880/diff/


Testing
---

Tested Ranger installation on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47738: [Hive View] Non-visual explain gives a bunch of strangely clickable links

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47738/#review134945
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 26, 2016, 7:44 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47738/
> ---
> 
> (Updated May 26, 2016, 7:44 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16825
> https://issues.apache.org/jira/browse/AMBARI-16825
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed unlickable links.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js
>  20092e2 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> c974dea 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/tree-view.hbs
>  cb83ec3 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index/history-query/explain.hbs
>  3f8810f 
> 
> Diff: https://reviews.apache.org/r/47738/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47738: [Hive View] Non-visual explain gives a bunch of strangely clickable links

[Pallav Kulshreshtha]

> On May 24, 2016, 1:08 p.m., Nitiraj Rathore wrote:
> > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js,
> >  line 135
> > 
> >
> > Instead of Array.map() you should use Array.filter().
> > Array.map will leave 'undefined' values in the new array. while 
> > Array.filter() will remove the unwanted elements.

Correct, implemented this change in new upload.


- Pallav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47738/#review134574
---


On May 23, 2016, 6:44 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47738/
> ---
> 
> (Updated May 23, 2016, 6:44 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16825
> https://issues.apache.org/jira/browse/AMBARI-16825
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed unlickable links.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js
>  20092e2 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> be6d9ac 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/tree-view.hbs
>  cb83ec3 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index/history-query/explain.hbs
>  3f8810f 
> 
> Diff: https://reviews.apache.org/r/47738/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47738: [Hive View] Non-visual explain gives a bunch of strangely clickable links

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47738/
---

(Updated May 26, 2016, 7:44 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16825
https://issues.apache.org/jira/browse/AMBARI-16825


Repository: ambari


Description
---

Removed unlickable links.


Diffs (updated)
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js
 20092e2 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss c974dea 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/tree-view.hbs
 cb83ec3 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index/history-query/explain.hbs
 3f8810f 

Diff: https://reviews.apache.org/r/47738/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 47774: AMBARI-16843. Auto logout zeppelin server in case of session inactivity.

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47774/
---

(Updated May 26, 2016, 7:18 a.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.


Bugs: AMBARI-16843
https://issues.apache.org/jira/browse/AMBARI-16843


Repository: ambari


Description
---

Enable zeppelin logout automatically in case of session inactivity.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 268f5d6 

Diff: https://reviews.apache.org/r/47774/diff/


Testing
---

tested on VirtualBox


Thanks,

Prabhjyot Singh

Re: Review Request 47579: Spark2 service definition for Ambari

[Jayush Luniya]

> On May 25, 2016, 8:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py,
> >  line 25
> > 
> >
> > Use explicit import

Sorry I missed these. Saisai, can you include these changes with AMBARI-16864


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134827
---


On May 23, 2016, 2:55 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
> 
> (Updated May 23, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> ---
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 47722: AMBARI-16813 Ranger Usersync config to support Group Based Search for LDAP Sync Source

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47722/#review134934
---


Ship it!




Ship It!

- Jayush Luniya


On May 25, 2016, 10:38 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47722/
> ---
> 
> (Updated May 25, 2016, 10:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16813
> https://issues.apache.org/jira/browse/AMBARI-16813
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include
> - Added two new properties under ranger-ugsync-site.xml to support Group 
> based search.
> - quicklinks.json
> - adding multiLine for property 
> hadoop.kms.authentication.kerberos.name.rules
> - hdfs audit for KMS should pick up the fs.defaultFS from core-site.xml
> - Add Proxy in kms-site.xml, hadoop.kms.proxyuser.ranger.users/groups/hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  e9c9507 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  d4418e0 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json
>  795e464 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
>  5298169 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-application-properties.xml
>  ea00fbe 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json
>  d5efca4 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  e559d92 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
>  7c98fb3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 188479e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml
>  fca42b3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json
>  cce73e0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6981205 
> 
> Diff: https://reviews.apache.org/r/47722/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>