Re: Review Request 52411: If ambari-server fails to start, appropriate error message should be displayed.

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52411/#review150979
---




ambari-server/src/main/python/ambari_server/utils.py (line 177)


Shorter message: server not yet listening http port 8080 after 45 seconds. 
Exiting


- Sid Wagle


On Sept. 29, 2016, 10:58 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52411/
> ---
> 
> (Updated Sept. 29, 2016, 10:58 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18501
> https://issues.apache.org/jira/browse/AMBARI-18501
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If due to some error, ambari-server JAR exits with -1, we still display 
> “Ambari Server ‘start’ completed successfully”
> In AmbariServer.java::main(), if an exception occurs, the program exits with 
> -1. Howerver, the caller ambari-server.py::main() displays the status message 
> as "Ambari Server 'start' completed successfully".
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/utils.py 012d428 
>   ambari-server/src/main/python/ambari_server_main.py 57ec58d 
>   ambari-server/src/test/python/TestUtils.py db94d92 
> 
> Diff: https://reviews.apache.org/r/52411/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52411: If ambari-server fails to start, appropriate error message should be displayed.

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52411/#review150977
---




ambari-server/src/main/python/ambari_server/utils.py (line 169)


Doesn't this connect need a timeout?



ambari-server/src/main/python/ambari_server/utils.py (line 170)


Typo: Server started listening on port



ambari-server/src/main/python/ambari_server/utils.py (line 179)


We are waiting for pid already right, so why wait again?


- Sid Wagle


On Sept. 29, 2016, 10:58 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52411/
> ---
> 
> (Updated Sept. 29, 2016, 10:58 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18501
> https://issues.apache.org/jira/browse/AMBARI-18501
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If due to some error, ambari-server JAR exits with -1, we still display 
> “Ambari Server ‘start’ completed successfully”
> In AmbariServer.java::main(), if an exception occurs, the program exits with 
> -1. Howerver, the caller ambari-server.py::main() displays the status message 
> as "Ambari Server 'start' completed successfully".
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/utils.py 012d428 
>   ambari-server/src/main/python/ambari_server_main.py 57ec58d 
>   ambari-server/src/test/python/TestUtils.py db94d92 
> 
> Diff: https://reviews.apache.org/r/52411/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review150976
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 30, 2016, 12:39 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> ---
> 
> (Updated Sept. 30, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
> https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 65d166a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> ---
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/
---

(Updated Sept. 30, 2016, 12:39 a.m.)


Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
Marron, Laszlo Puskas, and Robert Nettleton.


Bugs: AMBARI-18355
https://issues.apache.org/jira/browse/AMBARI-18355


Repository: ambari


Description
---

Currently stack definitions do not list conditional dependencies, adding those 
to the stack definitions would make it easy to validate errors in case of 
blueprint deployment. Please refer to document attached to Jira


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 
e3db662 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 a5f33ff 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
65d166a 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 b1de8ef 

Diff: https://reviews.apache.org/r/51815/diff/


Testing
---

Written Junit test cases. Perfomred manual testing to check the Namenode HA 
component dependency. Was able to proceed with the installation for valid 
blueprint. and got validation error message while registering blueprint when 
the Blueprint did not satisfy the conditional dependencies.


Thanks,

Amruta Borkar

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150968
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 124)


We should move this into its own function, like updateGroupTable

You can then use the column capture in UpgradeCatalog250Test to assert that 
this is called.


- Alejandro Fernandez


On Sept. 30, 2016, 12:11 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 30, 2016, 12:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51814/#review150963
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 29, 2016, 4:18 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51814/
> ---
> 
> (Updated Sept. 29, 2016, 4:18 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18362
> https://issues.apache.org/jira/browse/AMBARI-18362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update sinks to read multiple collector hostnames from configs
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  da61d83 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrAmsClient.java
>  85ea69d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  426eb42 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
>  7fadeb2 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
>  ccaa574 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  1b36e9a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  b720ba9 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  f44ca35 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  9c16564 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  73381d9 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0d3b770 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  9082e70 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  f6531c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  4618618 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  a8a7327 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
>  3cd535e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
>  586cd47 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  b839eb8 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  9c79909 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
>  b960296 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  49b684b 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
>  e62ce9e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
>  818 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
>  2b9964b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  558aa95 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
>  88be81b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
>  3d71867 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
>  ba44af5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
>  77f128b 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  ab4d701 
>   
> 

Review Request 52411: If ambari-server fails to start, appropriate error message should be displayed.

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52411/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18501
https://issues.apache.org/jira/browse/AMBARI-18501


Repository: ambari


Description
---

If due to some error, ambari-server JAR exits with -1, we still display “Ambari 
Server ‘start’ completed successfully”
In AmbariServer.java::main(), if an exception occurs, the program exits with 
-1. Howerver, the caller ambari-server.py::main() displays the status message 
as "Ambari Server 'start' completed successfully".


Diffs
-

  ambari-server/src/main/python/ambari_server/utils.py 012d428 
  ambari-server/src/main/python/ambari_server_main.py 57ec58d 
  ambari-server/src/test/python/TestUtils.py db94d92 

Diff: https://reviews.apache.org/r/52411/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Alejandro Fernandez]

> On Sept. 29, 2016, 8:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Vishal, you need to also upload this code review with the new patch.
> > 
> > In the Apache Jira, I don't see changes to add the group_type column 
> > with a default value of "LOCAL".
> > What happens to existing groups stored in the DB?
> 
> Vishal Ghugare wrote:
> My apologies, i am new to reviewboard and getting a hang of it. 
> 
> I have added code to UpgradeCatalog to 1.add group_type column with 
> default value of 'LOCAL' 2.update group_type for existing ldap groups.
> 
> Alejandro Fernandez wrote:
> You can upload a new patch as opposed to an attachment.

Update -> Update Diff


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150928
---


On Sept. 29, 2016, 10:35 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 29, 2016, 10:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/29/544f4689-1ae6-414b-8bcc-f6dfe30992cf__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/
---

(Updated Sept. 29, 2016, 3:35 p.m.)


Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-12263
https://issues.apache.org/jira/browse/AMBARI-12263


Repository: ambari


Description
---

Hello Robert,

How are you doing? 

We have been working on PAM support into Ambari and have something ready for 
review. Can you please take a look at the patch and documentation and provide 
your feedback.

Please let me know if you have any questions.

Note: I have added you as a reviewer as i see some authentication related 
commits under your name.

Thanks,
-Vishal


Diffs
-

  ambari-server/pom.xml d507b82 
  ambari-server/sbin/ambari-server 762ae19 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1fc9dbf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
 ef28f61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 e1aa5ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 bdd73a6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
e4ed9c6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 00e233e 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
 26d4da7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 b20df8d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aa9f3e0 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 e547f05 
  ambari-server/src/main/python/ambari-server.py bb6bc0e 
  ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
  ambari-server/src/main/resources/properties.json eb27878 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 

Diff: https://reviews.apache.org/r/52369/diff/


Testing
---

No test cases added at this point.


File Attachments (updated)


AMBARI-12263_trunk.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/29/544f4689-1ae6-414b-8bcc-f6dfe30992cf__AMBARI-12263_trunk.patch


Thanks,

Vishal Ghugare

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Alejandro Fernandez]

> On Sept. 29, 2016, 8:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Vishal, you need to also upload this code review with the new patch.
> > 
> > In the Apache Jira, I don't see changes to add the group_type column 
> > with a default value of "LOCAL".
> > What happens to existing groups stored in the DB?
> 
> Vishal Ghugare wrote:
> My apologies, i am new to reviewboard and getting a hang of it. 
> 
> I have added code to UpgradeCatalog to 1.add group_type column with 
> default value of 'LOCAL' 2.update group_type for existing ldap groups.

You can upload a new patch as opposed to an attachment.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150928
---


On Sept. 29, 2016, 9:57 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 29, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/29/37f4e76f-2430-4aea-b8eb-281863c821da__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Sept. 29, 2016, 1:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Vishal, you need to also upload this code review with the new patch.
> > 
> > In the Apache Jira, I don't see changes to add the group_type column 
> > with a default value of "LOCAL".
> > What happens to existing groups stored in the DB?

My apologies, i am new to reviewboard and getting a hang of it. 

I have added code to UpgradeCatalog to 1.add group_type column with default 
value of 'LOCAL' 2.update group_type for existing ldap groups.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150928
---


On Sept. 29, 2016, 2:57 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 29, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/29/37f4e76f-2430-4aea-b8eb-281863c821da__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/
---

(Updated Sept. 29, 2016, 2:57 p.m.)


Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-12263
https://issues.apache.org/jira/browse/AMBARI-12263


Repository: ambari


Description
---

Hello Robert,

How are you doing? 

We have been working on PAM support into Ambari and have something ready for 
review. Can you please take a look at the patch and documentation and provide 
your feedback.

Please let me know if you have any questions.

Note: I have added you as a reviewer as i see some authentication related 
commits under your name.

Thanks,
-Vishal


Diffs
-

  ambari-server/pom.xml d507b82 
  ambari-server/sbin/ambari-server 762ae19 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1fc9dbf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
 ef28f61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 e1aa5ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 bdd73a6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
e4ed9c6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 00e233e 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
 26d4da7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 b20df8d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aa9f3e0 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 e547f05 
  ambari-server/src/main/python/ambari-server.py bb6bc0e 
  ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
  ambari-server/src/main/resources/properties.json eb27878 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 

Diff: https://reviews.apache.org/r/52369/diff/


Testing
---

No test cases added at this point.


File Attachments (updated)


AMBARI-12263_trunk.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/29/37f4e76f-2430-4aea-b8eb-281863c821da__AMBARI-12263_trunk.patch


Thanks,

Vishal Ghugare

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Sept. 29, 2016, 8:54 p.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, Zhe 
(Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs
-

  ambari-web/app/styles/config_history_flow.less 0b6dc3f 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments (updated)


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150928
---




ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql (line 296)


Vishal, you need to also upload this code review with the new patch.

In the Apache Jira, I don't see changes to add the group_type column with a 
default value of "LOCAL".
What happens to existing groups stored in the DB?


- Alejandro Fernandez


On Sept. 29, 2016, 7:34 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 29, 2016, 7:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Sept. 29, 2016, 8:01 p.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
---

Fixed a UI issue. Now minimum height of the the config versions box will extend 
based on the number of config versions present.


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less 0b6dc3f 

Diff: https://reviews.apache.org/r/49838/diff/


Testing (updated)
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments (updated)


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif
AMBARI-17636.v5.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/29/5f9a486d-f006-4a2a-890d-8cd2ac69efe9__AMBARI-17636.v5.patch


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Sept. 28, 2016, 5:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Is there already an UpgradeCatalog for Ambari 2.5 that will make these 
> > schema changes as well?
> 
> Vishal Ghugare wrote:
> Hi Alejandro, i need to add these changes to UpgradeCatalog. Will fix it. 
> Thank you.
> 
> Vishal Ghugare wrote:
> Fixed. New patch uploaded.
> 
> Alejandro Fernandez wrote:
> I still only see one revision.

I have recreated the AMBARI-12263_trunk.patch which now includes two patches- 
Patch 1: All previous changes & Patch 2: changes to UpgradeCatalog.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150789
---


On Sept. 29, 2016, 12:34 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 29, 2016, 12:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51814/#review150924
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 29, 2016, 4:18 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51814/
> ---
> 
> (Updated Sept. 29, 2016, 4:18 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18362
> https://issues.apache.org/jira/browse/AMBARI-18362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update sinks to read multiple collector hostnames from configs
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  da61d83 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrAmsClient.java
>  85ea69d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  426eb42 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
>  7fadeb2 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
>  ccaa574 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  1b36e9a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  b720ba9 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  f44ca35 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  9c16564 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  73381d9 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0d3b770 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  9082e70 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  f6531c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  4618618 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  a8a7327 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
>  3cd535e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
>  586cd47 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  b839eb8 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  9c79909 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
>  b960296 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  49b684b 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
>  e62ce9e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
>  818 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
>  2b9964b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  558aa95 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
>  88be81b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
>  3d71867 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
>  ba44af5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
>  77f128b 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  ab4d701 
>   
> 

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Alejandro Fernandez]

> On Sept. 29, 2016, 12:03 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Is there already an UpgradeCatalog for Ambari 2.5 that will make these 
> > schema changes as well?
> 
> Vishal Ghugare wrote:
> Hi Alejandro, i need to add these changes to UpgradeCatalog. Will fix it. 
> Thank you.
> 
> Vishal Ghugare wrote:
> Fixed. New patch uploaded.

I still only see one revision.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150789
---


On Sept. 29, 2016, 7:34 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 29, 2016, 7:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

[Alexandr Antonenko]

> On Sept. 29, 2016, 5:26 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Sangeeta Ravindran wrote:
> Thanks Alexandr. Can you please help push the fix.

np

done


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52396/#review150877
---


On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52396/
> ---
> 
> (Updated Sept. 29, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18490
> https://issues.apache.org/jira/browse/AMBARI-18490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If you cancel the Set Rack dialog without entering any value, an error 
> appears at the bottom of the dialog instead of the dialog being dismissed. 
> Only when you click the second time does the dialog disappear. This happens 
> because the validate function gets called during cancel and because no value 
> was entered for rack id, the rack id is null and the validation code flags 
> the error.
> 
> Fix is to initialize the rack id to an empty string so that validation does 
> not flag an error even during Cancel.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/hosts.js e4a437c 
> 
> Diff: https://reviews.apache.org/r/52396/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> mvn clean test
> 30366 tests complete (45 seconds)
> 151 tests pending
> 
> There are existing test cases for validation of rackID.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Sept. 28, 2016, 5:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Is there already an UpgradeCatalog for Ambari 2.5 that will make these 
> > schema changes as well?
> 
> Vishal Ghugare wrote:
> Hi Alejandro, i need to add these changes to UpgradeCatalog. Will fix it. 
> Thank you.

Fixed. New patch uploaded.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150789
---


On Sept. 28, 2016, 4:40 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 28, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

[Sangeeta Ravindran]

> On Sept. 29, 2016, 5:25 p.m., Di Li wrote:
> > Ship It!

Thank you Di.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52396/#review150875
---


On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52396/
> ---
> 
> (Updated Sept. 29, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18490
> https://issues.apache.org/jira/browse/AMBARI-18490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If you cancel the Set Rack dialog without entering any value, an error 
> appears at the bottom of the dialog instead of the dialog being dismissed. 
> Only when you click the second time does the dialog disappear. This happens 
> because the validate function gets called during cancel and because no value 
> was entered for rack id, the rack id is null and the validation code flags 
> the error.
> 
> Fix is to initialize the rack id to an empty string so that validation does 
> not flag an error even during Cancel.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/hosts.js e4a437c 
> 
> Diff: https://reviews.apache.org/r/52396/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> mvn clean test
> 30366 tests complete (45 seconds)
> 151 tests pending
> 
> There are existing test cases for validation of rackID.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

[Sangeeta Ravindran]

> On Sept. 29, 2016, 5:26 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thanks Alexandr. Can you please help push the fix.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52396/#review150877
---


On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52396/
> ---
> 
> (Updated Sept. 29, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18490
> https://issues.apache.org/jira/browse/AMBARI-18490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If you cancel the Set Rack dialog without entering any value, an error 
> appears at the bottom of the dialog instead of the dialog being dismissed. 
> Only when you click the second time does the dialog disappear. This happens 
> because the validate function gets called during cancel and because no value 
> was entered for rack id, the rack id is null and the validation code flags 
> the error.
> 
> Fix is to initialize the rack id to an empty string so that validation does 
> not flag an error even during Cancel.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/hosts.js e4a437c 
> 
> Diff: https://reviews.apache.org/r/52396/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> mvn clean test
> 30366 tests complete (45 seconds)
> 151 tests pending
> 
> There are existing test cases for validation of rackID.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52396/#review150877
---


Ship it!




Ship It!

- Alexandr Antonenko


On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52396/
> ---
> 
> (Updated Sept. 29, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18490
> https://issues.apache.org/jira/browse/AMBARI-18490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If you cancel the Set Rack dialog without entering any value, an error 
> appears at the bottom of the dialog instead of the dialog being dismissed. 
> Only when you click the second time does the dialog disappear. This happens 
> because the validate function gets called during cancel and because no value 
> was entered for rack id, the rack id is null and the validation code flags 
> the error.
> 
> Fix is to initialize the rack id to an empty string so that validation does 
> not flag an error even during Cancel.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/hosts.js e4a437c 
> 
> Diff: https://reviews.apache.org/r/52396/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> mvn clean test
> 30366 tests complete (45 seconds)
> 151 tests pending
> 
> There are existing test cases for validation of rackID.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52396/#review150875
---


Ship it!




Ship It!

- Di Li


On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52396/
> ---
> 
> (Updated Sept. 29, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18490
> https://issues.apache.org/jira/browse/AMBARI-18490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If you cancel the Set Rack dialog without entering any value, an error 
> appears at the bottom of the dialog instead of the dialog being dismissed. 
> Only when you click the second time does the dialog disappear. This happens 
> because the validate function gets called during cancel and because no value 
> was entered for rack id, the rack id is null and the validation code flags 
> the error.
> 
> Fix is to initialize the rack id to an empty string so that validation does 
> not flag an error even during Cancel.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/hosts.js e4a437c 
> 
> Diff: https://reviews.apache.org/r/52396/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> mvn clean test
> 30366 tests complete (45 seconds)
> 151 tests pending
> 
> There are existing test cases for validation of rackID.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52397/#review150874
---


Ship it!




Ship It!

- Alexandr Antonenko


On Sept. 29, 2016, 4:48 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52397/
> ---
> 
> (Updated Sept. 29, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18488
> https://issues.apache.org/jira/browse/AMBARI-18488
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Delete Group button always has the tooltip "Cannot Delete Group" even when a 
> group is deleteable. Fix is to remove the tooltip in the case where group can 
> be deleted and Delete Group button is enabled.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 
> 8271432 
> 
> Diff: https://reviews.apache.org/r/52397/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> Tests in ambari admin project ran clean.
> PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Sept. 28, 2016, 5:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > Is there already an UpgradeCatalog for Ambari 2.5 that will make these 
> > schema changes as well?

Hi Alejandro, i need to add these changes to UpgradeCatalog. Will fix it. Thank 
you.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review150789
---


On Sept. 28, 2016, 4:40 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Sept. 28, 2016, 4:40 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52397/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-18488
https://issues.apache.org/jira/browse/AMBARI-18488


Repository: ambari


Description
---

Delete Group button always has the tooltip "Cannot Delete Group" even when a 
group is deleteable. Fix is to remove the tooltip in the case where group can 
be deleted and Delete Group button is enabled.


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 
8271432 

Diff: https://reviews.apache.org/r/52397/diff/


Testing
---

Manual testing. 
Tests in ambari admin project ran clean.
PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)


Thanks,

Sangeeta Ravindran

Review Request 52396: Need to click Cancel twice to dismiss Set Rack dialog when no value entered

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52396/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-18490
https://issues.apache.org/jira/browse/AMBARI-18490


Repository: ambari


Description
---

If you cancel the Set Rack dialog without entering any value, an error appears 
at the bottom of the dialog instead of the dialog being dismissed. Only when 
you click the second time does the dialog disappear. This happens because the 
validate function gets called during cancel and because no value was entered 
for rack id, the rack id is null and the validation code flags the error.

Fix is to initialize the rack id to an empty string so that validation does not 
flag an error even during Cancel.


Diffs
-

  ambari-web/app/utils/hosts.js e4a437c 

Diff: https://reviews.apache.org/r/52396/diff/


Testing
---

Manual testing.
mvn clean test
30366 tests complete (45 seconds)
151 tests pending

There are existing test cases for validation of rackID.


Thanks,

Sangeeta Ravindran

Re: Review Request 52340: Refactor solr layer in logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52340/
---

(Updated Sept. 29, 2016, 4:24 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

- move converter package
- get rid of SearchCriteria object
- use objects on UserHistory endpoints as well (for Logfeeder filters etc.)
- fix regression issues (append more queries to facet queries & ui fixes: 
schema fields were not mappend on log file view)


Bugs: AMBARI-18310
https://issues.apache.org/jira/browse/AMBARI-18310


Repository: ambari


Description
---

- remove more unused endpoints + code
- introduce freemarker (using for download files)
- remove @Component and @Qualifier annotations
- remove Criteria (+ Criteria converter) layer
- convert request directly to solr queries
- get rid of QueryGeneration + QueryGenerationBase classes (keep GraphGenerator 
class , that is the response converter layer now)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-portal/pom.xml a1d1bfc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 9682a3d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 d9d3b86 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogType.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 786cf99 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/VResponse.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
 b279a83 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 7508fb1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractAuditLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractDateRangeFacetQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractServiceLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditBarGraphRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditComponentsRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditServiceLoadRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/BaseServiceLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/FieldAuditLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogAnyGraphRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogComponentLevelRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogComponentRequestFacetQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogLevelCountRequestQueryConverter.java
 PRE-CREATION 
  

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51814/
---

(Updated Сен. 29, 2016, 4:18 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-18362
https://issues.apache.org/jira/browse/AMBARI-18362


Repository: ambari


Description
---

Update sinks to read multiple collector hostnames from configs


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
 da61d83 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrAmsClient.java
 85ea69d 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 426eb42 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 7fadeb2 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
 ccaa574 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 1b36e9a 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 b720ba9 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 f44ca35 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 9c16564 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 73381d9 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 0d3b770 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 9082e70 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 f6531c8 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 4618618 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 a8a7327 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 3cd535e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 586cd47 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 b839eb8 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 9c79909 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 b960296 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 49b684b 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 e62ce9e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 818 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
 2b9964b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 558aa95 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
 88be81b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
 3d71867 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 ba44af5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 77f128b 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 ab4d701 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
 6cc85f4 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 a18c295 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 f96aeeb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
 a9760cb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 1f0875f 
  

Re: Review Request 52383: Clusters With Many Hosts Can Create Alerts With Text Too Large To Be Stored

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52383/#review150859
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 29, 2016, 10:56 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52383/
> ---
> 
> (Updated Sept. 29, 2016, 10:56 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18492
> https://issues.apache.org/jira/browse/AMBARI-18492
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When running alerts in a large cluster (for example a cluster with 1300 
> hosts), some alerts like the Stale Alert may create text too large to store 
> in the database.
> On MySQL, for example, the size of a TEXT field is 65k (less if UTF-8 is 
> used). Normally, this is plenty of space. However, some clusters experience:
> 
> ERROR [alert-event-bus-1] AmbariJpaLocalTxnInterceptor:188 - [DETAILED ERROR] 
> Internal exception (1) :
> com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 
> 'alert_text' at row 1
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4185)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 8252e0d 
>   ambari-server/src/test/java/org/apache/ambari/server/state/AlertTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52383/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52264/#review150856
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 26, 2016, 6:07 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52264/
> ---
> 
> (Updated Sept. 26, 2016, 6:07 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18466
> https://issues.apache.org/jira/browse/AMBARI-18466
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Simple string replacement
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  2182fd1 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/metainfo.xml
>  6998efc 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  891d2c9 
> 
> Diff: https://reviews.apache.org/r/52264/diff/
> 
> 
> Testing
> ---
> 
> Manual testing: created cluster with wizard
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52223: AMBARI-18051 - Services should be able to provide their own pre-req checks by supplying a jar file

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52223/#review150854
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 23, 2016, 7:59 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52223/
> ---
> 
> (Updated Sept. 23, 2016, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and 
> Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18051
> https://issues.apache.org/jira/browse/AMBARI-18051
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Services should be able to provide their own pre-req checks by supplying a 
> jar file.
> 
> This would allow custom services to supply their own jar files to handle 
> pre-req checks rather than forcing third party developers to make changes to 
> ambari-server code.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 5731c9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  498481d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
>  4ed345c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  7d7b618 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  cdedbb4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  30663a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> a77a22f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  8656896 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 6fda8bc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/sample/checks/SampleServiceCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  304fd5c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  659ae12 
> 
> Diff: https://reviews.apache.org/r/52223/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> -Dtest=PreUpgradeCheckResourceProviderTest,PreUpgradeCheckServiceTest,StackManagerExtensionTest,ServiceModuleTest,StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52298/#review150853
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 27, 2016, 10:05 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52298/
> ---
> 
> (Updated Sept. 27, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18471
> https://issues.apache.org/jira/browse/AMBARI-18471
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the most obvious points of the main jira. 
> 1\. Refactor this code to have individual functions for components.  
> 2\. Remove conditions for xmlConfigs, where they are not needed
> 
> The other part of the jira requires more discussion, it probably will be
> easier to do once we have a cleaner look on the code and shrink the scope of
> the issue.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  4d42861 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  a3a3a06 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 643f946 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 7b5ce18 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> dc11ba9 
>   ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py abfe756 
> 
> Diff: https://reviews.apache.org/r/52298/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review150852
---


Ship it!




Ship It!

- Dmytro Sen


On Сен. 29, 2016, 2:46 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Сен. 29, 2016, 2:46 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  426eb42 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  b720ba9 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  f44ca35 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52383: Clusters With Many Hosts Can Create Alerts With Text Too Large To Be Stored

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52383/
---

(Updated Сен. 29, 2016, 2:56 п.п.)


Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.


Bugs: AMBARI-18492
https://issues.apache.org/jira/browse/AMBARI-18492


Repository: ambari


Description
---

When running alerts in a large cluster (for example a cluster with 1300 hosts), 
some alerts like the Stale Alert may create text too large to store in the 
database.
On MySQL, for example, the size of a TEXT field is 65k (less if UTF-8 is used). 
Normally, this is plenty of space. However, some clusters experience:

ERROR [alert-event-bus-1] AmbariJpaLocalTxnInterceptor:188 - [DETAILED ERROR] 
Internal exception (1) :
com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 
'alert_text' at row 1
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4185)


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 8252e0d 
  ambari-server/src/test/java/org/apache/ambari/server/state/AlertTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52383/diff/


Testing
---

Unit tests passed.


Thanks,

Dmytro Sen

Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18487
https://issues.apache.org/jira/browse/AMBARI-18487


Repository: ambari


Description
---

1. Change metric monitor sharding strategy to hostname based.
2. Fix issues in AbstractTimelineMetricSink
3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 426eb42 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 b720ba9 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 f44ca35 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 3982c4e 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 

Diff: https://reviews.apache.org/r/52391/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 52378: [AMBARI-18489] configs.sh has a spelling mistake inside the script.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52378/#review150850
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 29, 2016, 2:01 a.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52378/
> ---
> 
> (Updated Sept. 29, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18489
> https://issues.apache.org/jira/browse/AMBARI-18489
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> [AMBARI-18489] configs.sh has a spelling mistake inside the script.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/configs.sh ba02d2d 
> 
> Diff: https://reviews.apache.org/r/52378/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 52383: Clusters With Many Hosts Can Create Alerts With Text Too Large To Be Stored

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52383/#review150849
---




ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java (lines 37 
- 38)


Is this right? It should be 65,536 - 2 bytes. Then I think it's safe to 
assume 2 bytes per character for UTF-8 databases which would make it 32617 
characters.



ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java (line 135)


Use \u2026 instead of '...' to represent a single character which can't be 
broken across lines.


- Jonathan Hurley


On Sept. 29, 2016, 6:19 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52383/
> ---
> 
> (Updated Sept. 29, 2016, 6:19 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18492
> https://issues.apache.org/jira/browse/AMBARI-18492
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When running alerts in a large cluster (for example a cluster with 1300 
> hosts), some alerts like the Stale Alert may create text too large to store 
> in the database.
> On MySQL, for example, the size of a TEXT field is 65k (less if UTF-8 is 
> used). Normally, this is plenty of space. However, some clusters experience:
> 
> ERROR [alert-event-bus-1] AmbariJpaLocalTxnInterceptor:188 - [DETAILED ERROR] 
> Internal exception (1) :
> com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 
> 'alert_text' at row 1
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:4185)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 8252e0d 
>   ambari-server/src/test/java/org/apache/ambari/server/state/AlertTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52383/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52378: [AMBARI-18489] configs.sh has a spelling mistake inside the script.

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52378/#review150845
---


Ship it!




Ship It!

- Nate Cole


On Sept. 29, 2016, 2:01 a.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52378/
> ---
> 
> (Updated Sept. 29, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18489
> https://issues.apache.org/jira/browse/AMBARI-18489
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> [AMBARI-18489] configs.sh has a spelling mistake inside the script.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/configs.sh ba02d2d 
> 
> Diff: https://reviews.apache.org/r/52378/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 52380: Spark user principal name is not always lowercase in HDP 2.5

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52380/#review150830
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 29, 2016, 9 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52380/
> ---
> 
> (Updated Вер. 29, 2016, 9 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18491
> https://issues.apache.org/jira/browse/AMBARI-18491
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Spark principal name is not always lowercase in HDP 2.5.
> 
> This is because the principal definition does not specify `toLower` in the HDP
> 2.5 specific Kerberos descriptor:
> 
> **stacks/HDP/2.5/services/SPARK/kerberos.json:12**
> 
> 
> 
> "value": "${spark-env/spark_user}-${cluster_name}@${realm}",
> 
> 
> Should be:
> 
> **stacks/HDP/2.5/services/SPARK/kerberos.json:12**
> 
> 
> 
> "value": "${spark-env/spark_user}-${cluster_name|toLower()}@${realm}",
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> 2d52fb3 
> 
> Diff: https://reviews.apache.org/r/52380/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150829
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On Sept. 28, 2016, 12:44 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> ---
> 
> (Updated Sept. 28, 2016, 12:44 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
> https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  bd875ba 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 2c9609f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  14625c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  5a54d85 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  922e27e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  873fb6f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  d594c7e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  608758f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  809c1c0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  0c70ee5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  66ef1ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  fb34d51 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  33540e9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  a7ae9b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f 
> 
> Diff: https://reviews.apache.org/r/51647/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 52355: Add HDP-2.6 stack deriving from 2.5

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52355/#review150828
---


Ship it!




Ship It!

- Dmytro Grinenko


On Sept. 28, 2016, 4:33 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52355/
> ---
> 
> (Updated Sept. 28, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18484
> https://issues.apache.org/jira/browse/AMBARI-18484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support for HDP-2.6 stack.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ACCUMULO/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/FALCON/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/FLUME/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KERBEROS/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/MAHOUT/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/PIG/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SLIDER/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/SQOOP/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/STORM/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/TEZ/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZOOKEEPER/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52355/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed. Only metainfo changed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52355: Add HDP-2.6 stack deriving from 2.5

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52355/#review150827
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 28, 2016, 4:33 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52355/
> ---
> 
> (Updated Вер. 28, 2016, 4:33 після полудня)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18484
> https://issues.apache.org/jira/browse/AMBARI-18484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support for HDP-2.6 stack.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ACCUMULO/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/FALCON/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/FLUME/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KERBEROS/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/MAHOUT/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/PIG/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SLIDER/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/SQOOP/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/STORM/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/TEZ/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZOOKEEPER/metainfo.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52355/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed. Only metainfo changed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>