Re: Review Request 55609: Add Livy session recovery configurations in Ambari

[Saisai Shao]

> On Jan. 19, 2017, 4:59 a.m., Bikas Saha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.
> 
> Saisai Shao wrote:
> It will not be in the top level HDFS dirs. It will be in User livy's 
> current home directory, which is "/user/livy/livy-recovery".
> 
> Bikas Saha wrote:
> My suggestion would be to change that to /apps/spark where such system 
> data tends to go for other apps. That would be the convention. What do the 
> Ambari folks think? Of course my understanding of existing convention might 
> be wrong :) In which case /user/livy/ is also ok.
> 
> Saisai Shao wrote:
> Bikas, there's no /apps/spark, and it actually is 
> "/hdp/apps/2.6.0.0-389/spark", which is hdp version specific. So I will 
> follow what spark history did "/spark-history", to create "/livy-recovery" 
> and "/livy2-recovery".

What do you think?


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 18, 2017, 2:25 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 18, 2017, 2:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 55609: Add Livy session recovery configurations in Ambari

[Saisai Shao]

> On Jan. 19, 2017, 4:59 a.m., Bikas Saha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.
> 
> Saisai Shao wrote:
> It will not be in the top level HDFS dirs. It will be in User livy's 
> current home directory, which is "/user/livy/livy-recovery".
> 
> Bikas Saha wrote:
> My suggestion would be to change that to /apps/spark where such system 
> data tends to go for other apps. That would be the convention. What do the 
> Ambari folks think? Of course my understanding of existing convention might 
> be wrong :) In which case /user/livy/ is also ok.

Bikas, there's no /apps/spark, and it actually is 
"/hdp/apps/2.6.0.0-389/spark", which is hdp version specific. So I will follow 
what spark history did "/spark-history", to create "/livy-recovery" and 
"/livy2-recovery".


- Saisai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 18, 2017, 2:25 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 18, 2017, 2:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 55871: Error on Files view-SIMPLE authentication is not enabled

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55871/#review162783
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 24, 2017, 5:47 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55871/
> ---
> 
> (Updated Jan. 24, 2017, 5:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19689
> https://issues.apache.org/jira/browse/AMBARI-19689
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting fs.defaultfs property to webhdfs url after reading the core-site and 
> hdfs-site.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  d1d1bb0 
> 
> Diff: https://reviews.apache.org/r/55871/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on local vm
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 55839: Hive View 2.0: Code hints for query editor are not working

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55839/#review162778
---


Fix it, then Ship it!




Ship It!


contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js (line 
79)


is this commented method required? If not please remove.


- Nitiraj Rathore


On Jan. 23, 2017, 11:46 a.m., Abhishek Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55839/
> ---
> 
> (Updated Jan. 23, 2017, 11:46 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19673
> https://issues.apache.org/jira/browse/AMBARI-19673
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see code hints and syntax colorization while typing 
> hive queries.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
> 27d43d5 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 
> 
> Diff: https://reviews.apache.org/r/55839/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Abhishek Kumar
> 
>

Re: Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/#review162777
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 23, 2017, 10:51 a.m., Abhishek Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55836/
> ---
> 
> (Updated Jan. 23, 2017, 10:51 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19667
> https://issues.apache.org/jira/browse/AMBARI-19667
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added jQuery-ui to add "draggable" functionality
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
> 27d43d5 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1 
>   contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7 
>   contrib/views/hive20/src/main/resources/ui/package.json ed7a299 
> 
> Diff: https://reviews.apache.org/r/55836/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Abhishek Kumar
> 
>

Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/#review162776
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 23, 2017, 11:37 a.m., Abhishek Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55837/
> ---
> 
> (Updated Jan. 23, 2017, 11:37 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19671
> https://issues.apache.org/jira/browse/AMBARI-19671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On selecting a database from right panel, display does not change. Ideally 
> followings should happen:
> 1. Move "checked" icon to selected database
> 2. Hide tables related to unselected database and show tables for the 
> selected one.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 950e4f3 
> 
> Diff: https://reviews.apache.org/r/55837/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Abhishek Kumar
> 
>

Re: Review Request 55814: Add log rotation settings - handle upgrade scenario - Storm, Hive

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55814/
---

(Updated Jan. 24, 2017, 6:42 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

Incorporated review comments.


Bugs: AMBARI-19660
https://issues.apache.org/jira/browse/AMBARI-19660


Repository: ambari


Description
---

Add log rotation settings - handle upgrade scenario - Storm, Hive


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
09de45c 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 81c470a 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 3e61aad 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 cffecaa3 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
5ae6876 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
eafb129 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
8101682 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
db848c1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 1c4325f 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 5808aa3 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9b159a4 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
2ac82ce 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
73e3c38 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 bce539d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
7f9e986 

Diff: https://reviews.apache.org/r/55814/diff/


Testing
---

Nonrolling upgrade HDP2.5->HDP2.6


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 55871: Error on Files view-SIMPLE authentication is not enabled

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55871/#review162772
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 24, 2017, 5:47 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55871/
> ---
> 
> (Updated Jan. 24, 2017, 5:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19689
> https://issues.apache.org/jira/browse/AMBARI-19689
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting fs.defaultfs property to webhdfs url after reading the core-site and 
> hdfs-site.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  d1d1bb0 
> 
> Diff: https://reviews.apache.org/r/55871/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on local vm
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 55871: Error on Files view-SIMPLE authentication is not enabled

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55871/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-19689
https://issues.apache.org/jira/browse/AMBARI-19689


Repository: ambari


Description
---

Setting fs.defaultfs property to webhdfs url after reading the core-site and 
hdfs-site.


Diffs
-

  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 d1d1bb0 

Diff: https://reviews.apache.org/r/55871/diff/


Testing
---

Manually tested on local vm


Thanks,

Gaurav Nagar

Re: Review Request 55814: Add log rotation settings - handle upgrade scenario - Storm, Hive

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55814/#review162764
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 (line 371)


Nit! 
LLAP instead of llap as its an acronym



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 (line 369)


Nit!
WebHCat instead of Webhcat


- Jayush Luniya


On Jan. 21, 2017, 6:11 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55814/
> ---
> 
> (Updated Jan. 21, 2017, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19660
> https://issues.apache.org/jira/browse/AMBARI-19660
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle upgrade scenario - Storm, Hive
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 09de45c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  81c470a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  3e61aad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  cffecaa3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 5ae6876 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> eafb129 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 8101682 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> db848c1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  1c4325f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  5808aa3 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9b159a4 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 2ac82ce 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 73e3c38 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  bce539d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 7f9e986 
> 
> Diff: https://reviews.apache.org/r/55814/diff/
> 
> 
> Testing
> ---
> 
> Nonrolling upgrade HDP2.5->HDP2.6
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55854: Small fixes for common log rotation

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55854/#review162763
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 23, 2017, 8 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55854/
> ---
> 
> (Updated Jan. 23, 2017, 8 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19682
> https://issues.apache.org/jira/browse/AMBARI-19682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Small fixes to log4j rotation properties - Yarn, ZooKeeper, AMS-Hbase, 
> Logsearch/Logfeeder
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
>  5a97804 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  33749ff 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  a845741 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml
>  31f0ff3 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
>  151ce3b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml
>  34e97d4 
> 
> Diff: https://reviews.apache.org/r/55854/diff/
> 
> 
> Testing
> ---
> 
> Manual. Verified from UI.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
---

(Updated Jan. 24, 2017, 12:16 a.m.)


Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685


Repository: ambari


Description
---

* Install Ambari cluster with latest trunk bits
* Modify 
/var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 to add the following:
Add to  node of ZEPPELIN_MASTER:

  SPARK/LIVY_SERVER
  host

Add to  node:
  
SPARK
  
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml 
change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one 
Livy Server is selected <- this validation should be handled by the stack 
advisor


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 adcb5b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java
 5fc5f52 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 5d9358c 
  ambari-server/src/main/resources/properties.json 698b6c5 
  ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
ff25512 

Diff: https://reviews.apache.org/r/55865/diff/


Testing (updated)
---

Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached to the reviewboard of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the 
patch


File Attachments


Validation error
  
https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
Validation error cluster scope
  
https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
Validation error host scope
  
https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png


Thanks,

Jaimin Jetly

Re: Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
---

(Updated Jan. 24, 2017, 12:15 a.m.)


Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685


Repository: ambari


Description
---

* Install Ambari cluster with latest trunk bits
* Modify 
/var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 to add the following:
Add to  node of ZEPPELIN_MASTER:

  SPARK/LIVY_SERVER
  host

Add to  node:
  
SPARK
  
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml 
change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one 
Livy Server is selected <- this validation should be handled by the stack 
advisor


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 adcb5b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java
 5fc5f52 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 5d9358c 
  ambari-server/src/main/resources/properties.json 698b6c5 
  ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
ff25512 

Diff: https://reviews.apache.org/r/55865/diff/


Testing
---

Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached on the jira of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the 
patch


File Attachments (updated)


Validation error
  
https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png
Validation error cluster scope
  
https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png
Validation error host scope
  
https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png


Thanks,

Jaimin Jetly

Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55865/
---

Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-19685
https://issues.apache.org/jira/browse/AMBARI-19685


Repository: ambari


Description
---

* Install Ambari cluster with latest trunk bits
* Modify 
/var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 to add the following:
Add to  node of ZEPPELIN_MASTER:

  SPARK/LIVY_SERVER
  host

Add to  node:
  
SPARK
  
* Install HDP 2.5.3 cluster with Spark
* Once the cluster is installed, use Add Service Wizard to add Zeppelin
* Assign Slaves and Clients step should appear (without the metainfo.xml 
change, it will be skipped)
* The user should not be able to proceed beyond this page unless at least one 
Livy Server is selected <- this validation should be handled by the stack 
advisor


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 adcb5b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java
 5fc5f52 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 5d9358c 
  ambari-server/src/main/resources/properties.json 698b6c5 
  ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
ff25512 

Diff: https://reviews.apache.org/r/55865/diff/


Testing
---

Tested installer and Add Service wizard to work with the patch as expected.
snapshots attached on the jira of the UI impact
Verfiied that related ambari-server (java/python) unit test passes with the 
patch


Thanks,

Jaimin Jetly

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

[Vitalyi Brodetskyi]

> On Січ. 23, 2017, 10:26 після полудня, Alejandro Fernandez wrote:
> > ambari-server/conf/unix/create-python-wrap.sh, line 35
> > 
> >
> > Why is this all of a sudden failing now?
> > Weren't we testing on Ubuntu 16 before?

The problem is that ubuntu16 which we are testing has three versions of python 
(3.5, 2.7.5 and 2.7.12). Python 3.5 is not actual for us. If you will call 
python byt simple "python" command you will get to python with version 2.7.5, 
this is not patched python for ubuntu16, looks like it was installed 
additinally. But if you will call /usr/bin/python you will get correct python 
version with correct behaviour of linux_distribution method. When we are trying 
to get os type from python we are not using python wrapper. So when we are 
creating python wrapper and then call python code which return os type 
everything works fine. Because python wrapper check version of python and 
creates link to /usr/bin/python.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162718
---


On Січ. 23, 2017, 10:16 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Січ. 23, 2017, 10:16 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162720
---




ambari-server/conf/unix/create-python-wrap.sh (line 1)


No shebang line? Ommitted on purpose?



ambari-server/conf/unix/create-python-wrap.sh (line 23)


Wy the comma?



ambari-server/conf/unix/create-python-wrap.sh (line 26)


Should there be a try ... catch in to make it more solid?


- Sid Wagle


On Jan. 23, 2017, 10:16 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Jan. 23, 2017, 10:16 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162718
---




ambari-server/conf/unix/create-python-wrap.sh (line 35)


Why is this all of a sudden failing now?
Weren't we testing on Ubuntu 16 before?


- Alejandro Fernandez


On Jan. 23, 2017, 10:16 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Jan. 23, 2017, 10:16 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55854: Small fixes for common log rotation

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55854/#review162701
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 23, 2017, 8 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55854/
> ---
> 
> (Updated Jan. 23, 2017, 8 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19682
> https://issues.apache.org/jira/browse/AMBARI-19682
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Small fixes to log4j rotation properties - Yarn, ZooKeeper, AMS-Hbase, 
> Logsearch/Logfeeder
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
>  5a97804 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  33749ff 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  a845741 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml
>  31f0ff3 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
>  151ce3b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml
>  34e97d4 
> 
> Diff: https://reviews.apache.org/r/55854/diff/
> 
> 
> Testing
> ---
> 
> Manual. Verified from UI.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 55853: AMBARI-19681: Credential store should add hadoop credential provider path property to all affected configuration types

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55853/
---

Review request for Ambari, Miklos Gergely and Sumit Mohanty.


Bugs: AMBARI-19681
https://issues.apache.org/jira/browse/AMBARI-19681


Repository: ambari


Description
---

AMBARI-19681: Credential store should add hadoop credential provider path 
property to all affected configuration types


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
02f42123b9b392251e1315f930d63cb11c0de2c7 

Diff: https://reviews.apache.org/r/55853/diff/


Testing
---

** 1. mvn test -DskipSurefireTests **

--
Ran 270 tests in 6.740s

OK
--
Total run:1151
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:13.542s
[INFO] Finished at: Mon Jan 23 11:57:11 PST 2017
[INFO] Final Memory: 50M/798M
[INFO] 

** 2. Manual testing **
Deployed the changes to a VM and manually verified that when the command 
contains multiple configurations that contain credentials, each config type 
gets a *hadoop.security.credential.provider.path* property pointing to its 
JCEKS provider.


Thanks,

Nahappan Somasundaram

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55680/#review162685
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 20, 2017, 11:21 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55680/
> ---
> 
> (Updated Jan. 20, 2017, 11:21 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19613
> https://issues.apache.org/jira/browse/AMBARI-19613
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On secure namenode HA clusters the ZKFC component needs to access the 
> zookeeper securely.
> On enabling security appropriate settings are configured to secure this 
> connection.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 1cf1603 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  3270430 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  f1891a5 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 4fdffcf 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
>  f76935a 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  f1891a5 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  783f811 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml
>  5be2b74 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
>  24e0193 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml
>  24e0193 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 766a014 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
>  f70c8e9 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml
>  e680c1b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py e952108 
> 
> Diff: https://reviews.apache.org/r/55680/diff/
> 
> 
> Testing
> ---
> 
> Testing done manually:
> 
> Created an unsecure NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - doesn't exist
> * checked the hadoop-env.sh - doesn't contain the variable export 
> HADOOP_ZKFC_OPTS
> * checked the hdfs_jaas.conf - doesn't exist
> * connected to zookeeper, listed znode acls - no limitations set
> 
> Kerberized the NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - set to sasl:nn:cdrwa
> * checked the hadoop-env.sh - contains the variable export HADOOP_ZKFC_OPTS 
> with proper value, points to the correct jaas file
> * checked the hdfs_jaas.conf - OK
> * connected to zookeeper, listed znode acls - set as required 
> (/hadoop-ha/mycluster/ActiveStandbyElectorLock)
> 
> Disabled Kerberos on the NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - removed
> * checked the hadoop-env.sh - doesn't contain the variable export 
> HADOOP_ZKFC_OPTS
> * connected to zookeeper, listed znode acls - set as required 
> (/hadoop-ha/mycluster/ActiveStandbyElectorLock)
> 
> Unit tests:
> Running in progress for trunk
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 55854: Small fixes for common log rotation

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55854/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-19682
https://issues.apache.org/jira/browse/AMBARI-19682


Repository: ambari


Description
---

Small fixes to log4j rotation properties - Yarn, ZooKeeper, AMS-Hbase, 
Logsearch/Logfeeder


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
 5a97804 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
 33749ff 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
 a845741 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml
 31f0ff3 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
 151ce3b 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml
 34e97d4 

Diff: https://reviews.apache.org/r/55854/diff/


Testing
---

Manual. Verified from UI.


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf directory instead of hard-coded /etc/atlas/conf path

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review162682
---


Fix it, then Ship it!





ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py (line 35)


Even in unit tests, don't hardcode /usr/hdp/


- Alejandro Fernandez


On Jan. 13, 2017, 4:46 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> ---
> 
> (Updated Jan. 13, 2017, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need 
> to update Atlac Conf path as per stack structures
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  1fd1b9b 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> f2fec70 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 
> 
> Diff: https://reviews.apache.org/r/55505/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh installation on centos-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/#review162681
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 23, 2017, 1:40 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55833/
> ---
> 
> (Updated Jan. 23, 2017, 1:40 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19668
> https://issues.apache.org/jira/browse/AMBARI-19668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Secure zookeeper ACLs should be supported only in HDP 2.6 and above. This 
> patch is about reworking the existing patches (oozie, hive, yarn-rm) and 
> removing secure zk acl support if stack version is < 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  02ce194 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  1a34b87 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  48c8ef0 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json
>  f1092f5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> c8b5989 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  7df82bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  77bd363 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> eaffec6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  e4a499b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> a8ef83c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  3059f14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 5fff05c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> eaffec6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  ddf8348 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
>  0b6b3ab 
> 
> Diff: https://reviews.apache.org/r/55833/diff/
> 
> 
> Testing
> ---
> 
> HDP2.6
>   - created a cluster with oozie and yarn
>   - enabled kerberos
>   - acl on /rmstore/ZKRMStateRoot and /oozie was sasl
>   - disabled kerberos
>   - acl on /rmstore/ZKRMStateRoot and /oozie was word:anyone
>   
> HDP2.5
>   - created a cluster with oozie and yarn
>   - enabled kerberos
>   - acl on /rmstore/ZKRMStateRoot and /oozie was world:anyone
>   - disabled kerberos
>   - acl on /rmstore/ZKRMStateRoot and /oozie was word:anyone
> 
> Ambari agent:
>   Ran 454 tests in 92.306s
>   OK
>   
> Ambari server:
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 55814: Add log rotation settings - handle upgrade scenario - Storm, Hive

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55814/#review162678
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 21, 2017, 6:11 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55814/
> ---
> 
> (Updated Jan. 21, 2017, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-19660
> https://issues.apache.org/jira/browse/AMBARI-19660
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add log rotation settings - handle upgrade scenario - Storm, Hive
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 09de45c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  81c470a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  3e61aad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  cffecaa3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 5ae6876 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> eafb129 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 8101682 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> db848c1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  1c4325f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  5808aa3 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9b159a4 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 2ac82ce 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 73e3c38 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  bce539d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 7f9e986 
> 
> Diff: https://reviews.apache.org/r/55814/diff/
> 
> 
> Testing
> ---
> 
> Nonrolling upgrade HDP2.5->HDP2.6
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55851: Dangling config-group hostmapping entries result in partial loading of config groups

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55851/#review162672
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Січ. 23, 2017, 8:36 після полудня, Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55851/
> ---
> 
> (Updated Січ. 23, 2017, 8:36 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19679
> https://issues.apache.org/jira/browse/AMBARI-19679
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Scenario_:
> ConfigGroups with host mapping to hosts that no longer exist.
> This results in an NPE during lookup from the in-memory Cluster Map.
> {code}
> Host host = clusters.getHost(hostMappingEntity.getHostname());
> {code}
> This is swallowed by the Guice assisted injector leading to partial loading 
> of the data from DB.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
>  fe1f338 
> 
> Diff: https://reviews.apache.org/r/55851/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 55851: Dangling config-group hostmapping entries result in partial loading of config groups

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55851/
---

Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.


Bugs: AMBARI-19679
https://issues.apache.org/jira/browse/AMBARI-19679


Repository: ambari


Description
---

_Scenario_:
ConfigGroups with host mapping to hosts that no longer exist.
This results in an NPE during lookup from the in-memory Cluster Map.
{code}
Host host = clusters.getHost(hostMappingEntity.getHostname());
{code}
This is swallowed by the Guice assisted injector leading to partial loading of 
the data from DB.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
 fe1f338 

Diff: https://reviews.apache.org/r/55851/diff/


Testing
---

Manually tested.


Thanks,

Sid Wagle

Re: Review Request 55821: Log Search: support credential store api (part 1)

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55821/#review162668
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 22, 2017, 6:57 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55821/
> ---
> 
> (Updated Jan. 22, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the patch is based by https://reviews.apache.org/r/55755/
> first part: support credential store api on logsearch part (originally 
> developed by Miklos Gergely)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  ea9f45d 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 645c5f0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  2fb4ff3 
> 
> Diff: https://reviews.apache.org/r/55821/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 55847: AMBARI-19657: Downgrade button does not work after restart Ambari server when upgrade wizard was left open

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55847/#review162667
---


Ship it!




Ship It!

- Tim Thorpe


On Jan. 23, 2017, 6:05 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55847/
> ---
> 
> (Updated Jan. 23, 2017, 6:05 p.m.)
> 
> 
> Review request for Ambari, Sangeeta Ravindran and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19657
> https://issues.apache.org/jira/browse/AMBARI-19657
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Run express/rolling upgrade on a trunk cluster. While the upgrade wizard UI 
> pauses on a manual step or a failed step, restart ambari server. Once the 
> Ambari Server restarts, reload Ambari web UI, observe that the wizard UI pops 
> up automatically with the paused step showing the Downgrade button. Clicking 
> the downgrade button doesn't do anything in this case because the 
> "currentVersion" variable in the controller isn't set yet. Workaround is to 
> close the wizard to force the Stack/Version page to reload, then reopen the 
> wizard and click the Downgrade button.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> 4f88d2f 
> 
> Diff: https://reviews.apache.org/r/55847/diff/
> 
> 
> Testing
> ---
> 
> build trunk code, run upgrade, restart ambari server when the upgrade wizard 
> is opened and paused at a menu step. 
> existing web UI unit tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55847: AMBARI-19657: Downgrade button does not work after restart Ambari server when upgrade wizard was left open

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55847/#review162666
---


Ship it!




Ship It!

- Sangeeta Ravindran


On Jan. 23, 2017, 4:25 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55847/
> ---
> 
> (Updated Jan. 23, 2017, 4:25 p.m.)
> 
> 
> Review request for Ambari and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-19657
> https://issues.apache.org/jira/browse/AMBARI-19657
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Run express/rolling upgrade on a trunk cluster. While the upgrade wizard UI 
> pauses on a manual step or a failed step, restart ambari server. Once the 
> Ambari Server restarts, reload Ambari web UI, observe that the wizard UI pops 
> up automatically with the paused step showing the Downgrade button. Clicking 
> the downgrade button doesn't do anything in this case because the 
> "currentVersion" variable in the controller isn't set yet. Workaround is to 
> close the wizard to force the Stack/Version page to reload, then reopen the 
> wizard and click the Downgrade button.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> 4f88d2f 
> 
> Diff: https://reviews.apache.org/r/55847/diff/
> 
> 
> Testing
> ---
> 
> build trunk code, run upgrade, restart ambari server when the upgrade wizard 
> is opened and paused at a menu step. 
> existing web UI unit tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55586: Cannot change group/user privileges in list view if the user has VIEW.USER privilege

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55586/#review162664
---


Ship it!




Ship It!

- Di Li


On Jan. 23, 2017, 5:44 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55586/
> ---
> 
> (Updated Jan. 23, 2017, 5:44 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, Di Li, 
> Oleg Nechiporenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-19542
> https://issues.apache.org/jira/browse/AMBARI-19542
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create a view for e.g. Capacity Scheduler view and grant a group / user 
> permissions for the view.
> 2. Go to Roles list view. Try to assign the group / user a different role via 
> the List view.
> 
> There is no response in the UI and the role is not updated. On the browser 
> console, the following erorr can be seen.
> 
> DELETE 
> http://9.30.56.80:8081/api/v1/clusters/C1/privileges?PrivilegeInfo/privilege_id.in(416)
>  500 (Internal Server Error)
> 
> In the ambari-server.log, the following exception is seen:
> 
> Caused by: org.apache.ambari.server.AmbariException: Can't remove VIEW 
> permission from a CAPACITY-SCHEDULER{1.0.0} resource.
> at 
> org.apache.ambari.server.controller.internal.PrivilegeResourceProvider$2.invoke(PrivilegeResourceProvider.java:460)
> 
> This does not happen when roles are assigned via the Block view.
> 
> This seems to be because the VIEW.USER privilege is also being passed in as 
> one of the privileges to be deleted when the role is being changed in the 
> List view.
> 
> To fix this, the arrayOfPrivileges passed in for deletion to the backend 
> should not contain VIEW.USER privilege.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
>  9869d0b 
> 
> Diff: https://reviews.apache.org/r/55586/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> Ran mvn test
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 55812: Error during Alert: Unable to authenticate through LDAP for Hiveserver2 (also floods HS2 log with error messages)

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55812/#review162662
---


Ship it!




Ship It!

- Swapan Shridhar


On Jan. 21, 2017, 1:58 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55812/
> ---
> 
> (Updated Jan. 21, 2017, 1:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Swapan Shridhar, and Thejas 
> Nair.
> 
> 
> Bugs: Ambari-19642
> https://issues.apache.org/jira/browse/Ambari-19642
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error during Alert: Unable to authenticate through LDAP for Hiveserver2 (also 
> floods HS2 log with error messages)
> 
> Details in the bug.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py
>  ebcf4f9 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  1386c36 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
>  32da1cc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
>  8db564d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 04ada3e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-env.xml
>  97a9e8b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> daabe1c 
> 
> Diff: https://reviews.apache.org/r/55812/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests locally - 
> 
> --
> Ran 270 tests in 6.792s
> 
> OK
> --
> Total run:1151
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 55850: Confirmation for adding host component from service summary page should be displayed once

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55850/#review162660
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 23, 2017, 5:42 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55850/
> ---
> 
> (Updated Янв. 23, 2017, 5:42 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19678
> https://issues.apache.org/jira/browse/AMBARI-19678
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While adding component to host via Service Actions menu on service summary 
> page, two confirmation popups are displayed: the first one with host 
> selection and the second one with configs changes. Confirmation should be 
> displayed once.
> The above is correct for Hive Metastore, Ranger KMS Server and Nimbus. Adding 
> any other component from service summary doesn't result in displaying 
> properties to be updated.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/host/details.js 1fcc14d 
>   ambari-web/app/controllers/main/service/item.js 3a60137 
>   ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
> ed8445e 
>   ambari-web/app/templates/main/service/add_host_popup.hbs e5f2c99 
>   ambari-web/test/controllers/main/host/details_test.js ff5887c 
> 
> Diff: https://reviews.apache.org/r/55850/diff/
> 
> 
> Testing
> ---
> 
> 20321 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 55850: Confirmation for adding host component from service summary page should be displayed once

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55850/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19678
https://issues.apache.org/jira/browse/AMBARI-19678


Repository: ambari


Description
---

While adding component to host via Service Actions menu on service summary 
page, two confirmation popups are displayed: the first one with host selection 
and the second one with configs changes. Confirmation should be displayed once.
The above is correct for Hive Metastore, Ranger KMS Server and Nimbus. Adding 
any other component from service summary doesn't result in displaying 
properties to be updated.


Diffs
-

  ambari-web/app/controllers/main/host/details.js 1fcc14d 
  ambari-web/app/controllers/main/service/item.js 3a60137 
  ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
ed8445e 
  ambari-web/app/templates/main/service/add_host_popup.hbs e5f2c99 
  ambari-web/test/controllers/main/host/details_test.js ff5887c 

Diff: https://reviews.apache.org/r/55850/diff/


Testing
---

20321 passing (21s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 55789: Deleted configuration groups are displayed along with active group with is_current value set to true using Ambari API's

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162659
---



There should be a test (and/or a negative test) covering this change.

- Nate Cole


On Jan. 23, 2017, 12:34 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55789/
> ---
> 
> (Updated Jan. 23, 2017, 12:34 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, and Nate Cole.
> 
> 
> Bugs: AMBARI-19641
> https://issues.apache.org/jira/browse/AMBARI-19641
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following REST API returns deleted config group along with active groups with 
> is_current value set to true.
> 
> http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS_current=true
> 
> Please here to the attachments ConfigHistory.png and 
> service_config_versions_HDFS_is_current as an example.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
>  2d6ca20 
> 
> Diff: https://reviews.apache.org/r/55789/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. After applying patch, deleted config group entries were not 
> returned for the above REST API call.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55848/#review162654
---


Ship it!




Ship It!

- Tim Thorpe


On Jan. 23, 2017, 4:51 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55848/
> ---
> 
> (Updated Jan. 23, 2017, 4:51 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19630
> https://issues.apache.org/jira/browse/AMBARI-19630
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari current requires stack version ( used in the repo) as x.x.x.x-, 
> Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  7274a59 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cd 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 
> 
> Diff: https://reviews.apache.org/r/55848/diff/
> 
> 
> Testing
> ---
> 
> unit tests
> build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then 
> upgrade again, at the Finalize step verify the hostcomponentstate table has 
> 2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous 
> "IN_PROGESS". then be able to click the finalize and finalize the upgrade.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55774: AMBARI-19636: Provide default values for Kafka nofile and nproc limit properties

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55774/#review162651
---


Ship it!




Ship It!

- Tim Thorpe


On Jan. 20, 2017, 4:01 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55774/
> ---
> 
> (Updated Jan. 20, 2017, 4:01 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19636
> https://issues.apache.org/jira/browse/AMBARI-19636
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide default values for Kafka nofile and nproc limit properties
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  6c7ff69 
> 
> Diff: https://reviews.apache.org/r/55774/diff/
> 
> 
> Testing
> ---
> 
> existing unit tests
> build ambari rpms with trunk code, install a trunk cluster.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55848/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19630
https://issues.apache.org/jira/browse/AMBARI-19630


Repository: ambari


Description
---

Ambari current requires stack version ( used in the repo) as x.x.x.x-, 
Ambari should be flexible enough to accept both x.x.x.x- and x.x.x.x


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
 7274a59 
  
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
 615a0cd 
  ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2 

Diff: https://reviews.apache.org/r/55848/diff/


Testing
---

unit tests
build an trunk cluster with version 2.6.0.0, run upgrade, downgrade, then 
upgrade again, at the Finalize step verify the hostcomponentstate table has 
2.6.0.0 as the version and upgrade_state as COMPLETE instead of the previous 
"IN_PROGESS". then be able to click the finalize and finalize the upgrade.


Thanks,

Di Li

Re: Review Request 55789: Deleted configuration groups are displayed along with active group with is_current value set to true using Ambari API's

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162649
---



Please add Nate Cole for the review.

- Di Li


On Jan. 20, 2017, 11:49 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55789/
> ---
> 
> (Updated Jan. 20, 2017, 11:49 p.m.)
> 
> 
> Review request for Ambari, Di Li and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-19641
> https://issues.apache.org/jira/browse/AMBARI-19641
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following REST API returns deleted config group along with active groups with 
> is_current value set to true.
> 
> http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS_current=true
> 
> Please here to the attachments ConfigHistory.png and 
> service_config_versions_HDFS_is_current as an example.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
>  2d6ca20 
> 
> Diff: https://reviews.apache.org/r/55789/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. After applying patch, deleted config group entries were not 
> returned for the above REST API call.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 55789: Deleted configuration groups are displayed along with active group with is_current value set to true using Ambari API's

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162648
---


Ship it!




Ship It!

- Di Li


On Jan. 20, 2017, 11:49 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55789/
> ---
> 
> (Updated Jan. 20, 2017, 11:49 p.m.)
> 
> 
> Review request for Ambari, Di Li and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-19641
> https://issues.apache.org/jira/browse/AMBARI-19641
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following REST API returns deleted config group along with active groups with 
> is_current value set to true.
> 
> http://hostname/api/v1/clusters/kafkatest68/configurations/service_config_versions?service_name=HDFS_current=true
> 
> Please here to the attachments ConfigHistory.png and 
> service_config_versions_HDFS_is_current as an example.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
>  2d6ca20 
> 
> Diff: https://reviews.apache.org/r/55789/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. After applying patch, deleted config group entries were not 
> returned for the above REST API call.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/#review162647
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 23, 2017, 5:33 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55845/
> ---
> 
> (Updated Jan. 23, 2017, 5:33 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19677
> https://issues.apache.org/jira/browse/AMBARI-19677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
> Atlas hook JARs, must be updated during an upgrade to point to the correct 
> versions of the JAR files.
> 
> # Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure 
> cluster via Blueprint
> # Perform HOU to 2.5.3.0 and let it complete
> # Run Storm service check
> 
> 
> During the upgrade, the pointers are changed to `current` of Atlas which 
> still points to the old JARs:
> 
> ```
> [root@r6-mams-ambari-re2-7 storm]# ls -lahrt  
> /usr/hdp/2.5.3.0-38/storm/extlib/
> total 16K
> drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
> lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
> storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
> lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
> atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
> drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  eeae4bc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c74d046 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  1fd1b9b 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  70caaea 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  d667d9f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  137f29a 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> e97759b 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 
> 
> Diff: https://reviews.apache.org/r/55845/diff/
> 
> 
> Testing
> ---
> 
> - Performed an upgrade and downgrade with Storm/Atlas and verified that the 
> symlinks are correctly created on upgrade and reset properly on downgrade. 
> - Also, verified that a restart after the upgrade has completed correctly 
> resets the pointers to `current`:
> 2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
> jars inside of /usr/hdp/current/storm-nimbus/extlib to 
> /usr/hdp/current/atlas-server/hook/storm if not already done.
> ```
> 2017-01-23 14:40:49,970 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  {'to': 
> '/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
> 2017-01-23 14:40:49,971 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  replacing old symlink to 
> /usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - Creating symbolic 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  to 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
>  {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-
> ```
> 
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 54.824 s
> [INFO] Finished at: 2017-01-23T09:57:20-05:00
> [INFO] Final Memory: 19M/245M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 55847: AMBARI-19657: Downgrade button does not work after restart Ambari server when upgrade wizard was left open

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55847/
---

Review request for Ambari and Sangeeta Ravindran.


Bugs: AMBARI-19657
https://issues.apache.org/jira/browse/AMBARI-19657


Repository: ambari


Description
---

Run express/rolling upgrade on a trunk cluster. While the upgrade wizard UI 
pauses on a manual step or a failed step, restart ambari server. Once the 
Ambari Server restarts, reload Ambari web UI, observe that the wizard UI pops 
up automatically with the paused step showing the Downgrade button. Clicking 
the downgrade button doesn't do anything in this case because the 
"currentVersion" variable in the controller isn't set yet. Workaround is to 
close the wizard to force the Stack/Version page to reload, then reopen the 
wizard and click the Downgrade button.


Diffs
-

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 4f88d2f 

Diff: https://reviews.apache.org/r/55847/diff/


Testing
---

build trunk code, run upgrade, restart ambari server when the upgrade wizard is 
opened and paused at a menu step. 
existing web UI unit tests.


Thanks,

Di Li

Re: Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/#review162642
---


Ship it!




Ship It!

- Nate Cole


On Jan. 23, 2017, 10:33 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55845/
> ---
> 
> (Updated Jan. 23, 2017, 10:33 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19677
> https://issues.apache.org/jira/browse/AMBARI-19677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
> Atlas hook JARs, must be updated during an upgrade to point to the correct 
> versions of the JAR files.
> 
> # Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure 
> cluster via Blueprint
> # Perform HOU to 2.5.3.0 and let it complete
> # Run Storm service check
> 
> 
> During the upgrade, the pointers are changed to `current` of Atlas which 
> still points to the old JARs:
> 
> ```
> [root@r6-mams-ambari-re2-7 storm]# ls -lahrt  
> /usr/hdp/2.5.3.0-38/storm/extlib/
> total 16K
> drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
> lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
> storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
> lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
> atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
> drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  eeae4bc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c74d046 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  1fd1b9b 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  70caaea 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  d667d9f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  137f29a 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> e97759b 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 
> 
> Diff: https://reviews.apache.org/r/55845/diff/
> 
> 
> Testing
> ---
> 
> - Performed an upgrade and downgrade with Storm/Atlas and verified that the 
> symlinks are correctly created on upgrade and reset properly on downgrade. 
> - Also, verified that a restart after the upgrade has completed correctly 
> resets the pointers to `current`:
> 2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
> jars inside of /usr/hdp/current/storm-nimbus/extlib to 
> /usr/hdp/current/atlas-server/hook/storm if not already done.
> ```
> 2017-01-23 14:40:49,970 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  {'to': 
> '/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
> 2017-01-23 14:40:49,971 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  replacing old symlink to 
> /usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - Creating symbolic 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  to 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
>  {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-
> ```
> 
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 54.824 s
> [INFO] Finished at: 2017-01-23T09:57:20-05:00
> [INFO] Final Memory: 19M/245M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 55843: Trailing slash (/) on cluster resource causes incorrect authorization logic flow

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55843/#review162639
---


Ship it!




Ship It!

- Attila Magyar


On Jan. 23, 2017, 2:49 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55843/
> ---
> 
> (Updated Jan. 23, 2017, 2:49 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, and Laszlo Puskas.
> 
> 
> Bugs: AMBARI-19670
> https://issues.apache.org/jira/browse/AMBARI-19670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trailing slash (/) on cluster resource causes incorrect authorization logic 
> flow. It is debatable whether Ambari should allow this, but since it seems to 
> in other cases - like if the user was an Ambari Administrator - this should 
> be fixed. 
> 
> The problem occurs in the 
> `org.apache.ambari.server.security.authorization.AmbariAuthorizationFilter` 
> where the filter attempts to figure out what the user is trying to get access 
> to.  Since the regular expression for Cluster resources does acknowledge that 
> a trailing "/" after the cluster name indicates a cluster, the request does 
> not fall through to the Cluster resource handler 
> (`org.apache.ambari.server.controller.internal.ClusterResourceProvider`) for 
> authorization checks.  It uses the legacy logic, which is a little flawed as 
> well.
> 
> The fix for this is to allow the trailing "/" in the regular expression 
> representing Cluster requests:
> # From 
> org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java:70
> ```
>   private static final String API_CLUSTERS_PATTERN = API_VERSION_PREFIX + 
> "/clusters/(\w+)?";
> ```
> 
> # To 
> org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java:70}
> ```
> private static final String API_CLUSTERS_PATTERN = API_VERSION_PREFIX + 
> "/clusters/(\w+/?)?";
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  1faadb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java
>  0ab75c5 
> 
> Diff: https://reviews.apache.org/r/55843/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Jenkins test reults: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/
---

(Updated Jan. 23, 2017, 10:33 a.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19677
https://issues.apache.org/jira/browse/AMBARI-19677


Repository: ambari


Description
---

The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
Atlas hook JARs, must be updated during an upgrade to point to the correct 
versions of the JAR files.

# Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure cluster 
via Blueprint
# Perform HOU to 2.5.3.0 and let it complete
# Run Storm service check


During the upgrade, the pointers are changed to `current` of Atlas which still 
points to the old JARs:

```
[root@r6-mams-ambari-re2-7 storm]# ls -lahrt  /usr/hdp/2.5.3.0-38/storm/extlib/
total 16K
drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
```


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 eeae4bc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 c74d046 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 1fd1b9b 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 70caaea 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 d667d9f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 137f29a 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
e97759b 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 

Diff: https://reviews.apache.org/r/55845/diff/


Testing
---

- Performed an upgrade and downgrade with Storm/Atlas and verified that the 
symlinks are correctly created on upgrade and reset properly on downgrade. 
- Also, verified that a restart after the upgrade has completed correctly 
resets the pointers to `current`:
2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
jars inside of /usr/hdp/current/storm-nimbus/extlib to 
/usr/hdp/current/atlas-server/hook/storm if not already done.
```
2017-01-23 14:40:49,970 - 
Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
 {'to': 
'/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
2017-01-23 14:40:49,971 - 
Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
 replacing old symlink to 
/usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
2017-01-23 14:40:49,973 - Creating symbolic 
Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
 to 
/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
2017-01-23 14:40:49,973 - 
Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
 {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-
```

--
Total run:1159
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 54.824 s
[INFO] Finished at: 2017-01-23T09:57:20-05:00
[INFO] Final Memory: 19M/245M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Jonathan Hurley]

> On Jan. 23, 2017, 10:30 a.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py,
> >  line 172
> > 
> >
> > Couldn't this use the `stack_root` variable direcly rather than 
> > `format("{stack_root}")`?

Ah - nice catch! Yes it can I beleive since it's static and this is what 
params.py does anyway. Seems better than relying on introspection via the 
format() function:
```
config = Script.get_config()
stack_root = Script.get_stack_root()
```


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/#review162636
---


On Jan. 23, 2017, 9:58 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55845/
> ---
> 
> (Updated Jan. 23, 2017, 9:58 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19677
> https://issues.apache.org/jira/browse/AMBARI-19677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
> Atlas hook JARs, must be updated during an upgrade to point to the correct 
> versions of the JAR files.
> 
> # Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure 
> cluster via Blueprint
> # Perform HOU to 2.5.3.0 and let it complete
> # Run Storm service check
> 
> 
> During the upgrade, the pointers are changed to `current` of Atlas which 
> still points to the old JARs:
> 
> ```
> [root@r6-mams-ambari-re2-7 storm]# ls -lahrt  
> /usr/hdp/2.5.3.0-38/storm/extlib/
> total 16K
> drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
> lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
> storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
> lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
> atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
> drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  eeae4bc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c74d046 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  1fd1b9b 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  70caaea 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  d667d9f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  137f29a 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> e97759b 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 
> 
> Diff: https://reviews.apache.org/r/55845/diff/
> 
> 
> Testing
> ---
> 
> - Performed an upgrade and downgrade with Storm/Atlas and verified that the 
> symlinks are correctly created on upgrade and reset properly on downgrade. 
> - Also, verified that a restart after the upgrade has completed correctly 
> resets the pointers to `current`:
> 2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
> jars inside of /usr/hdp/current/storm-nimbus/extlib to 
> /usr/hdp/current/atlas-server/hook/storm if not already done.
> ```
> 2017-01-23 14:40:49,970 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  {'to': 
> '/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
> 2017-01-23 14:40:49,971 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  replacing old symlink to 
> /usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - Creating symbolic 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  to 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
>  {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-
> ```
> 
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD 

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55680/#review162637
---


Ship it!




Ship It!

- Robert Levas


On Jan. 20, 2017, 6:21 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55680/
> ---
> 
> (Updated Jan. 20, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19613
> https://issues.apache.org/jira/browse/AMBARI-19613
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On secure namenode HA clusters the ZKFC component needs to access the 
> zookeeper securely.
> On enabling security appropriate settings are configured to secure this 
> connection.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 1cf1603 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  3270430 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  f1891a5 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/kerberos.json 
> 4fdffcf 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/utils.py
>  f76935a 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py
>  f1891a5 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  783f811 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml
>  5be2b74 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
>  24e0193 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml
>  24e0193 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 766a014 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
>  f70c8e9 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml
>  e680c1b 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py e952108 
> 
> Diff: https://reviews.apache.org/r/55680/diff/
> 
> 
> Testing
> ---
> 
> Testing done manually:
> 
> Created an unsecure NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - doesn't exist
> * checked the hadoop-env.sh - doesn't contain the variable export 
> HADOOP_ZKFC_OPTS
> * checked the hdfs_jaas.conf - doesn't exist
> * connected to zookeeper, listed znode acls - no limitations set
> 
> Kerberized the NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - set to sasl:nn:cdrwa
> * checked the hadoop-env.sh - contains the variable export HADOOP_ZKFC_OPTS 
> with proper value, points to the correct jaas file
> * checked the hdfs_jaas.conf - OK
> * connected to zookeeper, listed znode acls - set as required 
> (/hadoop-ha/mycluster/ActiveStandbyElectorLock)
> 
> Disabled Kerberos on the NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - removed
> * checked the hadoop-env.sh - doesn't contain the variable export 
> HADOOP_ZKFC_OPTS
> * connected to zookeeper, listed znode acls - set as required 
> (/hadoop-ha/mycluster/ActiveStandbyElectorLock)
> 
> Unit tests:
> Running in progress for trunk
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/#review162636
---


Fix it, then Ship it!




Ship It!


ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 (line 172)


Couldn't this use the `stack_root` variable direcly rather than 
`format("{stack_root}")`?


- Robert Levas


On Jan. 23, 2017, 9:58 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55845/
> ---
> 
> (Updated Jan. 23, 2017, 9:58 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19677
> https://issues.apache.org/jira/browse/AMBARI-19677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
> Atlas hook JARs, must be updated during an upgrade to point to the correct 
> versions of the JAR files.
> 
> # Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure 
> cluster via Blueprint
> # Perform HOU to 2.5.3.0 and let it complete
> # Run Storm service check
> 
> 
> During the upgrade, the pointers are changed to `current` of Atlas which 
> still points to the old JARs:
> 
> ```
> [root@r6-mams-ambari-re2-7 storm]# ls -lahrt  
> /usr/hdp/2.5.3.0-38/storm/extlib/
> total 16K
> drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
> lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
> storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
> lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
> atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
> drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  eeae4bc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c74d046 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  1fd1b9b 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  70caaea 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  d667d9f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  137f29a 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> e97759b 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 
> 
> Diff: https://reviews.apache.org/r/55845/diff/
> 
> 
> Testing
> ---
> 
> - Performed an upgrade and downgrade with Storm/Atlas and verified that the 
> symlinks are correctly created on upgrade and reset properly on downgrade. 
> - Also, verified that a restart after the upgrade has completed correctly 
> resets the pointers to `current`:
> 2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
> jars inside of /usr/hdp/current/storm-nimbus/extlib to 
> /usr/hdp/current/atlas-server/hook/storm if not already done.
> ```
> 2017-01-23 14:40:49,970 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  {'to': 
> '/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
> 2017-01-23 14:40:49,971 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  replacing old symlink to 
> /usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - Creating symbolic 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  to 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
>  {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-
> ```
> 
> --
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 54.824 s
> [INFO] Finished at: 2017-01-23T09:57:20-05:00
> [INFO] Final Memory: 19M/245M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> 

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

[Robert Levas]

> On Jan. 23, 2017, 9:39 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java,
> >  line 127
> > 
> >
> > I think there may be lots of similar places at our code. Maybe just add 
> > this config on cluster deployment?

@Dmitro... There are other places where something like this happens, but they 
occur in different work flows.  This cannot be done on cluster deploy since 
this needs to happen whenever the security type of the cluster changes.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162629
---


On Jan. 23, 2017, 8:24 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 23, 2017, 8:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162633
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
 (lines 130 - 132)


I think we tend to try to say away from this notation.  

How about something like
```
map = propertiesToSet.get("cluster-env")
if(map == null) {
  map = new HashMap<>();
  propertiesToSet.put("cluster-env", map);
}

map.put("security_enabled", security_enabled);
```


- Robert Levas


On Jan. 23, 2017, 8:24 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 23, 2017, 8:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 55843: Trailing slash (/) on cluster resource causes incorrect authorization logic flow

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55843/#review162634
---


Ship it!




Ship It!

- Jonathan Hurley


On Jan. 23, 2017, 9:49 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55843/
> ---
> 
> (Updated Jan. 23, 2017, 9:49 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, and Laszlo Puskas.
> 
> 
> Bugs: AMBARI-19670
> https://issues.apache.org/jira/browse/AMBARI-19670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trailing slash (/) on cluster resource causes incorrect authorization logic 
> flow. It is debatable whether Ambari should allow this, but since it seems to 
> in other cases - like if the user was an Ambari Administrator - this should 
> be fixed. 
> 
> The problem occurs in the 
> `org.apache.ambari.server.security.authorization.AmbariAuthorizationFilter` 
> where the filter attempts to figure out what the user is trying to get access 
> to.  Since the regular expression for Cluster resources does acknowledge that 
> a trailing "/" after the cluster name indicates a cluster, the request does 
> not fall through to the Cluster resource handler 
> (`org.apache.ambari.server.controller.internal.ClusterResourceProvider`) for 
> authorization checks.  It uses the legacy logic, which is a little flawed as 
> well.
> 
> The fix for this is to allow the trailing "/" in the regular expression 
> representing Cluster requests:
> # From 
> org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java:70
> ```
>   private static final String API_CLUSTERS_PATTERN = API_VERSION_PREFIX + 
> "/clusters/(\w+)?";
> ```
> 
> # To 
> org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java:70}
> ```
> private static final String API_CLUSTERS_PATTERN = API_VERSION_PREFIX + 
> "/clusters/(\w+/?)?";
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
>  1faadb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java
>  0ab75c5 
> 
> Diff: https://reviews.apache.org/r/55843/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Jenkins test reults: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/#review162632
---




ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 (lines 164 - 172)


This is the heart of the change: if in an upgrade, make sure to link to the 
new JARs.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 97)


This is wrong and just backwards. We set METADATA_HOME_DIR / METADATA_CONF 
via the Atlas environment shell script file:
```
# metadata configuration directory
115 export METADATA_CONF={{conf_dir}}
```

Ambari should never use a path from the environment, especially because it 
would prevent this bug from being fixed. If the environment home parameter is 
fixed, then we can never override the value when creating new JARs


- Jonathan Hurley


On Jan. 23, 2017, 9:58 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55845/
> ---
> 
> (Updated Jan. 23, 2017, 9:58 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19677
> https://issues.apache.org/jira/browse/AMBARI-19677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
> Atlas hook JARs, must be updated during an upgrade to point to the correct 
> versions of the JAR files.
> 
> # Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure 
> cluster via Blueprint
> # Perform HOU to 2.5.3.0 and let it complete
> # Run Storm service check
> 
> 
> During the upgrade, the pointers are changed to `current` of Atlas which 
> still points to the old JARs:
> 
> ```
> [root@r6-mams-ambari-re2-7 storm]# ls -lahrt  
> /usr/hdp/2.5.3.0-38/storm/extlib/
> total 16K
> drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
> lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
> storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
> lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
> atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
> drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  eeae4bc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  c74d046 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  1fd1b9b 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  70caaea 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  d667d9f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  137f29a 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> e97759b 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 
> 
> Diff: https://reviews.apache.org/r/55845/diff/
> 
> 
> Testing
> ---
> 
> - Performed an upgrade and downgrade with Storm/Atlas and verified that the 
> symlinks are correctly created on upgrade and reset properly on downgrade. 
> - Also, verified that a restart after the upgrade has completed correctly 
> resets the pointers to `current`:
> 2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
> jars inside of /usr/hdp/current/storm-nimbus/extlib to 
> /usr/hdp/current/atlas-server/hook/storm if not already done.
> ```
> 2017-01-23 14:40:49,970 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  {'to': 
> '/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
> 2017-01-23 14:40:49,971 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  replacing old symlink to 
> /usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - Creating symbolic 
> Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
>  to 
> /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
> 2017-01-23 14:40:49,973 - 
> Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
>  {'to': 

Review Request 55845: Storm service check failed after HOU to HDP-2.5.3 due to CNF for StormAtlasHook

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/
---

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19677
https://issues.apache.org/jira/browse/AMBARI-19677


Repository: ambari


Description
---

The {{extlib}} directory of Storm, which is managed by Ambari WRT things like 
Atlas hook JARs, must be updated during an upgrade to point to the correct 
versions of the JAR files.

# Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure cluster 
via Blueprint
# Perform HOU to 2.5.3.0 and let it complete
# Run Storm service check


During the upgrade, the pointers are changed to `current` of Atlas which still 
points to the old JARs:

```
[root@r6-mams-ambari-re2-7 storm]# ls -lahrt  /usr/hdp/2.5.3.0-38/storm/extlib/
total 16K
drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 ..
lrwxrwxrwx.  1 root root   81 Jan 20 07:08 
storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> 
/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar
lrwxrwxrwx.  1 root root   88 Jan 20 07:08 
atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> 
/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar
drwxr-xr-x.  2 root root 4.0K Jan 20 07:08 .
```


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 eeae4bc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 c74d046 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 1fd1b9b 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 70caaea 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 d667d9f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 137f29a 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
e97759b 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 

Diff: https://reviews.apache.org/r/55845/diff/


Testing
---

- Performed an upgrade and downgrade with Storm/Atlas and verified that the 
symlinks are correctly created on upgrade and reset properly on downgrade. 
- Also, verified that a restart after the upgrade has completed correctly 
resets the pointers to `current`:
2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink 
jars inside of /usr/hdp/current/storm-nimbus/extlib to 
/usr/hdp/current/atlas-server/hook/storm if not already done.
```
2017-01-23 14:40:49,970 - 
Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
 {'to': 
'/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'}
2017-01-23 14:40:49,971 - 
Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
 replacing old symlink to 
/usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
2017-01-23 14:40:49,973 - Creating symbolic 
Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar']
 to 
/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar
2017-01-23 14:40:49,973 - 
Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar']
 {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-
```

--
Total run:1159
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 54.824 s
[INFO] Finished at: 2017-01-23T09:57:20-05:00
[INFO] Final Memory: 19M/245M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 55844: ZKFC start failed

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55844/#review162631
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 23, 2017, 4:43 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55844/
> ---
> 
> (Updated Jan. 23, 2017, 4:43 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19676
> https://issues.apache.org/jira/browse/AMBARI-19676
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py",
>  line 224, in 
> ZkfcSlave().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 313, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py",
>  line 73, in start
> ZkfcSlaveDefault.start_static(env, upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py",
>  line 99, in start_static
> create_log_dir=True
>   File 
> "/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py",
>  line 271, in service
> Execute(daemon_cmd, not_if=process_id_exists_command, 
> environment=hadoop_env_exports)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 262, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> resource_management.core.exceptions.ExecutionFailed: Execution of 
> 'ambari-sudo.sh su hdfs -l -s /bin/bash -c 'ulimit -c unlimited ;  
> /usr/hdp/current/hadoop-client/sbin/hadoop-daemon.sh --config 
> /usr/hdp/current/hadoop-client/conf start zkfc'' returned 1. 
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Dzookeeper.sasl.client.username=zookeeper': not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Djava.security.auth.login.config=/usr/hdp/current/hadoop-client/conf/secure/hdfs_jaas.conf':
>  not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Dzookeeper.sasl.clientconfig=Client': not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Dzookeeper.sasl.client.username=zookeeper': not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Djava.security.auth.login.config=/usr/hdp/current/hadoop-client/conf/secure/hdfs_jaas.conf':
>  not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Dzookeeper.sasl.clientconfig=Client': not a valid identifier
> starting zkfc, logging to 
> /grid/0/log/hdfs/hdfs/hadoop-hdfs-zkfc-ctr-e125-1484958108044-0868-01-05.hwx.site.out
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Dzookeeper.sasl.client.username=zookeeper': not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Djava.security.auth.login.config=/usr/hdp/current/hadoop-client/conf/secure/hdfs_jaas.conf':
>  not a valid identifier
> /usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
> `-Dzookeeper.sasl.clientconfig=Client': not a valid identifier
> 
> 
> Diffs
> -
> 
>   
> 

Review Request 55843: Trailing slash (/) on cluster resource causes incorrect authorization logic flow

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55843/
---

Review request for Ambari, Attila Magyar, Eugene Chekanskiy, Jonathan Hurley, 
and Laszlo Puskas.


Bugs: AMBARI-19670
https://issues.apache.org/jira/browse/AMBARI-19670


Repository: ambari


Description
---

Trailing slash (/) on cluster resource causes incorrect authorization logic 
flow. It is debatable whether Ambari should allow this, but since it seems to 
in other cases - like if the user was an Ambari Administrator - this should be 
fixed. 

The problem occurs in the 
`org.apache.ambari.server.security.authorization.AmbariAuthorizationFilter` 
where the filter attempts to figure out what the user is trying to get access 
to.  Since the regular expression for Cluster resources does acknowledge that a 
trailing "/" after the cluster name indicates a cluster, the request does not 
fall through to the Cluster resource handler 
(`org.apache.ambari.server.controller.internal.ClusterResourceProvider`) for 
authorization checks.  It uses the legacy logic, which is a little flawed as 
well.

The fix for this is to allow the trailing "/" in the regular expression 
representing Cluster requests:
# From 
org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java:70
```
  private static final String API_CLUSTERS_PATTERN = API_VERSION_PREFIX + 
"/clusters/(\w+)?";
```

# To 
org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java:70}
```
private static final String API_CLUSTERS_PATTERN = API_VERSION_PREFIX + 
"/clusters/(\w+/?)?";
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
 1faadb6 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java
 0ab75c5 

Diff: https://reviews.apache.org/r/55843/diff/


Testing
---

Manually tested

# Jenkins test reults: PENDING


Thanks,

Robert Levas

Re: Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162629
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
 (line 127)


I think there may be lots of similar places at our code. Maybe just add 
this config on cluster deployment?


- Dmitro Lisnichenko


On Jan. 23, 2017, 3:24 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55842/
> ---
> 
> (Updated Jan. 23, 2017, 3:24 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19675
> https://issues.apache.org/jira/browse/AMBARI-19675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Regenerate keytabs apply all configs but not security_enabled.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
>  931806d 
> 
> Diff: https://reviews.apache.org/r/55842/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 55844: ZKFC start failed

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55844/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19676
https://issues.apache.org/jira/browse/AMBARI-19676


Repository: ambari


Description
---

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py",
 line 224, in 
ZkfcSlave().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 313, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py",
 line 73, in start
ZkfcSlaveDefault.start_static(env, upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py",
 line 99, in start_static
create_log_dir=True
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py",
 line 271, in service
Execute(daemon_cmd, not_if=process_id_exists_command, 
environment=hadoop_env_exports)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 262, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
raise ExecutionFailed(err_msg, code, out, err)
resource_management.core.exceptions.ExecutionFailed: Execution of 
'ambari-sudo.sh su hdfs -l -s /bin/bash -c 'ulimit -c unlimited ;  
/usr/hdp/current/hadoop-client/sbin/hadoop-daemon.sh --config 
/usr/hdp/current/hadoop-client/conf start zkfc'' returned 1. 
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Dzookeeper.sasl.client.username=zookeeper': not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Djava.security.auth.login.config=/usr/hdp/current/hadoop-client/conf/secure/hdfs_jaas.conf':
 not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Dzookeeper.sasl.clientconfig=Client': not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Dzookeeper.sasl.client.username=zookeeper': not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Djava.security.auth.login.config=/usr/hdp/current/hadoop-client/conf/secure/hdfs_jaas.conf':
 not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Dzookeeper.sasl.clientconfig=Client': not a valid identifier
starting zkfc, logging to 
/grid/0/log/hdfs/hdfs/hadoop-hdfs-zkfc-ctr-e125-1484958108044-0868-01-05.hwx.site.out
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Dzookeeper.sasl.client.username=zookeeper': not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Djava.security.auth.login.config=/usr/hdp/current/hadoop-client/conf/secure/hdfs_jaas.conf':
 not a valid identifier
/usr/hdp/current/hadoop-client/conf/hadoop-env.sh: line 123: export: 
`-Dzookeeper.sasl.clientconfig=Client': not a valid identifier


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml
 114c965 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
 0fbc67e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml
 6d9eaf0 

Diff: https://reviews.apache.org/r/55844/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 55821: Log Search: support credential store api (part 1)

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55821/#review162626
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 22, 2017, 7:57 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55821/
> ---
> 
> (Updated Jan. 22, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the patch is based by https://reviews.apache.org/r/55755/
> first part: support credential store api on logsearch part (originally 
> developed by Miklos Gergely)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  ea9f45d 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 645c5f0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  2fb4ff3 
> 
> Diff: https://reviews.apache.org/r/55821/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/
---

(Updated Jan. 23, 2017, 1:25 p.m.)


Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Changes
---

manual testing


Bugs: AMBARI-19668
https://issues.apache.org/jira/browse/AMBARI-19668


Repository: ambari


Description
---

Secure zookeeper ACLs should be supported only in HDP 2.6 and above. This patch 
is about reworking the existing patches (oozie, hive, yarn-rm) and removing 
secure zk acl support if stack version is < 2.6


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 02ce194 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 1a34b87 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 48c8ef0 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json 
f1092f5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
c8b5989 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 7df82bf 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 77bd363 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
eaffec6 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 e4a499b 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
a8ef83c 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 
3059f14 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
5fff05c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
eaffec6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
ddf8348 
  
contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
 0b6b3ab 

Diff: https://reviews.apache.org/r/55833/diff/


Testing (updated)
---

HDP2.6
  - created a cluster with oozie and yarn
  - enabled kerberos
  - acl on /rmstore/ZKRMStateRoot and /oozie was sasl
  - disabled kerberos
  - acl on /rmstore/ZKRMStateRoot and /oozie was word:anyone
  
HDP2.5
  - created a cluster with oozie and yarn
  - enabled kerberos
  - acl on /rmstore/ZKRMStateRoot and /oozie was world:anyone
  - disabled kerberos
  - acl on /rmstore/ZKRMStateRoot and /oozie was word:anyone


Thanks,

Attila Magyar

Review Request 55842: Regenerate Keytabs action does not set cluster-env/security_enabled to true

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/
---

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-19675
https://issues.apache.org/jira/browse/AMBARI-19675


Repository: ambari


Description
---

Regenerate keytabs apply all configs but not security_enabled.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
 931806d 

Diff: https://reviews.apache.org/r/55842/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55834/#review162625
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 23, 2017, 9:53 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55834/
> ---
> 
> (Updated Jan. 23, 2017, 9:53 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19669
> https://issues.apache.org/jira/browse/AMBARI-19669
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mofified the actions structure to an array. Removed the usage of 
> Object.values method which causes the issue.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js
>  966313f 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 3c89f5c 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 8cc40d6 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> 9126819 
> 
> Diff: https://reviews.apache.org/r/55834/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/#review162623
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 20, 2017, 5:55 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55718/
> ---
> 
> (Updated Jan. 20, 2017, 5:55 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19624
> https://issues.apache.org/jira/browse/AMBARI-19624
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added fields to support nofification message and upstream apps in the sla 
> componenent and added the necessary mappings to handle the new fields while 
> generating xml and importing xml.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 4cc89ef 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> 1929ddf 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
>  28bdf15 
> 
> Diff: https://reviews.apache.org/r/55718/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55840: AMBARI-19674. Asset Manager import and validation issues

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55840/#review162622
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 23, 2017, 11:59 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55840/
> ---
> 
> (Updated Jan. 23, 2017, 11:59 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19674
> https://issues.apache.org/jira/browse/AMBARI-19674
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> separate api for reading asset is implemented and used. Also validation for 
> assetName check is added
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java
>  238b002 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
>  53b43f9 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  7596de0 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  d8bf9ff 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java
>  df936a4 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  0622971 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java
>  9fe2f9c 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java
>  afdee9e 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java
>  7787bda 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 
> dcfba34 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 
> 9ad0494 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 
> 4674533 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  a04c66d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 1822a20 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 
> 3e87644 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs
>  3ae4bff 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs
>  bc5201d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs
>  7a21af1 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  7a6005a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  38d8eaf 
> 
> Diff: https://reviews.apache.org/r/55840/diff/
> 
> 
> Testing
> ---
> 
> manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 55822: Log Search: Snapshot tour fix & configurable CORS filter

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55822/#review162621
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 23, 2017, 10:49 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55822/
> ---
> 
> (Updated Jan. 23, 2017, 10:49 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Robert Nettleton, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19664
> https://issues.apache.org/jira/browse/AMBARI-19664
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> some small fix and addition for logsearch:
> - configurable CORS filter
> - in "Tours": select the snapshot button instead of auto-refresh button
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  115dcc3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchCorsFilter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Tour.js
>  fff82ed 
> 
> Diff: https://reviews.apache.org/r/55822/diff/
> 
> 
> Testing
> ---
> 
> tested, manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 55823: Log Search: Add basic auth support to Swagger UI

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55823/#review162620
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 23, 2017, 10:48 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55823/
> ---
> 
> (Updated Jan. 23, 2017, 10:48 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Robert Nettleton, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19665
> https://issues.apache.org/jira/browse/AMBARI-19665
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add basic auth support for swagger UI.
> - also uses the actual protocol + hostname + port instead instead of setting 
> on the backend
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  0ddad65 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/swagger/swagger.html
>  e1b052a 
> 
> Diff: https://reviews.apache.org/r/55823/diff/
> 
> 
> Testing
> ---
> 
> done, manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55834/#review162619
---


Ship it!




Ship It!

- belliraj hb


On Jan. 23, 2017, 9:53 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55834/
> ---
> 
> (Updated Jan. 23, 2017, 9:53 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19669
> https://issues.apache.org/jira/browse/AMBARI-19669
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mofified the actions structure to an array. Removed the usage of 
> Object.values method which causes the issue.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js
>  966313f 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 3c89f5c 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 8cc40d6 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> 9126819 
> 
> Diff: https://reviews.apache.org/r/55834/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55840: AMBARI-19674. Asset Manager import and validation issues

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55840/#review162618
---


Ship it!




Ship It!

- belliraj hb


On Jan. 23, 2017, 11:59 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55840/
> ---
> 
> (Updated Jan. 23, 2017, 11:59 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19674
> https://issues.apache.org/jira/browse/AMBARI-19674
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> separate api for reading asset is implemented and used. Also validation for 
> assetName check is added
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java
>  238b002 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
>  53b43f9 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  7596de0 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  d8bf9ff 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java
>  df936a4 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  0622971 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java
>  9fe2f9c 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java
>  afdee9e 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java
>  7787bda 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 
> dcfba34 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 
> 9ad0494 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 
> 4674533 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  a04c66d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 1822a20 
>   contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 
> 3e87644 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs
>  3ae4bff 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs
>  bc5201d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs
>  7a21af1 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  7a6005a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  38d8eaf 
> 
> Diff: https://reviews.apache.org/r/55840/diff/
> 
> 
> Testing
> ---
> 
> manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 55840: AMBARI-19674. Asset Manager import and validation issues

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55840/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary.


Bugs: AMBARI-19674
https://issues.apache.org/jira/browse/AMBARI-19674


Repository: ambari


Description
---

separate api for reading asset is implemented and used. Also validation for 
assetName check is added


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java
 238b002 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
 53b43f9 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 7596de0 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
 d8bf9ff 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java
 df936a4 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
 0622971 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java
 9fe2f9c 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java
 afdee9e 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java
 7787bda 
  contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 
dcfba34 
  contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 
9ad0494 
  contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 
4674533 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 a04c66d 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
1822a20 
  contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 
3e87644 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs
 3ae4bff 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs
 bc5201d 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs
 7a21af1 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
 7a6005a 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 38d8eaf 

Diff: https://reviews.apache.org/r/55840/diff/


Testing
---

manual


Thanks,

Madhan Reddy

Re: Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55818/#review162617
---


Ship it!




Ship It!

- Sandor Magyari


On Jan. 23, 2017, 10:27 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55818/
> ---
> 
> (Updated Jan. 23, 2017, 10:27 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19662
> https://issues.apache.org/jira/browse/AMBARI-19662
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the user makes a syntax error in a quick link definition, such as:
> 
> { "linKKK_name": "namenode_ui", "visible": true }
> 
> the filter will be misinterpreted as an accept-all filter, due to the fact 
> that the parser would expect a proper "link_name" tag to interpret it as a 
> link name filter. This would lead to unexpected and difficult to debug 
> behaviour.
> 
> To prevent this, quick link profile evaluation should throw an exception 
> whenever it finds unknown tags in a filter definition
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
>  fca1155 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
>  150b7d4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
>  1cc3fd3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
>  57badb8 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile_3.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55818/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Tested manually: installing cluster via blueprint with both good and bad 
> quick link profile in the request, viewing quick links with both good and bad 
> quick link profiles set via Ambari settings API
> - run the unit test suite for ambari-server. The only failing test was 
> org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
>  which currently fails on the trunk CI too.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 55839: Hive View 2.0: Code hints for query editor are not working

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55839/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19673
https://issues.apache.org/jira/browse/AMBARI-19673


Repository: ambari


Description
---

User should be able to see code hints and syntax colorization while typing hive 
queries.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
27d43d5 
  contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 

Diff: https://reviews.apache.org/r/55839/diff/


Testing
---

Manually tested


Thanks,

Abhishek Kumar

Re: Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/#review162615
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 23, 2017, 10:51 a.m., Abhishek Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55836/
> ---
> 
> (Updated Jan. 23, 2017, 10:51 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19667
> https://issues.apache.org/jira/browse/AMBARI-19667
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added jQuery-ui to add "draggable" functionality
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
> 27d43d5 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1 
>   contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7 
>   contrib/views/hive20/src/main/resources/ui/package.json ed7a299 
> 
> Diff: https://reviews.apache.org/r/55836/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Abhishek Kumar
> 
>

Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/
---

(Updated Jan. 23, 2017, 11:37 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19671
https://issues.apache.org/jira/browse/AMBARI-19671


Repository: ambari


Description
---

On selecting a database from right panel, display does not change. Ideally 
followings should happen:
1. Move "checked" icon to selected database
2. Hide tables related to unselected database and show tables for the selected 
one.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
950e4f3 

Diff: https://reviews.apache.org/r/55837/diff/


Testing (updated)
---

Manually tested


Thanks,

Abhishek Kumar

Re: Review Request 55838: Alert Popup doesn't execute callback if it's closed without click on "Primary"

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55838/#review162614
---


Ship it!




Ship It!

- Andrii Tkach


On Jan. 23, 2017, 11:33 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55838/
> ---
> 
> (Updated Jan. 23, 2017, 11:33 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-19672
> https://issues.apache.org/jira/browse/AMBARI-19672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> {{App.showAlertPopup}} shows popup with some message in the its body and on 
> button - "Primary". Click on it execute passed callback (if it exists). 
> Clicking on "x" or "Esc"-press closes modal without callback execution.
> Since this modal is not a confirmation-modal (we have 
> {{App.showConfirmationPopup}}), any  interaction with it (click "Ok", press 
> "Esc", click "x") should execute passed callback.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/modal_popups/alert_popup.js 413d33c 
> 
> Diff: https://reviews.apache.org/r/55838/diff/
> 
> 
> Testing
> ---
> 
> 20467 tests complete (31 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 55838: Alert Popup doesn't execute callback if it's closed without click on "Primary"

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55838/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-19672
https://issues.apache.org/jira/browse/AMBARI-19672


Repository: ambari


Description
---

{{App.showAlertPopup}} shows popup with some message in the its body and on 
button - "Primary". Click on it execute passed callback (if it exists). 
Clicking on "x" or "Esc"-press closes modal without callback execution.
Since this modal is not a confirmation-modal (we have 
{{App.showConfirmationPopup}}), any  interaction with it (click "Ok", press 
"Esc", click "x") should execute passed callback.


Diffs
-

  ambari-web/app/views/common/modal_popups/alert_popup.js 413d33c 

Diff: https://reviews.apache.org/r/55838/diff/


Testing
---

20467 tests complete (31 seconds)
  153 tests pending


Thanks,

Oleg Nechiporenko

Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55837/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19671
https://issues.apache.org/jira/browse/AMBARI-19671


Repository: ambari


Description
---

On selecting a database from right panel, display does not change. Ideally 
followings should happen:
1. Move "checked" icon to selected database
2. Hide tables related to unselected database and show tables for the selected 
one.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
950e4f3 

Diff: https://reviews.apache.org/r/55837/diff/


Testing
---


Thanks,

Abhishek Kumar

Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging

[Abhishek Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55836/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19667
https://issues.apache.org/jira/browse/AMBARI-19667


Repository: ambari


Description
---

Added jQuery-ui to add "draggable" functionality


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
27d43d5 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1 
  contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7 
  contrib/views/hive20/src/main/resources/ui/package.json ed7a299 

Diff: https://reviews.apache.org/r/55836/diff/


Testing
---

manually tested.


Thanks,

Abhishek Kumar

Re: Review Request 55765: llow user to add custom property for log4j

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55765/
---

(Updated Jan. 23, 2017, 10:36 a.m.)


Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty.


Bugs: AMBARI-19651
https://issues.apache.org/jira/browse/AMBARI-19651


Repository: ambari


Description
---

Existing rolling properties like MaxFileSize and MaxBackupIndex for various 
services have been parameterized for ease of use by end user.
These properties have been added for those services which did not originally 
have it.
During Ambari Upgrade, user will not be able to see these changes. One way is 
to document how the user can manually make use of this feature by adding a 
custom-log4j property as well as change the template with the same variable 
name as used in the backend python file. This jira is to make UI changes in 
order to allow user to add custom-log4j properties if they want to after an 
ambari upgrade.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
 5a97804 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-log4j.xml
 05c8f0a 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
 2662b51 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml
 2177705 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml
 3f73c19 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml
 37b339e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-exec-log4j.xml
 d90a679 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml
 3473b8c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml
 4ec22770 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml
 f6045cd 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-log4j.xml
 613d75f 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ldap-log4j.xml
 e078d9d 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml
 ff1e388 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml
 123d570 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml
 fdffcdf 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml
 141c8c9 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml
 4cbc34e 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
 3a63f38 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml
 92d6c38 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml
 45bf289 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml
 1cb17f0 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml
 c3de7cd 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml
 31f0ff3 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml
 1d828ee 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
 151ce3b 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml
 d052621 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml
 34e97d4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
 03e8dae 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
 aac3216 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
 25315b4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
 4790f0f 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml
 ec93b63 

Diff: https://reviews.apache.org/r/55765/diff/


Testing
---

Manually tested.


Thanks,

Andrii Tkach

Re: Review Request 55821: Log Search: support credential store api (part 1)

[Oliver Szabo]

> On Jan. 23, 2017, 7:26 a.m., Sebastian Toader wrote:
> > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java,
> >  line 129
> > 
> >
> > Isn't this an error that should be signaled wuth an Exception since the 
> > password file is provided?

my guess here we should not stop logfeeder in case of ssl is wrongly configured 
(e.g.: https is enabled for metrics, therefore publishing metrics wont work, 
but  logfeeder can still send data for solr)


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55821/#review162602
---


On Jan. 22, 2017, 6:57 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55821/
> ---
> 
> (Updated Jan. 22, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the patch is based by https://reviews.apache.org/r/55755/
> first part: support credential store api on logsearch part (originally 
> developed by Miklos Gergely)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  ea9f45d 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 645c5f0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  2fb4ff3 
> 
> Diff: https://reviews.apache.org/r/55821/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55818/
---

(Updated Jan. 23, 2017, 10:27 a.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
Sandor Magyari, and Sebastian Toader.


Changes
---

Review comments


Bugs: AMBARI-19662
https://issues.apache.org/jira/browse/AMBARI-19662


Repository: ambari


Description
---

When the user makes a syntax error in a quick link definition, such as:

{ "linKKK_name": "namenode_ui", "visible": true }

the filter will be misinterpreted as an accept-all filter, due to the fact that 
the parser would expect a proper "link_name" tag to interpret it as a link name 
filter. This would lead to unexpected and difficult to debug behaviour.

To prevent this, quick link profile evaluation should throw an exception 
whenever it finds unknown tags in a filter definition


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
 fca1155 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 150b7d4 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
 1cc3fd3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
 57badb8 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile_3.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/55818/diff/


Testing
---

- Wrote new unit tests
- Tested manually: installing cluster via blueprint with both good and bad 
quick link profile in the request, viewing quick links with both good and bad 
quick link profiles set via Ambari settings API
- run the unit test suite for ambari-server. The only failing test was 
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
 which currently fails on the trunk CI too.


Thanks,

Balázs Bence Sári

Re: Review Request 55831: Hive view loosing one row every 100 row in result set.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55831/#review162611
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55831/
> ---
> 
> (Updated Jan. 23, 2017, 7:15 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19666
> https://issues.apache.org/jira/browse/AMBARI-19666
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the order of boolean check to avoid fetching one more result from 
> resultSet when not required.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java
>  1052bd4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java
>  4b4a407 
> 
> Diff: https://reviews.apache.org/r/55831/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/#review162610
---


Ship it!




Ship It!

- Robert Levas


On Jan. 23, 2017, 5:03 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55833/
> ---
> 
> (Updated Jan. 23, 2017, 5:03 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19668
> https://issues.apache.org/jira/browse/AMBARI-19668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Secure zookeeper ACLs should be supported only in HDP 2.6 and above. This 
> patch is about reworking the existing patches (oozie, hive, yarn-rm) and 
> removing secure zk acl support if stack version is < 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  02ce194 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  1a34b87 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  48c8ef0 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json
>  f1092f5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> c8b5989 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  7df82bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  77bd363 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> eaffec6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  e4a499b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> a8ef83c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  3059f14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 5fff05c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> eaffec6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  ddf8348 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
>  0b6b3ab 
> 
> Diff: https://reviews.apache.org/r/55833/diff/
> 
> 
> Testing
> ---
> 
> in progress
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 55831: Hive view loosing one row every 100 row in result set.

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55831/#review162609
---


Ship it!




Ship It!

- Rohit Choudhary


On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55831/
> ---
> 
> (Updated Jan. 23, 2017, 7:15 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19666
> https://issues.apache.org/jira/browse/AMBARI-19666
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the order of boolean check to avoid fetching one more result from 
> resultSet when not required.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java
>  1052bd4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java
>  4b4a407 
> 
> Diff: https://reviews.apache.org/r/55831/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/
---

(Updated Jan. 23, 2017, 10:03 a.m.)


Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Changes
---

- updated description
- removed hive modification


Bugs: AMBARI-19668
https://issues.apache.org/jira/browse/AMBARI-19668


Repository: ambari


Description
---

Secure zookeeper ACLs should be supported only in HDP 2.6 and above. This patch 
is about reworking the existing patches (oozie, hive, yarn-rm) and removing 
secure zk acl support if stack version is < 2.6


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 02ce194 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 1a34b87 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 48c8ef0 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json 
f1092f5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
c8b5989 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 7df82bf 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 77bd363 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
eaffec6 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 e4a499b 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
a8ef83c 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 
3059f14 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
5fff05c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
eaffec6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
ddf8348 
  
contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
 0b6b3ab 

Diff: https://reviews.apache.org/r/55833/diff/


Testing
---

in progress


Thanks,

Attila Magyar

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/#review162608
---




ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
(line 26)


Maybe the description should be more explicit. eg. "Protect ZNodes with 
SASL acl in secure clusters"


- Sebastian Toader


On Jan. 23, 2017, 10:29 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55833/
> ---
> 
> (Updated Jan. 23, 2017, 10:29 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19668
> https://issues.apache.org/jira/browse/AMBARI-19668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Secure zookeeper ACLs should be supported only in HDP 2.6 and above. This 
> patch is about reworking the existing patches (oozie, hive, yarn-rm) and 
> removing secure zk acl support if stack version is < 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  02ce194 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  a8a8282 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  e9e6337 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  1a34b87 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  48c8ef0 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json
>  f1092f5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> c8b5989 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  7df82bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  77bd363 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> eaffec6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  e4a499b 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> a8ef83c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  3059f14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 5fff05c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> eaffec6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  ddf8348 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
>  0b6b3ab 
> 
> Diff: https://reviews.apache.org/r/55833/diff/
> 
> 
> Testing
> ---
> 
> in progress
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55834/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19669
https://issues.apache.org/jira/browse/AMBARI-19669


Repository: ambari


Description
---

Mofified the actions structure to an array. Removed the usage of Object.values 
method which causes the issue.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js
 966313f 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3c89f5c 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
8cc40d6 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 9126819 

Diff: https://reviews.apache.org/r/55834/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Review Request 55833: Supporting zookeeper security only from HDP 2.6

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/
---

Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Bugs: AMBARI-19668
https://issues.apache.org/jira/browse/AMBARI-19668


Repository: ambari


Description
---

Secure zookeeper ACLs should be supported only in HDP 2.6 and above. This patch 
is about reworking the existing patches (oozie, hive, yarn-rm) and removing 
secure zk acl support if stack version is < 2.6


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 02ce194 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 a8a8282 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 e9e6337 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 1a34b87 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 48c8ef0 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/kerberos.json 
f1092f5 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
c8b5989 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 7df82bf 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 77bd363 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
eaffec6 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 e4a499b 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
a8ef83c 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 
3059f14 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
5fff05c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
eaffec6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/OOZIE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
ddf8348 
  
contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/properties/stack_features.json
 0b6b3ab 

Diff: https://reviews.apache.org/r/55833/diff/


Testing
---

in progress


Thanks,

Attila Magyar