Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

[Sumit Mohanty]

> On March 3, 2017, 9:56 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
> > Line 178 (original), 178 (patched)
> > 
> >
> > Should this be an OR - if hbase.ssl.enabled is true or 
> > hbase.http.policy is true?

I see that Josh from HBase has reviewed it. +1


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167875
---


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57268/#review167925
---




ambari-web/app/models/configs/theme/sub_section_tab.js
Line 84 (original), 84-87 (patched)


Whats the reason behind making this computed property volatile ?


- Jaimin Jetly


On March 3, 2017, 7:34 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57268/
> ---
> 
> (Updated March 3, 2017, 7:34 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20287
> https://issues.apache.org/jira/browse/AMBARI-20287
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Take subSectionTab into consideration on show/hide
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/configs/theme/sub_section.js 7274569 
>   ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 
>   ambari-web/app/views/common/configs/service_config_layout_tab_view.js 
> 466a88d 
>   ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c 
> 
> 
> Diff: https://reviews.apache.org/r/57268/diff/1/
> 
> 
> Testing
> ---
> 
> Manully tested on live cluster. All unit tests passed.
>   20560 passing (25s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 57281: Script-Based Alert Dispathers support passing more parameters to script

[yao lei]

> On 三月 3, 2017, 6:48 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thank for reviewing this patch


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57281/#review167857
---


On 三月 3, 2017, 11:56 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57281/
> ---
> 
> (Updated 三月 3, 2017, 11:56 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20291
> https://issues.apache.org/jira/browse/AMBARI-20291
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Script-Based Alert Dispatcher now pass five parameters to script,including 
> alert definition name, definition label,service name, alert state, and alert 
> text.
> But if script can receive other two parameters from dispather,it will be 
> better.
> 1.hostname.
> Because hostname the alert for is not always included in alert text,although 
> it may be null like aggregate alerts.
> With it we can more quick to find the related host that occured alert.
> 2.alert timestamp.
> We may need to know the alert occurrence time ( state change time) more 
> exactly. After the alert happened,it will spend some time to schedule the 
> script to run.
> Without it,we can only regard the script start time as the alert occurrence 
> time.
> 
> We now use this feature to send alert information to mobile phone and suggest 
> also passing hostname and alert timestamp.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
>  174f31f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
>  9e0e406 
> 
> 
> Diff: https://reviews.apache.org/r/57281/diff/1/
> 
> 
> Testing
> ---
> 
> 1.cd ambari-server
>mvn test
> 
> 2.write a python script to receive parameters from dispatcher
> 
> 
> #!/usr/bin/python
> import sys
> import logging
> 
> def main():
> definitionName = sys.argv[1]
> definitionLabel = sys.argv[2]
> serviceName = sys.argv[3]
> alertState = sys.argv[4]
> alertText = sys.argv[5]
> alertTimestamp = sys.argv[6]
> hostname = sys.argv[7] if len(sys.argv)-1 == 7 else None
> 
> logFile='/var/log/ambari-server/log_py.log'
> 
> logging.basicConfig(filename = logFile, level = logging.DEBUG)
> logging.debug('received ' + str(len(sys.argv)-1) + ' parameters')
> for i in range(1, len(sys.argv)):
> logging.debug('parameter ' +str(i) + ':' +str(sys.argv[i]))
> 
> if __name__ == '__main__':
>main()
> 
> 
> Stop and start any service like HDFS , we can see the expected result in 
> /var/log/ambari-server/log_py.log,
> 
> 3.write a shell script to  receive parameters from dispatcher
> 
> 
> #!/bin/bash
> logFile=/var/log/ambari-server/log_sh.log
> definitionName=$1
> definitionLabel=$2
> serviceName=$3
> alertState=$4 
> alertText=$5
> alertTimestamp=$6
> hostname=$7
> 
> echo received $# parameters:  $definitionName, $definitionLabel, 
> $serviceName, $alertState ,$alertText ,$alertTimestamp, $hostname  >> $logFile
> 
> 
> Stop and start any service like HDFS , we can see the expected result in 
> /var/ambari-server/log_sh.log, we can see the expected result.
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 57304: Code review request for AMBARI-20157

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57304/#review167886
---


Ship it!




Ship It!

- Jonathan Hurley


On March 3, 2017, 3:23 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57304/
> ---
> 
> (Updated March 3, 2017, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20157
> https://issues.apache.org/jira/browse/AMBARI-20157
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for SNMP notification order
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java
>  ba86687 
> 
> 
> Diff: https://reviews.apache.org/r/57304/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Added the debug statements in "AlertNoticeDispatchService.java" file to 
> see the order before it actually dispatches the notifications
> Expected Result: it should print he notifications in correct order , smaller 
> notification_id notification first and bigger one later.
> Actual Result: PASS
> 
> ---
> 
> sample ambari-server.log
> 
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951  
> uuid:d237b8f4-9a89-4e62-9fe3-562119908732
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952  
> uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953  
> uuid:37bf8683--4c94-b2d0-763e85ef3d5c
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954  
> uuid:62d6ea6f-2190-4771-9497-eb07d45a4537
> 
> 
> --
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 57306: HiveServer2 log rotation is setup incorrectly

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57306/#review167878
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 9:52 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57306/
> ---
> 
> (Updated March 3, 2017, 9:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20312
> https://issues.apache.org/jira/browse/AMBARI-20312
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since hive2 has both timebased and sizebased triggering policy, the 
> filepattern needs to be modified so that multiple log files created on the 
> same day can persist instead of being overwritten based on the on the date.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
>  e6c925d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  0b3eddb 
> 
> 
> Diff: https://reviews.apache.org/r/57306/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167875
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
Line 178 (original), 178 (patched)


Should this be an OR - if hbase.ssl.enabled is true or hbase.http.policy is 
true?


- Sumit Mohanty


On March 3, 2017, 3:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated March 3, 2017, 3:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57306: HiveServer2 log rotation is setup incorrectly

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57306/#review167873
---


Ship it!




Ship It!

- Sumit Mohanty


On March 3, 2017, 9:52 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57306/
> ---
> 
> (Updated March 3, 2017, 9:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20312
> https://issues.apache.org/jira/browse/AMBARI-20312
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since hive2 has both timebased and sizebased triggering policy, the 
> filepattern needs to be modified so that multiple log files created on the 
> same day can persist instead of being overwritten based on the on the date.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
>  e6c925d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  0b3eddb 
> 
> 
> Diff: https://reviews.apache.org/r/57306/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 57306: HiveServer2 log rotation is setup incorrectly

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57306/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20312
https://issues.apache.org/jira/browse/AMBARI-20312


Repository: ambari


Description
---

Since hive2 has both timebased and sizebased triggering policy, the filepattern 
needs to be modified so that multiple log files created on the same day can 
persist instead of being overwritten based on the on the date.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
 e6c925d 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
 0b3eddb 


Diff: https://reviews.apache.org/r/57306/diff/1/


Testing
---


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57287: LogSearch Portal UI Fails on Last Page selection if logs were deleted in the meantime

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
---

(Updated March 3, 2017, 9:23 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

fix branch to 2.5-cloud


Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300


Repository: ambari


Description
---

If logs are deleted between the last screen generation and the clicking on the 
last page button an empty table comes up. The same happens if the user clicks 
on a page number which is no longer valid, as there are fewer logs since.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 d44b866 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 2dc0ef7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
 89873f3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
 c175397 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/TableLayout.js
 1066510 


Diff: https://reviews.apache.org/r/57287/diff/2/


Testing
---

Tested on local cluster setting extra short time for the logs to expire.


Thanks,

Miklos Gergely

Re: Review Request 57304: Code review request for AMBARI-20157

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57304/#review167866
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 8:23 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57304/
> ---
> 
> (Updated March 3, 2017, 8:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20157
> https://issues.apache.org/jira/browse/AMBARI-20157
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for SNMP notification order
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java
>  ba86687 
> 
> 
> Diff: https://reviews.apache.org/r/57304/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Added the debug statements in "AlertNoticeDispatchService.java" file to 
> see the order before it actually dispatches the notifications
> Expected Result: it should print he notifications in correct order , smaller 
> notification_id notification first and bigger one later.
> Actual Result: PASS
> 
> ---
> 
> sample ambari-server.log
> 
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951  
> uuid:d237b8f4-9a89-4e62-9fe3-562119908732
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952  
> uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953  
> uuid:37bf8683--4c94-b2d0-763e85ef3d5c
> ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
> RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954  
> uuid:62d6ea6f-2190-4771-9497-eb07d45a4537
> 
> 
> --
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Anita Jebaraj]

> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4324 (patched)
> > 
> >
> > Why did you need to restore the keys ? stringPropertyNames already 
> > returns a Set object that you may use directly.

Yes...I can use set directly, I have updated the patch


> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4327 (patched)
> > 
> >
> > close instream in finally{}

Fixed in new patch


> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 4329 (patched)
> > 
> >
> > How did Ambari server react to an i/o exception on the blacklist file? 
> > Please make sure Ambari server start restarts successfully even when the 
> > blacklist file causes an i/o exception as I don't think it's a sev1 err 
> > like some others in this class, i.e. can't read db pwd, can't read ssl cert 
> > pwd.

Throwing the exception would cause server error, so I have changed it to print 
a message in the log


> On March 3, 2017, 3:59 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
> > Lines 168 (patched)
> > 
> >
> > The second "tab" seemed to be a real tab than 2 white spaces. please 
> > make sure all tabs are replaced by spaces. You can set that in Eclipse as a 
> > general setting.

Fixed in new patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review167838
---


On March 3, 2017, 8:47 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 3, 2017, 8:47 p.m.)
> 
> 
> Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  eaecf35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  51114f8 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/4/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/
---

(Updated March 3, 2017, 8:47 p.m.)


Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20243
https://issues.apache.org/jira/browse/AMBARI-20243


Repository: ambari


Description
---

Currently all the details from the ambari.properties file is being returned by 
the API call.

Some of those information may not be utilized and hence an option can be 
provided to filter the properties

A ambari-blacklist.properties file can be created, the properties that are 
entered in the file, will be removed from the api call that returns the 
ambari.properties.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 eaecf35 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
 dadcf09 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 51114f8 


Diff: https://reviews.apache.org/r/57168/diff/4/

Changes: https://reviews.apache.org/r/57168/diff/3-4/


Testing
---

Added 1 test case
Ran mvn test


Thanks,

Anita Jebaraj

Review Request 57304: Code review request for AMBARI-20157

[Amarnath reddy pappu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57304/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-20157
https://issues.apache.org/jira/browse/AMBARI-20157


Repository: ambari


Description
---

Fix for SNMP notification order


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java
 ba86687 


Diff: https://reviews.apache.org/r/57304/diff/1/


Testing
---

1. Added the debug statements in "AlertNoticeDispatchService.java" file to see 
the order before it actually dispatches the notifications
Expected Result: it should print he notifications in correct order , smaller 
notification_id notification first and bigger one later.
Actual Result: PASS

---

sample ambari-server.log

ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2951  
uuid:d237b8f4-9a89-4e62-9fe3-562119908732
ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2952  
uuid:697a1597-bf4d-4196-aea6-d0b6ac6a8703
ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2953  
uuid:37bf8683--4c94-b2d0-763e85ef3d5c
ambari-server.log:03 Mar 2017 11:45:09,787  INFO [AlertNoticeDispatchService 
RUNNING] AlertNoticeDispatchService:282 - HWX Alert notice entity order:2954  
uuid:62d6ea6f-2190-4771-9497-eb07d45a4537


--


Thanks,

Amarnath reddy pappu

Re: Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/#review167862
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Березень 3, 2017, 3:43 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57293/
> ---
> 
> (Updated Березень 3, 2017, 3:43 після полудня)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20305
> https://issues.apache.org/jira/browse/AMBARI-20305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari fails to get jmx metrics from Hbase if it's running with https protocol
> 03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
> MetricsRetrievalService:481 - Unable to retrieve metrics from 
> http://host1:30010/jmx. Subsequent failures will be suppressed from the log 
> for 20 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  6967fee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  270d50a 
> 
> 
> Diff: https://reviews.apache.org/r/57293/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/#review167858
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 12:30 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57040/
> ---
> 
> (Updated March 3, 2017, 12:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The rebalancing operation may take a long time (hours, days) thus when issued 
> from the ambari UI the background operation may time out.
> As it's not possible to dynamically predict how long the rebalancing will 
> last , the approach taken by this solution is to only trigger the operation 
> and not wait to the operation to finish.
> 
> (NOTE: after this change the progress of the rebalance operation won't be 
> tracked anymore in the background operation; also the user won't be notified 
> about the success/failure of the operation)
> 
> UPDATE:
> The operation is only triggered if there's no other rebalance operation 
> running. (This is done by checking the existence of the /system/balancer.id 
> on hdfs As per the input from hdfs devs, this check may be misleading if a 
> balancer process is killed by an admin, as the file can remain there. - To 
> overcome this added a message to explain this behavior)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
>  1dc545e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bd05a95 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_rebalance.py
>  1dc545e 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
>  08578bc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py ec19dc4 
> 
> 
> Diff: https://reviews.apache.org/r/57040/diff/4/
> 
> 
> Testing
> ---
> 
> Manually tested on local unsecure cluster.
> Manually tested on local secure cluster
> 
> Unit tests successfully ran.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57281: Script-Based Alert Dispathers support passing more parameters to script

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57281/#review167857
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 11:56 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57281/
> ---
> 
> (Updated March 3, 2017, 11:56 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20291
> https://issues.apache.org/jira/browse/AMBARI-20291
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Script-Based Alert Dispatcher now pass five parameters to script,including 
> alert definition name, definition label,service name, alert state, and alert 
> text.
> But if script can receive other two parameters from dispather,it will be 
> better.
> 1.hostname.
> Because hostname the alert for is not always included in alert text,although 
> it may be null like aggregate alerts.
> With it we can more quick to find the related host that occured alert.
> 2.alert timestamp.
> We may need to know the alert occurrence time ( state change time) more 
> exactly. After the alert happened,it will spend some time to schedule the 
> script to run.
> Without it,we can only regard the script start time as the alert occurrence 
> time.
> 
> We now use this feature to send alert information to mobile phone and suggest 
> also passing hostname and alert timestamp.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
>  174f31f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
>  9e0e406 
> 
> 
> Diff: https://reviews.apache.org/r/57281/diff/1/
> 
> 
> Testing
> ---
> 
> 1.cd ambari-server
>mvn test
> 
> 2.write a python script to receive parameters from dispatcher
> 
> 
> #!/usr/bin/python
> import sys
> import logging
> 
> def main():
> definitionName = sys.argv[1]
> definitionLabel = sys.argv[2]
> serviceName = sys.argv[3]
> alertState = sys.argv[4]
> alertText = sys.argv[5]
> alertTimestamp = sys.argv[6]
> hostname = sys.argv[7] if len(sys.argv)-1 == 7 else None
> 
> logFile='/var/log/ambari-server/log_py.log'
> 
> logging.basicConfig(filename = logFile, level = logging.DEBUG)
> logging.debug('received ' + str(len(sys.argv)-1) + ' parameters')
> for i in range(1, len(sys.argv)):
> logging.debug('parameter ' +str(i) + ':' +str(sys.argv[i]))
> 
> if __name__ == '__main__':
>main()
> 
> 
> Stop and start any service like HDFS , we can see the expected result in 
> /var/log/ambari-server/log_py.log,
> 
> 3.write a shell script to  receive parameters from dispatcher
> 
> 
> #!/bin/bash
> logFile=/var/log/ambari-server/log_sh.log
> definitionName=$1
> definitionLabel=$2
> serviceName=$3
> alertState=$4 
> alertText=$5
> alertTimestamp=$6
> hostname=$7
> 
> echo received $# parameters:  $definitionName, $definitionLabel, 
> $serviceName, $alertState ,$alertText ,$alertTimestamp, $hostname  >> $logFile
> 
> 
> Stop and start any service like HDFS , we can see the expected result in 
> /var/ambari-server/log_sh.log, we can see the expected result.
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 57292: Services shows as Restart required after upgrading from Ambari-2.4.x to 2.5.0.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57292/#review167856
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 3, 2017, 3:26 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57292/
> ---
> 
> (Updated March 3, 2017, 3:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20304
> https://issues.apache.org/jira/browse/AMBARI-20304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Properties are added during upgrade to 2.5
> * falcon.atlas.hook
> * hive.atlas.hook
> * sqoop.atlas.hook
> * storm.atlas.hook
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  5663f57286 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  12135805b5 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
>  508cfab65c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
>  3b814a9b54 
> 
> 
> Diff: https://reviews.apache.org/r/57292/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

[Sumit Mohanty]

The flag is in the ServiceDesiredState table which is not updated.

Get Outlook for iOS




On Fri, Mar 3, 2017 at 9:47 AM -0800, "Jayush Luniya" 
> wrote:

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/57253/


Maybe I am missing something, but what logic ensures that upgrading an existing 
cluster does not enable the credential store for already deployed services?


- Jayush Luniya


On March 2nd, 2017, 7:48 p.m. UTC, Madhuvanthi Radhakrishnan wrote:

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.
By Madhuvanthi Radhakrishnan.

Updated March 2, 2017, 7:48 p.m.

Bugs: AMBARI-20275
Repository: ambari
Description

Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
Logsearch)


Testing

Manual Testing



Scenario - 1 FRESH INSTALL




Deploy Ambari 2.5 - HDP 2.6
0. Add services Hive, Oozie, Logsearch
1. GET http://:8080/api/v1/clusters/cl1/services/HIVE  - Hive Credential 
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
….
}
2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie Credential 
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
Credential Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
4. User is able to disable Hive and Oozie CS
PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
{"ServiceInfo": {"credential_store_enabled": "false"}}




GET http://:8080/api/v1/clusters/cl1/services/HIVE
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
…
}




PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
{"ServiceInfo": {"credential_store_enabled": "false"}}




GET http://:8080/api/v1/clusters/cl1/services/OOZIE
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
….
}






  1.  User is not able to disable Logsearch
PUT 
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
{"ServiceInfo": {"credential_store_enabled": "false"}}
Response:
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
disable credential store as it is required by the service. Service=LOGSEARCH"
}






Scenario - 1 AMBARI UPGRADE
1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
   Hive, Oozie, Logsearch - disabled
2. User is able to enable Credential Store for Hive, Oozie, Logsearch post 
upgrade


Diffs

  *   
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
(245a94d)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
(4230dd4)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
(75aa9d9)

View Diff

Re: Review Request 57296: Full-height modals overflow viewport vertically

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57296/#review167852
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Март 3, 2017, 6:07 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57296/
> ---
> 
> (Updated Март 3, 2017, 6:07 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20311
> https://issues.apache.org/jira/browse/AMBARI-20311
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modal popups that occupy all available height (i.e., containing background 
> operations logs) overflow viewport vertically.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/common.less ad1da66 
>   ambari-web/app/styles/log_file_search.less cf5ef29 
>   ambari-web/app/templates/common/host_progress_popup.hbs ae411b1 
>   ambari-web/app/views/common/host_progress_popup_body_view.js f119c3b 
>   ambari-web/app/views/common/modal_popup.js f09ae62 
> 
> 
> Diff: https://reviews.apache.org/r/57296/diff/1/
> 
> 
> Testing
> ---
> 
> 20575 passing (18s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 57296: Full-height modals overflow viewport vertically

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57296/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20311
https://issues.apache.org/jira/browse/AMBARI-20311


Repository: ambari


Description
---

Modal popups that occupy all available height (i.e., containing background 
operations logs) overflow viewport vertically.


Diffs
-

  ambari-web/app/styles/common.less ad1da66 
  ambari-web/app/styles/log_file_search.less cf5ef29 
  ambari-web/app/templates/common/host_progress_popup.hbs ae411b1 
  ambari-web/app/views/common/host_progress_popup_body_view.js f119c3b 
  ambari-web/app/views/common/modal_popup.js f09ae62 


Diff: https://reviews.apache.org/r/57296/diff/1/


Testing
---

20575 passing (18s)
  153 pending


Thanks,

Andriy Babiichuk

Review Request 57295: Atlas service check fails during EU on wire encrypted cluster

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57295/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-20308
https://issues.apache.org/jira/browse/AMBARI-20308


Repository: ambari


Description
---

During an upgrade to HDP 2.6, Atlas service checks are failing. This is because 
in ATLAS-1427, `TLSv1.2` was added as the default protocol and `TLSv1, TLSv1.1` 
were excluded. Some versions of cURL do not support TLSv1.2.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml
 47e1fb5 


Diff: https://reviews.apache.org/r/57295/diff/1/


Testing
---

Performed an EU to HDP 2.6 for Atlas and verified the property.


Thanks,

Jonathan Hurley

Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/#review167849
---



Maybe I am missing something, but what logic ensures that upgrading an existing 
cluster does not enable the credential store for already deployed services?

- Jayush Luniya


On March 2, 2017, 7:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57253/
> ---
> 
> (Updated March 2, 2017, 7:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20275
> https://issues.apache.org/jira/browse/AMBARI-20275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Credential Store should be enabled by default on fresh installs (Hive, Oozie, 
> Logsearch)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
> 4230dd4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
> 75aa9d9 
> 
> 
> Diff: https://reviews.apache.org/r/57253/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing
> ===
> *Scenario - 1 FRESH INSTALL*
> 
> Deploy Ambari 2.5 - HDP 2.6
> 0. Add services Hive, Oozie, Logsearch
> 1. GET http://:8080/api/v1/clusters/cl1/services/HIVE  - Hive 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> ….
> }
> 2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> …
> }
> 3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch 
> Credential Store enabled on fresh install
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "true",
> "credential_store_supported": "true",
> …
> }
> 4. User is able to disable Hive and Oozie CS
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> 
> GET http://:8080/api/v1/clusters/cl1/services/HIVE
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "false",
> "credential_store_supported": "true",
> …
> }
> 
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> 
> GET http://:8080/api/v1/clusters/cl1/services/OOZIE
> {
> "href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
> "ServiceInfo": {
> "cluster_name": "cl1",
> "credential_store_enabled": "false",
> "credential_store_supported": "true",
> ….
> }
> 
> 5. User is not able to disable Logsearch
> PUT 
> http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
> {"ServiceInfo": {"credential_store_enabled": "false"}}
> Response:
> {
>   "status" : 400,
>   "message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot 
> disable credential store as it is required by the service. Service=LOGSEARCH"
> }
> 
> *Scenario - 1 AMBARI UPGRADE*
> 1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
>Hive, Oozie, Logsearch - disabled
> 2. User is able to enable Credential Store for Hive, Oozie, Logsearch post 
> upgrade
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review167838
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 4324 (patched)


Why did you need to restore the keys ? stringPropertyNames already returns 
a Set object that you may use directly.



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 4327 (patched)


close instream in finally{}



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 4329 (patched)


How did Ambari server react to an i/o exception on the blacklist file? 
Please make sure Ambari server start restarts successfully even when the 
blacklist file causes an i/o exception as I don't think it's a sev1 err like 
some others in this class, i.e. can't read db pwd, can't read ssl cert pwd.



ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
Lines 168 (patched)


The second "tab" seemed to be a real tab than 2 white spaces. please make 
sure all tabs are replaced by spaces. You can set that in Eclipse as a general 
setting.


- Di Li


On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57168/
> ---
> 
> (Updated March 2, 2017, 1:05 a.m.)
> 
> 
> Review request for Ambari, Di Li, Oleksandr Diachenko, Sangeeta Ravindran, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20243
> https://issues.apache.org/jira/browse/AMBARI-20243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently all the details from the ambari.properties file is being returned 
> by the API call.
> 
> Some of those information may not be utilized and hence an option can be 
> provided to filter the properties
> 
> A ambari-blacklist.properties file can be created, the properties that are 
> entered in the file, will be removed from the api call that returns the 
> ambari.properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  eaecf35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  dadcf09 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  51114f8 
> 
> 
> Diff: https://reviews.apache.org/r/57168/diff/3/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Review Request 57293: All HBase Masters listed as in standby if Hbase ssl is enabled.

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57293/
---

Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20305
https://issues.apache.org/jira/browse/AMBARI-20305


Repository: ambari


Description
---

Ambari fails to get jmx metrics from Hbase if it's running with https protocol
03 Mar 2017 15:24:00,903 ERROR [ambari-metrics-retrieval-service-thread-17] 
MetricsRetrievalService:481 - Unable to retrieve metrics from 
http://host1:30010/jmx. Subsequent failures will be suppressed from the log for 
20 minutes.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 6967fee 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
 270d50a 


Diff: https://reviews.apache.org/r/57293/diff/1/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 57292: Services shows as Restart required after upgrading from Ambari-2.4.x to 2.5.0.

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57292/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-20304
https://issues.apache.org/jira/browse/AMBARI-20304


Repository: ambari


Description
---

Properties are added during upgrade to 2.5
* falcon.atlas.hook
* hive.atlas.hook
* sqoop.atlas.hook
* storm.atlas.hook


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 5663f57286 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 12135805b5 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
 508cfab65c 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
 3b814a9b54 


Diff: https://reviews.apache.org/r/57292/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 57275: WFM FS editor needs to maintain order of FS operations

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57275/#review167837
---


Ship it!




Ship It!

- Gaurav Nagar


On March 3, 2017, 10:40 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57275/
> ---
> 
> (Updated March 3, 2017, 10:40 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-20293
> https://issues.apache.org/jira/browse/AMBARI-20293
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> WFM FS editor needs to maintain order of FS operations
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 305861010c 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 
> 12d12d2754 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> dd63a3a995 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
>  72235815e0 
> 
> 
> Diff: https://reviews.apache.org/r/57275/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 57284: AMBARI-20296.Workflow Manger support for pointing to kill node in decision editor.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57284/#review167836
---


Ship it!




Ship It!

- Gaurav Nagar


On March 3, 2017, 12:07 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57284/
> ---
> 
> (Updated March 3, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20296
> https://issues.apache.org/jira/browse/AMBARI-20296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by enabling the changing of target nodes for each condition in the 
> decision editor
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  41bb1e5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  419be37 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 2f8455f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js
>  ce04863 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  09bffe7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  ae178b3 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js d815df1 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 228f0e2 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/decision-config.hbs
>  cb7ff46 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  d428815 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs
>  fe46446 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  788916b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57284/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 57267: AMBARI-20247. Show full error while importing the workflow from encrypted file

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57267/#review167834
---


Ship it!




Ship It!

- Gaurav Nagar


On March 3, 2017, 6:46 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57267/
> ---
> 
> (Updated March 3, 2017, 6:46 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20247
> https://issues.apache.org/jira/browse/AMBARI-20247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing the full stack trace on the UI if there is an exception. And also 
> added the loggers.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  c4e5bbd 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  3355c85 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java
>  fd4ce80 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  e1a5808 
> 
> 
> Diff: https://reviews.apache.org/r/57267/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 57291: HiveView2.0: Issues in worksheet

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57291/#review167833
---


Ship it!




Ship It!

- Gaurav Nagar


On March 3, 2017, 3:11 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57291/
> ---
> 
> (Updated March 3, 2017, 3:11 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20303
> https://issues.apache.org/jira/browse/AMBARI-20303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Worksheet tab is provided with the button to close the worksheet and upon 
> double-click of worksheet tab, rename modal will be opened.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 
> 7bd2214 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> d08a47b 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs 
> b8e19da 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 8a771eb 
> 
> 
> Diff: https://reviews.apache.org/r/57291/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 57279: Simple queries show "no tez plan found"

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57279/#review167829
---


Ship it!




Ship It!

- Nitiraj Rathore


On March 3, 2017, 11:10 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57279/
> ---
> 
> (Updated March 3, 2017, 11:10 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20294
> https://issues.apache.org/jira/browse/AMBARI-20294
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added condition for showing the plan for simple queries.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
> fc7cf64 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> d08a47b 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js
>  2310b3c 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js 
> 3513a23 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  48706cb 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  f69b1d4 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  e6cf3f3 
> 
> 
> Diff: https://reviews.apache.org/r/57279/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 57291: HiveView2.0: Issues in worksheet

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57291/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20303
https://issues.apache.org/jira/browse/AMBARI-20303


Repository: ambari


Description
---

Worksheet tab is provided with the button to close the worksheet and upon 
double-click of worksheet tab, rename modal will be opened.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 7bd2214 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
d08a47b 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs b8e19da 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
8a771eb 


Diff: https://reviews.apache.org/r/57291/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 57290: Despite user selecting not to apply Config Changes, Changes are being applied

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57290/#review167830
---


Ship it!




Ship It!

- Alexandr Antonenko


On March 3, 2017, 3:08 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57290/
> ---
> 
> (Updated March 3, 2017, 3:08 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20302
> https://issues.apache.org/jira/browse/AMBARI-20302
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps:
> 1) On an existing cluster, Delete Ambari Infra service
> 2) At time of deletion , there will be a popup which shows Recommended Config 
> changes
> 3) Unselect the recommended config change and continue
> Expected:
> Config change should not be applied
> Acutal:
> Config change was applied regardless
> Refer to screenshot for the example config which got changed
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js 621c3b6 
>   ambari-web/test/controllers/main/service/item_test.js fff321c 
> 
> 
> Diff: https://reviews.apache.org/r/57290/diff/1/
> 
> 
> Testing
> ---
> 
> 20575 passing (33s)
>   153 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Review Request 57290: Despite user selecting not to apply Config Changes, Changes are being applied

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57290/
---

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-20302
https://issues.apache.org/jira/browse/AMBARI-20302


Repository: ambari


Description
---

Steps:
1) On an existing cluster, Delete Ambari Infra service
2) At time of deletion , there will be a popup which shows Recommended Config 
changes
3) Unselect the recommended config change and continue
Expected:
Config change should not be applied
Acutal:
Config change was applied regardless
Refer to screenshot for the example config which got changed


Diffs
-

  ambari-web/app/controllers/main/service/item.js 621c3b6 
  ambari-web/test/controllers/main/service/item_test.js fff321c 


Diff: https://reviews.apache.org/r/57290/diff/1/


Testing
---

20575 passing (33s)
  153 pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 57287: LogSearch Portal UI Fails on Last Page selection if logs were deleted in the meantime

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
---

(Updated March 3, 2017, 2:06 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

rename last page variable to lastPage


Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300


Repository: ambari


Description
---

If logs are deleted between the last screen generation and the clicking on the 
last page button an empty table comes up. The same happens if the user clicks 
on a page number which is no longer valid, as there are fewer logs since.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 d44b866 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 2dc0ef7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
 89873f3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
 c175397 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/TableLayout.js
 1066510 


Diff: https://reviews.apache.org/r/57287/diff/2/

Changes: https://reviews.apache.org/r/57287/diff/1-2/


Testing
---

Tested on local cluster setting extra short time for the logs to expire.


Thanks,

Miklos Gergely

Re: Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57289/#review167821
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 3, 2017, 1:47 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57289/
> ---
> 
> (Updated March 3, 2017, 1:47 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20301
> https://issues.apache.org/jira/browse/AMBARI-20301
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changing the execution of ember from local node
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/pom.xml 564a82d 
> 
> 
> Diff: https://reviews.apache.org/r/57289/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57289/#review167820
---


Ship it!




Ship It!

- belliraj hb


On March 3, 2017, 1:47 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57289/
> ---
> 
> (Updated March 3, 2017, 1:47 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20301
> https://issues.apache.org/jira/browse/AMBARI-20301
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changing the execution of ember from local node
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/pom.xml 564a82d 
> 
> 
> Diff: https://reviews.apache.org/r/57289/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57289/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20301
https://issues.apache.org/jira/browse/AMBARI-20301


Repository: ambari


Description
---

Changing the execution of ember from local node


Diffs
-

  contrib/views/wfmanager/pom.xml 564a82d 


Diff: https://reviews.apache.org/r/57289/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 57287: LogSearch Portal UI Fails on Last Page selection if logs were deleted in the meantime

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/#review167819
---


Fix it, then Ship it!




Ship It!


ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
Line 86 (original), 86 (patched)


can we still use lastPage as a parameter? that means it would be better to 
change on the UI


- Oliver Szabo


On March 3, 2017, 1:30 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57287/
> ---
> 
> (Updated March 3, 2017, 1:30 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20300
> https://issues.apache.org/jira/browse/AMBARI-20300
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If logs are deleted between the last screen generation and the clicking on 
> the last page button an empty table comes up. The same happens if the user 
> clicks on a page number which is no longer valid, as there are fewer logs 
> since.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  a260ed0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
>  d44b866 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  2dc0ef7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
>  89873f3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  f960250 
> 
> 
> Diff: https://reviews.apache.org/r/57287/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster setting extra short time for the logs to expire.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/#review167817
---


Ship it!




Ship It!

- Robert Levas


On March 3, 2017, 7:30 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57040/
> ---
> 
> (Updated March 3, 2017, 7:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The rebalancing operation may take a long time (hours, days) thus when issued 
> from the ambari UI the background operation may time out.
> As it's not possible to dynamically predict how long the rebalancing will 
> last , the approach taken by this solution is to only trigger the operation 
> and not wait to the operation to finish.
> 
> (NOTE: after this change the progress of the rebalance operation won't be 
> tracked anymore in the background operation; also the user won't be notified 
> about the success/failure of the operation)
> 
> UPDATE:
> The operation is only triggered if there's no other rebalance operation 
> running. (This is done by checking the existence of the /system/balancer.id 
> on hdfs As per the input from hdfs devs, this check may be misleading if a 
> balancer process is killed by an admin, as the file can remain there. - To 
> overcome this added a message to explain this behavior)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
>  1dc545e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bd05a95 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_rebalance.py
>  1dc545e 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
>  08578bc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py ec19dc4 
> 
> 
> Diff: https://reviews.apache.org/r/57040/diff/4/
> 
> 
> Testing
> ---
> 
> Manually tested on local unsecure cluster.
> Manually tested on local secure cluster
> 
> Unit tests successfully ran.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 57287: LogSearch Portal UI Fails on Last Page selection if logs were deleted in the meantime

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300


Repository: ambari


Description
---

If logs are deleted between the last screen generation and the clicking on the 
last page button an empty table comes up. The same happens if the user clicks 
on a page number which is no longer valid, as there are fewer logs since.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 a260ed0 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 d44b866 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 2dc0ef7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
 89873f3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 


Diff: https://reviews.apache.org/r/57287/diff/1/


Testing
---

Tested on local cluster setting extra short time for the logs to expire.


Thanks,

Miklos Gergely

Re: Review Request 57286: Popup "Save changed" appears when user switches config versions

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57286/#review167816
---


Ship it!




Ship It!

- Denys Buzhor


On March 3, 2017, 1:28 p.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57286/
> ---
> 
> (Updated March 3, 2017, 1:28 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20297
> https://issues.apache.org/jira/browse/ambari-20297
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Create several config versions
> * Switch to one of them
> * While it's loading (spinner is shown) try to switch to another version
> 
> *ER* Confirmation popup should not be shown
> *AR* This popup is shown
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f 
> 
> 
> Diff: https://reviews.apache.org/r/57286/diff/1/
> 
> 
> Testing
> ---
> 
> 30365 passing (22s)
>   157 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 57286: Popup "Save changed" appears when user switches config versions

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57286/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20297
https://issues.apache.org/jira/browse/ambari-20297


Repository: ambari


Description
---

* Create several config versions
* Switch to one of them
* While it's loading (spinner is shown) try to switch to another version

*ER* Confirmation popup should not be shown
*AR* This popup is shown


Diffs
-

  ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f 


Diff: https://reviews.apache.org/r/57286/diff/1/


Testing
---

30365 passing (22s)
  157 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/
---

(Updated March 3, 2017, 12:30 p.m.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
and Sebastian Toader.


Changes
---

Updated to the patch against the trunk.


Bugs: AMBARI-20175
https://issues.apache.org/jira/browse/AMBARI-20175


Repository: ambari


Description
---

The rebalancing operation may take a long time (hours, days) thus when issued 
from the ambari UI the background operation may time out.
As it's not possible to dynamically predict how long the rebalancing will last 
, the approach taken by this solution is to only trigger the operation and not 
wait to the operation to finish.

(NOTE: after this change the progress of the rebalance operation won't be 
tracked anymore in the background operation; also the user won't be notified 
about the success/failure of the operation)

UPDATE:
The operation is only triggered if there's no other rebalance operation 
running. (This is done by checking the existence of the /system/balancer.id on 
hdfs As per the input from hdfs devs, this check may be misleading if a 
balancer process is killed by an admin, as the file can remain there. - To 
overcome this added a message to explain this behavior)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
 1dc545e 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 bd05a95 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_rebalance.py
 1dc545e 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
 08578bc 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py ec19dc4 


Diff: https://reviews.apache.org/r/57040/diff/4/

Changes: https://reviews.apache.org/r/57040/diff/3-4/


Testing
---

Manually tested on local unsecure cluster.
Manually tested on local secure cluster

Unit tests successfully ran.


Thanks,

Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/#review167814
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
Lines 349 (patched)


Maybe worth adding to the message that in case of very large clusters this 
operation may take hours or days to complete.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
Lines 351-353 (patched)


Wouldn't be enough just writing out

"There is already a balancer running. Note that the process may take a long 
time to finish (hours, even days on very large clusters)."


- Sebastian Toader


On March 3, 2017, 9:52 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57040/
> ---
> 
> (Updated March 3, 2017, 9:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The rebalancing operation may take a long time (hours, days) thus when issued 
> from the ambari UI the background operation may time out.
> As it's not possible to dynamically predict how long the rebalancing will 
> last , the approach taken by this solution is to only trigger the operation 
> and not wait to the operation to finish.
> 
> (NOTE: after this change the progress of the rebalance operation won't be 
> tracked anymore in the background operation; also the user won't be notified 
> about the success/failure of the operation)
> 
> UPDATE:
> The operation is only triggered if there's no other rebalance operation 
> running. (This is done by checking the existence of the /system/balancer.id 
> on hdfs As per the input from hdfs devs, this check may be misleading if a 
> balancer process is killed by an admin, as the file can remain there. - To 
> overcome this added a message to explain this behavior)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
>  1dc545e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  123486e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 
> 
> 
> Diff: https://reviews.apache.org/r/57040/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested on local unsecure cluster.
> Manually tested on local secure cluster
> 
> Unit tests successfully ran.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57283: AMBARI-20295. Workflow manager view is not loading

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57283/#review167813
---


Ship it!




Ship It!

- belliraj hb


On March 3, 2017, 12:06 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57283/
> ---
> 
> (Updated March 3, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20295
> https://issues.apache.org/jira/browse/AMBARI-20295
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Latest version of cytoscape.js is having issues. So setting the bower working 
> versions.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/bower.json b44a83b 
> 
> 
> Diff: https://reviews.apache.org/r/57283/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Re: Review Request 57284: AMBARI-20296.Workflow Manger support for pointing to kill node in decision editor.

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57284/#review167812
---


Ship it!




Ship It!

- belliraj hb


On March 3, 2017, 12:07 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57284/
> ---
> 
> (Updated March 3, 2017, 12:07 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20296
> https://issues.apache.org/jira/browse/AMBARI-20296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by enabling the changing of target nodes for each condition in the 
> decision editor
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  41bb1e5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  419be37 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 2f8455f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js
>  ce04863 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  09bffe7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  ae178b3 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js d815df1 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 228f0e2 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/decision-config.hbs
>  cb7ff46 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  d428815 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs
>  fe46446 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  788916b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57284/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 57283: AMBARI-20295. Workflow manager view is not loading

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57283/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20295
https://issues.apache.org/jira/browse/AMBARI-20295


Repository: ambari


Description
---

Latest version of cytoscape.js is having issues. So setting the bower working 
versions.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json b44a83b 


Diff: https://reviews.apache.org/r/57283/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 57280: While Comparing versions, value in latest version is not shown for custom property

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57280/#review167810
---


Ship it!




Ship It!

- Alexandr Antonenko


On March 3, 2017, 11:35 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57280/
> ---
> 
> (Updated March 3, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-20286
> https://issues.apache.org/jira/browse/AMBARI-20286
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Difftool which shows the comparison between 2versions doesnt show custom 
> properties added to a service
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/common/configs/configs_comparator.js 4adc5ae 
>   ambari-web/app/models/configs/objects/service_config_property.js ed72dc3 
>   ambari-web/app/templates/common/configs/service_config_category.hbs c9bedc5 
>   ambari-web/app/utils/config.js 8eeca5f 
>   ambari-web/test/views/common/table_view_test.js dd289b0 
> 
> 
> Diff: https://reviews.apache.org/r/57280/diff/1/
> 
> 
> Testing
> ---
> 
> 20574 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 57281: Script-Based Alert Dispathers support passing more parameters to script

[yao lei]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57281/
---

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-20291
https://issues.apache.org/jira/browse/AMBARI-20291


Repository: ambari


Description
---

Script-Based Alert Dispatcher now pass five parameters to script,including 
alert definition name, definition label,service name, alert state, and alert 
text.
But if script can receive other two parameters from dispather,it will be better.
1.hostname.
Because hostname the alert for is not always included in alert text,although it 
may be null like aggregate alerts.
With it we can more quick to find the related host that occured alert.
2.alert timestamp.
We may need to know the alert occurrence time ( state change time) more 
exactly. After the alert happened,it will spend some time to schedule the 
script to run.
Without it,we can only regard the script start time as the alert occurrence 
time.

We now use this feature to send alert information to mobile phone and suggest 
also passing hostname and alert timestamp.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 907588d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
 174f31f 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
 9e0e406 


Diff: https://reviews.apache.org/r/57281/diff/1/


Testing
---

1.cd ambari-server
   mvn test

2.write a python script to receive parameters from dispatcher


#!/usr/bin/python
import sys
import logging

def main():
definitionName = sys.argv[1]
definitionLabel = sys.argv[2]
serviceName = sys.argv[3]
alertState = sys.argv[4]
alertText = sys.argv[5]
alertTimestamp = sys.argv[6]
hostname = sys.argv[7] if len(sys.argv)-1 == 7 else None

logFile='/var/log/ambari-server/log_py.log'

logging.basicConfig(filename = logFile, level = logging.DEBUG)
logging.debug('received ' + str(len(sys.argv)-1) + ' parameters')
for i in range(1, len(sys.argv)):
logging.debug('parameter ' +str(i) + ':' +str(sys.argv[i]))

if __name__ == '__main__':
   main()


Stop and start any service like HDFS , we can see the expected result in 
/var/log/ambari-server/log_py.log,

3.write a shell script to  receive parameters from dispatcher


#!/bin/bash
logFile=/var/log/ambari-server/log_sh.log
definitionName=$1
definitionLabel=$2
serviceName=$3
alertState=$4 
alertText=$5
alertTimestamp=$6
hostname=$7

echo received $# parameters:  $definitionName, $definitionLabel, $serviceName, 
$alertState ,$alertText ,$alertTimestamp, $hostname  >> $logFile


Stop and start any service like HDFS , we can see the expected result in 
/var/ambari-server/log_sh.log, we can see the expected result.


Thanks,

yao lei

Review Request 57280: While Comparing versions, value in latest version is not shown for custom property

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57280/
---

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-20286
https://issues.apache.org/jira/browse/AMBARI-20286


Repository: ambari


Description
---

Difftool which shows the comparison between 2versions doesnt show custom 
properties added to a service


Diffs
-

  ambari-web/app/mixins/common/configs/configs_comparator.js 4adc5ae 
  ambari-web/app/models/configs/objects/service_config_property.js ed72dc3 
  ambari-web/app/templates/common/configs/service_config_category.hbs c9bedc5 
  ambari-web/app/utils/config.js 8eeca5f 
  ambari-web/test/views/common/table_view_test.js dd289b0 


Diff: https://reviews.apache.org/r/57280/diff/1/


Testing
---

20574 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 57275: WFM FS editor needs to maintain order of FS operations

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57275/#review167808
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 3, 2017, 10:40 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57275/
> ---
> 
> (Updated March 3, 2017, 10:40 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-20293
> https://issues.apache.org/jira/browse/AMBARI-20293
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> WFM FS editor needs to maintain order of FS operations
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 305861010c 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 
> 12d12d2754 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> dd63a3a995 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
>  72235815e0 
> 
> 
> Diff: https://reviews.apache.org/r/57275/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 57279: Simple queries show "no tez plan found"

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57279/#review167807
---


Ship it!




Ship It!

- Gaurav Nagar


On March 3, 2017, 11:10 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57279/
> ---
> 
> (Updated March 3, 2017, 11:10 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20294
> https://issues.apache.org/jira/browse/AMBARI-20294
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added condition for showing the plan for simple queries.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
> fc7cf64 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> d08a47b 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js
>  2310b3c 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js 
> 3513a23 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  48706cb 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  f69b1d4 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  e6cf3f3 
> 
> 
> Diff: https://reviews.apache.org/r/57279/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 57279: Simple queries show "no tez plan found"

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57279/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20294
https://issues.apache.org/jira/browse/AMBARI-20294


Repository: ambari


Description
---

Added condition for showing the plan for simple queries.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 
fc7cf64 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
d08a47b 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js 
2310b3c 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js 
3513a23 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
 48706cb 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
f69b1d4 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 e6cf3f3 


Diff: https://reviews.apache.org/r/57279/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 57275: WFM FS editor needs to maintain order of FS operations

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57275/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
Kulshreshtha.


Bugs: AMBARI-20293
https://issues.apache.org/jira/browse/AMBARI-20293


Repository: ambari


Description
---

WFM FS editor needs to maintain order of FS operations


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
305861010c 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 
12d12d2754 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
dd63a3a995 
  
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
 72235815e0 


Diff: https://reviews.apache.org/r/57275/diff/1/


Testing
---

Manual testing.


Thanks,

belliraj hb

Re: Review Request 57259: AMBARI-20285. Spark2 Thrift Server stopped due to incompletely uploaded tar.gz

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57259/#review167804
---


Ship it!




Ship It!

- Sandor Magyari


On March 2, 2017, 11:08 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57259/
> ---
> 
> (Updated March 2, 2017, 11:08 p.m.)
> 
> 
> Review request for Ambari, Bikas Saha, Laszlo Puskas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20285
> https://issues.apache.org/jira/browse/AMBARI-20285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Explicitly set permissions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  12988c8 
> 
> 
> Diff: https://reviews.apache.org/r/57259/diff/1/
> 
> 
> Testing
> ---
> 
> Manual test: create cluster via blueprint, verify 
> `/tmp/spark2/spark2-hdp-yarn-archive.tar.gz` is world readable, and that 
> Spark2 Thrift Server does not stop soon after start.
> 
> Existing unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 57259: AMBARI-20285. Spark2 Thrift Server stopped due to incompletely uploaded tar.gz

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57259/#review167803
---


Ship it!




Ship It!

- Sebastian Toader


On March 3, 2017, 12:08 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57259/
> ---
> 
> (Updated March 3, 2017, 12:08 a.m.)
> 
> 
> Review request for Ambari, Bikas Saha, Laszlo Puskas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20285
> https://issues.apache.org/jira/browse/AMBARI-20285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Explicitly set permissions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  12988c8 
> 
> 
> Diff: https://reviews.apache.org/r/57259/diff/1/
> 
> 
> Testing
> ---
> 
> Manual test: create cluster via blueprint, verify 
> `/tmp/spark2/spark2-hdp-yarn-archive.tar.gz` is world readable, and that 
> Spark2 Thrift Server does not stop soon after start.
> 
> Existing unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1192
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

> On Feb. 24, 2017, 4:54 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
> > Line 346 (original), 346 (patched)
> > 
> >
> > Please also make this change for HDFS 3.0.0.3.0

Added patch for the trunk to the jira.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/#review166728
---


On March 3, 2017, 8:52 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57040/
> ---
> 
> (Updated March 3, 2017, 8:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20175
> https://issues.apache.org/jira/browse/AMBARI-20175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The rebalancing operation may take a long time (hours, days) thus when issued 
> from the ambari UI the background operation may time out.
> As it's not possible to dynamically predict how long the rebalancing will 
> last , the approach taken by this solution is to only trigger the operation 
> and not wait to the operation to finish.
> 
> (NOTE: after this change the progress of the rebalance operation won't be 
> tracked anymore in the background operation; also the user won't be notified 
> about the success/failure of the operation)
> 
> UPDATE:
> The operation is only triggered if there's no other rebalance operation 
> running. (This is done by checking the existence of the /system/balancer.id 
> on hdfs As per the input from hdfs devs, this check may be misleading if a 
> balancer process is killed by an admin, as the file can remain there. - To 
> overcome this added a message to explain this behavior)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
>  1dc545e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  123486e 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 
> 
> 
> Diff: https://reviews.apache.org/r/57040/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested on local unsecure cluster.
> Manually tested on local secure cluster
> 
> Unit tests successfully ran.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/
---

(Updated March 3, 2017, 8:52 a.m.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
and Sebastian Toader.


Bugs: AMBARI-20175
https://issues.apache.org/jira/browse/AMBARI-20175


Repository: ambari


Description
---

The rebalancing operation may take a long time (hours, days) thus when issued 
from the ambari UI the background operation may time out.
As it's not possible to dynamically predict how long the rebalancing will last 
, the approach taken by this solution is to only trigger the operation and not 
wait to the operation to finish.

(NOTE: after this change the progress of the rebalance operation won't be 
tracked anymore in the background operation; also the user won't be notified 
about the success/failure of the operation)

UPDATE:
The operation is only triggered if there's no other rebalance operation 
running. (This is done by checking the existence of the /system/balancer.id on 
hdfs As per the input from hdfs devs, this check may be misleading if a 
balancer process is killed by an admin, as the file can remain there. - To 
overcome this added a message to explain this behavior)


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
 1dc545e 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 123486e 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 


Diff: https://reviews.apache.org/r/57040/diff/3/


Testing (updated)
---

Manually tested on local unsecure cluster.
Manually tested on local secure cluster

Unit tests successfully ran.


Thanks,

Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57040/
---

(Updated March 3, 2017, 8:16 a.m.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sandor Magyari, 
and Sebastian Toader.


Changes
---

Added check for another balancer running. Added message (to the backgroung 
operation popup) to explain how the command operates.


Bugs: AMBARI-20175
https://issues.apache.org/jira/browse/AMBARI-20175


Repository: ambari


Description (updated)
---

The rebalancing operation may take a long time (hours, days) thus when issued 
from the ambari UI the background operation may time out.
As it's not possible to dynamically predict how long the rebalancing will last 
, the approach taken by this solution is to only trigger the operation and not 
wait to the operation to finish.

(NOTE: after this change the progress of the rebalance operation won't be 
tracked anymore in the background operation; also the user won't be notified 
about the success/failure of the operation)

UPDATE:
The operation is only triggered if there's no other rebalance operation 
running. (This is done by checking the existence of the /system/balancer.id on 
hdfs As per the input from hdfs devs, this check may be misleading if a 
balancer process is killed by an admin, as the file can remain there. - To 
overcome this added a message to explain this behavior)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_rebalance.py
 1dc545e 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 123486e 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py fae500f 


Diff: https://reviews.apache.org/r/57040/diff/3/

Changes: https://reviews.apache.org/r/57040/diff/2-3/


Testing (updated)
---

Manually tested on local unsecure cluster.
Manually tested on local secure cluster

Unit tests running.


Thanks,

Laszlo Puskas