Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179169 ---

Re: Review Request 60516: AMBARI-21371 - Adding ranger failed when user has custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60516/#review179165 --- Ship it! Ship It! - Jaimin Jetly On June 28, 2017, 8:31

Review Request 60516: AMBARI-21371 - Adding ranger failed when user has custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60516/ --- Review request for Ambari, Andrii Babiichuk, Aleksandr Kovalenko, Denys Buzhor,

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

> On June 28, 2017, 10:20 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > > Lines 1416 (patched) > > > > > > Is this a copy of data or adding a

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179163 ---

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

> On June 28, 2017, 8:09 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > > Lines 1416 (patched) > > > > > > This should be

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

> On June 28, 2017, 7:51 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > > Lines 118 (patched) > > > > > > This is missing right,

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179157 ---

Review Request 60514: Use JDK 8 maven compiler plugin for Log Search and Infra projects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60514/ --- Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton,

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/ --- (Updated June 28, 2017, 6:23 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 60509: AMBARI-21368 Update Ambari server rat exclude list with BI AMS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60509/#review179146 --- Ship it! Ship It! - Tim Thorpe On June 28, 2017, 6:03 p.m.,

Re: Review Request 60509: AMBARI-21368 Update Ambari server rat exclude list with BI AMS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60509/#review179144 --- Ship it! Ship It! - Jonathan Hurley On June 28, 2017, 2:03

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179142 ---

Review Request 60509: AMBARI-21368 Update Ambari server rat exclude list with BI AMS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60509/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179141 --- Ship it! Ship It! - Jonathan Hurley On June 28, 2017, 11:16

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote: > > Should this also be put into trunk? We would still need to support this > > moving forward. Maybe we need a Jira to track an actual property which > > governs which database executable to invoke. > > Di Li wrote: > An updated

Re: Review Request 60506: Fix Unit Test Failures Caused by AMBARI-21358

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60506/#review179129 --- Ship it! Ship It! - Sid Wagle On June 28, 2017, 4:47 p.m.,

Review Request 60506: Fix Unit Test Failures Caused by AMBARI-21358

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60506/ --- Review request for Ambari, Alejandro Fernandez and Sid Wagle. Bugs:

Re: Review Request 60501: Create property descriptions for internal Log Search configs

> On June 28, 2017, 4:23 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java > > Lines 47 (patched) > > >

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179125 --- Ship it! Ship It! - Attila Doroszlai On June 28, 2017, 5:16

Re: Review Request 60501: Create property descriptions for internal Log Search configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60501/#review179121 --- Fix it, then Ship it! Patch looks fine to me, other than the

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

> On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java > > Lines 57 (patched) > > > > > > Probably not necessary... you are right,

Re: Review Request 60501: Create property descriptions for internal Log Search configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60501/ --- (Updated June 28, 2017, 3:51 p.m.) Review request for Ambari, Andrii

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

> On June 27, 2017, 2:45 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java > > Lines 72 (patched) > > > > > > Should probably be

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179117 --- Ship it! Ship It! - Tim Thorpe On June 28, 2017, 3:16 p.m.,

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/ --- (Updated June 28, 2017, 3:16 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote: > > Should this also be put into trunk? We would still need to support this > > moving forward. Maybe we need a Jira to track an actual property which > > governs which database executable to invoke. An updated version should be pushed to

Re: Review Request 60501: Create property descriptions for internal Log Search configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60501/ --- (Updated June 28, 2017, 2:51 p.m.) Review request for Ambari, Andrii

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179109 --- Should this also be put into trunk? We would still need to

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179108 --- Ship it! Ship It! - Jonathan Hurley On June 27, 2017, 4:08

Review Request 60501: Create property descriptions for internal Log Search configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60501/ --- Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179104 --- Ship it! Ship It! - Jonathan Hurley On June 28, 2017, 8:27

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/ --- (Updated June 28, 2017, 1:34 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 60488: Ability to delete a view instance from view instance list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60488/#review179098 --- Ship it! Ship It! - Di Li On June 28, 2017, 5:21 a.m.,

Re: Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60489/#review179097 --- Ship it! Ship It! - Di Li On June 28, 2017, 5:23 a.m.,

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179096 --- Ship it! Ship It! - Dmytro Grinenko On June 28, 2017, 12:27

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/ --- (Updated June 28, 2017, 2:27 p.m.) Review request for Ambari, Alejandro

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

> On June 28, 2017, 12:10 p.m., Dmytro Grinenko wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java > > Lines 683 (patched) > > > > > > If we checking here for idempotent

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

> On June 28, 2017, 2:10 p.m., Dmytro Grinenko wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java > > Lines 683 (patched) > > > > > > If we checking here for idempotent

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179091 ---

Re: Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60489/#review179089 --- Ship it! Ship It! - Tim Thorpe On June 28, 2017, 5:23 a.m.,

Re: Review Request 60459: Workflow Manager view build failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/ --- (Updated June 28, 2017, 9:25 a.m.) Review request for Ambari, belliraj hb,

Re: Review Request 60459: Workflow Manager view build failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/ --- (Updated June 28, 2017, 9:15 a.m.) Review request for Ambari, belliraj hb,

Re: Review Request 60459: Workflow Manager view build failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/ --- (Updated June 28, 2017, 9:13 a.m.) Review request for Ambari, belliraj hb,

Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179081 ---

Re: Review Request 60488: Ability to delete a view instance from view instance list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60488/#review179080 --- Ship it! Ship It! - Alexandr Antonenko On June 28, 2017,

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179074 ---