---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54665/#review159194
---
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 13, 2016
es/zkmigrator.py
(line 32)
<https://reviews.apache.org/r/54698/#comment230146>
Can you add Dmitry L. to the review?
This path may have to be prefixed with the home dir for the PERF cluster.
- Alejandro Fernandez
On Dec. 14, 2016, 1:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54747/#review159199
---
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 14, 2016, 3
x27;s perfectly
fine to name the exception anything they want, as opposed to being forced to
name it "ignore".
Same goes for the other checks here. Having a try-catch-finally inside of a
finally block to close a reader/handler is perfectly legitimate java.
- Alejandro Fernande
s good practice, I'm ok with it. Otherwise, it's just busy work
forcing a developer to write something like,
catch (Exception e) {
// Forced to put a comment since ignoring this exception.
}
- Alejandro Fernandez
On Dec. 15
> On Dec. 15, 2016, 5:50 p.m., Alejandro Fernandez wrote:
> > ambari-server/checkstyle.xml, line 33
> > <https://reviews.apache.org/r/54735/diff/4/?file=1585584#file1585584line33>
> >
> > The only one I'm in favor of is "AvoidNestedBlocks".
>
> On Dec. 15, 2016, 5:50 p.m., Alejandro Fernandez wrote:
> > ambari-server/checkstyle.xml, line 33
> > <https://reviews.apache.org/r/54735/diff/4/?file=1585584#file1585584line33>
> >
> > The only one I'm in favor of is "AvoidNestedBlocks".
>
> On Dec. 14, 2016, 6:25 p.m., Alejandro Fernandez wrote:
> > ambari-agent/pom.xml, line 57
> > <https://reviews.apache.org/r/54698/diff/3/?file=1584249#file1584249line57>
> >
> > Can this be moved to another project, say contrib?
> >
> >
54802/diff/
Testing
---
Verified on live cluster.
Thanks,
Alejandro Fernandez
a8ae9
Diff: https://reviews.apache.org/r/54802/diff/
Testing (updated)
---
Verified on live cluster.
The main bug is that
ambari-server/src/main/resources/common-services/YARN/3.0.0/metainfo.xml had
the wrong version (2.1.0.2.0 instead of 3.0.0.3.0)
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54810/#review159477
---
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 16, 2016
/diff/
Testing
---
Thanks,
Alejandro Fernandez
PRE-CREATION
Diff: https://reviews.apache.org/r/54871/diff/
Testing
---
Ran python unit tests
Thanks,
Alejandro Fernandez
g/r/54871/#comment230663>
This was a duplicate config, its value should be "authentication"
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml
<https://reviews.apache.org/r/54871/#comment230664>
Remove dup configs.
- Alejandro
, 2016, 5:18 p.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54866/
> ---
>
> (Updated Dec. 19, 2016, 5:1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54822/#review159840
---
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 20, 2016, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55043/#review160129
---
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 26, 2016
/entities/HostComponentStateEntity.java
(line 73)
<https://reviews.apache.org/r/55207/#comment231746>
What should the behavior be if the record has a version of NONE? No
comparison will happen.
- Alejandro Fernandez
On Jan. 5, 2017, 6:37 p.m., Nate Cole
/package/scripts/service_check.py
(line 40)
<https://reviews.apache.org/r/55009/#comment231756>
Do these changes also need to be made for HDFS 3.0.0.3.0 ?
- Alejandro Fernandez
On Jan. 3, 2017, 6:09 a.m., Weiwei Yang
6f60206
Diff: https://reviews.apache.org/r/55244/diff/
Testing
---
mvn checkstyle:checkstyle
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55244/#review160712
-------
On Jan. 6, 2017, 1:25 a.m., Alejandro Fernandez wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55230/#review160737
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 6, 2017, 2
/configuration/oozie-site.xml
(line 22)
<https://reviews.apache.org/r/54970/#comment231938>
HDP 2.5 and higher use Oozie 4.2.0.2.5
What should happen during EU/RU to HDP 2.5 or 2.6?
Should this config value change?
- Alejandro Fernandez
On Dec. 24, 2016, 7:12 a.m., pin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55260/#review160742
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 6, 2017, 9
s.version IS NONE OR hcs.version !=
:version)"
- Alejandro Fernandez
On Jan. 5, 2017, 6:37 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To repl
-site.xml
01c3b47
ambari-server/src/main/resources/stacks/HDP/3.0/role_command_order.json
PRE-CREATION
Diff: https://reviews.apache.org/r/54871/diff/
Testing
---
Ran python unit tests
Thanks,
Alejandro Fernandez
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55231/#review160783
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 5, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/#review160786
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 5, 2017, 6
run:1157
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
(line 549)
<https://reviews.apache.org/r/55293/#comment232022>
Right now, each Service Advisor class requires a very specific name. We can
do much better at finding the right class to use.
- Alejandro Fernandez
On Jan. 7, 2017, 1:36 a.m., Al
props since EU/RU will add
them.
- Alejandro Fernandez
On Jan. 9, 2017, 2:08 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
ot;*={{spark_conf_dir}}"?
If the answer is keep their current value, then no change needed.
If it must force it to "*={{spark_conf_dir}}", then this will also require
a change in the EU/RU upgrade packs to set the config value.
- Alejandro Fernandez
On Dec.
and Ship it
- Alejandro Fernandez
On Jan. 3, 2017, 6:09 a.m., Weiwei Yang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46268/#review161095
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 10, 2017, 1
> On Jan. 9, 2017, 7:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> > line 22
> > <https://reviews.apache.org/r/54970/diff/3/?file=1591716#file1591716line22>
> >
> &g
views.apache.org/r/55369/
> ---
>
> (Updated Jan. 10, 2017, 5:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver
> Szabo, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-19415
> https://issues.apache.org/jira/browse/AM
logy?
I want to understand the root cause first.
- Alejandro Fernandez
On Jan. 10, 2017, 7 p.m., Di Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
/package/scripts/service_check.py
(line 37)
<https://reviews.apache.org/r/55382/#comment232390>
Why is this iterating over every atlas host? On a large cluster, this would
not be good.
Shouldn't this be the server?
- Alejandro Fernandez
On Jan. 10, 2017, 3:54 p.m., Vis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55009/#review161285
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 10, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review161286
---
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 24, 2016, 7
-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
(line 126)
<https://reviews.apache.org/r/55007/#comment232519>
Extra closing parenthesis.
- Alejandro Fernandez
On Dec. 23, 2016, 5:23 a.m., Vishal Suvagia wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55432/#review161294
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 11, 2017, 8
t want this to cause failures
for features like Rolling Upgrade.
- Alejandro Fernandez
On Jan. 10, 2017, 3:54 p.m., Vishal Suvagia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
/resource_management/libraries/script/script.py
(line 112)
<https://reviews.apache.org/r/55016/#comment232533>
I prefer to move imports like this to the top of the file
- Alejandro Fernandez
On Jan. 11, 2017, 10:40 a.m., Attila Doroszlai
/resource_management/libraries/script/script.py
(line 112)
<https://reviews.apache.org/r/55016/#comment232535>
Can you add a quick comment for that?
Things like that are not obvious, especially if someone else has to look at
the code or refactor.
- Alejandro Fernandez
On Jan. 11, 20
> On Jan. 11, 2017, 9:24 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py,
> > line 37
> > <https://reviews.apache.org/r/55382/diff/1/?file=1601257#file1601257line37>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55016/#review161333
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 11, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55423/#review161402
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 11, 2017, 1
h the stale-config indicator?
- Alejandro Fernandez
On Jan. 12, 2017, 1:58 p.m., Vishal Suvagia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55016/#review161441
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 12, 2017, 9
branch-2.5, commit 06e88d39d718ce02bd8559a1c52a7b62e9726275
- Alejandro Fernandez
On Dec. 14, 2016, 1:26 p.m., Vishal Suvagia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
(line 234)
<https://reviews.apache.org/r/55478/#comment232720>
Does this need to check the number of capture groups?
- Alejandro Fernandez
On Jan. 12, 2017, 11:19 p.m., Madhuvanthi Radhakrishnan
/HDP/2.6/services/SPARK/configuration/livy-conf.xml
(line 79)
<https://reviews.apache.org/r/55486/#comment232849>
This a new stack, please everywhere
- Alejandro Fernandez
On Jan. 13, 2017, 9:52 a.m., Jeff Zhang
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> > line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> > line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161594
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 13, 2017, 3
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py,
> > line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
passed.
Total run:1157
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
04>
This method was moved from HDP 2.0.6 stack advisor to the default stack
advisor.
ambari-server/src/main/resources/stacks/stack_advisor.py (line 1052)
<https://reviews.apache.org/r/55529/#comment232905>
New method.
- Alejandro Fernandez
On Jan
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
>
> (Updated Jan. 13, 2017, 7:03 p.m.)
>
>
> Review request for Amba
064>
Nice!
ambari-server/src/main/resources/stacks/PERF/install_packages.py (line 41)
<https://reviews.apache.org/r/55515/#comment233060>
How much of this was copied from the one in HDP?
Can we derive both from a base class?
- Alejandro Fernandez
On Jan. 13, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55504/#review161771
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 13, 2017, 4
)
<https://reviews.apache.org/r/6/#comment233071>
Can this come from metainfo instead of being hardcoded on the UI?
Please add Jaimin Jetly for input.
- Alejandro Fernandez
On Jan. 16, 2017, 2:32 p.m., alice alice
f9fb1f5
Diff: https://reviews.apache.org/r/55529/diff/
Testing
---
Verified recommendation and validation of HDFS while deploying HDP 3.0
Python unit tests passed.
Total run:1157
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
ces in
behavior
* Abstract knowledge of the web-layer having to know about Hadoop
I think the 2nd approach is more consistent with the rest of Ambari.
- Alejandro Fernandez
On Jan. 17, 2017, 2:12 a.m., alice alice wrote:
>
> -
he end, and during PREPEND that it doesn't already exist at
the beginning.
This should help in cases where the existing config value may already
contain in, and to make this idempotent.
- Alejandro Fernandez
On Jan. 17, 2017, 2:54 a.m., Jonat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55597/#review161920
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 17, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55634/#review161927
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 17, 2017, 7
/kerberos.json
(line 26)
<https://reviews.apache.org/r/55129/#comment233219>
This is essentially changing the config name.
What should happen to existing clusters already Kerberized?
Should the propery be renamed?
- Alejandro Fernandez
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55642/#review161948
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 17, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55647/#review161999
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 17, 2017
> On Jan. 17, 2017, 7:09 p.m., Alejandro Fernandez wrote:
> > ambari-web/app/models/stack_service_component.js, line 200
> > <https://reviews.apache.org/r/6/diff/1/?file=1605673#file1605673line200>
> >
> > The standard is to provide that information in t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6/#review162154
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 18, 2017, 6
/configuration/hadoop-env.xml
(line 238)
<https://reviews.apache.org/r/53213/#comment233408>
This annotation is missing in HDFS 3.0.0.3.0, YARN 3.0.0.3.0, and ZK 3.4.9
- Alejandro Fernandez
On Jan. 12, 2017, 12:33 a.m., Amruta Borkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55663/#review162175
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 18, 2017, 5
- Alejandro Fernandez
On Jan. 14, 2017, 12:51 a.m., Jeff Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Jan. 18, 2017, 6:45 p.m., Alejandro Fernandez wrote:
> > Ship It!
Correction, this is only intended for 2.5 and trunk (3.0)
- Alejandro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
branch-2.5, commit fa6bbfff68c7f6a61e890b04e70577c5890ec94b
- Alejandro Fernandez
On Jan. 18, 2017, 6:01 a.m., alice alice wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162329
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 19, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/#review162334
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 19, 2017, 7
-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml
(line 75)
<https://reviews.apache.org/r/53213/#comment233680>
This is also needed in ZK 3.4.9
- Alejandro Fernandez
On Jan. 19, 2017, 6:16 p.m., Amruta Borkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55663/#review162336
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 18, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55733/#review162364
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 19, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162365
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 19, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55692/#review162367
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 19, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55737/#review162370
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 20, 2017
-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml
(line 22)
<https://reviews.apache.org/r/55765/#comment233792>
Please also change HDFS 3.0.0.3.0 and YARN 3.0.0.3.0 in common-services.
- Alejandro Fernandez
On Jan. 20, 2017, 2:05 p.m., Andrii Tkach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55774/#review162465
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 20, 2017, 4
/configuration/hdfs-log4j.xml
(line 56)
<https://reviews.apache.org/r/55590/#comment233797>
Please also modify HDFS 3.0.0.3.0 in common services, before-START hook for
HDP 3.0
Will this Jira address changing these values during an EU/RU?
- Alejandro Fernandez
On Jan. 20, 2
)
<https://reviews.apache.org/r/55775/#comment233798>
Why does this need to be so high?
What's the root cause of failures?
- Alejandro Fernandez
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
/configuration/hdfs-log4j.xml
(line 24)
<https://reviews.apache.org/r/54760/#comment233801>
We need to make the same changes for HDFS 3.0.0.3.0 and the hooks in HDP
3.0.
- Alejandro Fernandez
On Dec. 20, 2016, 10 p.m., Madhuvanthi Radhakrishnan
> On Jan. 20, 2017, 7:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 106
> > <https://reviews.apache.org/r/55775/diff/1/?file=1610796#file1610796line106>
> >
> > Why does this need to be so high?
> >
> On Jan. 20, 2017, 7:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 106
> > <https://reviews.apache.org/r/55775/diff/1/?file=1610796#file1610796line106>
> >
> > Why does this need to be so high?
> >
branch-2.5, commit 6ab074be3b8fde6694f2b0aacef17b8939b48bdd
- Alejandro Fernandez
On Jan. 19, 2017, 6:16 p.m., Amruta Borkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55814/#review162678
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 21, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/#review162681
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 23, 2017, 1
/2.3/ATLAS/test_metadata_server.py (line 35)
<https://reviews.apache.org/r/55505/#comment234026>
Even in unit tests, don't hardcode /usr/hdp/
- Alejandro Fernandez
On Jan. 13, 2017, 4:46 p.m., Vishal Suvagia wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55680/#review162685
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 20, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55854/#review162701
---
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 23, 2017, 8
tps://reviews.apache.org/r/55859/#comment234043>
Why is this all of a sudden failing now?
Weren't we testing on Ubuntu 16 before?
- Alejandro Fernandez
On Jan. 23, 2017, 10:16 p.m., Vitalyi Brodetskyi wrote:
>
> ---
901 - 1000 of 1678 matches
Mail list logo
