ripts) or adding
unnecessary properties to existing configuration xml files.
- Di
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55460/#review161381
---
Ship it!
Ship It!
- Di Li
On Jan. 12, 2017, 1:28 p.m., Tim
> On Jan. 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!
>
> ping wang wrote:
> Hi Di, could you please help commit the code? Thanks!
Done. Please close this RB request.
- Di
---
This is an automatically generate
05cbe
Diff: https://reviews.apache.org/r/55387/diff/
Testing
---
existing unit test
build Ambari RPMS off trunk code and install a cluster.
Thanks,
Di Li
> > -1. If the config doesn't exist at all, that's a problem and we
> > shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing
> > knoxsso-topology?
> >
> > I want to understand the root
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55518/#review161597
---
Ship it!
Ship It!
- Di Li
On Jan. 13, 2017, 7:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55522/#review161599
---
Ship it!
Ship It!
- Di Li
On Jan. 13, 2017, 9:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55523/#review161730
---
Ship it!
Ship It!
- Di Li
On Jan. 13, 2017, 9:43 p.m
/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
23a25a0
Diff: https://reviews.apache.org/r/55584/diff/
Testing
---
existing unit tests
build rpms off trunk source code and deploy a cluster.
Thanks,
Di Li
delivered to trunk ?
- Di Li
On Dec. 22, 2016, 8:59 p.m., Diego Santesteban wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55516/#review161901
---
Ship it!
Ship It!
- Di Li
On Jan. 17, 2017, 5:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162146
---
Ship it!
Ship It!
- Di Li
On Jan. 12, 2017, 12:33 a.m
Diff: https://reviews.apache.org/r/55720/diff/
Testing
---
existing unit test
patch trunk code build ambari rpms and install a trunk cluster
Thanks,
Di Li
/55774/diff/
Testing
---
existing unit tests
build ambari rpms with trunk code, install a trunk cluster.
Thanks,
Di Li
n the upgrade wizard is
opened and paused at a menu step.
existing web UI unit tests.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162648
---
Ship it!
Ship It!
- Di Li
On Jan. 20, 2017, 11:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review162649
---
Please add Nate Cole for the review.
- Di Li
On Jan. 20, 2017
nalize the upgrade.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55586/#review162664
---
Ship it!
Ship It!
- Di Li
On Jan. 23, 2017, 5:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55310/#review162848
---
Ship it!
Ship It!
- Di Li
On Jan. 24, 2017, 7:50 p.m., Shi
"IN_PROGESS". then be able to click the finalize and finalize the upgrade.
Thanks,
Di Li
HUB_AMBARI as my ambari repo id.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55935/#review163131
---
Ship it!
Ship It!
- Di Li
On Jan. 25, 2017, 8:58 p.m
Client Conf"
Diffs
-
ambari-web/app/utils/helper.js 927f8a6
ambari-web/test/utils/helper_test.js b438a7a
Diff: https://reviews.apache.org/r/55990/diff/
Testing
---
unit tests
patch a trunk cluster with the change, the label showed up on the UI correctly
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55992/#review163164
---
Ship it!
Ship It!
- Di Li
On Jan. 26, 2017, 7:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55993/#review163165
---
Ship it!
Ship It!
- Di Li
On Jan. 26, 2017, 7:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56051/#review163523
---
Ship it!
Ship It!
- Di Li
On Jan. 28, 2017, 8:32 a.m
---
patched a cluster with the change, run preinstall_check.py script
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164118
---
Ship it!
Ship It!
- Di Li
On Feb. 2, 2017, 8:01 p.m
> On Feb. 3, 2017, 1:28 p.m., Di Li wrote:
> > Ship It!
pushed to trunk as
https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=ecfc951b5c8589b9225684c3ad2660cdb4ef4445
- Di
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56503/#review164987
---
Ship it!
Ship It!
- Di Li
On Feb. 9, 2017, 6:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165564
---
Ship it!
Ship It!
- Di Li
On Feb. 14, 2017, 3 a.m., Yuanbo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56627/#review165566
---
Ship it!
Ship It!
- Di Li
On Feb. 14, 2017, 12:37 a.m
the proper
branch for the fix.
- Di Li
On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Feb. 17, 2017, 1:46 p.m., Di Li wrote:
> > Hello Yuan Bo, Please add JIRA ID to the Bugs field and specify the proper
> > branch for the fix.
nm branch, just the JIRA ID
- Di
---
This is an automatically gener
> On Feb. 14, 2017, 8 p.m., Di Li wrote:
> > Ship It!
pushed to trunk as
https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=9e5c57e3e7ae4a8b3df51efcbddcdb97a1f7b398
Yuanbo, please close this rb request.
- Di
--
A1
A2
UI code needs updates accordingly.
- Di Li
On Feb. 22, 2017, 1:52 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
> On Feb. 22, 2017, 9:21 p.m., Di Li wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml,
> > line 109
> > <https://reviews.apache.org/r/55817/diff/3/?file=1641784#file1641784line109>
> >
> > Hello Yao,
> >
check host operation submitted by the Ambari web UI during Host
registration step.
Current behavior is a hard fail, but I think it's still the correct
behavior nontheless.
- Di Li
On Feb. 25, 2017, 3 a.m., Amruta Borkar wrote:
>
>
/VersionUtils.java
d3d8592
ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java
821565e
Diff: https://reviews.apache.org/r/57146/diff/
Testing
---
existing unit tests, new unit tests, trunk cluster install
Thanks,
Di Li
ows.xml
Lines 44 (patched)
<https://reviews.apache.org/r/57168/#comment239412>
please refer to my comments about not shipping empty files
ambari-server/src/main/assemblies/server.xml
Lines 257 (patched)
<https://reviews.apache.org/r/57168/#comment239411>
please refer to my comm
e replaced by spaces. You can set that in Eclipse as a general
setting.
- Di Li
On March 2, 2017, 1:05 a.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57297/#review168042
---
Ship it!
Ship It!
- Di Li
On March 3, 2017, 6:59 p.m
(patched)
<https://reviews.apache.org/r/57168/#comment240090>
The for loop should not run anyway when propertiesToHideInResponse is empty.
- Di Li
On March 3, 2017, 8:47 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically ge
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168163
---
Ship it!
Ship It!
- Di Li
On March 6, 2017, 10:45 p.m
nonrolling-upgrade-2.6.xml
a1bf456
Diff: https://reviews.apache.org/r/57419/diff/1/
Testing
---
patch trunk cluster, run EU and RU, verify the messages are shown as sections
instead of one long paragraph.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57429/#review168330
---
Ship it!
Ship It!
- Di Li
On March 8, 2017, 7:45 p.m
/upgrades/upgrade-2.6.xml
10ae959
Diff: https://reviews.apache.org/r/57463/diff/1/
Testing
---
patched a trunk cluster run RU, verify messages were shown in sections.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57346/#review168483
---
Ship it!
Ship It!
- Di Li
On March 8, 2017, 11:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57467/#review168484
---
Ship it!
Ship It!
- Di Li
On March 9, 2017, 5:24 p.m
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml
10ae959
Diff: https://reviews.apache.org/r/57463/diff/2/
Changes: https://reviews.apache.org/r/57463/diff/1-2/
Testing
---
patched a trunk cluster run RU, verify messages were shown in sections.
Thanks,
Di Li
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml
cb163e4
Diff: https://reviews.apache.org/r/57463/diff/3/
Changes: https://reviews.apache.org/r/57463/diff/2-3/
Testing
---
patched a trunk cluster run RU, verify messages were shown in sections.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57525/#review168785
---
Ship it!
Ship It!
- Di Li
On March 11, 2017, 12:41 a.m
nfigs/default.json fa7419f
Diff: https://reviews.apache.org/r/57579/diff/1/
Testing
---
unit tests
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57563/#review168852
---
Ship it!
Ship It!
- Di Li
On March 13, 2017, 5:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57610/#review169093
---
Ship it!
Ship It!
- Di Li
On March 14, 2017, 5:21 p.m
code, run
ambari upgrade, verify override_uid is set to false in cluster-env, so that
UIDs that I already set on my cluster are respected.
Thanks,
Di Li
, are created when WEBHDFS is disabled.
Thanks,
Di Li
e-mail. To reply, visit:
https://reviews.apache.org/r/57686/#review169144
-------
On March 16, 2017, 12:47 p.m., Di Li wrote:
>
> ---
> This is an aut
---
build fast-hdfs-resource jar, patch a trunk cluster with the new jar, verify
the dirs , such as /mapred, are created when WEBHDFS is disabled.
Thanks,
Di Li
eviews.apache.org/r/57579/#review169034
-------
On March 17, 2017, 12:53 p.m., Di Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57579/
> ---
2.0.6/configs/default.json fa7419f
Diff: https://reviews.apache.org/r/57579/diff/2/
Changes: https://reviews.apache.org/r/57579/diff/1-2/
Testing
---
unit tests
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169286
---
Ship it!
Ship It!
- Di Li
On March 16, 2017, 10:40 p.m
,
Di Li
ect it.
Thanks.
Di
- Di
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57674/#review169742
---
On March 16, 2017, 2:15 a.m., Di
with my custom stack where HBase does
not have override_hbase_uid property. build Ambari rpm from trunk code, run
ambari upgrade, verify override_uid is set to false in cluster-env, so that
UIDs that I already set on my cluster are respected.
Thanks,
Di Li
---
unit tests
install Ambari 2.2.0 cluster with my own stack, build trunk Ambari RPMs with my
fix then upgrade, verify service check can run successfully when my stack has
services that do not have conf types (directly and via inheritance)
Thanks,
Di Li
fix then upgrade, verify service check can run successfully when my stack has
services that do not have conf types (directly and via inheritance)
Thanks,
Di Li
, build trunk Ambari RPMs with my
fix then upgrade, verify service check can run successfully when my stack has
services that do not have conf types (directly and via inheritance)
Thanks,
Di Li
---
unit tests
patch Ambari trunk cluster, update upgrade.xml to include for example YARN as a
removed service, run EU/RU, verify precheck fails and couldn't proceed
(expected)
Thanks,
Di Li
/
Testing
---
unit tests
install Ambari 2.2.0 cluster with my own stack, build trunk Ambari RPMs with my
fix then upgrade, verify service check can run successfully when my stack has
services that do not have conf types (directly and via inheritance)
Thanks,
Di Li
2.0.6/configs/default.json fa7419f
Diff: https://reviews.apache.org/r/57579/diff/3/
Changes: https://reviews.apache.org/r/57579/diff/2-3/
Testing
---
unit tests
Thanks,
Di Li
---
unit tests
install Ambari 2.2.0 cluster with my own stack, build trunk Ambari RPMs with my
fix then upgrade, verify service check can run successfully when my stack has
services that do not have conf types (directly and via inheritance)
Thanks,
Di Li
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58002/#review170340
---
On March 28, 2017, 8:04 p.m., Di Li wrote:
>
> -
a
Line 21 (original), 21 (patched)
<https://reviews.apache.org/r/57563/#comment243749>
why change the junit classes imported ?
- Di Li
On April 3, 2017, 4:42 p.m., Amruta Borkar wrote:
>
> ---
> This is an automatically
/internal/BlueprintConfigurationProcessor.java
Lines 522 (patched)
<https://reviews.apache.org/r/58122/#comment243752>
nitpicking a little, use String.format instead of concating strings.
- Di Li
On March 31, 2017, 11:05 p.m., Amruta Borkar
> On April 3, 2017, 4:49 p.m., Di Li wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 931 (patched)
> > <https://reviews.apache.org/r/57563/diff/2/?file=1683692#file1683692line931>
&g
/internal/BlueprintConfigurationProcessor.java
Lines 523 (patched)
<https://reviews.apache.org/r/58122/#comment243836>
For performance, please avoid string concatenation, just use a long string
as it is or use a stringbuffer/stringbuilder.
- Di Li
On April 3, 2017, 10:42 p.m., Amruta
ange both
ambari server and UI change, then update metainfo.xml for hbase in common
services (to test inheritance) verify UI does not show Delete service menu item
for HBase after restart Ambari server.
Thanks,
Di Li
Diff: https://reviews.apache.org/r/58211/diff/1/
Testing
---
unit testing
Install a trunk cluster with HDP 2.6 stack.Patch it with the code change both
ambari server and UI change, then update metainfo.xml for hbase in common
services (to test inheritance) verify UI does not show Delete service menu item
for HBase after restart Ambari server.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58122/#review171200
---
Ship it!
Ship It!
- Di Li
On April 5, 2017, 11:45 p.m
following fields ?
Branch: put in Trunk
Bugs: put in your Ambari JIRA id as AMBARI-
- Di Li
On April 6, 2017, 8:51 p.m., Bharat Viswanadham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/#review171333
---
Ship it!
Ship It!
- Di Li
On April 6, 2017, 11:04 p.m
following fields ?
Branch: put in Trunk
Bugs:put in your Ambari JIRA id as AMBARI-
- Di Li
On April 6, 2017, 11:04 p.m., Bharat Viswanadham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58244/#review171367
---
Ship it!
Ship It!
- Di Li
On April 7, 2017, 4:50 p.m
c Repository radio button is
hidden. When at least one repoinfo.xml has the "latest" section, the Use Public
Repository radio button is shown.
Thanks,
Di Li
your JIRA
2. Click Submit Patch button on your JIRA so HadoopQA can run a round of
integration test ?
- Di Li
On April 13, 2017, 4:16 a.m., Yuanbo Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
un Install step before the EU/RU
Thanks,
Di Li
Testing
---
patch a trunk cluster with the change, run Install step before the EU/RU
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/#review171887
---
Ship it!
Ship It!
- Di Li
On April 13, 2017, 3:21 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58152/#review171893
---
Ship it!
Ship It!
- Di Li
On April 13, 2017, 4:20 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58425/#review171902
---
Ship it!
Ship It!
- Di Li
On April 13, 2017, 5:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/#review171909
---
Ship it!
Ship It!
- Di Li
On April 13, 2017, 6:19 p.m., Tim
with the Ambari JIRA ID ,
branch the issue applies, tests done, etc ?
- Di Li
On April 13, 2017, 7:37 p.m., Bharat Viswanadham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58431/#review171929
---
Ship it!
Ship It!
- Di Li
On April 13, 2017, 8:11 p.m
> On April 7, 2017, 12:48 p.m., Di Li wrote:
> > Ship It!
>
> Bharat Viswanadham wrote:
> Hi Di,
> Could you please help in commit these changes.
Please close this request, as it has been pushed to trunk as
https://git-wip-us.apache.org/repos/asf?p=
> On April 7, 2017, 4:57 p.m., Di Li wrote:
> > Ship It!
>
> Bharat Viswanadham wrote:
> Hi Di,
> Could you please help in commit these changes.
Please close this RB request as it has been pushed to trunk as
https://git-wip-us.apache.org/repos/asf?p=
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58409/#review172084
---
Ship it!
Ship It!
- Di Li
On April 13, 2017, 4:16 a.m
> On April 13, 2017, 8:26 p.m., Di Li wrote:
> > Ship It!
>
> Bharat Viswanadham wrote:
> Hi Di,
> Could you please help in commit these changes.
please close this RB request as the change is pushed to trunk as
https://git-wip-us.apache.org/repos/asf?p=
https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=22b114defc43858798f6f20211c0d04b440ee7ce
now.
- Di Li
On April 13, 2017, 4:16 a.m., Yuanbo Liu wrote:
>
> ---
> This is an automatically generated e-mail. To rep
201 - 300 of 452 matches
Mail list logo
