,
Robert Levas
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
/KerberosDescriptorUpdateHelperTest.java
247d17ec09
Diff: https://reviews.apache.org/r/60878/diff/1/
Testing
---
manual tests
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
keep the
user-defined identitiy as-is.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60878/#review180571
------
76859#file1776859line313>
> >
> > Can we document why both stacks (original and new) must contain the key
> > before merging in the user value? It might not be clear from this
> > if-statement.
>
> Robert Levas wrote:
> Acutually, *must* is a strong word here. The bug
]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60861/#review180817
---
Ship it!
Ship It!
- Robert Levas
On July 17, 2017, 7:44 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/#review181112
---
Ship it!
Ship It!
- Robert Levas
On July 21, 2017, 8:21 a.m
ternal/HostResourceProvider.java
Lines 533-536 (patched)
<https://reviews.apache.org/r/61140/#comment257151>
Not a proper JavaDoc comment
- Robert Levas
On July 26, 2017, 11:42 a.m., Sebastian Toader wrote:
>
> ---
> Thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61140/#review181573
---
Ship it!
Ship It!
- Robert Levas
On July 27, 2017, 11:25
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61162/#review181572
---
Ship it!
Ship It!
- Robert Levas
On July 26, 2017, 5:22 p.m
> On July 27, 2017, 3:55 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixAuthToLocalMappingAction.java
> > Lines 36-37 (patched)
> > <https://reviews.apache.org/r/61168/diff/2/?file=1784339#file1784339line3
grades/FixAuthToLocalMappingAction.java
Lines 83 (patched)
<https://reviews.apache.org/r/61168/#comment257193>
Technically there should be no HTTP rule in the auth_to_local rules. This
is not really a user identitiy.
- Robert Levas
On July 27, 2017, 2:58 p.m., Sid
: https://reviews.apache.org/r/61163/diff/1/
Testing
---
Manually tested on CentOS6 and CentOS7.
# Local test results: PENDING
# Jenkins test resilts: PENDING
Thanks,
Robert Levas
)
<https://reviews.apache.org/r/61163/#comment257110>
Version 4.3.0 required GLIBC 2.14, but CentOS6 does not support that.
Changing to Version 4.2.2 allows for GLIBC 2.12, which is supported by Centos6
and Centos7.
- Robert Levas
On July 26, 2017, 5:48 p.m., Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60975/#review180957
---
Ship it!
Ship It!
- Robert Levas
On July 19, 2017, 2:34 p.m
min
[INFO] Finished at: 2017-07-07T07:47:34-04:00
[INFO] Final Memory: 108M/1769M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
: 108M/1769M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
ed)
<https://reviews.apache.org/r/60431/#comment253411>
javadoc
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
Lines 391 (patched)
<https://reviews.apache.org/r/60431/#comment253412>
javadoc
/ServiceRemovedEvent.java
Lines 59 (patched)
<https://reviews.apache.org/r/60637/#comment254441>
This is Java8-specific code. Was it officially declared that Java7 is to
be dropped for Ambari?
- Robert Levas
On July 4, 2017, 11:20 a.m., Attila Magyar
> On July 5, 2017, 11:21 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/ServiceRemovedEvent.java
> > Lines 59 (patched)
> > <https://reviews.apache.org/r/60637/diff/3/?file=1769225#file1769225line65>
> >
&g
> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/60431/diff/5/?file=1763803#file1763803line72>
-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
Lines 33 (patched)
<https://reviews.apache.org/r/60403/#comment254487>
Would it be possible to use
`resource_management.libraries.functions.curl_krb_request.curl_krb_request`
instead?
- Robert Levas
On June 23, 2017, 6:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58735/#review173042
---
Ship it!
Ship It!
- Robert Levas
On April 26, 2017, 9:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58736/#review173044
---
Ship it!
Ship It!
- Robert Levas
On April 26, 2017, 9:49
To reply, visit:
> https://reviews.apache.org/r/58735/
> ---
>
> (Updated April 26, 2017, 9:09 a.m.)
>
>
> Review request for Ambari, Robert Levas and Sandor Magyari.
>
>
> Bugs: AMBARI-20849
> https://is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58657/#review172763
---
Ship it!
Ship It!
- Robert Levas
On April 24, 2017, 3:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58855/#review173379
---
Ship it!
Ship It!
- Robert Levas
On April 28, 2017, 4:41
istent with other Ambari-specific authentication providers. For
example,
`org.apache.ambari.server.security.authorization.AmbariLocalUserProvider`
- Robert Levas
On April 28, 2017, 1:45 p.m., Anita Jebaraj wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58667/#review172787
---
Ship it!
Ship It!
- Robert Levas
On April 24, 2017, 10:45
/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py
Line 47 (original), 48 (patched)
<https://reviews.apache.org/r/58667/#comment245827>
Fix comment to indicate the retry will be using the _forced_ protocol.
- Robert Levas
On April 24, 2017, 10:15 a.m., Eugene Chekanskiy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58814/#review173250
---
Ship it!
Ship It!
- Robert Levas
On April 27, 2017, 3:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61168/#review181676
---
Ship it!
Ship It!
- Robert Levas
On July 28, 2017, 11:28
w this should be done via sudo in the event the agent is not running
as root. Maybe a KeytabFile resource can be created for this? See
`resource_management.core.providers.system.FileProvider` and
`resource_management.core.resources.system.File`.
- Robert Levas
On Aug. 1, 2017, 5:58 a.m.
urce properties. See
`org.apache.ambari.server.api.resources.ClusterResourceDefinition#getUpdateDirectives`.
- Robert Levas
On Aug. 18, 2017, 1:12 p.m., Eugene Chekanskiy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/#review183069
---
Ship it!
Ship It!
- Robert Levas
On Aug. 16, 2017, 4:47 p.m
] Finished at: 2017-08-16T15:38:34-04:00
[INFO] Final Memory: 106M/1721M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
. :(
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173631
---
On May 2, 2017, 3:09 p.m., Rob
> On May 2, 2017, 4:11 p.m., Attila Doroszlai wrote:
> > FYI see https://reviews.apache.org/r/58840/ for a way to smoke-test the
> > SQLServer DB script using Docker.
>
> Robert Levas wrote:
> Attila, thanks for the link. However I am having difficulty getting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173790
---
Ship it!
Ship It!
- Robert Levas
On May 3, 2017, 2:24 p.m
occur.
For example:
```
UserEntitiy foundUser = userDAO.findUserByName(username)'
if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
... Fail ...
}
```
- Robert Levas
On May 3, 2017, 12:48 p.m., Anita
--------
On May 3, 2017, 4:15 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58929/
> --
sgress, MySQL, MS SQL Server, and Derby.
_I have no way to test creating Oracle and SQL Anywhere databases._
Thanks,
Robert Levas
;
> Jonathan Hurley wrote:
> Or maybe consecutive_failures
done.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173633
-----
;attempts"
Renamed to `consecutive_failures`.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173629
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review173630
-------
On May 3, 2017, 4:15 p.m., Robert Levas wrote:
>
> -
hanges: https://reviews.apache.org/r/58929/diff/1-2/
Testing
---
Tested creating new databases using Posgress, MySQL, and Derby.
_I have no way to test creating Oracle, MS SQL, and SQL Anywhere databases._
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review174910
---
Ship it!
Ship It!
- Robert Levas
On May 13, 2017, 4:56 p.m
and Java 1.8 using both trusing and non-trusting
SSL sockets to ensure expected behavior.
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
]
[INFO] Total time: 26:12 min
[INFO] Finished at: 2017-05-09T12:37:05-04:00
[INFO] Final Memory: 76M/582M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
ges: https://reviews.apache.org/r/59338/diff/1-2/
Testing
---
Manually tested upgrades from Ambari 2.4.0 to Ambari 2.5.1, and from Ambari
2.5.0 to Ambari 2.5.1
#Local test results: PENDING
#Jenkins test results: PENDING
Thanks,
Robert Levas
: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review174316
---
Ship it!
Ship It!
- Robert Levas
On May 9, 2017, 5:38 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/#review174319
---
Ship it!
Ship It!
- Robert Levas
On May 9, 2017, 5:49 a.m
`wwwAuthHeader` shouldn't be `null`, but if it is, this will probably throw
an NPE.
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
Lines 111 (patched)
<https://reviews.apache.org/r/59149/#comment248078>
This should be removed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/#review177609
---
Ship it!
Ship It!
- Robert Levas
On June 12, 2017, 8:44 a.m
]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
/#comment251145>
This will be handled in AMBARI-21216
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java
Line 45 (original), 47 (patched)
<https://reviews.apache.org/r/59956/#comment251146>
This wil
eply, visit:
https://reviews.apache.org/r/59956/#review177610
-------
On June 9, 2017, 5:17 p.m., Robert Levas wrote:
>
> ---
> This is an automatically g
ng code and I am reluctant to change it.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59956/#review177610
---------
] Finished at: 2017-06-09T17:05:32-04:00
[INFO] Final Memory: 209M/1768M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
think cascading should be removed here (AFAIK there were some issues
> > where cascading was interfering with some DAO logic)
>
> Robert Levas wrote:
> Cascade seems to be used a few lines up in this file...
> ```
> @OneToMany(mappedBy = "user", casca
]
[INFO] Total time: 29:50 min
[INFO] Finished at: 2017-06-21T15:43:10-04:00
[INFO] Final Memory: 86M/1822M
[INFO]
```
#Jasper test results: PENDING
Thanks,
Robert
]
```
#Jasper test results: PENDING
Thanks,
Robert Levas
le1753553line1349>
> >
> > Shouldn't use optimistic locking here as well?
Nice call.. thanks. Exception should be handled here as well. Thanks for
catching that.
- Robert
---
This is an automatically generated e-mail. To
]
```
#Jasper test results: PENDING
Thanks,
Robert Levas
/1760M
[INFO]
```
#Jasper test results: PENDING
Thanks,
Robert Levas
it contains the latest data... so a _refresh_ is
needed.
- Robert Levas
On June 19, 2017, 4:26 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59701/#review178795
---
Ship it!
Ship It!
- Robert Levas
On June 23, 2017, 9:04 a.m
]
```
#Jasper test results: PENDING
Thanks,
Robert Levas
/configuration/Configuration.java
Lines 351-356 (patched)
<https://reviews.apache.org/r/59503/#comment249265>
Is this necessary? It seems like the option is only releated to setup, not
for normal runtime.
- Robert Levas
On May 23, 2017, 7:26 p.m., Anita Jebaraj
> On May 24, 2017, 9:51 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 351-356 (patched)
> > <https://reviews.apache.org/r/59503/diff/2/?file=1730906#file1730906line351>
> >
> >
to create (and possibly update) Ambari
user accounts while by-passing needed authorization checks.
- Robert Levas
On May 23, 2017, 7:26 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
apache/ambari/server/controller/CreateUserHelperTest.java
Lines 36-39 (patched)
<https://reviews.apache.org/r/59503/#comment249552>
This is not testing anything.
- Robert Levas
On May 24, 2017, 4:40 p.m., Anita Jebaraj wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59612/#review176224
---
Ship it!
Ship It!
- Robert Levas
On May 26, 2017, 4:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59613/#review176253
---
Ship it!
Ship It!
- Robert Levas
On May 26, 2017, 5:22 p.m
e risk of collisions since names do not need
to be unique, but _paths_ do.
For example:
`resource_manager_rm` -> `/YARN/RESOURCEMANAGER/resource_manager_rm`
`smokeuser` --> `/smokeuser'
- Robert Levas
On May 29, 2017, 9:53 a.m., Attila
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59637/#review176310
---
Ship it!
Ship It!
- Robert Levas
On May 30, 2017, 11:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59520/#review176301
---
Ship it!
Ship It!
- Robert Levas
On May 30, 2017, 9:15 a.m
> On May 26, 2017, 10:57 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Line 350 (original), 350-356 (patched)
> > <https://reviews.apache.org/r/59503/diff/3/?file=1731981#file1731981line350>
&g
/CreateUserHelperTest.java
Lines 49 (patched)
<https://reviews.apache.org/r/59503/#comment250470>
Add a test case testing that a user will not be created if an admin user
already exists.
- Robert Levas
On June 1, 2017, 2:08 a.m., Anita Jebaraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59701/#review177045
---
Ship it!
Ship It!
- Robert Levas
On June 1, 2017, 1:04 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review177998
---
Ship it!
Ship It!
- Robert Levas
On June 15, 2017, 7:53 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60131/#review178034
---
Ship it!
Ship It!
- Robert Levas
On June 15, 2017, 3:38 p.m
/org/apache/ambari/server/controller/AuthToLocalBuilder.java
Lines 671 (patched)
<https://reviews.apache.org/r/60048/#comment251600>
The naming convention is to use the plural form of this... `COMMAS`.
- Robert Levas
On June 13, 2017, 9:18 a.m., Eugene Chekanskiy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60047/#review177904
---
Ship it!
Ship It!
- Robert Levas
On June 13, 2017, 8:42 a.m
ne 276 (original), 276 (patched)
<https://reviews.apache.org/r/60033/#comment251592>
Request order is being lost. Could this cause an issue?
- Robert Levas
On June 13, 2017, 12:43 a.m., Sebastian
> On June 14, 2017, 10:54 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
> > Line 949 (original), 950 (patched)
> > <https://reviews.apache.org/r/60033/diff/1/?file=1749561#file1749561line950>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59954/#review177900
---
Ship it!
Ship It!
- Robert Levas
On June 13, 2017, 10:44
ps://reviews.apache.org/r/59956/#review177734
-------
On June 12, 2017, 1:15 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail.
ews.apache.org/r/59956/diff/2/?file=1748770#file1748770line98>
> >
> > Are these all nullable? The default when not specified is true.
`consecutive_failures` is not nullable, but the others are. Fixing.
- Robert
---
This i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60081/#review177897
---
Ship it!
Ship It!
- Robert Levas
On June 14, 2017, 8:37 a.m
Memory: 209M/1768M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
think cascading should be removed here (AFAIK there were some issues
> > where cascading was interfering with some DAO logic)
>
> Robert Levas wrote:
> Cascade seems to be used a few lines up in this file...
> ```
> @OneToMany(mappedBy = "user", casca
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60130/#review178096
---
Ship it!
Ship It!
- Robert Levas
On June 15, 2017, 4:08 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60153/#review178105
---
Ship it!
Ship It!
- Robert Levas
On June 16, 2017, 8:40 a.m
/
Testing
---
Manually tested
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173498
---
Ship it!
Ship It!
- Robert Levas
On May 1, 2017, 4 p.m
> On May 1, 2017, 4:09 p.m., Robert Levas wrote:
> > Ship It!
>
> Anita Jebaraj wrote:
> Thank you Robert, can you please help in pushing the changes
Sure. On it now.
- Robert
---
This is an automaticall
601 - 700 of 836 matches
Mail list logo
