---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61050/#review181145
---
Ship it!
Ship It!
- Tim Thorpe
On July 21, 2017, 8:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61039/#review181125
---
Ship it!
Ship It!
- Tim Thorpe
On July 21, 2017, 4:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60509/#review179146
---
Ship it!
Ship It!
- Tim Thorpe
On June 28, 2017, 6:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60537/#review179262
---
Ship it!
Ship It!
- Tim Thorpe
On June 29, 2017, 1:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60574/#review179402
---
Ship it!
Ship It!
- Tim Thorpe
On June 30, 2017, 7:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60489/#review179089
---
Ship it!
Ship It!
- Tim Thorpe
On June 28, 2017, 5:23 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179117
---
Ship it!
Ship It!
- Tim Thorpe
On June 28, 2017, 3:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179055
---
Ship it!
Ship It!
- Tim Thorpe
On June 27, 2017, 8:08 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179056
---
Ship it!
Ship It!
- Tim Thorpe
On June 27, 2017, 9:02 p.m
/hdfs/ConfigurationBuilder.java
Lines 270 (patched)
<https://reviews.apache.org/r/58480/#comment246134>
!StringUtils.isEmpty(namenodeIDs) should be enough. That will check
whether the string is null or empty.
- Tim Thorpe
On April 20, 2017, 8:53 p.m., Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58480/#review173090
---
Ship it!
Ship It!
- Tim Thorpe
On April 26, 2017, 8:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173354
---
Ship it!
Ship It!
- Tim Thorpe
On April 28, 2017, 5:45 p.m
To reply, visit:
https://reviews.apache.org/r/58845/#review173348
-----------
On April 28, 2017, 5:48 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172780
---
Ship it!
Ship It!
- Tim Thorpe
On April 24, 2017, 12:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172840
---
Ship it!
Ship It!
- Tim Thorpe
On April 24, 2017, 7:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172908
---
Ship it!
Ship It!
- Tim Thorpe
On April 25, 2017, 4:51 a.m
/HDP/0.3/services/ZOOKEEPER/metainfo.xml
PRE-CREATION
Diff: https://reviews.apache.org/r/58845/diff/1/
Testing
---
mvn clean test
mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61377/#review181990
---
Ship it!
Ship It!
- Tim Thorpe
On Aug. 2, 2017, 1:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61371/#review181982
---
Ship it!
Ship It!
- Tim Thorpe
On Aug. 2, 2017, 1:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61415/#review182199
---
Ship it!
Ship It!
- Tim Thorpe
On Aug. 3, 2017, 8:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61813/#review183480
---
Ship it!
Ship It!
- Tim Thorpe
On Aug. 22, 2017, 1:42 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58968/#review173791
---
Ship it!
Ship It!
- Tim Thorpe
On May 3, 2017, 6:24 p.m
t:
> https://reviews.apache.org/r/58968/
> -------
>
> (Updated May 3, 2017, 4:48 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim
> Thorpe.
>
>
> Bugs: AMBARI-20909
>
Entitiy foundUser = userDAO.findUserByName(username)'
> > if((foundUser != null) && (foundUser.getUserType != UserType.PAM)) {
> > ... Fail ...
> > }
> > ```
>
> Tim Thorpe wrote:
> Hi Robert, I'm not sure I'm following your logic here. M
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/#review174676
---
On May 9, 2017, 2:39 p.m., Tim Thorpe wrote:
>
> ---
> > hdfs-site
> > dfs.nameservices
> >
> >
> >
> >
>
> Tim Thorpe wrote:
> I'm not exactly sure what your worry is here. Adding this new section
> seems like duplication of the
Thanks,
Tim Thorpe
How do we capture this dependency only when HA is enabled?
>
> Tim Thorpe wrote:
> There are several options:
>
> 1) We don't. The UI already has an explicit check for ZOOKEEPER when
> attempting to enable NameNode HA. This is the option I implemented.
elies on HDFS's dependency on ZOOKEEPER.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/#review174341
-------
On M
to enable NameNode
HA. This is prevented with the same error you'd see if ZooKeeper was enabled
but you had fewer than 3 ZooKeeper servers configured.
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/#review174844
---
Ship it!
Ship It!
- Tim Thorpe
On May 12, 2017, 7:43 p.m
g/r/59232/#comment248057>
"New repository setting" instead of "New RepoistorySetting".
- Tim Thorpe
On May 12, 2017, 6:47 p.m., Di Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59955/#review177515
---
Ship it!
Ship It!
- Tim Thorpe
On June 9, 2017, 8:07 p.m
-DskipSurefireTests -Dpython.test.mask=test_stack_advisor.py
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60390/#review178892
---
Ship it!
Ship It!
- Tim Thorpe
On June 23, 2017, 3:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60206/#review178317
---
Ship it!
Ship It!
- Tim Thorpe
On June 19, 2017, 8:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175918
---
Ship it!
Ship It!
- Tim Thorpe
On May 23, 2017, 11:26 p.m
new test case to test the recommendation of dependencies for slaves and
masters
mvn clean test -DskipSurefireTests
New trunk without my change
Total run:1168
Total errors:13
Total failures:0
New trunk with my change
Total run:1169
Total errors:13
Total failures:0
Thanks,
Tim Thorpe
the recommendation of dependencies for slaves and
masters
mvn clean test -DskipSurefireTests
New trunk without my change
Total run:1168
Total errors:13
Total failures:0
New trunk with my change
Total run:1169
Total errors:13
Total failures:0
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/#review176625
-------
On May 9, 2017, 2:39 p.m., Tim Thorpe wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59440/#review176601
---
Ship it!
Ship It!
- Tim Thorpe
On June 1, 2017, 1:37 a.m
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59095/#review176366
---
On May 9, 2017, 2:39 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59913/#review177310
---
Ship it!
Ship It!
- Tim Thorpe
On June 8, 2017, 12:45 p.m
clean test -DskipSurefireTests
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59727/#review177169
---
Ship it!
Ship It!
- Tim Thorpe
On June 6, 2017, 8:23 p.m
ters
mvn clean test -DskipSurefireTests
New trunk without my change
Total run:1168
Total errors:13
Total failures:0
New trunk with my change
Total run:1169
Total errors:13
Total failures:0
Thanks,
Tim Thorpe
To reply, visit:
https://reviews.apache.org/r/59838/#review177782
---
On June 7, 2017, 12:26 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59953/#review177507
---
Ship it!
Ship It!
- Tim Thorpe
On June 9, 2017, 7:01 p.m
... Haven't
done that so far.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review173909
-------
On April 28, 2017, 5:48 p.m., Tim Thorpe wrote:
>
> -
://reviews.apache.org/r/58845/diff/2/
Changes: https://reviews.apache.org/r/58845/diff/1-2/
Testing
---
mvn clean test
mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
Thanks,
Tim Thorpe
clean test
mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests
mvn clean test
-Dtest=StackManagerExtensionTest,StackManagerCommonServicesTest,StackManagerMiscTest,StackManagerTest,AmbariManagementControllerImplTest,AmbariManagementControllerTest
-DskipPythonTests
Thanks,
Tim Thorpe
lly stop ambari server from starting.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58845/#review173909
-----------
O
/resourceFilesKeeper.py
Line 168 (original), 168 (patched)
<https://reviews.apache.org/r/59053/#comment247309>
Should add a comment in here saying the archive will be created if it
doesn't exist even if there is a hash file with equal to the directories hash.
- Tim Thorpe
On May 8, 2017, 4:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59053/#review174188
---
Ship it!
Ship It!
- Tim Thorpe
On May 8, 2017, 4:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/#review173598
---
Ship it!
Ship It!
- Tim Thorpe
On May 2, 2017, 3:37 p.m
errors:13
Total failures:0
New trunk with my change
Total run:1169
Total errors:13
Total failures:0
Thanks,
Tim Thorpe
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59838/#review177055
-------
On June 6, 2017, 11:33 a.m., Tim Thorpe wrote:
>
> --
only cluster and attempted to enable NameNode
HA. This is prevented with the same error you'd see if ZooKeeper was enabled
but you had fewer than 3 ZooKeeper servers configured.
Thanks,
Tim Thorpe
/upgrade/ExecuteHostType.java
Lines 60 (patched)
<https://reviews.apache.org/r/62787/#comment264090>
Remove this
- Tim Thorpe
On Oct. 5, 2017, 1:24 p.m., Di Li wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62787/#review187197
---
Ship it!
Ship It!
- Tim Thorpe
On Oct. 5, 2017, 3:17 p.m
testing with different extension and stack versions.
mvn test -DskipPythonTests
-Dtest=StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest,StackManagerExtensionTest
Thanks,
Tim Thorpe
/diff/1/
Testing
---
mvn test
-Dtest=StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest,StackManagerExtensionTest
Manual testing both valid and invalid extension version updates
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61948/#review183937
---
Ship it!
Ship It!
- Tim Thorpe
On Aug. 28, 2017, 3:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61861/#review183663
---
Ship it!
Ship It!
- Tim Thorpe
On Aug. 23, 2017, 8:25 p.m
,StackManagerMiscTest,StackManagerExtensionTest
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64311/#review192750
---
Ship it!
Ship It!
- Tim Thorpe
On Dec. 4, 2017, 7:20 p.m
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64311/
> -----------
>
> (Updated Dec. 4, 2017, 8:08 p.m.)
>
>
> Review request for Ambari, Jonathan Hur
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63877/#review191176
---
Ship it!
Ship It!
- Tim Thorpe
On Nov. 16, 2017, 1:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63800/#review190961
---
Ship it!
Ship It!
- Tim Thorpe
On Nov. 14, 2017, 4:46 p.m
ttps://reviews.apache.org/r/63513/#comment267153>
Should this be moved to a debug message?
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
Lines 664 (patched)
<https://reviews.apache.org/r/63513/#comment267154>
Should this be moved to a debug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63513/#review189951
---
Ship it!
Ship It!
- Tim Thorpe
On Nov. 2, 2017, 7:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63640/#review190455
---
Ship it!
Ship It!
- Tim Thorpe
On Nov. 7, 2017, 5:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64311/#review192887
---
Ship it!
Ship It!
- Tim Thorpe
On Dec. 5, 2017, 5:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64771/#review194338
---
Ship it!
Ship It!
- Tim Thorpe
On Dec. 21, 2017, 2:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64809/#review194447
---
Ship it!
Ship It!
- Tim Thorpe
On Dec. 22, 2017, 2:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64781/#review194347
---
Ship it!
Ship It!
- Tim Thorpe
On Dec. 21, 2017, 4:29 p.m
201 - 276 of 276 matches
Mail list logo
