---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64974/#review194858
---
Ship it!
Ship It!
- Robert Levas
On Jan. 5, 2018, 5:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64952/#review194769
---
Ship it!
Ship It!
- Robert Levas
On Jan. 4, 2018, 12:06 p.m
/org/apache/ambari/server/controller/StackServiceComponentResponse.java
Lines 120 (patched)
<https://reviews.apache.org/r/64948/#comment273742>
missing JavaDoc. Claficiation of this property may be useful in the future.
- Robert Levas
On Jan. 4, 2018, 9:06 a.m., Attila Magyar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64914/#review194695
---
Ship it!
Ship It!
- Robert Levas
On Jan. 3, 2018, 6:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64913/#review194694
---
Ship it!
Ship It!
- Robert Levas
On Jan. 3, 2018, 4:16 a.m
5:00
[INFO] Final Memory: 71M/907M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review194176
---
Ship it!
Ship It!
- Robert Levas
On Dec. 13, 2017, 1:14 p.m
t quite see what this query is doing and it's
> > ok... Thought I'd flag it for discussion.
>
> Robert Levas wrote:
> I assumed that this would fail if run multiple times. This is why there
> is a conditional right before it:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193804
---
Ship it!
Ship It!
- Robert Levas
On Dec. 14, 2017, 6:26 a.m
]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
te the FK declarations inside the table declarations.
>
> Robert Levas wrote:
> I did this for a reason, but now I can't remember. I will test it and fix
> or post my reason.
Looks like I was doing it for consistency... The IntelliJ Oracle SQL doc
validator does not seem to li
it and fix or
post my reason.
- Robert
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64544/#review193564
---
On Dec. 12, 2017, 9:35 a.m., Robert Levas wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193704
---
Ship it!
Ship It!
- Robert Levas
On Dec. 12, 2017, 10:38
ply, visit:
> https://reviews.apache.org/r/64542/
> ---
>
> (Updated Dec. 12, 2017, 10:38 a.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and
> Sandor Molnar.
>
>
> Bugs: AMBARI-22634
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64568/#review193698
---
Ship it!
Ship It!
- Robert Levas
On Dec. 13, 2017, 1:54 a.m
/reviews.apache.org/r/64118/#comment272148>
Change this to use `DigestUtils.sha256Hex` for security concious folks... I
know this is not being used in a security-related context, but SHA1 is being
frowned upon.
- Robert Levas
On Dec. 6, 2017, 5:21
: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64373/#review192988
---
Ship it!
Ship It!
- Robert Levas
On Dec. 6, 2017, 8:04 a.m
hange requires
> > to have this set per user or for the whole default group, if you dont
> > change the default. Is this documented?
>
> Robert Levas wrote:
> Thanks for the comment.
>
> I understand the use of the group. The concept is not being removed,
eviews.apache.org/r/64305/#review192729
---
On Dec. 4, 2017, 12:02 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To re
Cryptography Extensions (JCE) have been setup on the Ambari Server
host and all hosts in the cluster
Diffs
-
ambari-web/app/messages.js 06deecbf89
Diff: https://reviews.apache.org/r/64309/diff/1/
Testing
---
Manually tested
Thanks,
Robert Levas
05/diff/1/
Testing
---
Manually tested
Thanks,
Robert Levas
]
[INFO] Total time: 30:23 min
[INFO] Finished at: 2017-12-01T16:35:50-05:00
[INFO] Final Memory: 99M/2005M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert
] Final Memory: 99M/2005M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192480
---
Ship it!
Ship It!
- Robert Levas
On Dec. 1, 2017, 5:09 a.m
o reply, visit:
https://reviews.apache.org/r/64089/#review192031
-------
On Nov. 29, 2017, 2:16 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-
t tests in
ambari-server.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12743//console
```
Thanks,
Robert Levas
>
> >
> > Do we need this init() method? I don't think @StaticallyInject requires
> > it.
>
> Nate Cole wrote:
> +1 for this comment.
>
> Robert Levas wrote:
> I could not get my unittest to inject the objects properly, so I added
> this.
]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
ari-DDL-SQLAnywhere-CREATE.sql
Line 912 (original), 918 (patched)
<https://reviews.apache.org/r/64118/#comment270065>
This should be renamed to `PK_kerberos_keytab`
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
Line 936 (original), 942 (patched)
<https://reviews.apa
o try to get injection to work in the
unittest.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64089/#review192005
------
3//console
```
Thanks,
Robert Levas
996M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationServiceTest.java
ec78e5662a
Diff: https://reviews.apache.org/r/64089/diff/1/
Testing
---
Manually tested against various LDAP servers.
# Local test results: IN-PROGRESS
# Jenkins test results: PENDING
Thank
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63937/#review191596
---
Ship it!
Ship It!
- Robert Levas
On Nov. 21, 2017, 2:28 a.m
c/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 716 (patched)
<https://reviews.apache.org/r/63937/#comment269258>
I suspect that this should be set to `null` rather than an empty string.
But if it works, I am ok with it.
- Robert Levas
On Nov. 18, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63907/#review191324
---
Ship it!
Ship It!
- Robert Levas
On Nov. 17, 2017, 7:48 a.m
]
[INFO] Total time: 30:50 min
[INFO] Finished at: 2017-11-14T13:41:32-05:00
[INFO] Final Memory: 99M/1963M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/#review190821
---
Ship it!
Ship It!
- Robert Levas
On Nov. 13, 2017, 10:03
ambari-qa_cc_e9e01054f2ce1b0a41f59c30a282cd6e8a0aacc207f6be80b3b5fc57
```
SHA256
```
web_alert_ambari-qa_cc_90a8d884d4b9c869a647be5d9690386b2c1e7352e876fba54b96438a648b1d7d
```
- Robert Levas
On Nov. 10, 2017, 11:43 a.m., Robert Levas
> On Nov. 10, 2017, 11:57 a.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
> > Line 35 (original), 37 (patched)
> > <https://reviews.apache.org/r/63735/diff/1/?file=1888554#file1888554line39>
> &
is required when FIPS mode is enabled on the RHEL OS
Diffs
-
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
95e8625d67
Diff: https://reviews.apache.org/r/63735/diff/1/
Testing
---
Manually tested
Thanks,
Robert Levas
not increase the
total number of javac compiler warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
```
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63729/#review190725
---
Ship it!
Ship It!
- Robert Levas
On Nov. 10, 2017, 10:21
]
[INFO] Total time: 04:38 min
[INFO] Finished at: 2017-11-10T06:04:05-05:00
[INFO] Final Memory: 30M/1361M
[INFO]
```
Thanks,
Robert Levas
] Final Memory: 98M/1957M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
test results: PENDING
Thanks,
Robert Levas
.json
Line 106 (original), 106 (patched)
<https://reviews.apache.org/r/63698/#comment268070>
This may not be a good idea since it opens up the keytab file to all users
of the group - which is typically "hadoop".
Assuming most of the the time {{livy-env/liv
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63180/#review189718
---
Ship it!
Ship It!
- Robert Levas
On Oct. 24, 2017, 2:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189717
---
Ship it!
Ship It!
- Robert Levas
On Oct. 31, 2017, 9:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63354/#review189569
---
Ship it!
Ship It!
- Robert Levas
On Oct. 27, 2017, 6:26 a.m
]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
ove this when working on AMBARI-21217 (which has been
comnitted)
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
Line 1326 (original)
<https://reviews.apache.org/r/63219/#comment265895>
Forgot to remove this when working on AMBARI-21221 (which has bee
/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
6908c559ce
Diff: https://reviews.apache.org/r/63219/diff/1/
Testing
---
Manually tested
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
onfigurations for certain services
not yet installed in anticipation for them being installed so that we can
reduce the need to restart the core Hadoop services.
- Robert Levas
On Oct. 20, 2017, 9:25 a.m., Eugene Chekanskiy wrote:
>
> ---
/AmbariPamAuthenticationProviderTest.java
38f9a9ecdf
Diff: https://reviews.apache.org/r/63167/diff/1/
Testing
---
Manually tested
# Local test results: PENDING
# Jenkins test result: PENDING
Thanks,
Robert Levas
]
```
# Jenkins test result: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62998/#review188072
---
Ship it!
Ship It!
- Robert Levas
On Oct. 14, 2017, 2:05 a.m
/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java
Lines 27-29 (patched)
<https://reviews.apache.org/r/62985/#comment265094>
These should be `private static final` members of the class.
- Robert Levas
On Oct. 13, 2017, 4:21 p.m., Vishal Suvagia
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62948/#review187865
---
Ship it!
Ship It!
- Robert Levas
On Oct. 12, 2017, 4:33 p.m
ad been previously optimized out trying to not _recompile_
configuration data for every processed host. So now the host information needs
to be added to the configuration conext used for variable replacement
operations.
- Robert Levas
On Oct. 12, 2017, 2:57 p.m.,
SUCCESS
[INFO]
[INFO] Total time: 24:35 min
[INFO] Finished at: 2017-10-12T13:44:20-04:00
[INFO] Final Memory: 72M/877M
[INFO]
```
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62871/#review187579
---
Ship it!
Ship It!
- Robert Levas
On Oct. 10, 2017, 3:44 p.m
n a
service:
```
regenerate_components=HDFS:*
```
- Robert Levas
On Oct. 8, 2017, 7:36 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Final Memory: 108M/1995M
[INFO] --------
```
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62789/#review187192
---
Ship it!
Ship It!
- Robert Levas
On Oct. 5, 2017, 10:53 a.m
ps://reviews.apache.org/r/62757/#review187029
-------
On Oct. 4, 2017, 9:19 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail.
Local test results: PASSED
Thanks,
Robert Levas
renamed from `AmbariLocalUserProviderTest`.
The generic authentication provider tests were moved to
`AbstractAuthenticationProviderTes` to provide a way to test all relevant
authentication providers so that they behave in a similar way.
- Robert Levas
On Oct. 3, 2017, 4:23 p.m., Robert
: https://reviews.apache.org/r/62757/diff/1/
Testing
---
Manually tested
Local test results: PASSED
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62675/#review186625
---
Ship it!
Ship It!
- Robert Levas
On Sept. 28, 2017, 2:27
59-460 (patched)
<https://reviews.apache.org/r/62628/#comment263041>
This is resurrected code.
- Robert Levas
On Sept. 27, 2017, 4:53 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To
CESS
[INFO]
[INFO] Total time: 35:23 min
[INFO] Finished at: 2017-09-27T16:29:47-04:00
[INFO] Final Memory: 70M/591M
[INFO]
```
Thanks,
Robert Levas
---
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.438 s - in
org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
Thanks,
Robert Levas
://reviews.apache.org/r/62586/diff/1/
Testing
---
In progress
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/#review185896
---
Ship it!
Ship It!
- Robert Levas
On Sept. 21, 2017, 11:32
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185846
---
On Sept. 21, 2017, 7:56 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail.
449/diff/2/
Changes: https://reviews.apache.org/r/62449/diff/1-2/
Testing
---
Tested new Ambari 2.6.0 cluster.
Test upgrade from Ambari 2.5.1 to Ambari 2.6.0
# Local test results:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO] -----
t upgrade from Ambari 2.5.1 to Ambari 2.6.0
# Local test results:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO] --------
[INFO] Total time: 31:25 min
[INFO] Finished at: 2017-09-20T13:11:03-04:00
[INFO] Final Memory: 89M/2007M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> > Lines 1176 (patched)
> > <https://reviews.apache.org/r/62414/diff/1/?file=1829942#file1829942line1179>
> >
> >
gt;
Unless this would be used for something else, wouldn't it be simpler if
this method returned a boolean value rather than a Set? You could then
potentially save some time by not having to visit all of the properties
- Robert Levas
On Sept. 19, 2017, 1:38 p.
2017, 11:54 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
>
>
Use com.networknt:json-schema-validator:0.1.10, which appears to work when
using either Java 1.7 or Java 1.8.
Diffs
-
ambari-server/pom.xml 4a896ad261
Diff: https://reviews.apache.org/r/62412/diff/1/
Testing
---
Ran unit tests using Java7 and Java8
Thanks,
Robert Levas
- org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
Thanks,
Robert Levas
generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185554
-------
On Sept. 15, 2017, 10:34 a.m., Robert Levas wrote:
>
> ---
> Thi
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
Thanks,
Robert Levas
> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote:
> > That's a lot of validation! I'm curious though - did you happen to look at
> > something like http://json-schema.org/ instead of doing it explicitely in
> > each descriptor class?
>
> Laszlo Pus
for a validator implemention?
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62290/#review185399
---
On Sept.
- org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
Thanks,
Robert Levas
- org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62259/#review185308
---
Ship it!
Ship It!
- Robert Levas
On Sept. 12, 2017, 9:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62182/#review185205
---
Ship it!
Ship It!
- Robert Levas
On Sept. 12, 2017, 11:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62182/#review185191
---
Ship it!
Ship It!
- Robert Levas
On Sept. 12, 2017, 10:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/#review184994
---
Ship it!
Ship It!
- Robert Levas
On Sept. 8, 2017, 2:34 p.m
=
!"true".equalsIgnoreCase(identityRecord.get(KerberosIdentityDataFileReader.ONLY_KEYTAB_WRITE));
} else {
```
- Robert Levas
On Sept. 8, 2017, 12:17 p.m., Eugene Chekanskiy wrote:
>
> ---
> This is an automatic
-services/RANGER_KMS/0.5.0.2.3/kerberos.json
Lines 37-39 (original), 34-36 (patched)
<https://reviews.apache.org/r/62157/#comment261044>
Shouldn't this be removed as well?
- Robert Levas
On Sept. 7, 2017, 10:33 a.m., Mugdha Var
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62084/#review184638
---
Ship it!
Ship It!
- Robert Levas
On Sept. 6, 2017, 2:41 a.m
1 - 100 of 948 matches
Mail list logo
