Review Request 49662: Show gpadmin as hawq service account user on Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49662/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-17571 https://issues.apache.org/jira/browse/AMBARI-17571 Repository: ambari Description --- Show gpadmin as hawq service account user on Ambari Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml cfab63f Diff: https://reviews.apache.org/r/49662/diff/ Testing --- manual. Thanks, bhuvnesh chaudhary
Review Request 49659: Update config update message for Activate HAWQ Standby wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49659/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-17569 https://issues.apache.org/jira/browse/AMBARI-17569 Repository: ambari Description --- Update config update message for Activate HAWQ Standby wizard Diffs - ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step3_controller.js 326b704 ambari-web/app/messages.js dcf0426 Diff: https://reviews.apache.org/r/49659/diff/ Testing --- ok Thanks, bhuvnesh chaudhary
Re: Review Request 48663: Export PGHOST before any HAWQ Master or Standby custom command is executed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48663/#review137412 --- Ship it! Ship It! - bhuvnesh chaudhary On June 13, 2016, 10:25 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48663/ > --- > > (Updated June 13, 2016, 10:25 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-17207 > https://issues.apache.org/jira/browse/AMBARI-17207 > > > Repository: ambari > > > Description > --- > > Export PGHOST before any HAWQ Master or Standby custom command is executed > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 1804f11 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > dc9bb12 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > 119f2c7 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > 12d3511 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py aa63004 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 185bde8 > > Diff: https://reviews.apache.org/r/48663/diff/ > > > Testing > --- > > Manually tested. > > Updated unit tests: > ``` > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (te
Review Request 48664: Add logging for the command executed during PXF service check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48664/ --- Review request for Ambari, Alexander Denissov and Matt. Bugs: AMBARI-17208 https://issues.apache.org/jira/browse/AMBARI-17208 Repository: ambari Description --- Add logging for the command executed during PXF service check Diffs - ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py c39a85e Diff: https://reviews.apache.org/r/48664/diff/ Testing --- yes Thanks, bhuvnesh chaudhary
Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type
on HDFS-HA, Standalone Resource Management, Kerberized ... 2016-06-03 15:50:22,359 - Executing HAWQ Check ... ok test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-06-03 15:50:22,370 - Executing HAWQ Check ... ok test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-06-03 15:50:22,381 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-06-03 15:50:22,396 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-06-03 15:50:22,407 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-06-03 15:50:22,420 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-06-03 15:50:22,431 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-06-03 15:50:22,442 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-06-03 15:50:22,461 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_activate_hawq_standby (test_hawqstandby.TestHawqStandby) Test Activate HAWQ Standby Command ... 2016-06-03 15:50:22,535 - Activating HAWQ standby... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_getHostsForMasterComponent (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.381s OK Thanks, bhuvnesh chaudhary
Re: Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type
> On June 3, 2016, 11:05 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 185 > > <https://reviews.apache.org/r/48235/diff/1/?file=1406214#file1406214line185> > > > > better to move these lines higher to after line 149 where the similar > > logic resides ? done > On June 3, 2016, 11:05 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 193 > > <https://reviews.apache.org/r/48235/diff/1/?file=1406214#file1406214line193> > > > > are we repeating default values already defined in .xml file ? Would be > > better not to do that, if possible. fixed for vm.overcommit_ratio. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48235/#review136128 --- On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48235/ > --- > > (Updated June 3, 2016, 10:49 p.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-17023 > https://issues.apache.org/jira/browse/AMBARI-17023 > > > Repository: ambari > > > Description > --- > > Show only relevant properties based on the status of HAWQ Resource Manager. > When Yarn mode is enable, only two parameters should be invisible. > hawq_rm_memory_limit_perseg > hawq_rm_nvcore_limit_perseg > When standalone mode is enabled, four parameters should be invisible. what > you list are correct. > hawq_rm_yarn_app_name > hawq_rm_yarn_queue_name > hawq_rm_yarn_scheduler_address > hawq_rm_yarn_address > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 3ac4e89 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 28eb82f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 5750938 > > Diff: https://reviews.apache.org/r/48235/diff/ > > > Testing > --- > > yes. > Now testing > /Users/bhuvneshchaudhary/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ > ~/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ > ~/github/ambari-toolbox/vagrant/ambari > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_syn
Review Request 48235: Show only relevant properties in HAWQ based on the status of HAWQ Resource Manager type
HawqMaster) Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-06-03 15:50:22,370 - Executing HAWQ Check ... ok test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-06-03 15:50:22,381 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-06-03 15:50:22,396 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-06-03 15:50:22,407 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-06-03 15:50:22,420 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-06-03 15:50:22,431 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-06-03 15:50:22,442 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-06-03 15:50:22,461 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_activate_hawq_standby (test_hawqstandby.TestHawqStandby) Test Activate HAWQ Standby Command ... 2016-06-03 15:50:22,535 - Activating HAWQ standby... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_getHostsForMasterComponent (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_getServiceConfigurationRecommendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 53 tests in 0.381s OK Thanks, bhuvnesh chaudhary
Review Request 48194: Update name of PXF component to PXF Agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48194/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-17024 https://issues.apache.org/jira/browse/AMBARI-17024 Repository: ambari Description --- Update name of PXF component to PXF Agent Diffs - ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml ba1c58e Diff: https://reviews.apache.org/r/48194/diff/ Testing --- yes. Thanks, bhuvnesh chaudhary
Re: Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48155/#review135863 --- Ship it! Ship It! - bhuvnesh chaudhary On June 1, 2016, 9:02 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48155/ > --- > > (Updated June 1, 2016, 9:02 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16992 > https://issues.apache.org/jira/browse/AMBARI-16992 > > > Repository: ambari > > > Description > --- > > Set hawq_rm_nvcore_limit_perseg as the lowest cpu_count across all HAWQ hosts > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 94e1854 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 6fbdf45 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > b931dc6 > > Diff: https://reviews.apache.org/r/48155/diff/ > > > Testing > --- > > Manually tested. > > Added unit test: > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_sparkts_no_hive > (test_stac
Review Request 48091: Update derivation of hawq_rm_memory_limit_perseg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48091/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-16970 https://issues.apache.org/jira/browse/AMBARI-16970 Repository: ambari Description --- Update derivation of hawq_rm_memory_limit_perseg. It should be calculated based on vm.overcommit_ratio, vm.overcommit_memory and the available system memory. It should also have a default value. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml b096702 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 2ec145f ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py a634062 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 1d6a85c Diff: https://reviews.apache.org/r/48091/diff/ Testing --- yes test case updated. Thanks, bhuvnesh chaudhary
Review Request 47975: BP deploy to put default password for hawq_password
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47975/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-16936 https://issues.apache.org/jira/browse/AMBARI-16936 Repository: ambari Description --- BP deploy to put default password for hawq_password Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml 56d2b26 Diff: https://reviews.apache.org/r/47975/diff/ Testing --- yes. Thanks, bhuvnesh chaudhary
Review Request 47926: Use postgres database instead of template1 during service check in HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47926/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-16917 https://issues.apache.org/jira/browse/AMBARI-16917 Repository: ambari Description --- Use postgres database instead of template1 during service check in HAWQ. template1 database is used as a default template while creating new databases, so anything in template1 gets carried over to the new database. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py 17724bc ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py e916f07 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 4a75a78 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py f37b13f Diff: https://reviews.apache.org/r/47926/diff/ Testing --- yes. Thanks, bhuvnesh chaudhary
Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env
> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json, > > line 201 > > <https://reviews.apache.org/r/47802/diff/1/?file=1392948#file1392948line201> > > > > can this be a slider between 0 ad 100 ? Should we also have validation > > that the value is within that range if user manually enters the number ? > > bhuvnesh chaudhary wrote: > Based on some of the articles i read, it suggested that the value of this > parameter can be greater than 100 and was not able to find what is the > maximum, so kept it as text-field > > Alexander Denissov wrote: > maybe at least specify min value as 0 for the property in the .xml file ? ok, will add and test. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134692 --- On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47802/ > --- > > (Updated May 26, 2016, 4:54 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16827 > https://issues.apache.org/jira/browse/AMBARI-16827 > > > Repository: ambari > > > Description > --- > > expose vm.overcommit_ratio on hawq-sysctl-env > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 5be3848 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > c51b012 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 836144c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > e4d1c45 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47802/diff/ > > > Testing > --- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env
> On May 26, 2016, 5:05 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 340 > > <https://reviews.apache.org/r/47802/diff/2/?file=1395185#file1395185line340> > > > > Is this an override? > > I don't see this function being called anywhere... will remove this for now. to not display some of the properties based on a config value we need to set the attribute so added this function earlier. > On May 26, 2016, 5:05 a.m., Matt wrote: > > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py, line > > 210 > > <https://reviews.apache.org/r/47802/diff/2/?file=1395187#file1395187line210> > > > > This required? yes. vm.overcommit_ratio = '' indicates that this is the first time when the configuration is loaded i.e while coming on the configuration page the first time while adding a service. if this is '', we recommend vm.overcommit_memory and set vm.overcommit_ratio = 50, so now on the screen both the values vm.overcommit_memory and vm.overcommit_ratio will be there. So if now on this page, you change ratio or memory, the values entered by the user are taken for calculations. However, there is one issue which needs to be fixed yet. For configuration with value-list, the recommendation are given by the stack advisor, but the UI loads the value which is the default for it in the xml file, ex vm.overcommit_memory. > On May 26, 2016, 5:05 a.m., Matt wrote: > > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py, line > > 216 > > <https://reviews.apache.org/r/47802/diff/2/?file=1395187#file1395187line216> > > > > This required? yes. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134917 --- On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47802/ > --- > > (Updated May 26, 2016, 4:54 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16827 > https://issues.apache.org/jira/browse/AMBARI-16827 > > > Repository: ambari > > > Description > --- > > expose vm.overcommit_ratio on hawq-sysctl-env > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 5be3848 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > c51b012 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 836144c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > e4d1c45 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47802/diff/ > > > Testing > --- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env
> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 207 > > <https://reviews.apache.org/r/47802/diff/1/?file=1392947#file1392947line207> > > > > if user manually puts a value for this field, will we override it with > > our recommendations every time they navigate to the config page ? When HAWQ service is being added, recommendation will be given. Once on the customize service page while adding user changes vm.overcommit_memory or vm.overcommit_ratio, recommendation will be updated. If the user updates hawq_rm_memory_limit_perseg directly, no recommendations are given, so it will not be overridden > On May 25, 2016, 3:38 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json, > > line 201 > > <https://reviews.apache.org/r/47802/diff/1/?file=1392948#file1392948line201> > > > > can this be a slider between 0 ad 100 ? Should we also have validation > > that the value is within that range if user manually enters the number ? Based on some of the articles i read, it suggested that the value of this parameter can be greater than 100 and was not able to find what is the maximum, so kept it as text-field - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134692 --- On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47802/ > --- > > (Updated May 26, 2016, 4:54 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16827 > https://issues.apache.org/jira/browse/AMBARI-16827 > > > Repository: ambari > > > Description > --- > > expose vm.overcommit_ratio on hawq-sysctl-env > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 5be3848 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > c51b012 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 836144c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > e4d1c45 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47802/diff/ > > > Testing > --- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/ --- (Updated May 26, 2016, 4:54 a.m.) Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Changes --- Recommendations will be given whenever vm.overcommit_memory or vm.overcommit_ratio is changed Bugs: AMBARI-16827 https://issues.apache.org/jira/browse/AMBARI-16827 Repository: ambari Description --- expose vm.overcommit_ratio on hawq-sysctl-env Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 5be3848 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml c51b012 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 836144c ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json e4d1c45 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 53c5574 Diff: https://reviews.apache.org/r/47802/diff/ Testing --- yes. test case added. Thanks, bhuvnesh chaudhary
Re: Review Request 47840: Change location of HAWQ tmp directories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47840/#review134803 --- Ship it! Ship It! - bhuvnesh chaudhary On May 25, 2016, 6:37 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47840/ > --- > > (Updated May 25, 2016, 6:37 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16885 > https://issues.apache.org/jira/browse/AMBARI-16885 > > > Repository: ambari > > > Description > --- > > Update HAWQ temp directories to /data/hawq/tmp/master and > /data/hawq/tmp/segment respectively > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > c3b1f82 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5cf2d2f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py fde5fd3 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 4e2a9cd > ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 36513c5 > > Diff: https://reviews.apache.org/r/47840/diff/ > > > Testing > --- > > Updated unit tests: > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor) >
Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-16827 https://issues.apache.org/jira/browse/AMBARI-16827 Repository: ambari Description --- expose vm.overcommit_ratio on hawq-sysctl-env Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml c51b012 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 836144c ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json e4d1c45 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 53c5574 Diff: https://reviews.apache.org/r/47802/diff/ Testing --- yes. test case added. Thanks, bhuvnesh chaudhary
Re: Review Request 47679: PXF operations considers the agent status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47679/#review134226 --- Ship it! Ship It! - bhuvnesh chaudhary On May 20, 2016, 11:24 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47679/ > --- > > (Updated May 20, 2016, 11:24 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Yusaku Sako. > > > Bugs: AMBARI-16670 > https://issues.apache.org/jira/browse/AMBARI-16670 > > > Repository: ambari > > > Description > --- > > PXF operations considers the agent status > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js 77584ba > ambari-web/app/models/host_component.js 569879f > ambari-web/test/controllers/main/service/item_test.js 0830d63 > ambari-web/test/views/main/service/item_test.js f612f2d > > Diff: https://reviews.apache.org/r/47679/diff/ > > > Testing > --- > > Manually tested. > > ``` > [INFO] Scanning for projects... > [INFO] > > [INFO] > > [INFO] Building Ambari Web 2.0.0.0-SNAPSHOT > [INFO] > > [INFO] > > [92m [0m[32m 27833 tests complete[0m[90m (23 seconds)[0m > [36m [0m[36m 154 tests pending[0m > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 55.768 s > [INFO] Finished at: 2016-05-20T16:22:20-07:00 > [INFO] Final Memory: 12M/310M > [INFO] > > > ``` > > > Thanks, > > Matt > >
Review Request 47657: Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47657/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs: AMBARI-16800 https://issues.apache.org/jira/browse/AMBARI-16800 Repository: ambari Description --- Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py b52b477 Diff: https://reviews.apache.org/r/47657/diff/ Testing --- yes. Thanks, bhuvnesh chaudhary
Review Request 47627: hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47627/ --- Review request for Ambari, Alexander Denissov, Matt, and Robert Nettleton. Bugs: AMBARI-16786 https://issues.apache.org/jira/browse/AMBARI-16786 Repository: ambari Description --- hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 1ddc4e1 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 5c6aeaf Diff: https://reviews.apache.org/r/47627/diff/ Testing --- yes. test case added. Thanks, bhuvnesh chaudhary
Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47580/#review134032 --- Ship it! Ship It! - bhuvnesh chaudhary On May 19, 2016, 6:58 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47580/ > --- > > (Updated May 19, 2016, 6:58 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16752 > https://issues.apache.org/jira/browse/AMBARI-16752 > > > Repository: ambari > > > Description > --- > > In service install wizard, pxf-hbase.jar should be added to the > HBASE_CLASSPATH (recommendation and validation) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py > e2510eb > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/47580/diff/ > > > Testing > --- > > Manually Tested. > > Unit tests added. > > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_sparkts_no_hive > (test_stack_advisor.TestHDP23StackAdvisor) > Test Sp
Re: Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard
> On May 19, 2016, 4:22 a.m., Alexander Denissov wrote: > > ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js, > > line 64 > > <https://reviews.apache.org/r/47573/diff/1/?file=1387567#file1387567line64> > > > > does this single fix solves both issues ? The host is considered as invalid if this parameter is not set. (recently changed behavior) This fix will not mark the host as invalid if its not in maintenance due to which next button remains enabled not sure which second issue you are referring ? - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47573/#review133872 --- On May 19, 2016, 1:29 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47573/ > --- > > (Updated May 19, 2016, 1:29 a.m.) > > > Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr > Diachenko. > > > Bugs: AMBARI-16754 > https://issues.apache.org/jira/browse/AMBARI-16754 > > > Repository: ambari > > > Description > --- > > Next button is disabled on assign master page in Add Hawq Standby wizard. > Host maintenance state is not propageted from the wizard view to the > underlying controllers. > > > Diffs > - > > > ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js > def93f3 > > Diff: https://reviews.apache.org/r/47573/diff/ > > > Testing > --- > > yes. > > > 27821 tests complete (31 seconds) > 154 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > ---- > [INFO] Total time: 01:32 min > [INFO] Finished at: 2016-05-18T18:26:48-07:00 > [INFO] Final Memory: 14M/339M > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47573/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-16754 https://issues.apache.org/jira/browse/AMBARI-16754 Repository: ambari Description --- Next button is disabled on assign master page in Add Hawq Standby wizard. Host maintenance state is not propageted from the wizard view to the underlying controllers. Diffs - ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js def93f3 Diff: https://reviews.apache.org/r/47573/diff/ Testing --- yes. 27821 tests complete (31 seconds) 154 tests pending [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 01:32 min [INFO] Finished at: 2016-05-18T18:26:48-07:00 [INFO] Final Memory: 14M/339M Thanks, bhuvnesh chaudhary
Review Request 47570: Recommend value for hawq_rm_memory_limit_perseg for HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47570/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-16745 https://issues.apache.org/jira/browse/AMBARI-16745 Repository: ambari Description --- Recommend value for hawq_rm_memory_limit_perseg for HAWQ. Below is the recommendation basis. vm.overcommit_memory recommedation existing 1) If RAM >=32 then 2 else 1 For recommendation % for memory based on the size of cluster RAM = RAM / 2 if vm.overcommit == 2 else 1 1) If HAWQ Segment Hosts has RAM <= 64 GB, allocate 75% 2) If HAWQ Segment Hosts has 64 < RAM <= 512, allocate 85% 3) If HAWQ Segment Hosts has 512 < RAM, allocate 95% Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 276dd3a ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 50f3a1f Diff: https://reviews.apache.org/r/47570/diff/ Testing --- yes. test_getServiceConfigurationRecommendations (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok -- Ran 51 tests in 0.317s OK Thanks, bhuvnesh chaudhary
Review Request 47434: Remove unused parameters from hawq-site.xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47434/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-16694 https://issues.apache.org/jira/browse/AMBARI-16694 Repository: ambari Description --- Remove the below unused parameters from hawq-site.xml hawq_re_cgroup_hierarchy_name hawq_re_cgroup_mount_point hawq_re_cpu_enable Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 170e8cf Diff: https://reviews.apache.org/r/47434/diff/ Testing --- yes. Thanks, bhuvnesh chaudhary
Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47328/#review133178 --- Ship it! Ship It! - bhuvnesh chaudhary On May 13, 2016, 6:59 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47328/ > --- > > (Updated May 13, 2016, 6:59 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, and Lav Jain. > > > Bugs: AMBARI-16646 > https://issues.apache.org/jira/browse/AMBARI-16646 > > > Repository: ambari > > > Description > --- > > Consider all HAWQ host machines. > If the lowest memory among all systems is >= 32 GB set vm.overcommit_memory > as 2, else use 1 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > a26a398 > ambari-server/src/main/resources/stacks/service_advisor.py 86682c5 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > be0f3e4 > > Diff: https://reviews.apache.org/r/47328/diff/ > > > Testing > --- > > Added unit tests. > > ``` > bash-3.2$ cd ambari-server/src/test/python/stacks/2.3/common/ > bash-3.2$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_insta
Re: Review Request 47134: HAWQ Password handling updated
> On May 12, 2016, 4:43 a.m., Matt wrote: > > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py, line 31 > > <https://reviews.apache.org/r/47134/diff/1-2/?file=1377033#file1377033line31> > > > > This is not required. Refer comment on the test_hawqsegment.py file. Thanks Matt for the suggestion. Used getConfig. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47134/#review132812 --- On May 12, 2016, 1:07 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47134/ > --- > > (Updated May 12, 2016, 1:07 a.m.) > > > Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr > Diachenko. > > > Bugs: AMBARI-16386 > https://issues.apache.org/jira/browse/AMBARI-16386 > > > Repository: ambari > > > Description > --- > > Updated salt used while creating HAWQ user, and also ensured that the > password is treated exactly as entered on the HAWQ config ui. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > 1bdc85a > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py > 670a58b > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a > > Diff: https://reviews.apache.org/r/47134/diff/ > > > Testing > --- > > yes. > bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing > HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ > Standby Master Re-Sync started in fast mode... > ok > test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 1: Non HDFS-HA, Standalone
Re: Review Request 47134: HAWQ Password handling updated
heck_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-05-09 12:54:42,031 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-09 12:54:42,043 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-09 12:54:42,055 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-05-09 12:54:42,064 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-09 12:54:42,073 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-09 12:54:42,083 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-05-09 12:54:42,098 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 50 tests in 0.300s OK Thanks, bhuvnesh chaudhary
Re: Review Request 47134: HAWQ Password handling updated
heck_case4 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, Kerberized ... 2016-05-09 12:54:42,031 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-09 12:54:42,043 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-09 12:54:42,055 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-05-09 12:54:42,064 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-09 12:54:42,073 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-09 12:54:42,083 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-05-09 12:54:42,098 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 50 tests in 0.300s OK Thanks, bhuvnesh chaudhary
Review Request 47277: hawq_ssh_exkeys config should be a checkbox on UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47277/ --- Review request for Ambari, Alexander Denissov, jun aoki, and Matt. Bugs: AMBARI-16624 https://issues.apache.org/jira/browse/AMBARI-16624 Repository: ambari Description --- hawq_ssh_exkeys config should be a checkbox on UI. Currently it accepts a string. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml d2da5b2 Diff: https://reviews.apache.org/r/47277/diff/ Testing --- yes. manual. Thanks, bhuvnesh chaudhary
Review Request 47134: HAWQ Password handling updated
N Resource Management Non YARN_HA, Kerberized ... 2016-05-09 12:54:42,031 - Executing HAWQ Check ... ok test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not Kerberized ... 2016-05-09 12:54:42,043 - Executing HAWQ Check ... ok test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, Kerberized ... 2016-05-09 12:54:42,055 - Executing HAWQ Check ... ok test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not Kerberized ... 2016-05-09 12:54:42,064 - Executing HAWQ Check ... ok test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, Kerberized ... 2016-05-09 12:54:42,073 - Executing HAWQ Check ... ok test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not Kerberized ... 2016-05-09 12:54:42,083 - Executing HAWQ Check ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-05-09 12:54:42,098 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) Run Stop HAWQ Cluster Immediate Mode ... ok test_stop_default (test_hawqmaster.TestHawqMaster) Run Stop HAWQMASTER ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 50 tests in 0.300s OK Thanks, bhuvnesh chaudhary
Re: Review Request 46996: HAWQ service can be stopped and checked even when STANDBY MASTER is stopped
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46996/#review131771 --- Ship it! Ship It! - bhuvnesh chaudhary On May 4, 2016, 11:52 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46996/ > --- > > (Updated May 4, 2016, 11:52 p.m.) > > > Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav > Jain, and Matt. > > > Bugs: AMBARI-16236 > https://issues.apache.org/jira/browse/AMBARI-16236 > > > Repository: ambari > > > Description > --- > > HAWQ service can be stopped and checked even when STANDBY MASTER is stopped > > > Diffs > - > > ambari-web/app/controllers/main/service/item.js bfede8a > ambari-web/test/controllers/main/service/item_test.js 4bac784 > > Diff: https://reviews.apache.org/r/46996/diff/ > > > Testing > --- > > manual. added unit tests: > > 27532 tests complete (29 seconds) > 154 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 45.229 s > [INFO] Finished at: 2016-05-04T16:25:14-08:00 > > > Thanks, > > Alexander Denissov > >
Re: Review Request 46860: Move RM wizard should update HAWQ related parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131403 --- ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 581) <https://reviews.apache.org/r/46860/#comment195363> somehow placing the logic here does not fit well to the method, you can move this logic to setAdditionalConfigs which imo more appropriate place and hopefully it will work there too as its used after setting additional configurations ? - bhuvnesh chaudhary On May 2, 2016, 9:47 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46860/ > --- > > (Updated May 2, 2016, 9:47 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-16174 > https://issues.apache.org/jira/browse/AMBARI-16174 > > > Repository: ambari > > > Description > --- > > when RM HA is not enabled, following properties should be updated in > hawq-site.xml should be updated. > hawq_rm_yarn_address > hawq_rm_yarn_scheduler_address > When RM HA Is enabled and then a RM is moved, following properties in > yarn-client.xml should be updated > yarn.resourcemanager.ha > yarn.resourcemanager.scheduler.ha > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > 736f467 > ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 329249c > > Diff: https://reviews.apache.org/r/46860/diff/ > > > Testing > --- > > Unit test passed > Calling set on destroyed view > > 27428 tests complete (35 seconds) > 154 tests pending > > > Manually tested > > > Thanks, > > jun aoki > >
Re: Review Request 46860: Move RM wizard should update HAWQ related parameters
> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line
> > 85
> > <https://reviews.apache.org/r/46860/diff/1/?file=1367779#file1367779line85>
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be
> > functional and we may need not restart HAWQ with the move of RM.
> > So do you think should we restart it only when HAWQ is using
> > hawq_global_rm_type as yarn ?
>
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh
> information to decide if HAWQ is on YARN.
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.
You can get the configuration as soon you reach onLoadConfigs, and then you can
use it which is before the start service ?
- bhuvnesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---
On May 2, 2016, 9:47 p.m., jun aoki wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
>
> (Updated May 2, 2016, 9:47 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
>
>
> Repository: ambari
>
>
> Description
> ---
>
> when RM HA is not enabled, following properties should be updated in
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/service/reassign/step4_controller.js
> 736f467
> ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de
> ambari-web/test/controllers/main/service/reassign/step4_controller_test.js
> 329249c
>
> Diff: https://reviews.apache.org/r/46860/diff/
>
>
> Testing
> ---
>
> Unit test passed
> Calling set on destroyed view
>
> 27428 tests complete (35 seconds)
> 154 tests pending
>
>
> Manually tested
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46860: Move RM wizard should update HAWQ related parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131232 --- ambari-web/test/controllers/main/service/reassign/step4_controller_test.js (line 561) <https://reviews.apache.org/r/46860/#comment195138> When RM is there, test if you get the yarn-client and hawq-site configuration with the specific tag, i dont see them being used ? ambari-web/test/controllers/main/service/reassign/step4_controller_test.js (line 632) <https://reviews.apache.org/r/46860/#comment195139> When RM is there, test if you get the yarn-client and hawq-site configuration with the specific tag, i dont see them being used ? ambari-web/test/controllers/main/service/reassign/step4_controller_test.js (line 683) <https://reviews.apache.org/r/46860/#comment195140> if you move the location of removing hawq-site and yarn-client from onLoadConfigsTag, probably you will remove the change here - bhuvnesh chaudhary On April 29, 2016, 11:57 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46860/ > --- > > (Updated April 29, 2016, 11:57 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-16174 > https://issues.apache.org/jira/browse/AMBARI-16174 > > > Repository: ambari > > > Description > --- > > when RM HA is not enabled, following properties should be updated in > hawq-site.xml should be updated. > hawq_rm_yarn_address > hawq_rm_yarn_scheduler_address > When RM HA Is enabled and then a RM is moved, following properties in > yarn-client.xml should be updated > yarn.resourcemanager.ha > yarn.resourcemanager.scheduler.ha > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > a20aa82 > ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 460726b > > Diff: https://reviews.apache.org/r/46860/diff/ > > > Testing > --- > > Unit test passed > Calling set on destroyed view > > 27428 tests complete (35 seconds) > 154 tests pending > > > Manually tested > > > Thanks, > > jun aoki > >
Re: Review Request 46860: Move RM wizard should update HAWQ related parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131230 --- ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 582) <https://reviews.apache.org/r/46860/#comment195136> I think you can move this part to getConfigUrlParams where components impacted by NAMENODE (HBASE, ACCUMULO) are also listed. Also, it would be better to add them if HAWQ exists instead of putting it as default and later removing it. - bhuvnesh chaudhary On April 29, 2016, 11:57 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46860/ > --- > > (Updated April 29, 2016, 11:57 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-16174 > https://issues.apache.org/jira/browse/AMBARI-16174 > > > Repository: ambari > > > Description > --- > > when RM HA is not enabled, following properties should be updated in > hawq-site.xml should be updated. > hawq_rm_yarn_address > hawq_rm_yarn_scheduler_address > When RM HA Is enabled and then a RM is moved, following properties in > yarn-client.xml should be updated > yarn.resourcemanager.ha > yarn.resourcemanager.scheduler.ha > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > a20aa82 > ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 460726b > > Diff: https://reviews.apache.org/r/46860/diff/ > > > Testing > --- > > Unit test passed > Calling set on destroyed view > > 27428 tests complete (35 seconds) > 154 tests pending > > > Manually tested > > > Thanks, > > jun aoki > >
Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard
> On April 29, 2016, 9:12 p.m., jun aoki wrote: > > ambari-web/app/utils/configs/move_namenode_config_initializer.js, line 113 > > <https://reviews.apache.org/r/46852/diff/1/?file=1367645#file1367645line113> > > > > Did you test if this works when HAWQ is not installed? > > bhuvnesh chaudhary wrote: > Did not test it yet without HAWQ, will do. > However, it will work. Tested no issues without hawq. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46852/#review131189 ------- On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46852/ > --- > > (Updated April 29, 2016, 8:50 p.m.) > > > Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr > Diachenko. > > > Bugs: AMBARI-16191 > https://issues.apache.org/jira/browse/AMBARI-16191 > > > Repository: ambari > > > Description > --- > > HAWQ Configuration should be updated whenever Namenode is being moved using > the move namenode wizard. > Parameters which should be updated > Case 1: HDFS HA > hdfs-client parameters under HAWQ service > dfs.namenode.rpc-address.. > dfs.namenode.http-address.. > Case 2: Non HA HDFS > hawq-site parmeters under HAWQ service > hawq_dfs_url > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > a20aa82 > ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 460726b > > Diff: https://reviews.apache.org/r/46852/diff/ > > > Testing > --- > > yes. > 27472 tests complete (29 seconds) > 154 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > ---- > [INFO] Total time: 46.556 s > [INFO] Finished at: 2016-04-29T13:53:51-07:00 > [INFO] Final Memory: 14M/338M > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard
> On April 29, 2016, 9:12 p.m., jun aoki wrote: > > ambari-web/app/utils/configs/move_namenode_config_initializer.js, line 113 > > <https://reviews.apache.org/r/46852/diff/1/?file=1367645#file1367645line113> > > > > Did you test if this works when HAWQ is not installed? Did not test it yet without HAWQ, will do. However, it will work. > On April 29, 2016, 9:12 p.m., jun aoki wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 571 > > <https://reviews.apache.org/r/46852/diff/1/?file=1367644#file1367644line571> > > > > you can use serviceToConfigSiteMap structure to add HAWQ. Yes i could have, but to keep in sync with the current codebase (HBASE and ACCUMULO service configuration are updated in case of NAMENODE move as well), so added it here. So will keep it as is. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46852/#review131189 --- On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46852/ > --- > > (Updated April 29, 2016, 8:50 p.m.) > > > Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr > Diachenko. > > > Bugs: AMBARI-16191 > https://issues.apache.org/jira/browse/AMBARI-16191 > > > Repository: ambari > > > Description > --- > > HAWQ Configuration should be updated whenever Namenode is being moved using > the move namenode wizard. > Parameters which should be updated > Case 1: HDFS HA > hdfs-client parameters under HAWQ service > dfs.namenode.rpc-address.. > dfs.namenode.http-address.. > Case 2: Non HA HDFS > hawq-site parmeters under HAWQ service > hawq_dfs_url > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > a20aa82 > ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 460726b > > Diff: https://reviews.apache.org/r/46852/diff/ > > > Testing > --- > > yes. > 27472 tests complete (29 seconds) > 154 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 46.556 s > [INFO] Finished at: 2016-04-29T13:53:51-07:00 > [INFO] Final Memory: 14M/338M > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard
> On April 29, 2016, 9:16 p.m., jun aoki wrote: > > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line > > 83 > > <https://reviews.apache.org/r/46852/diff/1/?file=1367644#file1367644line83> > > > > Do you know how related services (or HAWQ) are restared after > > proeprties are changed? Map unrelatedServicesMap controls the services which will be started. In case of Namenode, since NAMENODE is not available as a key, it will result in defined, and in the function startRequiredServices, it will go ahead and start all services (similarly for stop) /** * make server call to start services */ startRequiredServices - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46852/#review131191 ------- On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46852/ > --- > > (Updated April 29, 2016, 8:50 p.m.) > > > Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr > Diachenko. > > > Bugs: AMBARI-16191 > https://issues.apache.org/jira/browse/AMBARI-16191 > > > Repository: ambari > > > Description > --- > > HAWQ Configuration should be updated whenever Namenode is being moved using > the move namenode wizard. > Parameters which should be updated > Case 1: HDFS HA > hdfs-client parameters under HAWQ service > dfs.namenode.rpc-address.. > dfs.namenode.http-address.. > Case 2: Non HA HDFS > hawq-site parmeters under HAWQ service > hawq_dfs_url > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > a20aa82 > ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 460726b > > Diff: https://reviews.apache.org/r/46852/diff/ > > > Testing > --- > > yes. > 27472 tests complete (29 seconds) > 154 tests pending > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > ---- > [INFO] Total time: 46.556 s > [INFO] Finished at: 2016-04-29T13:53:51-07:00 > [INFO] Final Memory: 14M/338M > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46852/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-16191 https://issues.apache.org/jira/browse/AMBARI-16191 Repository: ambari Description --- HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard. Parameters which should be updated Case 1: HDFS HA hdfs-client parameters under HAWQ service dfs.namenode.rpc-address.. dfs.namenode.http-address.. Case 2: Non HA HDFS hawq-site parmeters under HAWQ service hawq_dfs_url Diffs - ambari-web/app/controllers/main/service/reassign/step4_controller.js a20aa82 ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 460726b Diff: https://reviews.apache.org/r/46852/diff/ Testing --- yes. 27472 tests complete (29 seconds) 154 tests pending [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 46.556 s [INFO] Finished at: 2016-04-29T13:53:51-07:00 [INFO] Final Memory: 14M/338M Thanks, bhuvnesh chaudhary
Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46800/ --- (Updated April 29, 2016, 8:46 p.m.) Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr Diachenko, and Richard Zang. Changes --- Applied feedback Bugs: AMBARI-16172 https://issues.apache.org/jira/browse/AMBARI-16172 Repository: ambari Description --- HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard. Parameters which should be updated Case 1: HDFS HA hdfs-client parameters under HAWQ service dfs.namenode.rpc-address.. dfs.namenode.http-address.. Case 2: Non HA HDFS hawq-site parmeters under HAWQ service hawq_dfs_url Diffs (updated) - ambari-web/app/controllers/main/service/reassign/step4_controller.js 840bda3 ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 1e137ee Diff: https://reviews.apache.org/r/46800/diff/ Testing --- yes. 10505 tests complete (13 seconds) 121 tests pending [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 29.607 s [INFO] Finished at: 2016-04-28T14:53:42-07:00 [INFO] Final Memory: 11M/213M Thanks, bhuvnesh chaudhary
Re: Review Request 46791: Capitalize HAWQ and PXF on service check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46791/#review130994 --- Ship it! Ship It! - bhuvnesh chaudhary On April 28, 2016, 5:03 p.m., Goutam Tadi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46791/ > --- > > (Updated April 28, 2016, 5:03 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16168 > https://issues.apache.org/jira/browse/AMBARI-16168 > > > Repository: ambari > > > Description > --- > > Capitalize HAWQ and PXF on service check > > > Diffs > - > > ambari-web/app/utils/helper.js 3cffc09 > > Diff: https://reviews.apache.org/r/46791/diff/ > > > Testing > --- > > Yes, Tested manually. Tests passed. > > > Thanks, > > Goutam Tadi > >
Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46800/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr Diachenko, and Richard Zang. Bugs: AMBARI-16172 https://issues.apache.org/jira/browse/AMBARI-16172 Repository: ambari Description --- HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard. Parameters which should be updated Case 1: HDFS HA hdfs-client parameters under HAWQ service dfs.namenode.rpc-address.. dfs.namenode.http-address.. Case 2: Non HA HDFS hawq-site parmeters under HAWQ service hawq_dfs_url Diffs - ambari-web/app/controllers/main/service/reassign/step4_controller.js 840bda3 ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 1e137ee Diff: https://reviews.apache.org/r/46800/diff/ Testing --- yes. 10505 tests complete (13 seconds) 121 tests pending [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 29.607 s [INFO] Finished at: 2016-04-28T14:53:42-07:00 [INFO] Final Memory: 11M/213M Thanks, bhuvnesh chaudhary
Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46509/ --- (Updated April 21, 2016, 11:01 p.m.) Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-16024 https://issues.apache.org/jira/browse/AMBARI-16024 Repository: ambari Description --- Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA. So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace. Diffs - ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f Diff: https://reviews.apache.org/r/46509/diff/ Testing (updated) --- yes. 25660 tests complete (29 seconds) 154 tests pending [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 46.511 s [INFO] Finished at: 2016-04-21T16:03:11-07:00 [INFO] Final Memory: 14M/331M Thanks, bhuvnesh chaudhary
Review Request 46509: Remove performing service check during "Remove Standby Wizard"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46509/ --- Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-16024 https://issues.apache.org/jira/browse/AMBARI-16024 Repository: ambari Description --- Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA. So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace. Diffs - ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f Diff: https://reviews.apache.org/r/46509/diff/ Testing --- yes. ~/github/ambari-vagrant/centos6.4/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ ~/github/ambari-vagrant/centos6.4/ambari test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-21 12:15:00,349 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 35 tests in 0.178s OK Thanks, bhuvnesh chaudhary
Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46294/#review129409 --- Ship it! Ship It! - bhuvnesh chaudhary On April 16, 2016, 12:56 a.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46294/ > --- > > (Updated April 16, 2016, 12:56 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15926 > https://issues.apache.org/jira/browse/AMBARI-15926 > > > Repository: ambari > > > Description > --- > > Activating standby could start a master with an old port, and the following > operations in the Activate Standby wizard could be mislead. > The fix is to stop the newly become master so that the wizard will only have > to deal with the current value. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > e2114d8 > > Diff: https://reviews.apache.org/r/46294/diff/ > > > Testing > --- > > Unit test passed. > Manually tested. > > > Thanks, > > jun aoki > >
Review Request 46283: hawq init master fails to syncup hawq-site xml if there is a segment host down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46283/ --- Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Srimanth Gunturi. Bugs: AMBARI-15930 https://issues.apache.org/jira/browse/AMBARI-15930 Repository: ambari Description --- In hawq init command, default bucket number is calculated and the updated hawq-site.xml is copied to all the other nodes, if there is a segment host down it will fail to syncup the fail. Including the option to skip bad hosts as ambari will override this file whenever the segment host is brought online and started. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py b929430 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 5f7f085 Diff: https://reviews.apache.org/r/46283/diff/ Testing --- yes. bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-15 15:16:22,910 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok -- Ran 35 tests in 0.148s OK Thanks, bhuvnesh chaudhary
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review128975 --- Ship it! Ship It! - bhuvnesh chaudhary On April 14, 2016, 7:18 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46186/ > --- > > (Updated April 14, 2016, 7:18 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15852 > https://issues.apache.org/jira/browse/AMBARI-15852 > > > Repository: ambari > > > Description > --- > > HAWQ restart after port change will fail because Ambari looks for a currently > running process with a new port number. > This change is to make Ambari to look for an older port value. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > 413cf1a > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py > 3f6c371 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py > f2ec914 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py > 636dcad > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > 67d1cb0 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py > 92ac0af > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > 0baa4c5 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 > > Diff: https://reviews.apache.org/r/46186/diff/ > > > Testing > --- > > Unit test has passed. > Manual Test in progress. > > > Thanks, > > jun aoki > >
Review Request 46126: Activate HAWQ standby wizard fails to delete previous hawq standby master
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46126/ --- Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki, Jayush Luniya, Matt, and Oleksandr Diachenko. Bugs: AMBARI-15849 https://issues.apache.org/jira/browse/AMBARI-15849 Repository: ambari Description --- Activate HAWQ standby wizard fails to delete previous hawq standby master. Currently, HAWQ standby status check is done based on the pid available in a directory. This directory is same for HAWQ master and HAWQ standby, thus if standby has been activated to active master, status of HAWQ Standby component still relies on the file and states it as running, and when an attempt is made to remove the standby component, it fails. Fixed the hawq component status derivation logic in this patch. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 98dedf1 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 8a5ad16 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py fb677ee ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py a1b6dd9 Diff: https://reviews.apache.org/r/46126/diff/ Testing --- yes. bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-12 17:51:26,025 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok -- Ran 34 tests in 0.149s OK Thanks, bhuvnesh chaudhary
Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/ --- (Updated April 12, 2016, 7:12 p.m.) Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and Oleksandr Diachenko. Changes --- Applied feedback Bugs: AMBARI-15820 https://issues.apache.org/jira/browse/AMBARI-15820 Repository: ambari Description --- HAWQ HDFS directory should be owned by postgres user if secured. Currently, it is owned by gpadmin even when the cluster is secured. Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 665d18e ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 87d3c8a Diff: https://reviews.apache.org/r/46072/diff/ Testing --- yes bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-11 23:28:50,081 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok -- Ran 34 tests in 0.140s OK Thanks, bhuvnesh chaudhary
Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/ --- Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and Oleksandr Diachenko. Bugs: AMBARI-15820 https://issues.apache.org/jira/browse/AMBARI-15820 Repository: ambari Description --- HAWQ HDFS directory should be owned by postgres user if secured. Currently, it is owned by gpadmin even when the cluster is secured. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 98dedf1 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 87d3c8a ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 9017d24 Diff: https://reviews.apache.org/r/46072/diff/ Testing --- yes bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts" ok test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok test_configure_default (test_hawqmaster.TestHawqMaster) ... ok test_install_default (test_hawqmaster.TestHawqMaster) ... ok test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-11 23:28:50,081 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml ok test_stop_default (test_hawqmaster.TestHawqMaster) ... ok test_configure_default (test_hawqsegment.TestHawqSegment) ... ok test_install_default (test_hawqsegment.TestHawqSegment) ... ok test_start_default (test_hawqsegment.TestHawqSegment) ... ok test_stop_default (test_hawqsegment.TestHawqSegment) ... ok test_configure_default (test_hawqstandby.TestHawqStandby) ... ok test_install_default (test_hawqstandby.TestHawqStandby) ... ok test_start_default (test_hawqstandby.TestHawqStandby) ... ok test_stop_default (test_hawqstandby.TestHawqStandby) ... ok -- Ran 34 tests in 0.140s OK Thanks, bhuvnesh chaudhary
Re: Review Request 45832: Add ignore-bad-hosts flag to hawq activate standby custom action
> On April 7, 2016, 5:53 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py, > > line 59 > > <https://reviews.apache.org/r/45832/diff/1/?file=1328786#file1328786line59> > > > > Would a service restart be required afer bad hosts (which will get > > ignored) become 'good'? Not service restart, but once the host is back, the component needs to be started and ambari will push the new configurations. (Regular behavior) - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45832/#review127562 --- On April 6, 2016, 7:57 p.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45832/ > --- > > (Updated April 6, 2016, 7:57 p.m.) > > > Review request for Ambari, jun aoki, Matt, and Oleksandr Diachenko. > > > Bugs: AMBARI-15743 > https://issues.apache.org/jira/browse/AMBARI-15743 > > > Repository: ambari > > > Description > --- > > If a HAWQ Component host is down, HAWQ fails during activate standby > operation syncing configuration file to down hosts. > We should use the flag ignore-bad-hosts to exclude the hosts which are > currently marked down so that hawq activate commands does not syncs the file > on bad node. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py > 2e5dccf > > Diff: https://reviews.apache.org/r/45832/diff/ > > > Testing > --- > > yes manually. > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 45832: Add ignore-bad-hosts flag to hawq activate standby custom action
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45832/ --- Review request for Ambari, jun aoki, Matt, and Oleksandr Diachenko. Bugs: AMBARI-15743 https://issues.apache.org/jira/browse/AMBARI-15743 Repository: ambari Description --- If a HAWQ Component host is down, HAWQ fails during activate standby operation syncing configuration file to down hosts. We should use the flag ignore-bad-hosts to exclude the hosts which are currently marked down so that hawq activate commands does not syncs the file on bad node. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 2e5dccf Diff: https://reviews.apache.org/r/45832/diff/ Testing --- yes manually. Thanks, bhuvnesh chaudhary
Re: Review Request 45391: HAWQ - Add option to enable or disabling exchanging keys during HAWQ start.
> On March 28, 2016, 6:03 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py,
> > line 313
> > <https://reviews.apache.org/r/45391/diff/1/?file=1316870#file1316870line313>
> >
> > can use default("/configuration/hdfs-site/dfs.allow.truncate", None)
Thanks for the review Alejandro, will make the change.
- bhuvnesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45391/#review125690
-------
On March 28, 2016, 5:42 p.m., bhuvnesh chaudhary wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45391/
> ---
>
> (Updated March 28, 2016, 5:42 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and
> Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15595
> https://issues.apache.org/jira/browse/AMBARI-15595
>
>
> Repository: ambari
>
>
> Description
> ---
>
> In HAWQ, SSH Keys are exchanged currently during every start of HAWQ Master.
> This patch introduces a flag to enable / disable exchanging keys during start.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml
> fc5385f
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
> d634fb2
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
> 7c3a832
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
> 9d8b32d
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
> d3c9009
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 4dc3cc8
> ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json 99d43cb
> ambari-web/app/data/HDP2.3/site_properties.js e706d40
>
> Diff: https://reviews.apache.org/r/45391/diff/
>
>
> Testing
> ---
>
> yes
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus)
> ... ok
> test_hawq_segment_critical
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus)
> ... ok
> test_hawq_standby_critical
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus)
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus)
> ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ...
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-28
> 10:42:36,732 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
>
> --
> Ran 27 tests in 0.175s
>
> OK
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 45343: Stack Advisor Recommendation overrides installed slave components topology
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45343/#review125479 --- Ship it! Ship It! - bhuvnesh chaudhary On March 25, 2016, 9:04 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45343/ > --- > > (Updated March 25, 2016, 9:04 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Mahadev > Konar, and Srimanth Gunturi. > > > Bugs: AMBARI-15589 > https://issues.apache.org/jira/browse/AMBARI-15589 > > > Repository: ambari > > > Description > --- > > Stack Advisor recommendation overrides installed slaves topology of installed > services when a new service is added. > Steps to reproduce: > - Install a cluster with HDFS and HAWQ select HAWQSEGMENTs on hosts different > from the recommended set of hosts > - Install any other service (HBASE). Error: On the assign slaves page, the > HAWQSEGMENTs are checked according to recommendations and not according to > the current host topology. > > The patch attached to this JIRA would fix the following issues: > - Recommendation given during Add Service wizard should be a combination of > current topology for installed services and recommendation for service that > is to be installed. > - Adding a new service after adding HAWQ or PXF would checkbox the > HAWQSEGMENTs and PXFs correctly even if the user has placed these components > different from the layout provided by the recommendation. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > cbcc4cb > ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 6dd0b44 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 8ae32a1 > > Diff: https://reviews.apache.org/r/45343/diff/ > > > Testing > --- > > Manually Tested. > Ran unit tests on all stack advisors. > > > Thanks, > > Matt > >
Re: Review Request 45252: PXF service checks fails on secured cluster without YARN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45252/#review125472
---
Ship it!
Ship It!
- bhuvnesh chaudhary
On March 25, 2016, 8:50 p.m., Lav Jain wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45252/
> ---
>
> (Updated March 25, 2016, 8:50 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh
> chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton
> Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15542
> https://issues.apache.org/jira/browse/AMBARI-15542
>
>
> Repository: ambari
>
>
> Description
> ---
>
> PXF service checks fails on secured cluster
> ```
> 2016-03-11 23:37:35,588 - HdfsResource[None] {'security_enabled': True,
> 'keytab': '/etc/security/keytabs/hdfs.headless.keytab', 'default_fs':
> 'hdfs://c6401.ambari.apache.org:8020', 'hdfs_site': ..., 'kinit_path_local':
> '/usr/bin/kinit', 'principal_name': 'hdfs-...@ambari.apache.org', 'user':
> 'hdfs', 'action': ['execute']}
> 2016-03-11 23:37:35,588 - Testing PXF HDFS read
> 2016-03-11 23:37:35,675 - Error code: 500
> 2016-03-11 23:37:35,675 - HDFS test Failed: Exception occurred in HDFS test:
> PXF data read failed: HTTP Error 500: Internal Server Error
> ```
>
> Pxf log says
> ```
> SEVERE: Servlet.service() for servlet [PXF REST Service] in context with path
> [/pxf] threw exception [java.io.IOException: Can't get Master Kerberos
> principal for use as renewer] with root cause
> java.io.IOException: Can't get Master Kerberos principal for use as renewer
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:116)
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodesInternal(TokenCache.java:100)
> at
> org.apache.hadoop.mapreduce.security.TokenCache.obtainTokensForNamenodes(TokenCache.java:80)
> at
> org.apache.hadoop.mapred.FileInputFormat.listStatus(FileInputFormat.java:206)
> at
> org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:315)
> at
> org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getSplits(HdfsDataFragmenter.java:108)
> at
> org.apache.hawq.pxf.plugins.hdfs.HdfsDataFragmenter.getFragments(HdfsDataFragmenter.java:69)
> at
> org.apache.hawq.pxf.service.rest.FragmenterResource.getFragments(FragmenterResource.java:84)
> ```
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
> eed2d18
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
> 40e6d6f
>
> Diff: https://reviews.apache.org/r/45252/diff/
>
>
> Testing
> ---
>
> Tested manually with and without YARN, with and without security.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 45303: Update HAWQ default_hash_table_bucket_number property logic
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45303/#review125370 --- ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 693) <https://reviews.apache.org/r/45303/#comment188142> nice. - bhuvnesh chaudhary On March 24, 2016, 6:34 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45303/ > --- > > (Updated March 24, 2016, 6:34 p.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, Jayush Luniya, Lav Jain, Matt, Oleksandr Diachenko, and Sumit Mohanty. > > > Bugs: AMBARI-15566 > https://issues.apache.org/jira/browse/AMBARI-15566 > > > Repository: ambari > > > Description > --- > > Update HAWQ default_hash_table_bucket_number property logic > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 4635199 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 682e1c2 > > Diff: https://reviews.apache.org/r/45303/diff/ > > > Testing > --- > > manual > > -- > Ran 246 tests in 7.045s > > OK > -- > Total run:911 > Total errors:0 > Total failures:0 > > > Thanks, > > Alexander Denissov > >
Re: Review Request 45255: PXF should use hostname instead of localhost in pxf urls
> On March 24, 2016, 4:49 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, > > line 136 > > <https://reviews.apache.org/r/45255/diff/1/?file=1312736#file1312736line136> > > > > Did anything break when it was localhost? > > > > Would be surprised if it caused any issue. none breaks, the host listens on all the interface, but generally its better to listen on hostname rather than localhost. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45255/#review125212 --- On March 24, 2016, 12:24 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45255/ > --- > > (Updated March 24, 2016, 12:24 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jonathan Hurley, > Jayush Luniya, and Oleksandr Diachenko. > > > Bugs: AMBARI-15550 > https://issues.apache.org/jira/browse/AMBARI-15550 > > > Repository: ambari > > > Description > --- > > PXF should use actual hostname instead of localhost in pxf urls. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py > 3134f41 > > Diff: https://reviews.apache.org/r/45255/diff/ > > > Testing > --- > > yes. manually > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 45191: HAWQ - exchange keys should be done only from HAWQMASTER
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45191/ --- Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and Oleksandr Diachenko. Bugs: AMBARI-15524 https://issues.apache.org/jira/browse/AMBARI-15524 Repository: ambari Description --- HAWQ - exchange keys should be done only from HAWQMASTER. Currently, both standby and master does exchange keys however, its not required be done twice Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 0631144 ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py 2c3493a ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 1891ede ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 0f52b9e ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py 330b6c0 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 3907ad9 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 8049821 ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 039d109 Diff: https://reviews.apache.org/r/45191/diff/ Testing --- yes. manually Thanks, bhuvnesh chaudhary
Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters
> On March 16, 2016, 8 p.m., Jayush Luniya wrote: > > Ship It! Thank you Jayush. No worries, will do merge now. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44688/#review123919 --- On March 11, 2016, 1:26 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44688/ > --- > > (Updated March 11, 2016, 1:26 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Matt, and Oleksandr Diachenko. > > > Bugs: AMBARI-15380 > https://issues.apache.org/jira/browse/AMBARI-15380 > > > Repository: ambari > > > Description > --- > > PXF alerts are not working on secured HDFS HA clusters. When the cluster is > HA, Active Namenode should be used to get the delegation token for pxf, > however currently it goes to localhost. > Updated the logic to find out the active namenode and use it. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py > 871da2b > > Diff: https://reviews.apache.org/r/44688/diff/ > > > Testing > --- > > yes. manually. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44987/#review124306 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 57) <https://reviews.apache.org/r/44987/#comment186776> with hawq you don't call master directory for segment hawq_segment_dir ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 67) <https://reviews.apache.org/r/44987/#comment186778> probably should have stripped of spaces before creating the dir. - bhuvnesh chaudhary On March 18, 2016, 10:17 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44987/ > --- > > (Updated March 18, 2016, 10:17 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15475 > https://issues.apache.org/jira/browse/AMBARI-15475 > > > Repository: ambari > > > Description > --- > > Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many > [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment] > and the change is not propagated to segments and the folders are not created. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > d62332d > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py > 0a597b6 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py > 9482b35 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 1bdc5aa > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > dc6c203 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496 > > Diff: https://reviews.apache.org/r/44987/diff/ > > > Testing > --- > > manually tested. > > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 > 15:33:42,969 - Standby host c6401.ambari.apache.org initialized > ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 > 15:33:43,025 - Active master c6401.ambari.apache.org initialized > ok > test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 > 15:33:43,049 - Master c6401.ambari.apache.org started > ok > test_stop_default (test_hawqmaster.TestHawqMaster) ... ok > > > Thanks, > > jun aoki > >
Re: Review Request 44987: Editing tmp dir from single to multiple dir doesn't trigger the backend change
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44987/#review124309 --- Ship it! Ship It! - bhuvnesh chaudhary On March 18, 2016, 10:17 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44987/ > --- > > (Updated March 18, 2016, 10:17 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15475 > https://issues.apache.org/jira/browse/AMBARI-15475 > > > Repository: ambari > > > Description > --- > > Modified "HAWQ Segment Temp Directory” from one [/d1/tmp/hawqsegment] to many > [/d1/tmp/hawqsegment,/d2/tmp/hawqsegment,/d3/tmp/hawqsegment,/d4/tmp/hawqsegment,/d5/tmp/hawqsegment] > and the change is not propagated to segments and the folders are not created. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > d62332d > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py > 0a597b6 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py > 9482b35 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 1bdc5aa > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py > dc6c203 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 14b5a5f > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 6ca83b7 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py eaba496 > > Diff: https://reviews.apache.org/r/44987/diff/ > > > Testing > --- > > manually tested. > > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... 2016-03-17 > 15:33:42,969 - Standby host c6401.ambari.apache.org initialized > ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-03-17 > 15:33:43,025 - Active master c6401.ambari.apache.org initialized > ok > test_start_localmaster (test_hawqmaster.TestHawqMaster) ... 2016-03-17 > 15:33:43,049 - Master c6401.ambari.apache.org started > ok > test_stop_default (test_hawqmaster.TestHawqMaster) ... ok > > > Thanks, > > jun aoki > >
Re: Review Request 45012: Recommendation and validation logic for HAWQ hdfs-client.xml output.replace-datanode-on-failure property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45012/#review124226 --- Ship it! Ship It! - bhuvnesh chaudhary On March 18, 2016, 2:01 a.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45012/ > --- > > (Updated March 18, 2016, 2:01 a.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Jayush Luniya, Lav Jain, and Sumit Mohanty. > > > Bugs: AMBARI-15499 > https://issues.apache.org/jira/browse/AMBARI-15499 > > > Repository: ambari > > > Description > --- > > Recommendation and validation logic for HAWQ hdfs-client.xml > output.replace-datanode-on-failure property > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml > c2a756a > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > c0bc4e2 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 4f0b4b7 > > Diff: https://reviews.apache.org/r/45012/diff/ > > > Testing > --- > > manual > > -- > Ran 253 tests in 7.111s > > OK > -- > Total run:927 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alexander Denissov > >
Re: Review Request 44769: Config recommendations for installed services are getting cleared out
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123759 --- Ship it! Ship It! - bhuvnesh chaudhary On March 14, 2016, 3:59 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44769/ > --- > > (Updated March 14, 2016, 3:59 p.m.) > > > Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr > Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, > Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi. > > > Bugs: AMBARI-15396 > https://issues.apache.org/jira/browse/AMBARI-15396 > > > Repository: ambari > > > Description > --- > > As part of AMBARI-15189, dfs.allow.truncate was set to true if HAWQ service > is being installed. However, the recommendation is getting cleared in > ambari-web because HDFS is already installed. > > > Diffs > - > > ambari-web/app/mixins/common/configs/enhanced_configs.js 1ee4526 > > Diff: https://reviews.apache.org/r/44769/diff/ > > > Testing > --- > > Tested manually with and without HAWQ. > > > Thanks, > > Lav Jain > >
Re: Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters
> On March 14, 2016, 5:10 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, > > line 140 > > <https://reviews.apache.org/r/44688/diff/1/?file=1295170#file1295170line140> > > > > Check for null (i.e. no active namenode) > > bhuvnesh chaudhary wrote: > Thanks for review Jayush, > > I was testing the behavior when the Namenode is down to essentially test > for no active namenode, and > https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L135-L143 > handles if the active_namenode identified is an empty list, and returns > UnknownConfiguration(..) if none is found which handles the null / empty case > ? So, thought not to handle it here again. > > On the other hand, the response from get_active_namenode returned is > 'Configuration parameter 'fs_root' was not found in configurations > dictionary!' when no active namenode is found (i turned down HDFS), which is > kind of not explanatory, do you think we should make this as an exception in > a separate jira ? Jayush, Let me know if there is any concern if i drop the issue based on the response provided up. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44688/#review123456 --- On March 11, 2016, 1:26 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44688/ > --- > > (Updated March 11, 2016, 1:26 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Matt, and Oleksandr Diachenko. > > > Bugs: AMBARI-15380 > https://issues.apache.org/jira/browse/AMBARI-15380 > > > Repository: ambari > > > Description > --- > > PXF alerts are not working on secured HDFS HA clusters. When the cluster is > HA, Active Namenode should be used to get the delegation token for pxf, > however currently it goes to localhost. > Updated the logic to find out the active namenode and use it. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py > 871da2b > > Diff: https://reviews.apache.org/r/44688/diff/ > > > Testing > --- > > yes. manually. > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 44687: Update RCO : PXF should start after HDFS
> On March 11, 2016, 9:06 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json, > > line 14 > > <https://reviews.apache.org/r/44687/diff/1/?file=1295169#file1295169line14> > > > > RCO can be defined at service level > > (https://issues.apache.org/jira/browse/AMBARI-9363). Instead of updating > > RCO of HDP stack, can you move the HAWQ and PXF specific ordering into the > > service? Thanks Jayush for the suggestion, let me try that. However, RCO at service level will be applicable only for trunk, for 2.2 branch we still need to update HDP rco. correct ? If so i will remove trunk tag from the list of branches, and keep this pathc for 2.2.0 only. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44687/#review123118 ------- On March 11, 2016, 1:22 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44687/ > --- > > (Updated March 11, 2016, 1:22 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Matt, and Oleksandr Diachenko. > > > Bugs: AMBARI-15381 > https://issues.apache.org/jira/browse/AMBARI-15381 > > > Repository: ambari > > > Description > --- > > Update RCO to ensure that PXF is started after HDFS. > PXF connects to namenode during startup and retries couple of times until > namenode has come up. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > b28f2a9 > > Diff: https://reviews.apache.org/r/44687/diff/ > > > Testing > --- > > yes. manually. > > > Thanks, > > bhuvnesh chaudhary > >
Review Request 44688: PXF should reach out to active namenode to get the delegation token on HDFS HA clusters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44688/ --- Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Matt, and Oleksandr Diachenko. Bugs: AMBARI-15380 https://issues.apache.org/jira/browse/AMBARI-15380 Repository: ambari Description --- PXF alerts are not working on secured HDFS HA clusters. When the cluster is HA, Active Namenode should be used to get the delegation token for pxf, however currently it goes to localhost. Updated the logic to find out the active namenode and use it. Diffs - ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py 871da2b Diff: https://reviews.apache.org/r/44688/diff/ Testing --- yes. manually. Thanks, bhuvnesh chaudhary
Review Request 44687: Update RCO : PXF should start after HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44687/ --- Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Matt, and Oleksandr Diachenko. Bugs: AMBARI-15381 https://issues.apache.org/jira/browse/AMBARI-15381 Repository: ambari Description --- Update RCO to ensure that PXF is started after HDFS. PXF connects to namenode during startup and retries couple of times until namenode has come up. Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json b28f2a9 Diff: https://reviews.apache.org/r/44687/diff/ Testing --- yes. manually. Thanks, bhuvnesh chaudhary
Re: Review Request 44542: Use pxf-service restart method when Restart action is called via Ambari
> On March 9, 2016, 8:17 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py, > > line 62 > > <https://reviews.apache.org/r/44542/diff/2/?file=1292928#file1292928line62> > > > > What happens now if PXF is in started state? > > > > Ideally when you do a restart: > > - if PXF is already in started state, do stop and start > > - if PXF is already in stopped state, do start pxf has restart method which is used for starting it. the method name is start which call it. Dropping the issue. - bhuvnesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44542/#review122791 --- On March 9, 2016, 4:32 a.m., bhuvnesh chaudhary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44542/ > --- > > (Updated March 9, 2016, 4:32 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Matt, and Oleksandr Diachenko. > > > Bugs: AMBARI-15341 > https://issues.apache.org/jira/browse/AMBARI-15341 > > > Repository: ambari > > > Description > --- > > This patch updates the method used to restart PXF. > We should use pxf-service restart method when Restart action is called via > Ambari. > Currently we use pxf-service stop followed by pxf-service start, due to which > if pxf-service is already stopped, stop command fails. > pxf-service restart takes care of not exiting with exit code 1 if pxf-service > is already stopped, and finishes successfully. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py > 9a1eaf3 > > Diff: https://reviews.apache.org/r/44542/diff/ > > > Testing > --- > > yes. manually > > > Thanks, > > bhuvnesh chaudhary > >
Re: Review Request 44528: Align PXF Alert description with other services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44528/#review122635 --- ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json (line 7) <https://reviews.apache.org/r/44528/#comment184744> This host-level alert is triggered if the PXF process cannot be established to be up and listening on the network. - bhuvnesh chaudhary On March 8, 2016, 9:46 p.m., jun aoki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44528/ > --- > > (Updated March 8, 2016, 9:46 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15339 > https://issues.apache.org/jira/browse/AMBARI-15339 > > > Repository: ambari > > > Description > --- > > Align PXF Alert description with other services > > > Diffs > - > > ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json > d32fc97 > > Diff: https://reviews.apache.org/r/44528/diff/ > > > Testing > --- > > Manually Done > > > Thanks, > > jun aoki > >
