Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary 


> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json,
> >  line 201
> > 
> >
> > can this be a slider between 0 ad 100 ? Should we also have validation 
> > that the value is within that range if user manually enters the number ?
> 
> bhuvnesh chaudhary wrote:
> Based on some of the articles i read, it suggested that the value of this 
> parameter can be greater than 100 and was not able to find what is the 
> maximum, so kept it as text-field
> 
> Alexander Denissov wrote:
> maybe at least specify min value as 0 for the property in the .xml file ?

ok, will add and test.


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134692
---


On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> ---
> 
> (Updated May 26, 2016, 4:54 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
> https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  5be3848 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary 


> On May 26, 2016, 5:05 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 340
> > 
> >
> > Is this an override?
> > I don't see this function being called anywhere...

will remove this for now.
to not display some of the properties based on a config value we need to set 
the attribute so added this function earlier.


> On May 26, 2016, 5:05 a.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py, line 
> > 210
> > 
> >
> > This required?

yes. vm.overcommit_ratio = '' indicates that this is the first time when the 
configuration is loaded i.e while coming on the configuration page the first 
time while adding a service. 
if this is '', we recommend vm.overcommit_memory and set vm.overcommit_ratio = 
50, so now on the screen both the values vm.overcommit_memory and 
vm.overcommit_ratio will be there. So if now on this page, you change ratio or 
memory, the values entered by the user are taken for calculations.

However, there is one issue which needs to be fixed yet. For configuration with 
value-list, the recommendation are given by the stack advisor, but the UI loads 
the value which is the default for it in the xml file, ex vm.overcommit_memory.


> On May 26, 2016, 5:05 a.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py, line 
> > 216
> > 
> >
> > This required?

yes.


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134917
---


On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> ---
> 
> (Updated May 26, 2016, 4:54 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
> https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  5be3848 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134917
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 (line 325)


Might have to change this if you are changing the default to 2 on line 320



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 336)


Is this an override?
I don't see this function being called anywhere...



ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py (line 210)


This required?



ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py (line 216)


This required?


- Matt


On May 25, 2016, 9:54 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> ---
> 
> (Updated May 25, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
> https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  5be3848 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary 


> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 207
> > 
> >
> > if user manually puts a value for this field, will we override it with 
> > our recommendations every time they navigate to the config page ?

When HAWQ service is being added, recommendation will be given.
Once on the customize service page while adding user changes 
vm.overcommit_memory or vm.overcommit_ratio, recommendation will be updated.
If the user updates hawq_rm_memory_limit_perseg directly, no recommendations 
are given, so it will not be overridden


> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json,
> >  line 201
> > 
> >
> > can this be a slider between 0 ad 100 ? Should we also have validation 
> > that the value is within that range if user manually enters the number ?

Based on some of the articles i read, it suggested that the value of this 
parameter can be greater than 100 and was not able to find what is the maximum, 
so kept it as text-field


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134692
---


On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> ---
> 
> (Updated May 26, 2016, 4:54 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
> https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  5be3848 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-25 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/
---

(Updated May 26, 2016, 4:54 a.m.)


Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.


Changes
---

Recommendations will be given whenever vm.overcommit_memory or 
vm.overcommit_ratio is changed


Bugs: AMBARI-16827
https://issues.apache.org/jira/browse/AMBARI-16827


Repository: ambari


Description
---

expose vm.overcommit_ratio on hawq-sysctl-env


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 5be3848 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 c51b012 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
836144c 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
e4d1c45 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 53c5574 

Diff: https://reviews.apache.org/r/47802/diff/


Testing
---

yes. test case added.


Thanks,

bhuvnesh chaudhary

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-24 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134692
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 207)


if user manually puts a value for this field, will we override it with our 
recommendations every time they navigate to the config page ?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
(line 201)


can this be a slider between 0 ad 100 ? Should we also have validation that 
the value is within that range if user manually enters the number ?


- Alexander Denissov


On May 25, 2016, 12:17 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> ---
> 
> (Updated May 25, 2016, 12:17 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
> https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-24 Thread Lav Jain 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134670
---


Ship it!




Ship It!

- Lav Jain


On May 25, 2016, 12:17 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> ---
> 
> (Updated May 25, 2016, 12:17 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
> https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 47802: expose vm.overcommit_ratio on hawq-sysctl-env

2016-05-24 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/
---

Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.


Bugs: AMBARI-16827
https://issues.apache.org/jira/browse/AMBARI-16827


Repository: ambari


Description
---

expose vm.overcommit_ratio on hawq-sysctl-env


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 c51b012 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
836144c 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
e4d1c45 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 53c5574 

Diff: https://reviews.apache.org/r/47802/diff/


Testing
---

yes. test case added.


Thanks,

bhuvnesh chaudhary