> On March 11, 2016, 1:36 a.m., Joshua Cohen wrote:
> > Given the proposal to move towards the Mesos unified containerizer, do you
> > think it makes sense to hold off on this and instead implement it in
> > conjunction with those upcoming changes?
> >
> > I h
behavior being exercised related to the Mesos containerizer?
- Joshua Cohen
On March 11, 2016, 12:44 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123036
---
@ReviewBot retry
- Joshua Cohen
On March 10, 2016, 10:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123026
---
@ReviewBot retry
- Joshua Cohen
On March 10, 2016, 10:36 p.m
: https://reviews.apache.org/r/44680/diff/
Testing
---
./pants test src/test/python/apache/thermos/core/
Thanks,
Joshua Cohen
d e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123014
-------
On March 10, 2016, 9:59 p.m., Joshua Cohen wrote:
>
> ---
> This is an a
tps://reviews.apache.org/r/44680/#comment185134>
I'm not sure if there's anything up the call stack that also tries to catch
exceptions here? Would it be wise to re-raise?
- Joshua Cohen
On March 10, 2016, 9:59 p.m., Jo
/core/
Thanks,
Joshua Cohen
> On March 10, 2016, 6:56 p.m., Joshua Cohen wrote:
> > docs/deploying-aurora-scheduler.md, lines 289-291
> > <https://reviews.apache.org/r/44602/diff/2/?file=1294546#file1294546line289>
> >
> > I think this "only" is misleading here? If I underst
b.multi` or `www-data/web.multi`, correct?
- Joshua Cohen
On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44589/#review122801
---
Ship it!
Ship It!
- Joshua Cohen
On March 9, 2016, 8:08 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122786
---
Ship it!
Ship It!
- Joshua Cohen
On March 8, 2016, 5:45 p.m
> On March 8, 2016, 7:25 p.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before launching
accurately reflect the
actual change being made (exposing ports to shell health checkers)?
- Joshua Cohen
On March 8, 2016, 12:49 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
change that
operators should be aware of?
- Joshua Cohen
On March 7, 2016, 11:55 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review122119
---
Ship it!
Ship It!
- Joshua Cohen
On March 4, 2016, 6:03 p.m
need to add an
expectation to the test for the `subject.getPrincipal()` call you added to
generate the response entity?
- Joshua Cohen
On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44368/#review121958
---
Ship it!
Ship It!
- Joshua Cohen
On March 3, 2016, 11:28
.html
821783aca26b54c3b9c824f06ee7c18505ff4629
Diff: https://reviews.apache.org/r/43784/diff/
Testing
---
Verified the pointer showed up in the UI.
Thanks,
Joshua Cohen
e None
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 177)
<https://reviews.apache.org/r/43027/#comment180479>
Might be helpful to have a comment here explaining the allowed values?
- Joshua Cohen
On Feb. 13, 2016, 2:17 a.m., Benjamin S
/r/43486/diff/
Testing
---
./build-support/python/jenkins.sh
Thanks,
Joshua Cohen
src/test/python/apache/aurora/executor/test_thermos_executor.py
32e8b9bad4803b2196716cbc6710366a8a8c01a3
Diff: https://reviews.apache.org/r/43486/diff/
Testing
---
./build-support/python/jenkins.sh
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43373/#review118707
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 10, 2016, 6:33 p.m
che.org/r/43373/#comment179696>
What happens if someone specifies an instance range here instead of a
single instance?
- Joshua Cohen
On Feb. 9, 2016, 7:44 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43253/#review118412
---
@ReviewBot retry
- Joshua Cohen
On Feb. 9, 2016, 4:22 p.m
3c8d1b0a0e/src/sched/sched.cpp#L1057)
> > tends to indicated that thermos has crashed.
>
> Bill Farner wrote:
> +1 to both
>
> Joshua Cohen wrote:
> I'll add a NEWS entry. The `executorLost` call is in the 0.26.x -> 0.27.x
> upgrade though, so going
sTest.java
7e0709fefc42c1a2379bda37219fddf28cfbbb9a
Diff: https://reviews.apache.org/r/43253/diff/
Testing
---
./gradlew build -Pq
End to end tests all pass.
Thanks,
Joshua Cohen
0d41466aa791590d219721aa4e12937d7b5939a4
src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java
7e0709fefc42c1a2379bda37219fddf28cfbbb9a
Diff: https://reviews.apache.org/r/43253/diff/
Testing
---
./gradlew build -Pq
End to end tests all pass.
Thanks,
Joshua Cohen
lTest.java
0d41466aa791590d219721aa4e12937d7b5939a4
src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java
7e0709fefc42c1a2379bda37219fddf28cfbbb9a
Diff: https://reviews.apache.org/r/43253/diff/
Testing
---
./gradlew build -Pq
End to end tests all pass.
Thanks,
Joshua Cohen
a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43253/#review118021
-------
On Feb. 5, 2016, 4:05 p.m., Joshua Cohen wrote:
>
> --
.
Thanks,
Joshua Cohen
-Pq
End to end tests all pass.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117471
---
On Feb. 2, 2016, 9:51 p.m., Joshua Cohen wrote:
>
> --
/test_bypass_leader_redirect_end_to_end.sh
PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
1171dca4af01a11e684f0b7a63a50250a8da1d22
Diff: https://reviews.apache.org/r/42964/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
use there
> > is a default.
Yep, fixed.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117260
-------
On Feb.
nt and an end to end test to validate the behavior.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117259
-------
On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
>
>
----------
On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> ---
---
./gradlew build -Pq
Thanks,
Joshua Cohen
/test_end_to_end.sh
1171dca4af01a11e684f0b7a63a50250a8da1d22
Diff: https://reviews.apache.org/r/42964/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
21371d951f8c6e44c40f97793d6acd26d3ca5614
src/test/python/apache/aurora/client/api/test_scheduler_client.py
4c4caaf76ce9f529c834f33f786036022766044d
Diff: https://reviews.apache.org/r/42964/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
ated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117013
---
On Feb. 1, 2016, 8:05 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42985/#review117227
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 29, 2016, 11:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42979/#review117226
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 29, 2016, 10:38
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117036
---
On Jan. 29, 2016, 8:54 p.m., Joshua Co
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117013
-------
On Jan. 29, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -
21371d951f8c6e44c40f97793d6acd26d3ca5614
Diff: https://reviews.apache.org/r/42964/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
8438f7287b9a95a2cecd72c996b84901cabed4e1
Diff: https://reviews.apache.org/r/42922/diff/
Testing
---
Thanks,
Joshua Cohen
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review116973
---
On Jan. 29, 2016, 5:53 p.m., Joshua Co
icket, but we've
filed https://issues.apache.org/jira/browse/AURORA-1603 to track the triage of
what actually went wrong with this commit.
- Joshua Cohen
On Jan. 28, 2016, 10:15 p.m., Joshua Cohen wrote:
>
> ---
> This
/org/apache/aurora/scheduler/http/AbstractJettyTest.java
19c8a1fe06a24022da11f74d7c96b2942587
Diff: https://reviews.apache.org/r/42964/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
---
On Jan. 28, 2016, 10:15 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42922/
> --
,
Joshua Cohen
---
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42804/#review116391
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 26, 2016, 4:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42567/#review115456
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 20, 2016, 7:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42077/#review115222
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 12, 2016, 7:58 p.m
post an updated
review? Then I'll commit this change.
- Joshua Cohen
On Jan. 12, 2016, 7:58 p.m., George Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42046/#review114060
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 12, 2016, 6:52 p.m
ines 153 - 156)
<https://reviews.apache.org/r/42046/#comment174792>
Nit, just use `//` for multi-line comments.
- Joshua Cohen
On Jan. 12, 2016, 1:15 a.m., Amol Deshmukh wrote:
>
> ---
> This is an automatically gener
s (and
other instances of aligned method args) should be formatted as:
public OfferAllocationImpl(
Offer offer,
ResourceSlot taskSlot,
...
TierInfo tierInfo) {
requireNonNull(offer);
...
- Joshua Cohen
ly, visit:
> https://reviews.apache.org/r/42046/
> ---
>
> (Updated Jan. 9, 2016, 12:55 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-1576
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review113135
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 6, 2016, 8:47 p.m
to let me set a
custom serverset path (i.e. it seems similar to the `announcer-serverset-path`
flag).
- Joshua Cohen
On Jan. 5, 2016, 9:33 p.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41966/#review113089
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 6, 2016, 4:27 a.m
> On Jan. 5, 2016, 5 p.m., Joshua Cohen wrote:
> > Ship It!
We're seeing similar timeouts on our internal build as well.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apac
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/#review112868
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 5, 2016, 7:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41899/#review112867
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 4, 2016, 11:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112275
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 29, 2015, 10:32 p.m
#x27;re at it, can we name the test targets to match the directory (so
`api` in this case)? That way we can use pants target shorthand of `./pants
test src/test/python/apache/aurora/client/api` rather than having to do, e.g.,
`api:all`
- Joshua Cohen
On Dec. 29, 2015, 9:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41775/#review112179
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 29, 2015, 4:06 p.m
using a newer version?
Presumably 2.5 and 2.6 are compatible, but just want to be sure...
- Joshua Cohen
On Dec. 29, 2015, 3:53 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
/r/41743/diff/
Testing
---
Thanks,
Joshua Cohen
---
Added a note for committers on formatting commit messages generated by ./rbt
patch
Diffs
-
CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
Diff: https://reviews.apache.org/r/41743/diff/
Testing
---
Thanks,
Joshua Cohen
743/#comment172308>
Let me know if you think this should be 100 chars?
- Joshua Cohen
On Dec. 28, 2015, 3:58 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Dec. 23, 2015, 4:48 p.m., Joshua Cohen wrote:
> > build-support/jenkins/review_feedback.py, lines 142-143
> > <https://reviews.apache.org/r/41659/diff/2/?file=1174743#file1174743line142>
> >
> > Not sure there's anything we can do about it, but if
, and keep an
eye out for erroneous "needs rebase" messages from ReviewBot).
- Joshua Cohen
On Dec. 22, 2015, 9:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41537/#review111788
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 23, 2015, 4:33 p.m
a/uploaded/files/2015/12/17/2759a88b-a2c4-4c45-a45f-037126e30f1e__Screen_Shot_2015-12-17_at_5.02.51_PM.png
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41536/#review111485
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 18, 2015, 12:20 a.m
r: Service Unavailable,
reconnecting...
File Attachments
No Leader page
https://reviews.apache.org/media/uploaded/files/2015/12/17/2759a88b-a2c4-4c45-a45f-037126e30f1e__Screen_Shot_2015-12-17_at_5.02.51_PM.png
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111063
---
Ship it!
lgtm pending the changes Bill requested.
- Joshua Cohen
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
(line 150)
<https://reviews.apache.org/r/41473/#comment171043>
Same here, one arg per line.
- Joshua Cohen
On Dec. 17, 2015, 9:10 p.m., Renan DelValle wrote:
>
>
,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41428/#review111032
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 17, 2015, 7:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41522/#review111001
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 17, 2015, 6:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41523/#review111000
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 17, 2015, 6:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41486/#review110994
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 17, 2015, 5:55 p.m
org/r/41521/diff/
Testing
---
Applied settings to a checkout on a windows box and verified I was able to
provision a VM w/ Vagrant and connect to the scheduler there.
Thanks,
Joshua Cohen
va/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
(line 150)
<https://reviews.apache.org/r/41473/#comment170986>
Add a message to provide context on the exception? E.g.
throw new IllegalArgumentException("Failed to read executor settings: "
+ e
(line 214)
<https://reviews.apache.org/r/41428/#comment170828>
Rename this var too? `_end` was never great, but now it's lost all
relevance ;).
- Joshua Cohen
On Dec. 16, 2015, 10:43 p.m., Dmitriy Shirchenko wrote:
>
>
> On Dec. 16, 2015, 10:14 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/client/test_config.py, line 187
> > <https://reviews.apache.org/r/41428/diff/4/?file=1166716#file1166716line187>
> >
> > Kill this comment? It seems superfluous.
>
>
line 272)
<https://reviews.apache.org/r/41428/#comment170769>
Drop this comment as well.
- Joshua Cohen
On Dec. 16, 2015, 7:08 p.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41453/#review110738
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 16, 2015, 7:53 p.m
> On Dec. 16, 2015, 4:22 p.m., Joshua Cohen wrote:
> > I'd like to propose an alternate configuration schema for consideration. I
> > feel like the version presented in this review is redundant and tries to
> > shoehorn the "endpoint" concept onto a shell
al_secs = 30,
health_checker = HealthChecker(http=HttpHealthChecker(...)))
So I guess what I'm getting at is, instead of calling everything an `endpoint`,
let's call them `health_checker`s?
- Joshua Cohen
On Dec. 16, 2015, 7:15 a.m., Dmitriy Shirchenko wrote:
>
> -
> On Dec. 11, 2015, 7:43 p.m., Zameer Manji wrote:
> > Overall this LGTM. The only thing holding back my shipit is a possible
> > addition to the e2e test suite.
> >
> > Bill, Maxim, Josh: Do you think this change requires an addition to the e2e
> > suite? I'm on the fence. It seems overkill f
chema changes.
- Joshua Cohen
On Dec. 11, 2015, 7:25 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
47)
<https://reviews.apache.org/r/41154/#comment169604>
Should we use `shlex.split` here instead?
- Joshua Cohen
On Dec. 11, 2015, 2:36 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e
> On Dec. 11, 2015, 1:28 a.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/common/BUILD, line 26
> > <https://reviews.apache.org/r/41154/diff/4/?file=1159642#file1159642line26>
> >
> > I don't think we need this dependency here. The tests und
ck/test_shell.py (line 39)
<https://reviews.apache.org/r/41154/#comment169585>
Mind splitting these up into individual test cases?
- Joshua Cohen
On Dec. 11, 2015, 12:08 a.m., Dmitriy Shirchenko wrote:
>
> ---
501 - 600 of 746 matches
Mail list logo
