Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136375 --- Ship it! Ship It! - Stephan Erb On June 4, 2016, 8:33 p.m.,

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136176 --- Ship it! Master (d64e179) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On June 4, 2016, 5:17 p.m., Stephan Erb wrote: > > docs/features/webhooks.md, line 1 > > > > > > Please add a reference to this file in `docs/README.md` Done. > On June 4, 2016, 5:17 p.m., Stephan Erb wrote: > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated June 4, 2016, 6:33 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136169 --- docs/features/webhooks.md (line 1)

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136144 --- Ship it! Master (692b5d1) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated June 3, 2016, 11:54 p.m.) Review request for Aurora, Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated June 3, 2016, 10:17 p.m.) Review request for Aurora, Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 27, 2016, 2 p.m., Stephan Erb wrote: > > Repeating from my previous review: Would be great if you could add > > > > * an entry to the release notes > > * a minimal docs/features/webhooks.md that shows a valid webhook config and > > how a dispatched event would look like. Done. > On

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135233 --- Repeating from my previous review: Would be great if you could

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 22, 2016, 3:28 p.m., Stephan Erb wrote: > > docs/reference/scheduler-configuration.md, line 222 > > > > > > How about something like: "File to configure a HTTP webhook to receive > > task state change

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135111 --- Ship it! Master (b76e38f) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135104 --- Master (b76e38f) is red with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 26, 2016, 10:01 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java, line 46 > > > > > > kill newline Done. > On May 26, 2016, 10:01 p.m., Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 26, 2016, 10:29 p.m.) Review request for Aurora, Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135093 --- Ship it! Master (b76e38f) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135087 --- Ship it!

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 26, 2016, 9:48 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135082 --- Ship it! Master (b76e38f) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135074 ---

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 26, 2016, 9:14 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134853 --- src/main/java/org/apache/aurora/scheduler/events/Webhook.java

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134811 --- LGTM. Only minor comments/questions left.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134674 --- Ship it! Master (9f6a660) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 23, 2016, 6 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 39 > > > > > > Can your return this from `initializeConnection()` instead of keeping a > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134637 --- docs/reference/scheduler-configuration.md (line 222)

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134392 --- src/main/java/org/apache/aurora/scheduler/events/Webhook.java

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 45 > > > > > > +1 > > > > Also, consider caching and reusing the connection in a

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 19, 2016, midnight, Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 163 > > > > > > By using the object as-is, we have effectively made in internal API > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134264 --- LGTM overall. Some notes below and some quetions to Maxim as I

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 10:56 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 76 > > > > > > Given that state changes happen very frequently, should we consider > > using

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 4:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133862 --- Ship it! Master (3cbff41) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 18, 2016, 10 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 45 > > > > > > I am surprised to find this one here. Are you planning to bundle a > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 19, 2016, 2:16 a.m.) Review request for Aurora. Bugs:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133816 --- Ship it! Master (3cbff41) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 31 > > > > > > move to previous line Done. > On May 17, 2016, 5:09 p.m., Maxim

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 18, 2016, 9:12 p.m.) Review request for Aurora. Bugs:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 2:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133555 --- docs/reference/scheduler-configuration.md (line 84)

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133517 --- src/main/java/org/apache/aurora/scheduler/events/Webhook.java

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133505 --- Ship it! Master (3cbff41) is green with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 2:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 17, 2016, 6:44 a.m.) Review request for Aurora. Bugs:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133496 --- Master (3cbff41) is red with this patch.

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- (Updated May 17, 2016, 5:49 a.m.) Review request for Aurora. Bugs:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 2:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > >

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133482 --- Exciting to see progress on this functionality!

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133479 --- Master (3cbff41) is red with this patch.

Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/ --- Review request for Aurora. Bugs: AURORA-1683