Re: Review Request 37956: Only process instances if there's been a change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97500 --- Ship it! Ship It! - David McLaughlin On Sept. 1, 2015, 4:03

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Aug. 31, 2015, 7:35 p.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, line 1 > > > > > > Can you expand this example to include the command executor? That's > > likely to be the first

Re: Review Request 37926: Adding oversubscription e2e tests.

> On Aug. 31, 2015, 11:31 p.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 322 > > > > > > We probably only want to create a job using revocable resources and > > watch that

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review97468 --- examples/vagrant/executors-config.json (lines 4 - 7)

Re: Review Request 37926: Adding oversubscription e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/#review97480 --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (line 255)

Re: Review Request 37956: Only process instances if there's been a change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97479 --- Ship it! Ship It! - Bill Farner On Sept. 1, 2015, 9:03 a.m.,

Re: Review Request 37926: Adding oversubscription e2e tests.

> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote: > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255 > > > > > > What's being tested here? Are you trying to determine whether the task > >

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with

Re: Review Request 38080: Remove openjdk runtime requirement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38080/#review97573 --- Ship it! Ship It! - Bill Farner On Sept. 2, 2015, 4:36 p.m.,

Re: Review Request 38080: Remove openjdk runtime requirement.

> On Sept. 2, 2015, 5:08 p.m., Bill Farner wrote: > > Ship It! > > Kevin Sweeney wrote: > procedural question - I see there's a long-running 0.9.x branch - should > I merge this to master then merge this into that branch? More or less, yes - i've been cherry-picking back onto 0.9.x. -

Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/ --- Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji. Bugs:

Review Request 38080: Remove openjdk runtime requirement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38080/ --- Review request for Aurora, Steve Salevan and Bill Farner. Repository:

Review Request 38084: Builder should run createrepo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38084/ --- Review request for Aurora and Bill Farner. Repository: aurora-packaging

Re: Review Request 38079: Alter code generator to replace null collection fields with an empty collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38079/#review97591 --- -1, don't review this - the generated code is broken. Will

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Sept. 2, 2015, 4:45 p.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, lines 17-18 > > > > > > Can you omit this since it's blank? Yep, was just leaving it there for now so I don't forget to

Re: Review Request 38080: Remove openjdk runtime requirement.

> On Sept. 2, 2015, 5:08 p.m., Bill Farner wrote: > > Ship It! procedural question - I see there's a long-running 0.9.x branch - should I merge this to master then merge this into that branch? - Kevin --- This is an automatically

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, lines 4-7 > > > > > > The code later converts this array into a single command string. I > > suggest we just make this a

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, lines 4-7 > > > > > > The code later converts this array into a single command string. I > > suggest we just make this a

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97590 --- Ship it! Master (a459527) is green with this patch.

Re: Review Request 38084: Builder should run createrepo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38084/#review97595 --- Ship it! Thanks!! - Bill Farner On Sept. 2, 2015, 6:01 p.m.,

Review Request 38086: Add test environments for RPMs and debs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging

Re: Review Request 38086: Add test environments for RPMs and debs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/ --- (Updated Sept. 2, 2015, 7:59 p.m.) Review request for Aurora and Kevin

Re: Review Request 37926: Adding oversubscription e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37926/ --- (Updated Sept. 3, 2015, 4:23 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37956: Only process instances if there's been a change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97503 --- Master (64c00f1) is red with this patch.

Re: Review Request 38072: Revert "Refer to shared task_configs table for job updates."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38072/#review97543 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 2, 2015, 10:07

Re: Review Request 38072: Revert "Refer to shared task_configs table for job updates."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38072/#review97547 --- Ship it! Master (85f93a7) is green with this patch.