Re: Review Request 52897: added EA to adopter's list.

2016-10-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52897/#review152738 --- Ship it! Ship It! - Stephan Erb On Oct. 14, 2016, 11:14

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152572 --- Just a few more comments, overall lgtm!

Re: Review Request 52884: Document how to create a custom CLI build

2016-10-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152706 --- Ship it! We do build sdists but we don't upload them to PyPI.

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread David McLaughlin
> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 52884: Document how to create a custom CLI build

2016-10-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152691 --- Ship it! Ship It! - Joshua Cohen On Oct. 14, 2016, 3:03

Re: Review Request 52884: Document how to create a custom CLI build

2016-10-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152681 --- Master (8256000) is red with this patch.

Review Request 52884: Document how to create a custom CLI build

2016-10-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/ --- Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152662 --- Ship it! Master (8256000) is green with this patch.

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 14, 2016, 12:40 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152660 --- Master (8256000) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread Giulio Eulisse
> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread Giulio Eulisse
> On Oct. 13, 2016, 7:10 p.m., Santhosh Kumar Shanmugham wrote: > > src/test/python/apache/aurora/common/test_cookie_auth_module.py, line 18 > > > > > > Can we also have a negative test case, where the COOKIE auth

Re: Review Request 51893: Allow cookie based authentication

2016-10-14 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 14, 2016, 11:52 a.m.) Review request for Aurora, Joshua Cohen