Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47050/#review132503 --- Ship it! Ship It! - Joshua Cohen On May 10, 2016, 5:54 p.m

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

here? Sure, will do. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review131703 --- On May 4, 20

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

b33e8f5cd95ce25ba0dc4c08da32783cecf1c44d src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh eee6b4c62130567ecd5c32603feae88fce1c13a8 Diff: https://reviews.apache.org/r/46835/diff/ Testing --- ./gradlew build -Pq e2e tests with new base box. Thanks, Joshua Cohen

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

es this have to be bundled into this RB? We are still using this path > > in DEFAULT_CHECKPOINT_ROOT on the thermos side. Perhaps, have a more > > thorough cleanup in a separate patch? > > Joshua Cohen wrote: > I need to drop the mount for the e2e test to work. I can dr

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

es this have to be bundled into this RB? We are still using this path > > in DEFAULT_CHECKPOINT_ROOT on the thermos side. Perhaps, have a more > > thorough cleanup in a separate patch? > > Joshua Cohen wrote: > I need to drop the mount for the e2e test to work. I can dr

Re: Review Request 46241: Upgrade to Mesos 0.27.2

e always been 0. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46241/#review129054 --- On April 15, 2016, 1:

Review Request 46336: Revert "Revert "Upgrade to Mesos 0.27.2""

606dfa4fda020bee8d963a7dccab01502c721636 build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f Diff: https://reviews.apache.org/r/46336/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 46336: Revert "Revert "Upgrade to Mesos 0.27.2""

ed "Not yet released" from 0.13.0 - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46336/#review129357 ------- On Ap

Re: Review Request 46291: Moving db migration into LogStorage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46291/#review129359 --- Ship it! Ship It! - Joshua Cohen On April 15, 2016, 11:37

Re: Review Request 46336: Revert "Revert "Upgrade to Mesos 0.27.2""

a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e Vagrantfile 606dfa4fda020bee8d963a7dccab01502c721636 build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f Diff: https://reviews.apache.org/r/46336/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

check to be `sudo ...`. I may have missed the resolution of that discussion, was that not a feasible approach? - Joshua Cohen On April 18, 2016, 6:33 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generat

Review Request 46335: Add an explicit box version to Vagrantfile.

with latest local box being version 3, confirmed it pulled down version 4. Thanks, Joshua Cohen

Re: Review Request 46336: Revert "Revert "Upgrade to Mesos 0.27.2""

://reviews.apache.org/r/46336/diff/ Testing --- Thanks, Joshua Cohen

Review Request 46241: Upgrade to Mesos 0.27.2

e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f Diff: https://reviews.apache.org/r/46241/diff/ Testing --- build-support/jenkins/build.sh ran e2e tests. Thanks, Joshua Cohen

Re: Review Request 50480: Multiple executor support in Scheduler

the executor config exists here? The previous branch is checking if executorConfig is set and that the config exists, but won't we fall into this branch if executorConfig is not set? - Joshua Cohen On July 27, 2016, 2:04 a.m., Renan DelValle wrote: > > -

Re: Review Request 50478: Improve `executorLost` error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50478/#review143663 --- Ship it! Ship It! - Joshua Cohen On July 27, 2016, 1:25 a.m

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143388 --- @ReviewBot retry - Joshua Cohen On July 25, 2016, 3:30 p.m

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

(line 20) <https://reviews.apache.org/r/49048/#comment209161> Given that tier names are configurable by Aurora operators, should we word this differently? - Joshua Cohen On July 25, 2016, 3:30 p.m., Mehrdad Nurolahzade

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

ally generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > --- > > (Updated July 20, 2016, 5:56 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/brow

Re: Review Request 50530: AURORA-1656 Document tier concept

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50530/#review143793 --- Ship it! Ship It! - Joshua Cohen On July 27, 2016, 7:32 p.m

Review Request 50584: Upgrade to Mesos 1.0.0

://reviews.apache.org/r/50584/diff/ Testing --- ./build-support/jenkins/build.sh ran e2e tests. Thanks, Joshua Cohen

Re: Review Request 50584: Upgrade to Mesos 1.0.0

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50584/#review144164 ------- On July 28, 2016, 9:18 p.m., Joshua Cohen wrote: > > --- > This is

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

tps://reviews.apache.org/r/50432/#comment210196> Isn't this undoing the bug fix to compare w/ `Empty` instead of `None`? - Joshua Cohen On July 29, 2016, 9 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically g

Re: Review Request 50617: AURORA-1741 Added missing test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144223 --- Ship it! Ship It! - Joshua Cohen On July 29, 2016, 10:46

Re: Review Request 50584: Upgrade to Mesos 1.0.0

src/test/sh/org/apache/aurora/e2e/Dockerfile 6fdea3d28760f59235c51c5b6913d2ee0172ef1a Diff: https://reviews.apache.org/r/50584/diff/ Testing --- ./build-support/jenkins/build.sh ran e2e tests. Thanks, Joshua Cohen

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

python to ensure that the executor's filesystem is truly isolated. Thanks, Joshua Cohen

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

> On July 25, 2016, 3:55 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 20 > > <https://reviews.apache.org/r/49048/diff/7-8/?file=1440195#file1440195line20> > > > > Given that tier names are configurable by Aurora operators, should we > &

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

this up with a test case if possible? - Joshua Cohen On July 26, 2016, 2:36 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

that explicitly does not include python to ensure that the executor's filesystem is truly isolated. Thanks, Joshua Cohen

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

> On July 26, 2016, 2:36 p.m., Joshua Cohen wrote: > > I know this is already landed, but it would be nice to follow this up with > > a test case if possible? > > Mehrdad Nurolahzade wrote: > The logic has two test cases: > (https://gi

Re: Review Request 50716: Use Docker host network rather than bridging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50716/#review144529 --- Ship it! Ship It! - Joshua Cohen On Aug. 2, 2016, 9:13 p.m

Re: Review Request 50685: Support TBinaryProtocol over HTTP

for the response type to be dictated by the `Content-Type` of the request. We should probably use the `Accept` header instead? I don't necessarily know if the use case exists to send json yet want to receive binary, but it's more idiomatic HTTP to support that possibility. - Joshua Cohen On Aug

Re: Review Request 50480: Multiple executor support in Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50480/#review144578 --- Ship it! Ship It! - Joshua Cohen On Aug. 2, 2016, 11:38 p.m

Review Request 50669: Upgrade aurora-packaging for Mesos 1.0.0.

/ubuntu-trusty/provision.sh 8105f6ec122f29db8cb039957a79a8c2b758066f test/rpm/centos-7/provision.sh ae1fe693131bebaee0818c61ab022ad3cc244075 Diff: https://reviews.apache.org/r/50669/diff/ Testing --- Built local packages for ubuntu, debian and centos. Thanks, Joshua Cohen

Re: Review Request 50480: Multiple executor support in Scheduler

be a big change, I'd be ok with shipping it in a follow up review. - Joshua Cohen On Aug. 2, 2016, 11:38 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 50931: Remove unnecessary guice container parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50931/#review145300 --- Ship it! Ship It! - Joshua Cohen On Aug. 9, 2016, 7:53 p.m

Re: Review Request 50937: Bump jetty dependency to the latest release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50937/#review145301 --- Ship it! Ship It! - Joshua Cohen On Aug. 9, 2016, 9:57 p.m

Re: Review Request 50168: Add rollback functionality to the scheduler

to me, but I want Maxim to take another quick pass before shipping, as he expressed concerns about testing the new transition. - Joshua Cohen On Aug. 9, 2016, 10:41 p.m., Igor Morozov wrote: > > --- > This is an automatically ge

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

is truly isolated. Thanks, Joshua Cohen

Re: Review Request 50480: Multiple executor support in Scheduler

> On Aug. 3, 2016, 2:36 a.m., Joshua Cohen wrote: > > I was about to push this change, but in the process of running e2e tests > > locally after applying your patch, it occurs to me that perhaps this is > > something we should have e2e coverage for. > > > >

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

ok with shipping this. If others feel strongly that they're problematic then we can investigate a custom jackson serializer to clean them up. - Joshua Cohen On July 20, 2016, 4:26 p.m., Mehrdad Nurolahzade wrote

Re: Review Request 50168: Add rollback functionality to the scheduler

/aurora/client/cli/update.py#L61-L76 src/main/python/apache/aurora/client/cli/update.py (line 332) <https://reviews.apache.org/r/50168/#comment208800> Maybe something like "Rollback the latest in-progress or completed update."

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

oot `TO_BEAN` function returns) - Joshua Cohen On July 14, 2016, 11:08 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139923 --- Ship it! - Joshua Cohen On June 28, 2016, 11:57 p.m

Re: Review Request 49218: Add support for Mesos Fetcher

/#comment205265> It's hard to tell from looking at the review, do we have the inverse of this scenario covered as well (i.e. mesos fetcher is disabled and task config has no mesos fetcher uris set)? If not, would you mind adding coverage for that? - Joshua Cohen On June 28, 2016, 9:39 p.

Re: Review Request 49732: Update package scripts to 0.15.0.

> On July 7, 2016, 2:33 a.m., John Sirois wrote: > > I am slightly worried the tests only seem to work after this change ... > > IIUC Aurora 0.15.0 should work with mesos 0.27.2 (Aurora should work with > > the mesos its developed against +/- 1). > > John Sirois wrote: > Oh, now I

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

> On June 29, 2016, 3:39 a.m., Joshua Cohen wrote: > > > > Mehrdad Nurolahzade wrote: > Should this be merged with upstream now that 0.15 is released? Yes, we can land this now. Would you mind rebasing? Then I can com

Re: Review Request 49732: Update package scripts to 0.15.0.

depends on what we change in Aurora > to bump up the Mesos version. In 0.15.0, we upgraded Mesos to 0.28.2 that > required us to treat the new Mesos task state (KILLING). This means 0.15.0 > cannot rely on 0.27.2 anymore and >= 0.28.2 seems the only logical constraint > there. &

Re: Review Request 50826: Populate the source field of ExecutorInfo.

> On Aug. 5, 2016, 12:50 a.m., Joshua Cohen wrote: > > This does not compile. We have -Werror set on our builds which means the > > warning about the field being deprecated causes a build failure. If we do want to maintain this across a release boundary for compatibility s

Re: Review Request 50826: Populate the source field of ExecutorInfo.

means the warning about the field being deprecated causes a build failure. - Joshua Cohen On Aug. 5, 2016, 12:34 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50826: Populate the source field of ExecutorInfo.

We should extract sourceName to a var here just like we do in the test. - Joshua Cohen On Aug. 5, 2016, 1:05 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50168: Add rollback functionality to the scheduler

ly trying to roll back an update. We could update `JobUpdateStateMachine` to allow for the transition from `ROLL_FORWARD_AWAITING_PULSE` to `ROLLING_BACK`. - Joshua Cohen On Aug. 3, 2016, 10:16 p.m., Igor Moro

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

filesystem image that explicitly does not include python to ensure that the executor's filesystem is truly isolated. Thanks, Joshua Cohen

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

prefer if we throw an error (here, or at another appropriate > > place) if we are supposed to use a filesystem image without a containerizer > > path. Added some code to fail fast if task is using an image but path to mesos-containerizer is not provided. - Joshua --- This is an automatically gen

Re: Review Request 50685: Support TBinaryProtocol over HTTP

.org/r/50685/#comment210463> This could use HTTP 415? - Joshua Cohen On Aug. 2, 2016, 1:29 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140289 --- Ship it! Ship It! - Joshua Cohen On June 30, 2016, 11:29

Review Request 49384: Upgrade to Mesos 0.28.2.

Thanks, Joshua Cohen

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49384/#review140006 --- @ReviewBot retry - Joshua Cohen On June 29, 2016, 4:33 p.m

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

sed, but it doesn't seem to be available yet. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49384/#review140007 --------

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49384/#review140012 --- @ReviewBot retry - Joshua Cohen On June 29, 2016, 4:33 p.m

Re: Review Request 49384: Upgrade to Mesos 0.28.2.

ly, visit: https://reviews.apache.org/r/49384/#review140022 --- On June 29, 2016, 4:33 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 51192: Moving custom executors documentation to features, adding gorealis to tools

/configuration.md <https://reviews.apache.org/r/51192/#comment212458> I'd say leave something along these lines this in this file with a link to the full documentation? - Joshua Cohen On Aug. 17, 2016, 10:52 p.m., Renan DelValle

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review163995 --- Ship it! Ship It! - Joshua Cohen On Feb. 2, 2017, 12:57 a.m

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

> On Jan. 31, 2017, 7:09 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 155 > > > > > > Can you link to the commit that did this or

Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55471/#review162695 --- Ship it! Ship It! - Joshua Cohen On Jan. 23, 2017, 5 p.m

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162693 --- Ship it! Ship It! - Joshua Cohen On Jan. 23, 2017, 8:21 p.m

Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163334 --- Ship it! Ship It! - Joshua Cohen On Dec. 15, 2016, 5:48 p.m

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

intractable though. Would you mind taking a swing at that now that the json object is more complex? - Joshua Cohen On Jan. 25, 2017, 7:02 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 55020: AURORA-1835 Expose finer grained offer veto stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55020/#review163005 --- Ship it! Ship It! - Joshua Cohen On Dec. 23, 2016, 10:46

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162993 --- Ship it! lgtm pending a clean reviewbot run. - Joshua Cohen

Re: Review Request 55536: Improve `thriftw` robustness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55536/#review161945 --- Ship it! Ship It! - Joshua Cohen On Jan. 14, 2017, 6:19 p.m

Re: Review Request 55646: Ensure Aurora thrift support js and html.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55646/#review161968 --- Ship it! Ship It! - Joshua Cohen On Jan. 17, 2017, 9:30 p.m

Re: Review Request 55071: Disable H2 logging via SLF4J.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55071/#review161954 --- Ship it! Ship It! - Joshua Cohen On Dec. 28, 2016, 11:28

Re: Review Request 55684: Fix command escaping when using the Mesos containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55684/#review162338 --- Ship it! Ship It! - Joshua Cohen On Jan. 18, 2017, 8:54 p.m

Review Request 51298: A few executor fixes for filesystem isolation:

/ Testing --- ./build-support/jenkins/build.sh e2e tests Thanks, Joshua Cohen

Re: Review Request 51301: Use a fixed Debian mirror rather than relying on httpredir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51301/#review146536 --- Ship it! Ship It! - Joshua Cohen On Aug. 22, 2016, 9:05 p.m

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

for uid/gid exists as a reference). - Joshua Cohen On Aug. 31, 2016, 7:29 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

> ------- > > (Updated Aug. 31, 2016, 8:56 p.m.) > > > Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji. > > > Bugs: AURORA-1761 > https://issues.apache.org/jira/browse/AURORA-1761 > &

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

to update.py since that's the only place it's used now? - Joshua Cohen On Sept. 1, 2016, 12:54 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

> On Aug. 30, 2016, 9:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, > > line 130 > > <https://reviews.apache.org/r/51536/diff/1/?file=1488791#file1488791line130> > > > > Doing this based s

Re: Review Request 51469: Remove static Stats method `exportSize`.

fork and centralizing the stats interface with the understanding that we might re-add some of this in the future if/when the need arises. - Joshua Cohen On Aug. 26, 2016, 10:11 p.m., Zameer Manji wrote: > > --- > This is an auto

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51580/#review147855 --- Ship it! Ship It! - Joshua Cohen On Sept. 5, 2016, 6:56 p.m

Re: Review Request 51664: Document the Mesos containerizer

ines 158 - 159) <https://reviews.apache.org/r/51664/#comment215622> s/to pass// - Joshua Cohen On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 51500: Configure ssh for e2e tests once globally, rather than as part of a specific test case.

vagrant environment. Thanks, Joshua Cohen

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

rather than a set of strings which is what this will currently pass? - Joshua Cohen On Aug. 28, 2016, 3:58 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Aug. 29, 2016, 6:52 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 193 > > <https://reviews.apache.org/r/51384/diff/4/?file=1487511#file1487511line193> > > > > Am I missing something? Shouldn't this be a set of `Me

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

/executor/common/test_sandbox.py 2ba3341273efe54d1a79fe48be50d4253530dcbc src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 Diff: https://reviews.apache.org/r/51502/diff/ Testing --- ./build-support/jenkins/build.sh e2e tests Thanks, Joshua Cohen

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51502/#review147208 --- @ReviewBot retry - Joshua Cohen On Aug. 29, 2016, 8:28 p.m

Review Request 51502: Clean up leaking of mounts into the host's mtab.

/apache/aurora/e2e/test_end_to_end.sh 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 Diff: https://reviews.apache.org/r/51502/diff/ Testing --- ./build-support/jenkins/build.sh e2e tests Thanks, Joshua Cohen

Re: Review Request 51531: Minor improvements to the custom executor docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51531/#review147329 --- Ship it! Ship It! - Joshua Cohen On Aug. 30, 2016, 5:45 p.m

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

-mail. To reply, visit: > https://reviews.apache.org/r/51506/ > --- > > (Updated Aug. 29, 2016, 11:37 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Bugs: AURO

Re: Review Request 51513: Add support for ETags in the Aurora API.

> On Aug. 30, 2016, 1:32 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java, > > lines 139-142 > > <https://reviews.apache.org/r/51513/diff/1/?file=1488357#file1488357line139> > > > > Am I r

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148092 --- Ship it! Ship It! - Joshua Cohen On Sept. 7, 2016, 9:28 p.m

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

a/client/api/__init__.py (line 357) <https://reviews.apache.org/r/51662/#comment215570> move to previous line. - Joshua Cohen On Sept. 8, 2016, 12:30 a.m., Karthik Anantha Padmanabhan wrote: > > --- > This is an automatically

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147348 --- Ship it! Ship It! - Joshua Cohen On Aug. 30, 2016, 8 p.m

Re: Review Request 51536: @ReviewBot retry Scheduler updater will not use watch_sec if health check is enabled

IME`. Ideally we'd advance the time by some value less than `MIN_RUNNING_TIME` to prove that we're not waiting that long before declaring the task running? - Joshua Cohen On Aug. 30, 2016, 8:52 p.m., Kai Huang wrote: > > -

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

> On Aug. 29, 2016, 6:52 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 193 > > <https://reviews.apache.org/r/51384/diff/4/?file=1487511#file1487511line193> > > > > Am I missing something? Shouldn't this be a set of `Me

Re: Review Request 51513: Add support for ETags in the Aurora API.

given that the goal here is to optimize for the case where responses are large enough that sending them on the wire and processing them on the client side is causing a perf problem)? At the very least, perhaps we should only buffer the response if the `If-None-Match` header is set? - Joshua

Re: Review Request 51758: Document how to generate a changelog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51758/#review148343 --- Ship it! Ship It! - Joshua Cohen On Sept. 9, 2016, 1:40 p.m

Review Request 51899: Ensure shell health checkers running for tasks running under an isolated fileystem are run within that filesystem.

/test_health_checker.py bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 290627f8bc38d31ae123cfd1cdd36e9291c2de18 Diff: https://reviews.apache.org/r/51899/diff/ Testing --- ./build-support/jenkins/build.sh e2e tests Thanks, Joshua Cohen

<    1   2   3   4   5   6   >