://reviews.apache.org/r/48082/diff/
Testing
---
Manual/Explorative: Invoked from CLI-side to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
://reviews.apache.org/r/48082/diff/
Testing
---
Manual/Explorative: Invoked from CLI-side to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad
tests passed) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48559/#review137553
---
@ReviewBot retry
- Mehrdad Nurolahzade
On June 14, 2016, 10:12
anager``` but
then realized that migration scripts are instantiated through reflection by
ibatis and Guice injection did not work on them (or I don't know enough about
Guice to make it work).
Any suggestions?
- Mehrdad Nurolahzade
On June 14, 2016, 9:46 a.m., Mehrdad Nurolahzade
: https://reviews.apache.org/r/48082/diff/
Testing
---
Manual/Explorative: Invoked from CLI-side to see if the new API call works as
intended
Integration: ./build-support/jenkins/build.sh
E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Mehrdad Nurolahzade
Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48559/#review137763
---
On June 14, 2016, 10:12 a.m., Mehrdad Nurolahzade wrote:
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad Nurolahzade
chy. Now, I can move back to ```config.py``` again.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review138964
---------
) ***
mesos-master start/running, process 26886
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real17m53.514s
user0m1.443s
sys 0m0.624s
```
Thanks,
Mehrdad Nurolahzade
This should be unnecessary as zero is the default value for
> > 'production'.
>
> Mehrdad Nurolahzade wrote:
> Isn't this required to resolve the inconsistencies between the choice of
> ```production``` and ```tier``` in already scheduled jobs?
> For exa
iff: https://reviews.apache.org/r/48796/diff/
Testing
---
```
./build-support/jenkins/build.sh
+ date
Thu Jun 16 08:57:08 PDT 2016
+ ./gradlew -Pq clean build
...
09:03:14 00:03 [complete]
SUCCESS
```
Thanks,
Mehrdad Nurolahzade
This should be unnecessary as zero is the default value for
> > 'production'.
>
> Mehrdad Nurolahzade wrote:
> Isn't this required to resolve the inconsistencies between the choice of
> ```production``` and ```tier``` in already scheduled jobs?
> For exa
)
<https://reviews.apache.org/r/49048/#comment204470>
This is left over from refactoring, will remove.
- Mehrdad Nurolahzade
On June 23, 2016, 3:35 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically g
/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
'preemptible']) and not
to_bool(tier.settings['revocable'])
```
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139597
-
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139597
-------
On June 27, 2016, 9:02 a.m., Mehrdad Nurolahzade wrote:
>
>
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review139597
-------
On June 27, 2016, 9:02 a.m., Mehrdad Nurolahzade wrote:
>
> ---
>
ing update for: hello
Job update has started. View your update progress at
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]
Thanks,
Mehrdad Nurolahzade
ache.org/r/47550/diff/
Testing
---
Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit
Thanks,
Mehrdad Nurolahzade
03)
<https://reviews.apache.org/r/47550/#comment198436>
Copy & pasted from DiffCommand.execute() in jobs.py
src/main/python/apache/aurora/client/cli/update.py (line 205)
<https://reviews.apache.org/r/47550/#comment198437>
What should we do if the api.job_update_diff() call fail
tances: [2-3]
update instances: [0-1]
Thanks,
Mehrdad Nurolahzade
sit:
https://reviews.apache.org/r/47550/#review133966
-------
On May 23, 2016, 9:38 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To re
hello
Job update has started. View your update progress at
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]
Thanks,
Mehrdad Nurolahzade
-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]
Thanks,
Mehrdad Nurolahzade
145)
<https://reviews.apache.org/r/47550/#comment198676>
This is gonna break for update command (which does not supply local_tasks),
so it needs to be something like:
self.diff_no_update_details([] if local_tasks is None else local_tasks)
- Mehrdad Nurolahzade
On May 19, 2016
local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]
Thanks,
Mehrdad Nurolahzade
://reviews.apache.org/r/50432/diff/
Testing
---
```
./build-support/jenkins/build.sh
```
Thanks,
Mehrdad Nurolahzade
Diff: https://reviews.apache.org/r/50052/diff/
Testing
---
Manual, Jenkins, and end_to_end
Thanks,
Mehrdad Nurolahzade
closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
Diff: https://reviews.apache.org/r/50530/diff/
Testing
---
Thanks,
Mehrdad Nurolahzade
/python/apache/aurora/client/test_config.py
4742fa28e3156e5b20791b80f2db8392f7f2f4bf
Diff: https://reviews.apache.org/r/50432/diff/
Testing
---
```
./build-support/jenkins/build.sh
```
Thanks,
Mehrdad Nurolahzade
.apache.org/r/50432/#review144191
---
On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50530/#review144167
---
Can we git this merged?
- Mehrdad Nurolahzade
On July 27, 2016
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50432/#review144191
-------
On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> T
.
I'll sibmit a new version shortly.
- Mehrdad Nurolahzade
On July 29, 2016, 2:21 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
4742fa28e3156e5b20791b80f2db8392f7f2f4bf
Diff: https://reviews.apache.org/r/50617/diff/
Testing
---
`./pants test src/test/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
/
Testing
---
`./pants test src/test/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
------
On July 25, 2016, 8:30 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> -
> On July 26, 2016, 7:36 a.m., Joshua Cohen wrote:
> > I know this is already landed, but it would be nice to follow this up with
> > a test case if possible?
>
> Mehrdad Nurolahzade wrote:
> The logic has two test cases:
> (https://gi
/multitenancy.md 62bcd535d3bf39c9ea7e6d5958f6ae8ba0867c0d
docs/reference/configuration.md 64c076d862453545652fbaa2d3e29f284ddd164d
Diff: https://reviews.apache.org/r/50530/diff/
Testing
---
Thanks,
Mehrdad Nurolahzade
do.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50902/#review145364
---
On Aug. 8, 2016, 10:13 a.m., Mehrdad Nu
> On Aug. 10, 2016, 10:36 a.m., Maxim Khutornenko wrote:
> > The easiest way to validate doc changes like this is to push your branch to
> > your github remote and post a link here for review. Care to give it a try?
>
> Mehrdad Nurolahzade wrote:
> Will do.
Here i
ly, visit:
https://reviews.apache.org/r/50052/#review142524
-------
On July 15, 2016, 1:15 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail.
gle/protobuf/util/JsonFormat.java
> > *
> > http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3
>
> Mehrdad Nurolahzade wrote:
> Looking into protobuf util ...
I can see that we already have
[jackson-datatype-protobuf](https://
gle/protobuf/util/JsonFormat.java
> > *
> > http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util/3.0.0-beta-3
>
> Mehrdad Nurolahzade wrote:
> Looking into protobuf util ...
>
> Mehrdad Nurolahzade wrote:
> I can see that we already have
&
Thanks,
Mehrdad Nurolahzade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142681
---
@ReviewBot retry
- Mehrdad Nurolahzade
On July 8, 2016, 4:15
,
Mehrdad Nurolahzade
/files/2016/07/18/50faae5c-45ac-45af-aa3c-d68ca09d2e72__offers-new.json
Thanks,
Mehrdad Nurolahzade
", "value":
"devcluster/www-data/prod/hello"}]
}
}
}
]' \
-X POST http://192.168.33.7:5050/master/reserve
```
- Mehrdad
---
This is an automatically generated e-mail. To
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142828
---
On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wrote:
>
> ---
-----------
On July 20, 2016, 10:56 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49048/
> --
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review142828
---
On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wro
://reviews.apache.org/media/uploaded/files/2016/07/19/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json
Thanks,
Mehrdad Nurolahzade
BEAN`
> > function returns)
Correct, going to refactor all.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50052/#review142326
----------
[complete][31m
> >FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
This is passing locally, not sure why it's breaking on the server.
- Mehrdad
-
/aurora/e2e/test_end_to_end.sh
*** OK (All tests passed) ***
mesos-master start/running, process 26868
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad
0m1.318s
sys 0m0.533s
```
Thanks,
Mehrdad Nurolahzade
> On June 28, 2016, 1:53 p.m., David McLaughlin wrote:
> > config/legacy_untested_classes.txt, line 44
> > <https://reviews.apache.org/r/49334/diff/1/?file=1432053#file1432053line44>
> >
> > Isn't this a fairly easy class to test?
>
> Mehrdad
0m1.318s
sys 0m0.533s
```
Thanks,
Mehrdad Nurolahzade
,
Mehrdad Nurolahzade
e here I decided to give up. Let me know if you
have any suggestion for testing.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49334/#review139857
-------
g/r/49048/#review139923
---
On June 28, 2016, 4:57 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real19m46.324s
user0m1.496s
sys 0m0.774s
```
Thanks,
Mehrdad Nurolahzade
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote:
> >
>
> Mehrdad Nurolahzade wrote:
> Should this be merged with upstream now that 0.15 is released?
>
> Joshua Cohen wrote:
> Yes, we can land this now. Would you mind rebasing? Then I can commit it.
Alright
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49048/#review141698
---
@ReviewBot retry
- Mehrdad Nurolahzade
On July 8, 2016, 4:15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50819/#review144823
---
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Aug. 4, 2016, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163701
---
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Jan. 31, 2017
refactoring from `slave` to
`agent`?
- Mehrdad Nurolahzade
On Feb. 3, 2017, 11:38 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164519
---
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Feb. 6, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164517
---
@ReviewBot retry
- Mehrdad Nurolahzade
On Feb. 6, 2017, 6:44
in the patch. A more representative cluster setup would be one in
which only a subset of potential victims pass
`PreemptionVictimFilter.filterPreemptionVictims()` test.
Thanks,
Mehrdad Nurolahzade
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55089/#review163042
-----------
On Dec. 29, 2016, 9:58 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
---
Preemption performance improvement and new metrics release notes entry
Diffs
-
RELEASE-NOTES.md 7d01c90610e2cddf0f0629af669fd3bdb2afa7c5
Diff: https://reviews.apache.org/r/56048/diff/
Testing
---
Thanks,
Mehrdad Nurolahzade
ine51>
> >
> > ... should we use `scheduler_` as a prefix here as well?
Done.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55089/#review163351
--------
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real28m58.389s
user0m1.508s
sys 0m0.820s
```
Thanks,
Mehrdad Nurolahzade
/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 2359
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real28m58.389s
user0m1.508s
sys 0m0.820s
```
Thanks,
Mehrdad Nurolahzade
/test_end_to_end.sh
...
*** OK (All tests passed) ***
mesos-master start/running, process 2359
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.
real28m58.389s
user0m1.508s
sys 0m0.820s
```
Thanks,
Mehrdad
> > @ThriftWorkload(result ->
> > result.getJobSummaryResult().getSummariesSize())
> > ```
>
> Mehrdad Nurolahzade wrote:
> I like it! Let me try.
Unfortunately, due to language limitations, the elegant lambda expression
approach you suggested is not
riables-thread-safe-in-java
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55089/#review162893
---
On Dec. 29, 201
--
On Feb. 22, 2017, 11:34 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56935/
> ---
ibility into heap/GC.
- Mehrdad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56935/#review166387
---
On Feb. 22, 2017, 11:3
/MesosSchedulerImplTest.java
9bb319bb04bb386d9792c3cc0017b039e8f25044
Diff: https://reviews.apache.org/r/56935/diff/
Testing
---
```./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh```
Thanks,
Mehrdad Nurolahzade
/pruning/TaskHistoryPrunerTest.java
14e4040e0b94e96f77068b41454311fa3bf53573
Diff: https://reviews.apache.org/r/56575/diff/
Testing
---
Manual testing under Vagrant
Thanks,
Mehrdad Nurolahzade
roller` the dependency does not seem to
matter. Did you verify ignoring the `TaskGroups` dependency is safe?
- Mehrdad Nurolahzade
On Feb. 13, 2017, 6:01 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail.
the pruning
logic into `TaskStore`; similar to how it is currently done in
`JobUpdateStore.pruneHistory()`.
- Mehrdad Nurolahzade
On Feb. 13, 2017, 9:30 a.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generat
, visit:
https://reviews.apache.org/r/56575/#review165260
-----------
On Feb. 11, 2017, 3:12 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically gener
to be gained from
pushing this down to `TaskStore`.
Do you see any value in pursuing this idea any further? Or shall I restore it
to previous state?
- Mehrdad Nurolahzade
On Feb. 14, 2017, 3:38 p.m., Mehrdad Nurolahzade wrote
02719c312294b58525c1fddd3ed096a9b1cef601
Diff: https://reviews.apache.org/r/56575/diff/
Testing
---
Manual testing under Vagrant
Thanks,
Mehrdad Nurolahzade
> On Feb. 14, 2017, 4:02 p.m., Mehrdad Nurolahzade wrote:
> > Looking at it as is, I'm not sure if there is much value to be gained from
> > pushing this down to `TaskStore`.
> > Do you see any value in pursuing this idea any further? Or shall I restore
> > it to
can introduce
a new configuation parameter in `PruningModule` for specifying the max number
of tasks to be pruned per round. It can default to -1 (unlimited).
- Mehrdad Nurolahzade
On Feb. 12, 2017, 2:49 p.m., Mehrdad Nurolahzade wrote
/TaskHistoryPruner.java
f77849498ff23616f1d56d133eb218f837ac3413
src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java
14e4040e0b94e96f77068b41454311fa3bf53573
Diff: https://reviews.apache.org/r/56575/diff/
Testing
---
Manual testing under Vagrant
Thanks,
Mehrdad Nurolahzade
> On Feb. 12, 2017, 2:59 p.m., Mehrdad Nurolahzade wrote:
> > To further manage task history pruning heap/workload pressure, we can
> > introduce a new configuation parameter in `PruningModule` for specifying
> > the max number of tasks to be pruned per round.
1 - 100 of 213 matches
Mail list logo
