Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187094 --- Ship it! Nice! - Bill Farner On Oct. 3, 2017, 9:31 p.m.,

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187049 --- Ship it! Master (4e7cdc4) is green with this patch.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187047 --- Master (4e7cdc4) is red with this patch.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/ --- (Updated Oct. 4, 2017, 4:31 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187034 --- Ship it! Master (4e7cdc4) is green with this patch.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187031 ---

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/ --- (Updated Oct. 4, 2017, 12:16 a.m.) Review request for Aurora, David

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

> On Oct. 3, 2017, 10:38 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > > Line 86 (original), 91 (patched) > > > > > > This line results in very close coupling of the

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187008 --- Ship it! The code itself looks good to me +- the switch to a

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review187002 ---

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186994 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 3,

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186987 --- Ship it! Master (6fd6d50) is green with this patch.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

> On Oct. 3, 2017, 10:08 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > > Line 87 (original), 102 (patched) > > > > > > Do you know how the timeout

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

> On Oct. 3, 2017, 5:08 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > > Line 87 (original), 102 (patched) > > > > > > Do you know how the timeout scenario

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186975 --- src/main/java/org/apache/aurora/scheduler/events/Webhook.java

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/ --- (Updated Oct. 3, 2017, 5:01 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186926 --- Master (6fd6d50) is red with this patch.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/ --- (Updated Oct. 3, 2017, 4:25 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186900 --- LGMT. Minor comments. build.gradle Line 85 (original), 85

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186767 --- Ship it! Master (24d2caf) is green with this patch.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186765 --- Ship it! Ship It! - David McLaughlin On Sept. 30, 2017,

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/#review186764 --- Master (24d2caf) is red with this patch.

Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62700/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan