Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 9:03 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31171: Saving backups asynchronously.

2015-02-23 Thread Maxim Khutornenko
On Feb. 20, 2015, 12:06 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, line 261 https://reviews.apache.org/r/31171/diff/2/?file=869995#file869995line261 It may exceed your appetite for this review, but i would actually

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
On Feb. 23, 2015, 7:47 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33 https://reviews.apache.org/r/30895/diff/2/?file=873059#file873059line33 This is bound to become a Texas constructor [1]. Please consider using the

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31248/#review73603 --- Ship it! Ship It! - Joshua Cohen On Feb. 21, 2015, 6:33 p.m.,

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Joshua Cohen
On Feb. 21, 2015, 12:53 a.m., Joshua Cohen wrote: Can you fill in testing done? Bill Farner wrote: Honest question - do you find that useful for changes like this? I find it redundant to always type `./gradlew build -Pq`, especially since the build bot will do that anyhow. My

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-23 Thread Kevin Sweeney
On Feb. 18, 2015, 11:42 a.m., Kevin Sweeney wrote: Hi Craig, thanks for the contribution. I'm wondering if this document might be better suited as a gist or blog post given that it's dated (0.7.1) and we don't have automated test coverage to ensure it doesn't diverge from the rest of

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Bill Farner
On Feb. 23, 2015, 6:22 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, lines 199-201 https://reviews.apache.org/r/31248/diff/5/?file=871734#file871734line199 Well, I think this is actually worse than it was. In case there is

Re: Review Request 31251: Fix swallowed exceptions in health check test.

2015-02-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/ --- (Updated Feb. 23, 2015, 8:23 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31251: Fix swallowed exceptions in health check test.

2015-02-23 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/#review73658 --- Ship it! Ship It! - Joe Smith On Feb. 23, 2015, 12:23 p.m.,

Re: Review Request 31251: Fix swallowed exceptions in health check test.

2015-02-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/#review73650 --- Ship it! Ship It! - Zameer Manji On Feb. 23, 2015, 11:50 a.m.,

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-23 Thread Maxim Khutornenko
On Feb. 21, 2015, 12:43 a.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java, line 80 https://reviews.apache.org/r/30891/diff/5-6/?file=867194#file867194line80 This is kinda weird, what's the motivation here? Maxim Khutornenko

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/ --- (Updated Feb. 23, 2015, 8:36 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31289: Enabling bash -e for vagrant runs

2015-02-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31289/#review73674 --- Ship it! Thanks! Tested this patch by doing some build commands

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review73683 --- Master (277ac43) is red with this patch.

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Bill Farner
On Feb. 23, 2015, 8:02 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, lines 204-205 https://reviews.apache.org/r/31248/diff/5-6/?file=871734#file871734line204 one line I'm indifferent, figured whichever line break i chose i'd

Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31176/ --- (Updated Feb. 23, 2015, 2:41 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31176/#review73698 --- Ship it!

Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31176/#review73700 --- Ship it! Master (277ac43) is green with this patch.

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
On Feb. 23, 2015, 9:59 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 66 https://reviews.apache.org/r/30895/diff/3/?file=873099#file873099line66 Javadoc here would be nice. I failed to elaborate on the last review, but it's not

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 10:47 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review73703 --- Ship it!

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Kevin Sweeney
On Feb. 23, 2015, 11:47 a.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33 https://reviews.apache.org/r/30895/diff/2/?file=873059#file873059line33 This is bound to become a Texas constructor [1]. Please consider using the

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73677 --- Master (277ac43) is red with this patch.

Re: Review Request 31251: Fix swallowed exceptions in health check test.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/#review73688 --- Ship it! Master (277ac43) is green with this patch.

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73680 --- Ship it!

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31248/ --- (Updated Feb. 23, 2015, 10:34 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31289: Enabling bash -e for vagrant runs

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31289/#review73694 --- Master (277ac43) is red with this patch.

Review Request 31334: Fixing cron update quota checking.

2015-02-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31334/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-1134

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31334/#review73739 --- This patch does not apply cleanly on master (19378c1), do you need

Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-23 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- Review request for Aurora, Jay Buffington and Bill Farner. Bugs: AURORA-1107

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review73744 --- Ship it! Master (19378c1) is green with this patch.

Re: Review Request 31235: Refactoring CronJobManager interface.

2015-02-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31235/#review73738 --- Ship it! Master (19378c1) is green with this patch.