---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895/
---
(Updated Feb. 23, 2015, 9:03 p.m.)
Review request for Aurora, Kevin Sweeney
On Feb. 20, 2015, 12:06 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java,
line 261
https://reviews.apache.org/r/31171/diff/2/?file=869995#file869995line261
It may exceed your appetite for this review, but i would actually
On Feb. 23, 2015, 7:47 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33
https://reviews.apache.org/r/30895/diff/2/?file=873059#file873059line33
This is bound to become a Texas constructor [1].
Please consider using the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/#review73603
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 21, 2015, 6:33 p.m.,
On Feb. 21, 2015, 12:53 a.m., Joshua Cohen wrote:
Can you fill in testing done?
Bill Farner wrote:
Honest question - do you find that useful for changes like this? I find
it redundant to always type `./gradlew build -Pq`, especially since the build
bot will do that anyhow.
My
On Feb. 18, 2015, 11:42 a.m., Kevin Sweeney wrote:
Hi Craig, thanks for the contribution. I'm wondering if this document might
be better suited as a gist or blog post given that it's dated (0.7.1) and
we don't have automated test coverage to ensure it doesn't diverge from the
rest of
On Feb. 23, 2015, 6:22 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
lines 199-201
https://reviews.apache.org/r/31248/diff/5/?file=871734#file871734line199
Well, I think this is actually worse than it was. In case there is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/
---
(Updated Feb. 23, 2015, 8:23 p.m.)
Review request for Aurora, Joe Smith and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73658
---
Ship it!
Ship It!
- Joe Smith
On Feb. 23, 2015, 12:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73650
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 23, 2015, 11:50 a.m.,
On Feb. 21, 2015, 12:43 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java,
line 80
https://reviews.apache.org/r/30891/diff/5-6/?file=867194#file867194line80
This is kinda weird, what's the motivation here?
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/
---
(Updated Feb. 23, 2015, 8:36 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31289/#review73674
---
Ship it!
Thanks! Tested this patch by doing some build commands
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review73683
---
Master (277ac43) is red with this patch.
On Feb. 23, 2015, 8:02 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
lines 204-205
https://reviews.apache.org/r/31248/diff/5-6/?file=871734#file871734line204
one line
I'm indifferent, figured whichever line break i chose i'd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31176/
---
(Updated Feb. 23, 2015, 2:41 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31176/#review73698
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31176/#review73700
---
Ship it!
Master (277ac43) is green with this patch.
On Feb. 23, 2015, 9:59 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 66
https://reviews.apache.org/r/30895/diff/3/?file=873099#file873099line66
Javadoc here would be nice. I failed to elaborate on the last review,
but it's not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895/
---
(Updated Feb. 23, 2015, 10:47 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review73703
---
Ship it!
On Feb. 23, 2015, 11:47 a.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33
https://reviews.apache.org/r/30895/diff/2/?file=873059#file873059line33
This is bound to become a Texas constructor [1].
Please consider using the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895/#review73677
---
Master (277ac43) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73688
---
Ship it!
Master (277ac43) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895/#review73680
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/
---
(Updated Feb. 23, 2015, 10:34 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31289/#review73694
---
Master (277ac43) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-1134
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review73739
---
This patch does not apply cleanly on master (19378c1), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---
Review request for Aurora, Jay Buffington and Bill Farner.
Bugs: AURORA-1107
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review73744
---
Ship it!
Master (19378c1) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31235/#review73738
---
Ship it!
Master (19378c1) is green with this patch.
32 matches
Mail list logo