Re: Review Request 27630: Mark inotify disk collector test as flaky.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27630/#review59992 --- Ship it! Ship It! - Bill Farner On Nov. 5, 2014, 6:16 p.m

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

/log/WriteAheadStorageTest.java PRE-CREATION Diff: https://reviews.apache.org/r/27542/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

----- On Nov. 3, 2014, 10:11 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27542/ > ---

Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

src/test/python/apache/thermos/core/test_helper.py fe368ff4ecb22f1d99024117c6b944c64f86b8ff Diff: https://reviews.apache.org/r/27628/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27591: Remove --bind-var for cron deschedule.

reviews.apache.org/r/27591/ > --- > > (Updated Nov. 5, 2014, 2:52 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-854 > https://issues.apache.org/jira/browse/AURORA-854 > > > Repository

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

> On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: > > I'm not a fan of the refactor. For one, static analysis tools will no > > longer catch missing case coverage, and we have to expose the internal > > detail of this map. Instead, the unit test should self-check to

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

> On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: > > I'm not a fan of the refactor. For one, static analysis tools will no > > longer catch missing case coverage, and we have to expose the internal > > detail of this map. Instead, the unit test should self-check to

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is exercising all transaction operation types. - Bill Farner On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko

Re: Review Request 27591: Remove --bind-var for cron deschedule.

bot? Stinks that we still have to do this, but it's good to shoot for a green reply. - Bill Farner On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59680 ------- On Nov. 3, 2014, 10:46 p.m., Bill Farner wrote: > > --- > This is a

Re: Review Request 27586: Increase robustness when reading PEX-INFO

ws.apache.org/r/27586/ > --- > > (Updated Nov. 4, 2014, 7:55 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-456 > https://issues.apache.org/jira/browse/AURORA-456 > > > Repository: aurora > > > Description > --

Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59814 --- Ship it! Ship It! - Bill Farner On Nov. 3, 2014, 11:09 p.m

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

/KillRetryTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 1688a339a1a9c4072d7f834963cb5ccad6fe0736 Diff: https://reviews.apache.org/r/27467/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

a `BackoffStrategy` indirection there is useful. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59655 -----

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

/scheduler/storage/log/WriteAheadStorage.java 094d1c66e1f464687e0416bc652dba4b1bda0f7e src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION Diff: https://reviews.apache.org/r/27542/diff/ Testing --- Thanks, Bill Farner

Review Request 27542: Add test coverage for WriteAheadStorage.

094d1c66e1f464687e0416bc652dba4b1bda0f7e src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java PRE-CREATION Diff: https://reviews.apache.org/r/27542/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27541: Revert "Adding resource consumption calculation for cron jobs."

after committing. - Bill Farner On Nov. 3, 2014, 9:59 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

How about a stat counter here as well? Good call, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59591 -----

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

/KillRetryTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 1688a339a1a9c4072d7f834963cb5ccad6fe0736 Diff: https://reviews.apache.org/r/27467/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27538: Optionally ignore unknown transaction operations.

/LogStorageTest.java 2d44bd58cdd52e99644f1b80e4e7daf05f301df2 Diff: https://reviews.apache.org/r/27538/diff/ Testing --- Working on a test now. Thanks, Bill Farner

Review Request 27538: Optionally ignore unknown transaction operations.

Description --- Optionally ignore unknown transaction operations. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java ec9ccfd37ad6f4b8b478498d30e0e5a9e9b8576e Diff: https://reviews.apache.org/r/27538/diff/ Testing --- Working on a test now. Thanks, Bill

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review59610 --- Ship it! Ship It! - Bill Farner On Oct. 30, 2014, 5:11 p.m

Review Request 27467: Retry Driver.killTask periodically until the task changes states.

/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 1688a339a1a9c4072d7f834963cb5ccad6fe0736 Diff: https://reviews.apache.org/r/27467/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27375: Remove dependency on application-http.

/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27375: Remove dependency on application-http.

/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27375: Remove dependency on application-http.

to shutdown? Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375/#review59237 --- On Oct. 30, 2

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

--- Thanks, Bill Farner

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

visit: https://reviews.apache.org/r/27371/#review59232 --- On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27371/ > ---

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

. To reply, visit: https://reviews.apache.org/r/27371/#review59206 ------- On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote: > > --- > This is an automatica

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

it: https://reviews.apache.org/r/27371/#review59224 --- On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote: > > --- > This is an automatically generated e

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

+1 Good call, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59080 --- On Oct. 29, 2014,

Re: Review Request 27182: Add a test for the thermos resource module

> On Oct. 27, 2014, 7:46 p.m., Kevin Sweeney wrote: > > src/test/python/apache/thermos/monitoring/test_resource.py, line 64 > > > > > > patching a private method assumes intimate knowledge of the class under > > test a

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

es->IResourceAggregate step. AFAICT you'll get to remove some private helpers from this class, and this loop becomes more concise: ```java Resources sum = Resources.NONE; // Need to create this for (..) { sum = Resources.sum(sum, Resources.from(task));

Re: Review Request 27375: Remove dependency on application-http.

r EasyMock. As we progress down this path, we will translate Lifecycle into an interface. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375/#review59162 --------

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

tps://reviews.apache.org/r/27364/#comment100486> Double-check the license header, we don't include the year. - Bill Farner On Oct. 30, 2014, 1:06 a.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-m

Review Request 27375: Remove dependency on application-http.

958f60c9d804af4c915a53ccdaf489a91ee284c7 src/main/java/org/apache/aurora/scheduler/http/QuitCallback.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java PRE-CREATION Diff: https://reviews.apache.org/r/27375/diff/ Testing --- Thanks, Bill Farner

Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d Diff: https://reviews.apache.org/r/27371/diff/ Testing --- Thanks, Bill Farner

Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 90c8c065adc4329894e99946a8f494ac3e35629b src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java PRE-CREATION Diff: https://reviews.apache.org/r/27365/diff/ Testing --- Thanks, Bill Farner

Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

, Bill Farner

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

, Bill Farner

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

call, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59074 --- On Oct. 29, 2014, 11:19 p.m., Bill Farner wrote: > > ---

Review Request 27357: Document thermos checkpoint files, include them in git archives.

://reviews.apache.org/r/27357/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md Thanks, Bill Farner

Re: Review Request 27352: Cleaning up old vagrant cluster names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27352/#review59067 --- Ship it! Ship It! - Bill Farner On Oct. 29, 2014, 10:21 p.m

Re: Review Request 27309: Make executor overhead configurable via CLI.

--abbrev-commit commit 6b30cf7 Author: Zameer Manji Date: Wed Oct 29 14:56:43 2014 -0700 Make executor overhead configurable via CLI. Bugs closed: AURORA-830 Reviewed at https://reviews.apache.org/r/27309/ - Bill Farner On Oct. 29, 2014, 7:54

Re: Review Request 27316: Fix minor discrepancies in RC script.

Sweeney. Repository: aurora Description --- Fix minor discrepancies in RC script. Diffs (updated) - build-support/release/release-candidate 02223362d31485c43cbad6fd66b6cfd10aa02c7b Diff: https://reviews.apache.org/r/27316/diff/ Testing --- Thanks, Bill Farner

Review Request 27316: Fix minor discrepancies in RC script.

--- Fix minor discrepancies in RC script. Diffs - build-support/release/release-candidate 02223362d31485c43cbad6fd66b6cfd10aa02c7b Diff: https://reviews.apache.org/r/27316/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 27309: Make executor overhead configurable via CLI.

ed e-mail. To reply, visit: > https://reviews.apache.org/r/27309/ > --- > > (Updated Oct. 28, 2014, 8:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-830 > https://issues.apache.org/jira/browse/AURORA-830 > > > Reposi

Re: Review Request 27309: Make executor overhead configurable via CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/#review58896 --- Ship it! Ship It! - Bill Farner On Oct. 28, 2014, 8:57 p.m

Re: Review Request 27289: Fixing error reporting in v1 client updater.

<https://reviews.apache.org/r/27289/#comment100014> What is "the deprecation"? Can you point to a ticket? - Bill Farner On Oct. 28, 2014, 8:41 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically g

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27262/#review58861 --- Ship it! - Bill Farner On Oct. 28, 2014, 8:26 p.m., Maxim

Re: Review Request 27289: Fixing error reporting in v1 client updater.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27289/#review58851 --- Ship it! Ship It! - Bill Farner On Oct. 28, 2014, 5:13 p.m

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

> On Oct. 28, 2014, 5:30 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, > > line 129 > > <https://reviews.apache.org/r/27262/diff/2/?file=735497#file735497line129> > > > > Can you fully centralize

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

/StorageBackfill.java <https://reviews.apache.org/r/27262/#comment99987> Can you fully centralize the backfill and the counter increment? void populateJobKey(TaskConfig config) { if job key is valid: fill job key increment counter } - Bill Farner

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

/StorageBackfill.java <https://reviews.apache.org/r/27262/#comment99984> Is the cargo cult of the code below necessary? - Bill Farner On Oct. 28, 2014, 1:43 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e

Re: Review Request 27262: Adding missing JobConfiguration backfill for task config job field.

l. To reply, visit: https://reviews.apache.org/r/27262/#review58754 --- On Oct. 28, 2014, 1:43 a.m., Maxim Khutornenko wrote: > > ------- > This is an automatically generated e-mail. To rep

Re: Review Request 27266: Fixing transient error message formatting in scheduler_client.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27266/#review58822 --- Ship it! Ship It! - Bill Farner On Oct. 28, 2014, 3:23 a.m

Re: Review Request 27044: Make executor overhead configurable

remove newline src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java <https://reviews.apache.org/r/27044/#comment99888> newline above src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java <https://reviews.apache.org/r/27044/#comment99889>

Re: Review Request 27044: Make executor overhead configurable

> On Oct. 22, 2014, 10:07 p.m., Bill Farner wrote: > > config/legacy_untested_classes.txt, line 9 > > <https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line9> > > > > In the interest of this file being delete only, can you bite the bullet &g

Review Request 27258: Make job key backfilling more robust.

a test case for this issue. Thanks, Bill Farner

Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

--- Thanks, Bill Farner

Re: Review Request 27249: Raise .auroraversion to 0.6.0-SNAPSHOT.

w verbose output. > > -f, --fastRun tests in a single chroot. > > > > Builds the specified Python target(s). Use ./pants goal for JVM and other > > targets. > > Bill Farner wrote: > This is a red herring failure, this will be at the end of outpu

Re: Review Request 27249: Raise .auroraversion to 0.6.0-SNAPSHOT.

. We've been seeing a lot of this lately. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27249/#review58697 --- On Oc

Review Request 27249: Raise .auroraversion to 0.6.0-SNAPSHOT.

--- Thanks, Bill Farner

Re: Review Request 27188: Use ship-it instead of +/-1.

. Thanks, Bill Farner

Review Request 27188: Use ship-it instead of +/-1.

--- Use ship-it instead of +/-1. Diffs - build-support/jenkins/review_feedback.py 9d22358608d0d52019df0c4c5b96b08d0f157c43 Diff: https://reviews.apache.org/r/27188/diff/ Testing --- None yet, will do a dry run Monday before committing. Thanks, Bill Farner

Re: Review Request 27181: Allow the invoker to ignore patterns in git-clean.

Sweeney. Repository: aurora Description --- Like, i dunno, the credentials file, for example. Diffs (updated) - build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712 Diff: https://reviews.apache.org/r/27181/diff/ Testing --- Running. Thanks, Bill

Re: Review Request 27181: Allow the invoker to ignore patterns in git-clean.

ad of > > underscores, here and above. Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27181/#review58436 --- On

Review Request 27181: Allow the invoker to ignore patterns in git-clean.

--- Like, i dunno, the credentials file, for example. Diffs - build-support/jenkins/review_feedback.py 049f2ceec4acc0a6901105d7c5fcccbbdbb90712 Diff: https://reviews.apache.org/r/27181/diff/ Testing --- Running. Thanks, Bill Farner

Re: Review Request 27089: Add documentation for the beta-update command.

://reviews.apache.org/r/27089/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/document_updater/docs/client-commands.md Thanks, Bill Farner

Re: Review Request 27145: Add a script that publishes build results to review board.

https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner

Re: Review Request 27145: Add a script that publishes build results to review board.

> On Oct. 24, 2014, 9:49 p.m., Zameer Manji wrote: > > Can you document your exit codes somewhere? > > Bill Farner wrote: > Is that worthwhile? If it means documenting, i'd rather not vary them at > all. I don't think this is something that should be scri

Re: Review Request 27100: Cache the host's maintenance status with offer.

ment99412> maintenanceVeto.isPresent() - Bill Farner On Oct. 24, 2014, 10:38 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 27145: Add a script that publishes build results to review board.

d against. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58391 --- On Oct. 24, 2014, 9:42 p.m.

Re: Review Request 27114: Move from github to bintray for pants support binaries.

/master --abbrev-commit commit f98bec7 Author: Joe Smith Date: Fri Oct 24 15:13:21 2014 -0700 Move from github to bintray for pants support binaries. Reviewed at https://reviews.apache.org/r/27114/ - Bill Farner On Oct. 23, 2014, 10:19 p.m., Joe Smith wrote

Re: Review Request 27100: Cache the host's maintenance status with offer.

-- > > (Updated Oct. 24, 2014, 7:59 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-878 > https://issues.apache.org/jira/browse/AURORA-878 > > > Repository: aurora >

Re: Review Request 27145: Add a script that publishes build results to review board.

https://reviews.apache.org/r/27145/diff/ Testing --- I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner

Re: Review Request 27145: Add a script that publishes build results to review board.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58301 --- On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: > >

Re: Review Request 27145: Add a script that publishes build results to review board.

e exclaimation be +1 here? Sure, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58338 --- On Oct

Re: Review Request 27145: Add a script that publishes build results to review board.

tyle, so these should be indented 4 past the parent, not aligned? Fixed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58299 ------

Review Request 27145: Add a script that publishes build results to review board.

I've run this a handful of times on my workstation, it seems to be doing its job. Thanks, Bill Farner

Re: Review Request 27129: Upgrade psutil to 2.1.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27129/#review58230 --- Ship it! Ship It! - Bill Farner On Oct. 24, 2014, 2:13 a.m

Re: Review Request 27100: Cache the host's maintenance status with offer.

or dedicated host mismatches as well. - Bill Farner On Oct. 23, 2014, 6:27 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 27114: Move from github to bintray for pants support binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27114/#review58187 --- Ship it! Ship It! - Bill Farner On Oct. 23, 2014, 10:19 p.m

Re: Review Request 27098: Add Junit XML output for Python tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27098/#review58188 --- Ship it! Ship It! - Bill Farner On Oct. 23, 2014, 6:28 p.m

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26954/#review58132 --- Ship it! Ship It! - Bill Farner On Oct. 23, 2014, 10:02 p.m

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

nerated e-mail. To reply, visit: > https://reviews.apache.org/r/25366/ > --- > > (Updated Sept. 4, 2014, 11:36 p.m.) > > > Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, > and Bill Fa

Re: Review Request 27062: Fix typo in pants bash script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27062/#review57948 --- Ship it! Ship It! - Bill Farner On Oct. 23, 2014, 12:38 a.m

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

> On Oct. 22, 2014, 11:51 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_diff.py, line 60 > > <https://reviews.apache.org/r/26954/diff/3/?file=729386#file729386line60> > > > > While you're here, please change this to not

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

address here. - Bill Farner On Oct. 22, 2014, 11:59 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

Ditto for other cargo cults (thanks for collapsing a few, btw). - Bill Farner On Oct. 22, 2014, 11:11 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 27045: Add some wiggle room before requiring min coverage thresholds be raised.

> On Oct. 22, 2014, 9:30 p.m., Bill Farner wrote: > > Ship It! Thanks! This is now on master: $ git log -1 origin/master --abbrev-commit commit cba7ec2 Author: Joshua Cohen Date: Wed Oct 22 16:11:29 2014 -0700 Add some wiggle room before requiring min

Re: Review Request 27044: Make executor overhead configurable

g/r/27044/#comment98818> In the interest of this file being delete only, can you bite the bullet and create a unit test to cover these in a test? - Bill Farner On Oct. 22, 2014, 4:57 p.m., Zameer Manji wrote: > > ---

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

can ride it out until the field is removed with lower overall risk. - Bill Farner On Oct. 22, 2014, 9:10 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 26531: Defining schema for the heartbeat RPC.

tps://reviews.apache.org/r/26531/#comment98806> -1 indent src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/26531/#comment98816> Mind adding a note about what happens when an unknown job update is referenced? - Bill Farner On Oct. 21, 2014, 5:58

Re: Review Request 27045: Add some wiggle room before requiring min coverage thresholds be raised.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27045/#review57906 --- Ship it! Ship It! - Bill Farner On Oct. 22, 2014, 5:16 p.m

Re: Review Request 26762: Preparing for Identity struct deprecation (scheduler).

/api.thrift <https://reviews.apache.org/r/26762/#comment98763> How about s/key/job/? It's less ambiguous (since we could conceivably introduce a TaskConfigKey), and sufficiently desriptive. - Bill Farner On Oct. 22, 2014, 9:06

Re: Review Request 26991: Upgrade mesos to 0.20.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26991/#review57726 --- Ship it! Ship It! - Bill Farner On Oct. 21, 2014, 7:42 p.m

Re: Review Request 26753: Start removing clientv1.

> On Oct. 15, 2014, 6:24 p.m., Bill Farner wrote: > > Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a > > separte diff? > > > > Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's > > broken by this patch.

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

tringHelper(java.lang.Object) - Bill Farner On Oct. 21, 2014, 9:24 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

<    3   4   5   6   7   8   9   10   11   12   >