://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/api:updater
./pants test.pytest src/test/python/apache/aurora/client/api:updater_util
Thanks,
Maxim Khutornenko
7df013a38b2f1b55ddb10bbad6f1dee87c3f51ba
Diff: https://reviews.apache.org/r/30474/diff/
Testing
---
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
://issues.apache.org/jira/browse/AURORA-1072
Repository: aurora
Description
---
Fixing copyright notice
Diffs
-
NOTICE 712c10a70a055b729401f7c047ae5afe7a98b564
Diff: https://reviews.apache.org/r/30473/diff/
Testing
---
Thanks,
Maxim Khutornenko
---
On Jan. 29, 2015, 8:11 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731
://reviews.apache.org/r/30389/#comment115331
This is techincally not true for the client updater. Cron jobs are
supported despite the fact that we now have cron commands to do so. I suggest
narrowing down this validation to ad-hoc jobs only.
- Maxim Khutornenko
On Jan. 29, 2015, 5:13 p.m., Bill
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
avgt 100 68178760.746 ± 3225821.640 ns/op
```
Thanks,
Maxim Khutornenko
from creating a new
one.
- Maxim Khutornenko
On Jan. 30, 2015, 12:21 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30433
.
+ collect_result
+ [[ 1 = 0 ]]
+ echo '!!!'
!!!
+ echo 'FAIL (something returned non-zero)'
FAIL (something returned non-zero)
+ echo ''
```
Anything I am missing?
- Maxim Khutornenko
On Jan. 27, 2015, 4:58 p.m., Steve Niemitz wrote
of the write lock completely
here, because all you need are strongly consistent reads (which we have) to
accurately update the cooridinatedUpdateStates map correctly.
Maxim Khutornenko wrote:
An update blocked (not PAUSED) due to a missed pulse can be unblocked by
a new pulse
:
https://reviews.apache.org/r/30225/#review70058
---
On Jan. 23, 2015, 8:37 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
of the write lock completely
here, because all you need are strongly consistent reads (which we have) to
accurately update the cooridinatedUpdateStates map correctly.
Maxim Khutornenko wrote:
An update blocked (not PAUSED) due to a missed pulse can be unblocked by
a new pulse
of the
context of a lock).
Maxim Khutornenko wrote:
Moving a fetch call out of the write transaction would create a potential
for a race that may compromise the feature and create hard to reason/trace
corner cases. This is not worth the arguable gain in contention improvement
in my opinion
8c19f3b08135eb5f3098591ebf9931b42a086318
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
03d1fba76c23570c2c4102a48daf5ce035ecaaa3
Diff: https://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30331/#review69921
---
Ship it!
Confirmed. This eliminates the flakiness.
- Maxim
---
Thanks,
Maxim Khutornenko
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote:
I am not convinced there is enough value in this diff to risk possible
regression. Besides, the majority of what this diff touches will die out
along with the client updater.
Zameer Manji wrote:
Is there an ETA
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30207/#review69824
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 23, 2015, 3:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review69825
---
Ping.
- Maxim Khutornenko
On Jan. 23, 2015, 8:37 p.m., Maxim
---
The release publishing script needs a fix for git add .auroraversion.
Diffs
-
build-support/release/release 147568b86586940648c9511e5eff7d4b56fe18a1
Diff: https://reviews.apache.org/r/30302/diff/
Testing
---
Thanks,
Maxim Khutornenko
---
git add does not work with a symlinked file.
Diffs
-
build-support/release/release-candidate
fd217f8add548a3adffd8181a84cb99d6e943369
Diff: https://reviews.apache.org/r/30293/diff/
Testing
---
./build-support/release/release-candidate -r 1
Thanks,
Maxim Khutornenko
---
./build-support/release/release-candidate -r 1
Thanks,
Maxim Khutornenko
---
Bumping up aurora snapshot version in preparation for the 0.7.0 release.
Diffs
-
src/main/resources/apache/aurora/client/cli/.auroraversion
e8ff9d45c6326c28dae836a1409ec0c9b00fd75a
Diff: https://reviews.apache.org/r/30286/diff/
Testing
---
Thanks,
Maxim Khutornenko
7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987
Diff: https://reviews.apache.org/r/30225/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
possible
regression. Besides, the majority of what this diff touches will die out along
with the client updater.
- Maxim Khutornenko
On Jan. 23, 2015, 3:32 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote:
I am not convinced there is enough value in this diff to risk possible
regression. Besides, the majority of what this diff touches will die out
along with the client updater.
Zameer Manji wrote:
Is there an ETA
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote:
I am not convinced there is enough value in this diff to risk possible
regression. Besides, the majority of what this diff touches will die out
along with the client updater.
Zameer Manji wrote:
Is there an ETA
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote:
I am not convinced there is enough value in this diff to risk possible
regression. Besides, the majority of what this diff touches will die out
along with the client updater.
Zameer Manji wrote:
Is there an ETA
On Jan. 22, 2015, 7:43 p.m., Kevin Sweeney wrote:
We've explored this in the past, but how about moving the authentication
code to a decorator class and delegating the behavior-once-authenticated.
We have a TODO tracking this:
```
// TODO(Sathya): Remove this after AOP-style session
/SchedulerThriftInterface.java
https://reviews.apache.org/r/30178/#comment113859
This is only used in one place, inline?
- Maxim Khutornenko
On Jan. 22, 2015, 7:25 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail
/#review69051
---
On Jan. 7, 2015, 1:34 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731
relying on real objects as much as possible to get more realistic perf
picture. Especially given that `CachedClusterState` was introduced for
performance reasons, seems like it belongs here just as much if not more than
`StateManagerImpl`.
Maxim Khutornenko wrote:
I was referring
, 2015, 11:30 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/
---
(Updated Jan. 6, 2015, 11:30
-aurora/blob/populated_deprecation/docs/thrift-deprecation.md
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69047
---
On Jan. 7, 2015, 1:34 a.m., Maxim Khutornenko wrote
---
On Jan. 7, 2015, 1:34 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
avgt 100 68178760.746 ± 3225821.640 ns/op
```
Thanks,
Maxim Khutornenko
relying on real objects as much as possible to get more realistic perf
picture. Especially given that `CachedClusterState` was introduced for
performance reasons, seems like it belongs here just as much if not more than
`StateManagerImpl`.
Maxim Khutornenko wrote:
I was referring
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29943/#review68760
---
On Jan. 17, 2015, 8:54 p.m., Maxim Khutornenko wrote
://reviews.apache.org/r/29943/diff/
Testing
---
./gradlew -Pq build
./pants src/test/python:all
manual testing in vagrant
Thanks,
Maxim Khutornenko
dd3f228c5062d388b4393aa4fd5b60a685bdb3a6
src/test/python/apache/aurora/client/api/test_updater_util.py
fe3ac49491ca710761632405ac09de0cc0d038a5
Diff: https://reviews.apache.org/r/29943/diff/
Testing
---
./gradlew -Pq build
./pants src/test/python:all
manual testing in vagrant
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/#review68329
---
On Jan. 15, 2015, 7:44 p.m., Maxim Khutornenko wrote
@vagrant-ubuntu-trusty-64:~$ aurora job killall
devcluster/www-data/prod/hello
INFO] Checking status of devcluster/www-data/prod/hello
INFO]
No tasks to kill found for job devcluster/www-data/prod/hello
Job killall succeeded
Thanks,
Maxim Khutornenko
`, and not using mocks (ditto for
`create_scheduled_tasks`)? This aligns with the desired pattern of
avoiding unnecessary use of mocks.
You can borrow from `test_inspect.py` for an example:
https://reviews.apache.org/r/29696
Maxim Khutornenko wrote:
Sure, will do.
Refactored
://reviews.apache.org/r/29873/#review68082
---
On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29873/#review68083
---
On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote
:
https://reviews.apache.org/r/29873/#review68078
---
On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/python:all
vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall
devcluster/www-data/prod/hello
INFO] Checking status of devcluster/www-data/prod/hello
INFO]
No tasks to kill found for job devcluster/www-data/prod/hello
Job killall succeeded
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29717/#review67912
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 13, 2015, 1:33
.
- Maxim Khutornenko
On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29786/#review67564
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 9, 2015, 11:22
://reviews.apache.org/r/29734/#comment111341
if not diffs: should do the same
- Maxim Khutornenko
On Jan. 9, 2015, 12:31 a.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
://reviews.apache.org/r/29696/#comment111091
Is it a copy-paste from somewhere? I don't see anything using waiting
events around inspect command.
- Maxim Khutornenko
On Jan. 8, 2015, 2:19 a.m., Bill Farner wrote
on there that
changes almost every file in a repo?
- Maxim Khutornenko
On Jan. 8, 2015, 4:01 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29700
://reviews.apache.org/r/29698/#comment15
The majority of subcommand help strings (i.e. jobs.py) start with capital
letter. Suggest making it consistent here.
- Maxim Khutornenko
On Jan. 8, 2015, 3:33 a.m., Bill Farner wrote
/test_end_to_end.sh
2a436b40ebb2e13f88c1cabc610e41e0eea95dda
Diff: https://reviews.apache.org/r/29216/diff/
Testing
---
./pants src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29691/#review67138
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 8, 2015, 1:09 a.m
/test_end_to_end.sh
2a436b40ebb2e13f88c1cabc610e41e0eea95dda
Diff: https://reviews.apache.org/r/29216/diff/
Testing
---
./pants src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
, visit:
https://reviews.apache.org/r/29216/#review66928
---
On Dec. 23, 2014, 1:35 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/aurora/client/commands:core
Thanks,
Maxim Khutornenko
. To reply, visit:
https://reviews.apache.org/r/29672/#review67099
---
On Jan. 7, 2015, 9:30 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
://reviews.apache.org/r/29672/diff/
Testing
---
./pants src/test/python/apache/aurora/client/commands:core
Thanks,
Maxim Khutornenko
,
Maxim Khutornenko
/populated_deprecation/docs/thrift-deprecation.md
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review65988
---
On Dec. 15, 2014, 11:12 p.m., Maxim Khutornenko wrote:
---
This is an automatically
://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
instances
Thanks,
Maxim Khutornenko
/hello_world.aurora
INFO] Creating job hello
Job creation failed due to error:
Job www-data/prod/hello already exists
```
Thanks,
Maxim Khutornenko
± 3225821.640 ns/op
```
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review66714
---
On Dec. 15, 2014, 10:15 p.m., Maxim Khutornenko wrote
/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
Duplicate hooks target introduced in https://reviews.apache.org/r/29165
Diffs
-
src/main/python/apache/aurora/client/BUILD
a2a29ff53ffb0088909a10e1673f9578425df5ce
Diff: https://reviews.apache.org/r/29348/diff/
Testing
---
Thanks,
Maxim Khutornenko
```
Thanks,
Maxim Khutornenko
Diff: https://reviews.apache.org/r/29275/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/29216/diff/
Testing
---
./pants src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65325
---
On Dec. 17, 2014, 3:19 a.m., Maxim Khutornenko wrote
/29137/diff/
Testing
---
./pants src/test/python/apache/aurora/client:all
Verified in vagrant.
Thanks,
Maxim Khutornenko
On Dec. 17, 2014, 6:57 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 174
https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174
Why do we need a deep copy here?
Maxim Khutornenko wrote:
The [task] * config.instances
://reviews.apache.org/r/29137/diff/
Testing
---
./pants src/test/python/apache/aurora/client:all
Verified in vagrant.
Thanks,
Maxim Khutornenko
.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian
Wickman.
Bugs: AURORA-934
https://issues.apache.org/jira/browse/AURORA-934
Repository: aurora
Description
---
Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.
Diffs
?
- Maxim Khutornenko
On Dec. 18, 2014, 12:59 a.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29165/
---
(Updated
On Dec. 18, 2014, 1:19 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/base.py, line 257
https://reviews.apache.org/r/29165/diff/2/?file=795322#file795322line257
Adding space after ';' should make it more readable.
Joshua Cohen wrote:
I was going
-scheduler.md 7f6cc2e6c8e01115a9b7a7dc7633bcd88ba02a0f
docs/thrift-deprecation.md PRE-CREATION
Diff: https://reviews.apache.org/r/29117/diff/
Testing
---
https://github.com/maxim111333/incubator-aurora/blob/populated_deprecation/docs/thrift-deprecation.md
Thanks,
Maxim Khutornenko
/populated_deprecation/docs/thrift-deprecation.md
Thanks,
Maxim Khutornenko
/client:all
Verified in vagrant.
Thanks,
Maxim Khutornenko
/RequestLogger.java
916939d850ad964647c9d3071f9548d823fd40d8
src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java
6beaa6b67b04a60e92ade038dd97dafb810fe003
Diff: https://reviews.apache.org/r/29005/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
avgt 100 5165386.898 ± 344576.928 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example
avgt 100 5011738.309 ± 160249.620 ns/op
```
Thanks,
Maxim Khutornenko
---
On Dec. 12, 2014, 6:05 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/
---
(Updated
https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/28971/#comment108145
drop?
- Maxim Khutornenko
On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971
-4135-4016-a9bf-8d4815a4a573__NoStaticVetoFiltering.png
StaticVetoFiltering.png
https://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
916939d850ad964647c9d3071f9548d823fd40d8
src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java
6beaa6b67b04a60e92ade038dd97dafb810fe003
Diff: https://reviews.apache.org/r/29005/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
044e6099a81bfa241a317b6a6b0f6f46da49bdc2
src/test/python/apache/aurora/client/cli/util.py
6dba1855f8951d38882c0d5b01a5a609b774d00f
Diff: https://reviews.apache.org/r/29015/diff/
Testing
---
./pants src/test/python/apache/aurora/client/cli:all
Also, visually verified in vagrant.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64683
---
On Dec. 11, 2014, 2:55 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28876/#review64787
---
Ping, Bill.
- Maxim Khutornenko
On Dec. 9, 2014, 10:32 p.m
,
Maxim Khutornenko
o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example
avgt 100 5165386.898 ± 344576.928 ns/op
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example
avgt 100 5011738.309 ± 160249.620 ns/op
```
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28879/#review64827
---
Ship it!
Sorry, missed it.
- Maxim Khutornenko
On Dec. 9, 2014
201 - 300 of 1219 matches
Mail list logo
