81d1734a22a8744d6002aadb7fb446d132d10bd9
Diff: https://reviews.apache.org/r/24815/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
and doc to call out that the
validation is based on things being _added_ to the existing task pool.
Maxim Khutornenko wrote:
| It would be nice for the parameter name and doc to call out that the
validation is based on things being added to the existing task pool
://reviews.apache.org/r/24915/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
65f404915bc60ffe11a7a57d9861ac5b37fa646a
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
04137072891b2a1f0ad663182629dd469b09324f
Diff: https://reviews.apache.org/r/24915/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/25309/#comment91078
Curious, why not using multiple '\t' instead of spacing?
- Maxim Khutornenko
On Sept. 4, 2014, 1:24 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52311
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 4, 2014, 1:24
this).
I'll reply on the ticket to try to reach consensus on what the problem is
and what it means to fix it.
Maxim Khutornenko wrote:
I don't think we are trying to fix a Mesos problem here. Regardless of
the underlying Mesos resolution (MESOS-1646), I do think Aurora should be a
good
only used from SchedulerThriftInterface. I suggest putting it there.
Maxim Khutornenko wrote:
Right now that is correct. However, I'd expect JobUpdateController to
accept it in order to check quota any time an instance about to be added.
Bill Farner wrote:
in order to check quota
only used from SchedulerThriftInterface. I suggest putting it there.
Maxim Khutornenko wrote:
Right now that is correct. However, I'd expect JobUpdateController to
accept it in order to check quota any time an instance about to be added.
Bill Farner wrote:
in order to check quota
/TaskVarsTest.java
d02714c846a521ff9ac3e53d991731314e714ae2
Diff: https://reviews.apache.org/r/25357/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
--shards value fails the update.
- Maxim Khutornenko
On Sept. 4, 2014, 9:19 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25356
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24915/#review52328
---
On Aug. 20, 2014, 11:35 p.m., Maxim Khutornenko wrote
/gen/api.thrift.md5
81d1734a22a8744d6002aadb7fb446d132d10bd9
Diff: https://reviews.apache.org/r/24815/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
6654c1675ac9f5f7d481e115cea7c224fb212467
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
d02714c846a521ff9ac3e53d991731314e714ae2
Diff: https://reviews.apache.org/r/25357/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
On Sept. 4, 2014, 9:42 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52393
---
Ship it!
LGTM mod HttpSignaler mocking.
- Maxim Khutornenko
/JettyServerModule.java
https://reviews.apache.org/r/25285/#comment90944
typo
- Maxim Khutornenko
On Sept. 3, 2014, 5:23 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
state no-op transitions or throw here only if from != to?
- Maxim Khutornenko
On Sept. 3, 2014, 4:02 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25300
/thermos_task_runner.py
https://reviews.apache.org/r/25208/#comment90949
mesos_pb2 looks a bit cryptic here. How about the approach you sued
elsewhere:
from mesos.interface.mesos_pb2 import TaskState
- Maxim Khutornenko
On Sept. 3, 2014, 4:06 a.m., Joe Smith wrote
---
On Aug. 29, 2014, 10:28 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25204/
---
(Updated Aug. 29, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25309/#review52212
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 3, 2014, 6:17
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java,
lines 74-76
https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74
This will also throw for in-place transitions (e.g
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java,
lines 74-76
https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74
This will also throw for in-place transitions (e.g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25300/#review52231
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 3, 2014, 4:02
f5682801902589552907415b4563af5b069af929
Diff: https://reviews.apache.org/r/25311/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
with start_update? Any
chance to avoid sharing the option set here?
- Maxim Khutornenko
On Sept. 2, 2014, 4:36 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
, why not.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25311/#review52232
---
On Sept. 3, 2014, 7:41 p.m., Maxim Khutornenko
/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
f5682801902589552907415b4563af5b069af929
Diff: https://reviews.apache.org/r/25311/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/24815/#review52089
---
On Aug. 18, 2014, 8:04 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
On Aug. 20, 2014, 11:35 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24915
for the JobUpdateQuery constructor, but with different
parameter names. It makes the code harder to follow, not easier.
Maxim Khutornenko wrote:
The reason for this is mostly consistency (see build_query above) but I
personally prefer this approach as it decouples query building from
b47b6db31842fffba797c7f616b5f4deb8d04a86
Diff: https://reviews.apache.org/r/25204/diff/
Testing
---
./pants src/test/python/apache/aurora/client/api:api -s
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24995/#review51781
---
Ping, Kevin.
- Maxim Khutornenko
On Aug. 22, 2014, 8:55 p.m
237d4abacae78ff9d024f43d777ff6d3328b1dd9
Diff: https://reviews.apache.org/r/25159/diff/
Testing
---
./pants src/test/python/apache/aurora/client/api:api
Thanks,
Maxim Khutornenko
generated e-mail. To reply, visit:
https://reviews.apache.org/r/25158/
---
(Updated Aug. 28, 2014, 6:13 p.m.)
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.
Bugs: AURORA-614
None
Description
build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24995/#review51837
---
On Aug. 28, 2014, 8:58 p.m., Maxim Khutornenko wrote
://reviews.apache.org/r/25133/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25133/#review51736
---
On Aug. 28, 2014, 1:19 a.m., Maxim Khutornenko wrote
Diff: https://reviews.apache.org/r/24982/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
?
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
---
On Aug. 21, 2014, 11:23 p.m., Maxim Khutornenko wrote
fa611a913bad40a8c0515c578b394c460340e574
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
997ade0be58723d1d91725061bb128ccf45e25b4
Diff: https://reviews.apache.org/r/24995/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
the callback anymore. (It'll remove some complexity here,
and we can just make the callers worry about formatting and such)
Maxim Khutornenko wrote:
I don't see why we should remove it. This is a nice to have feature,
which adds flexibility in case someone needs to run a post-drain script
/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
a748c0183997a59f1773a2be62ec17f6c11ddd3a
Diff: https://reviews.apache.org/r/24871/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
https://reviews.apache.org/r/24953/#comment89288
trailing space
src/test/python/apache/aurora/client/cli/test_create.py
https://reviews.apache.org/r/24953/#comment89293
Any change to add some asserts here that would verify instances_binding and
cluster_binding values?
- Maxim Khutornenko
/async/GcExecutorLauncher.java
65f404915bc60ffe11a7a57d9861ac5b37fa646a
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
04137072891b2a1f0ad663182629dd469b09324f
Diff: https://reviews.apache.org/r/24915/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim
log or a client one (i.e.
loglens)?
src/test/python/apache/aurora/client/cli/test_create.py
https://reviews.apache.org/r/24852/#comment88860
This is the existing test, right? Diff shows it in green for some reason...
- Maxim Khutornenko
On Aug. 19, 2014, 3:22 p.m., Mark Chu-Carroll
/JobUpdateController.java
https://reviews.apache.org/r/24827/#comment88861
A TODO to follow up on deleted flag removal?
src/main/thrift/org/apache/aurora/gen/api.thrift
https://reviews.apache.org/r/24827/#comment88862
Is there really anything to resume for the paused updates?
- Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24852/#review50981
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 19, 2014, 3:22
On Aug. 19, 2014, 3:47 p.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234
https://reviews.apache.org/r/24852/diff/1/?file=664291#file664291line233
This is the existing test, right? Diff shows it in green for some
reason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24827/#review50995
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 19, 2014, 5:43
---
gradle -Pq build
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24662/#review51008
---
On Aug. 14, 2014, 8:20 p.m., Maxim Khutornenko wrote
/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java
2a7d9659d649f30d849ef2eb5eac4b8a4f040d7a
Diff: https://reviews.apache.org/r/24662/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/test_maintenance.py
a748c0183997a59f1773a2be62ec17f6c11ddd3a
Diff: https://reviews.apache.org/r/24871/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 538
https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538
What action is going to be used for an instance that failed to update
and the job rollback
/org/apache/aurora/scheduler/thrift/ThriftIT.java
43265fdab1ae900fb828374f6c69e562def2d682
Diff: https://reviews.apache.org/r/24815/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
).
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/#review50930
---
On Aug. 18, 2014, 8:10 p.m., Maxim Khutornenko wrote
/JobUpdateController.java
https://reviews.apache.org/r/24813/#comment88819
s/../.
- Maxim Khutornenko
On Aug. 18, 2014, 7:41 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24823/#review50941
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 18, 2014, 11:33
/SchedulerThriftInterface.java
https://reviews.apache.org/r/24727/#comment88585
Why this change? The lock is supposed to be already acquired by the time
startJobUpdate is executed, hense the Lock instance in the argument set. How
is it supposed to work now?
- Maxim Khutornenko
On Aug. 15, 2014, 3:19 a.m
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
lines 1293-1299
https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293
Why this change? The lock is supposed to be already
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
lines 1293-1299
https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293
Why this change? The lock is supposed to be already
://reviews.apache.org/r/24720/#comment88609
Rolling back assumes removing new (INSTANCE_REMOVED) and adding old
(INSTANCE_ADDED). Do we want to distinct those actions from the forward roll?
- Maxim Khutornenko
On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote
/client/api::
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24744/#review50755
---
On Aug. 15, 2014, 6:14 p.m., Maxim Khutornenko wrote
interfere with the updater.
Maxim Khutornenko wrote:
How do we ensure pause/resume/abort is authorized to act on the update
then? Sure, storing the lock on the client is not a good idea but unless we
have some secondary way to authorize the action anyone could interfere with
the update
interfere with the updater.
Maxim Khutornenko wrote:
How do we ensure pause/resume/abort is authorized to act on the update
then? Sure, storing the lock on the client is not a good idea but unless we
have some secondary way to authorize the action anyone could interfere with
the update
://reviews.apache.org/r/24720/#comment88672
What action is going to be used for an instance that failed to update and
the job rollback is disabled?
- Maxim Khutornenko
On Aug. 15, 2014, 5:52 p.m., David McLaughlin wrote
src/test/python/apache/aurora/client/api:api
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24702/#review50598
---
On Aug. 14, 2014, 4:08 p.m., Maxim Khutornenko wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24655/#review50594
---
On Aug. 13, 2014, 5:32 p.m., Maxim Khutornenko wrote
/ThriftIT.java
2562ff944b7cb304ce5a60d3f74beee22f6cc7bc
Diff: https://reviews.apache.org/r/24655/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/StorageTestUtil.java
4bad83963b98002f42b470d03e58f832bd96d568
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d34bd6f5fedddb8d70996dc0806b4158f4136874
Diff: https://reviews.apache.org/r/24662/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/24662/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
6bc6ccf37a34bfe6baf260034584be758a4c83f5
Diff: https://reviews.apache.org/r/24521/diff/
Testing
---
gradle -Pq build
./pants src/test/python/apache/aurora/client/api:scheduler_client
Thanks,
Maxim Khutornenko
6bc6ccf37a34bfe6baf260034584be758a4c83f5
Diff: https://reviews.apache.org/r/24521/diff/
Testing
---
gradle -Pq build
./pants src/test/python/apache/aurora/client/api:scheduler_client
Thanks,
Maxim Khutornenko
/api.thrift.md5
6bc6ccf37a34bfe6baf260034584be758a4c83f5
Diff: https://reviews.apache.org/r/24521/diff/
Testing
---
gradle -Pq build
./pants src/test/python/apache/aurora/client/api:scheduler_client
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24521/#review50348
---
On Aug. 12, 2014, 6:58 p.m., Maxim Khutornenko wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24616/#review50365
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 12, 2014, 8:56
---
gradle -Pq build
./pants src/test/python/apache/aurora/client/api:scheduler_client
Thanks,
Maxim Khutornenko
duplicates in the result?
Maxim Khutornenko wrote:
This is the only way to preserve ordering in the result set. I am happy
to revert it if we decide to sort on the client. It's a bit weird to support
paging with partial results coming out of order though.
David McLaughlin wrote
, 2014, 8:19 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-613
https://issues.apache.org/jira/browse/AURORA-613
Repository: aurora
Description
---
There are 3 levels to performing an update:
1. Move the job from state A to state B
/r/24465/#comment87555
I thought the thrift JobUpdateAction is what we would use here, no?
- Maxim Khutornenko
On Aug. 7, 2014, 11:11 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24521/#review50098
---
On Aug. 9, 2014, 12:15 a.m., Maxim Khutornenko wrote
://reviews.apache.org/r/24431/#review49860
---
On Aug. 7, 2014, 12:01 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
://reviews.apache.org/r/24431/#review49863
---
On Aug. 7, 2014, 12:01 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24431
-mail. To reply, visit:
https://reviews.apache.org/r/24431/#review49860
---
On Aug. 7, 2014, 12:01 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail
/test/resources/org/apache/aurora/gen/api.thrift.md5
f01e4b33ee94ee7e8a36aa71688b699a87bc0566
Diff: https://reviews.apache.org/r/24431/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
build
Thanks,
Maxim Khutornenko
48600b59b918434ef963b758279c48584ccd34ef
src/test/resources/org/apache/aurora/gen/api.thrift.md5
f01e4b33ee94ee7e8a36aa71688b699a87bc0566
Diff: https://reviews.apache.org/r/24431/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24357/#review49782
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 6, 2014, 5:52 p.m
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/db/LockMapper.xml
https://reviews.apache.org/r/24432/#comment87223
How about INNER JOIN instead to be totally explicit?
- Maxim Khutornenko
On Aug. 7, 2014, 12:03 a.m., Bill Farner wrote:
---
This is an automatically generated e
On Aug. 7, 2014, 12:05 a.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml,
line 63
https://reviews.apache.org/r/24432/diff/1/?file=654349#file654349line63
How about INNER JOIN instead to be totally explicit?
Bill Farner
On Aug. 7, 2014, 12:05 a.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml,
line 63
https://reviews.apache.org/r/24432/diff/1/?file=654349#file654349line63
How about INNER JOIN instead to be totally explicit?
Bill Farner
/storage/log/LogStorageTest.java
bef0ee70abf6a5d77ded65ba2aa581f97e26a851
Diff: https://reviews.apache.org/r/24317/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
a93291e9d422a93114a94f0edd25a22e9b16ebfb
Diff: https://reviews.apache.org/r/24334/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/resources/org/apache/aurora/gen/storage.thrift.md5
a93291e9d422a93114a94f0edd25a22e9b16ebfb
Diff: https://reviews.apache.org/r/24334/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
701 - 800 of 1219 matches
Mail list logo
