Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 16, 2014, 6:12 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, > > line 41 > > > > > > "...forward roll." - this is no longer correct as we use

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53570 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 16, 2014, 6:12 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, > > line 41 > > > > > > "...forward roll." - this is no longer correct as we use

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:29 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53555 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/up

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 6:06 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 12:32 a.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 16, 2014, 12:30 a.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53422 --- Ship it! Thanks for adding those subset-related comments, clearer n

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html, > > line 17 > > > > > > I'd love to see UTC here as well. > > David McLaughlin wrote: >

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 15, 2014, 6:53 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 12, 2014, 11:47 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line > > 54 > > > > > > I'd like to see the paused states disambiguated. I could imagine a

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53244 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 12, 2014, 10:39 p.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 12, 2014, 10:32 p.m.) Review request for Aurora, Joshua Cohen, K

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 12, 2014, 9:20 p.m., Joshua Cohen wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, lines > > 69-72 > > > > > > This might read a little bit cleaner if you chained it all? > >

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53216 --- Mostly just nitpicky style/readability stuff... src/main/resources

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 9, 2014, 11:42 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, > > line 81 > > > > > > s/is this/if this D'oh. Fixed. - David ---

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 11:50 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 277 > > > > > > This seems to be too short to make any visual difference b

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52801 --- src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettin

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- (Updated Sept. 9, 2014, 11:32 p.m.) Review request for Aurora, Joshua Cohen, Ke

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 277 > > > > > > Extract this as a configuration variable? Fixed. > On Sept.

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 277 > > > > > > This seems to be too short to make any visual difference b

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 277 > > > > > > This seems to be too short to make any visual difference b

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52665 --- src/main/resources/org/apache/aurora/scheduler/http/ui/js/controlle

Re: Review Request 25259: Add update information to the scheduler UI

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 277 > > > > > > This seems to be too short to make any visual difference b

Re: Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review52661 --- src/main/resources/org/apache/aurora/scheduler/http/ui/js/controlle

Review Request 25259: Add update information to the scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Bugs: