---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review58280
---
src/main/python/apache/aurora/client/cli/jobs.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review58294
---
Master (53f4e73) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27129/#review58296
---
LGTM! Master (53f4e73) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58300
---
LGTM! Master (53f4e73) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58299
---
Does it make sense to use the ReviewBoard Python client from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---
(Updated Oct. 24, 2014, 12:59 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58339
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/
---
(Updated Oct. 24, 2014, 8:09 p.m.)
Review request for Aurora, Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27129/#review58351
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 23, 2014, 7:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58301
---
Ship it!
build-support/jenkins/review_feedback.py
On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote:
Does it make sense to use the ReviewBoard Python client from rbtools?
https://www.reviewboard.org/docs/rbtools/0.5/api/overview/
What is the plan to actually run this script? Is it safe to assume that it
will be executed from an up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58374
---
It's not obvious from the diff: where do we gain perf? Can you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58376
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 24, 2014, 1:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27084/#review58377
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 23, 2014, 9:50 a.m.,
On Oct. 24, 2014, 2:10 p.m., Maxim Khutornenko wrote:
It's not obvious from the diff: where do we gain perf? Can you point to the
place where we don't do store calls anymore?
If you notice in `SchedulingFilterImplTest.java` many of the tests no longer
make calls to the maintenance
On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote:
Does it make sense to use the ReviewBoard Python client from rbtools?
https://www.reviewboard.org/docs/rbtools/0.5/api/overview/
What is the plan to actually run this script? Is it safe to assume that it
will be executed from an up
On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
build-support/jenkins/review_feedback.py, line 39
https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line39
Use print() as a function, here and throughout
Done.
On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote:
build-support/jenkins/review_feedback.py, lines 37-38
https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line37
replace with ternary?
Done.
On Oct. 24, 2014, 8:57 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/
---
(Updated Oct. 24, 2014, 9:42 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27084/#review58387
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 23, 2014, 4:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58391
---
Ship it!
Can you document your exit codes somewhere?
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58392
---
+1: Master (5be667f) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58396
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 24, 2014, 9:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58400
---
+1: Master (5be667f) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58403
---
-1: Master (5be667f) is red with this patch.
On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java,
line 119
https://reviews.apache.org/r/27100/diff/1/?file=730205#file730205line119
I don't understand what you mean by matches what we do for dedicated
host
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/#review58409
---
Ship it!
Thanks! This is now on master:
$ git log -1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---
(Updated Oct. 24, 2014, 3:38 p.m.)
Review request for Aurora, Maxim
On Oct. 24, 2014, 2:49 p.m., Zameer Manji wrote:
Can you document your exit codes somewhere?
Bill Farner wrote:
Is that worthwhile? If it means documenting, i'd rather not vary them at
all. I don't think this is something that should be scripted against.
I asumed you varried them
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58415
---
Ship it!
On Oct. 24, 2014, 9:49 p.m., Zameer Manji wrote:
Can you document your exit codes somewhere?
Bill Farner wrote:
Is that worthwhile? If it means documenting, i'd rather not vary them at
all. I don't think this is something that should be scripted against.
Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/
---
(Updated Oct. 24, 2014, 10:42 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/
---
(Updated Oct. 24, 2014, 10:48 p.m.)
Review request for Aurora, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58420
---
Ship it!
Long live ReviewBot!
- Kevin Sweeney
On Oct. 24, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58423
---
+1: Master (f98bec7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58426
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 24, 2014, 10:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27089/
---
(Updated Oct. 24, 2014, 11:05 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---
(Updated Oct. 24, 2014, 4:08 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58431
---
+1: Master (669981d) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27089/#review58432
---
Ship it!
docs/client-commands.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/#review58436
---
Ship it!
build-support/jenkins/review_feedback.py
On Oct. 24, 2014, 11:21 p.m., Kevin Sweeney wrote:
build-support/jenkins/review_feedback.py, line 112
https://reviews.apache.org/r/27181/diff/1/?file=733134#file733134line112
Should've caught this in the first review - dashes instead of
underscores, here and above.
Done.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/#review58438
---
-1: This patch does not apply cleanly on master (f98bec7), do you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27181/
---
(Updated Oct. 24, 2014, 11:25 p.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58444
---
-1: Master (3778330) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/
---
(Updated Oct. 25, 2014, 12:24 a.m.)
Review request for Aurora, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/
---
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58480
---
Ship it!
Ship It!
- Joe Smith
On Oct. 24, 2014, 8:17 p.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58481
---
+1: Master (3778330) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58483
---
Ship it!
_~
_~)_)_~
)_))_))_)
_!__!__!_
__t/
On Oct. 25, 2014, 4:39 a.m., Joshua Cohen wrote:
_~
_~)_)_~
)_))_))_)
_!__!__!_
__t/
~
Wow did that ever not format properly!
https://github.com/reviewboard/rb-extension-pack/blob/master/shipit_ascii_art/shipit_ascii_art/asciiart.py#L4
- Joshua
53 matches
Mail list logo
