Re: Review Request 18354: Add a packaging target for clientv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/#review35409 --- src/main/python/apache/aurora/client/BUILD https://reviews.apache.org/r/18354/#comment65891 Please, add this target into make-python-sdists as well. - Maxim Khutornenko On Feb. 21, 2014, 2:12 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- (Updated Feb. 21, 2014, 2:12 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-226 https://issues.apache.org/jira/browse/aurora-226 Repository: aurora Description --- Add a packaging target for clientv2. Diffs - src/main/python/apache/aurora/client/BUILD 11ad955866b82b327a57a0f52cff0cdc1a2d83fc Diff: https://reviews.apache.org/r/18354/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 18354: Add a packaging target for clientv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- (Updated Feb. 25, 2014, 11:33 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- Added clientv2 packaging target to make-python-sdists Bugs: aurora-226 https://issues.apache.org/jira/browse/aurora-226 Repository: aurora Description --- Add a packaging target for clientv2. Diffs (updated) - build-support/release/make-python-sdists 43e74be8496916cd4f56d4930b3e8d8a217c001c src/main/python/apache/aurora/client/BUILD 11ad955866b82b327a57a0f52cff0cdc1a2d83fc Diff: https://reviews.apache.org/r/18354/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 18354: Add a packaging target for clientv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/#review35410 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 25, 2014, 4:33 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- (Updated Feb. 25, 2014, 4:33 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-226 https://issues.apache.org/jira/browse/aurora-226 Repository: aurora Description --- Add a packaging target for clientv2. Diffs - build-support/release/make-python-sdists 43e74be8496916cd4f56d4930b3e8d8a217c001c src/main/python/apache/aurora/client/BUILD 11ad955866b82b327a57a0f52cff0cdc1a2d83fc Diff: https://reviews.apache.org/r/18354/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35426 --- src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18440/#comment65914 Echo of dealing with val types in a strongly typed language :) Changed. src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18440/#comment65917 Good point. Fixed. src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18440/#comment65922 Sure, fixed. src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/18440/#comment65925 Line wrapping it is. Done. src/main/python/apache/aurora/client/commands/admin.py https://reviews.apache.org/r/18440/#comment65927 Done. src/main/python/apache/aurora/client/commands/admin.py https://reviews.apache.org/r/18440/#comment65928 Was not sure about sorting applied to items(). Done. src/main/python/apache/aurora/client/commands/admin.py https://reviews.apache.org/r/18440/#comment65937 The inf reads infeasible and infinite - both would be right here. Also, inf is easier to parse from a shell script. That said, I don't feel strong about it as n/a is definitely self-explanatory. Changed. src/main/python/apache/aurora/client/commands/admin.py https://reviews.apache.org/r/18440/#comment65938 Done. - Maxim Khutornenko On Feb. 25, 2014, 1 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/ --- (Updated Feb. 25, 2014, 1 a.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-209 https://issues.apache.org/jira/browse/AURORA-209 Repository: aurora Description --- Implemented sla_probe_hosts command. Diffs - src/main/python/apache/aurora/client/api/sla.py fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e src/test/python/apache/aurora/client/api/test_sla.py 2778545b7cf42c20fb44e2fdb5b661556e84234f src/test/python/apache/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/ --- (Updated Feb. 25, 2014, 6:59 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Changes --- CR comments. Bugs: AURORA-209 https://issues.apache.org/jira/browse/AURORA-209 Repository: aurora Description --- Implemented sla_probe_hosts command. Diffs (updated) - src/main/python/apache/aurora/client/api/sla.py fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e src/test/python/apache/aurora/client/api/test_sla.py 2778545b7cf42c20fb44e2fdb5b661556e84234f src/test/python/apache/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35437 --- Ship it! Ship It! - Brian Wickman On Feb. 25, 2014, 6:59 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/ --- (Updated Feb. 25, 2014, 6:59 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-209 https://issues.apache.org/jira/browse/AURORA-209 Repository: aurora Description --- Implemented sla_probe_hosts command. Diffs - src/main/python/apache/aurora/client/api/sla.py fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e src/test/python/apache/aurora/client/api/test_sla.py 2778545b7cf42c20fb44e2fdb5b661556e84234f src/test/python/apache/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35438 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 25, 2014, 1:59 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/ --- (Updated Feb. 25, 2014, 1:59 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-209 https://issues.apache.org/jira/browse/AURORA-209 Repository: aurora Description --- Implemented sla_probe_hosts command. Diffs - src/main/python/apache/aurora/client/api/sla.py fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e src/test/python/apache/aurora/client/api/test_sla.py 2778545b7cf42c20fb44e2fdb5b661556e84234f src/test/python/apache/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35440 --- Thanks! Pushed to master. - Maxim Khutornenko On Feb. 25, 2014, 6:59 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/ --- (Updated Feb. 25, 2014, 6:59 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-209 https://issues.apache.org/jira/browse/AURORA-209 Repository: aurora Description --- Implemented sla_probe_hosts command. Diffs - src/main/python/apache/aurora/client/api/sla.py fd5edd1c8dffa99fd42c0e01ecfa8ec832a4a602 src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e src/test/python/apache/aurora/client/api/test_sla.py 2778545b7cf42c20fb44e2fdb5b661556e84234f src/test/python/apache/aurora/client/commands/test_admin_sla.py 780ad180366a5b8664367e499fe86470418c1344 Diff: https://reviews.apache.org/r/18440/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Review Request 18481: Upgrade pex to twitter.common.python==0.3.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18481/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description --- SSIA Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf Diff: https://reviews.apache.org/r/18481/diff/ Testing --- Tested upgrade on clean and dirty master. Thanks, Kevin Sweeney
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
On Feb. 25, 2014, 11:46 a.m., Bill Farner wrote: build-support/virtualenv, line 19 https://reviews.apache.org/r/18345/diff/3/?file=503119#file503119line19 I may be missing something, but isn't the pushd/popd obviated by the cd? The cd only happens in the subshell ($()), which is a different process than the parent. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35444 --- On Feb. 24, 2014, 6:45 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 24, 2014, 6:45 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
On Feb. 25, 2014, 7:46 p.m., Bill Farner wrote: build-support/virtualenv, line 19 https://reviews.apache.org/r/18345/diff/3/?file=503119#file503119line19 I may be missing something, but isn't the pushd/popd obviated by the cd? Kevin Sweeney wrote: The cd only happens in the subshell ($()), which is a different process than the parent. Ah, duh — thanks! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35444 --- On Feb. 25, 2014, 2:45 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 25, 2014, 2:45 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 17562: Added cluster name to page title.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review35447 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java https://reviews.apache.org/r/17562/#comment65966 doc here has drifted, please being it back in check src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/17562/#comment65969 A brief doc would go a long way here. What's this used for? Where do the fields go? src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/17562/#comment65970 Convention here is to pseudo-mangle the name by tacking DEPRECATED on the name. This has zero impact on the wire, and serves in place of compiler-assisted deprecation warnings. src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/17562/#comment65971 No action necessary on your part, but the TODO is the best you can do here. Thrift routes messages to handler methods based on the RPC method _name_, so name mangling here would actually break wire compatibility. src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java https://reviews.apache.org/r/17562/#comment65972 Mind putting some dummy data in ServerInfo fields? - Bill Farner On Feb. 25, 2014, 1:22 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 25, 2014, 1:22 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-120 https://issues.apache.org/jira/browse/AURORA-120 Repository: aurora Description --- Added getInfo API that returns page title and thrift API version. Added a TitleController to UI to set the page title. The controller queries the getInfo API to get the clusterName which is now included in the page title. Deprecated getVersion API in favor of getInfo to obtain the thrift API version. Diffs - build.gradle f8f00e6e73e566795d8208ca7edd6e70fc9c5d76 src/main/java/org/apache/aurora/scheduler/app/AppModule.java 296bc1f7f20c4d8bb0ce14dfd4f9c003473ceec7 src/main/java/org/apache/aurora/scheduler/http/ClusterName.java ac77f6ac0b71d5b3735cb269c9bfff3e2c6fda20 src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 3686a6682d39fa75baddfb4a1b739e14e2caf508 src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 25ba7da5f8bbe5416f41bb0b14850beb84392cc7 src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 36aa425e78c519188827c3455a0aef53b060d8eb src/main/java/org/apache/aurora/scheduler/http/Slaves.java cc8971ca6f4a402064a843eef5a23a47d2df06c1 src/main/java/org/apache/aurora/scheduler/http/Utilization.java 0cbdeeafde9db05e71fdb7e71b6d4529dee9cbdd src/main/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptor.java e3e050e493e4a69e1d424d3382cb37f7ce6b7a4c src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java c68977a7cef99a31baca2043618df304298b407e src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1916ff9c02216da906af4e6164212faeff37995e src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 94189642a4f35aa0cad8176589cfbd84964c2e14 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f0f0e39c40758cd40c981bcbde1e59f2e7a99e3f src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d src/test/java/org/apache/aurora/scheduler/thrift/aop/APIVersionInterceptorTest.java 2f0b6716fe2999c34c0351f03b6b4c1532eafee0 src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java d93ac53ec15863f2ee0e0ebc4737d8f4f8e4be9d src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/17562/diff/ Testing --- gradle clean build. gradle run. Thanks, Suman Karumuri
Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18241/#review35453 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 5:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18241/ --- (Updated Feb. 20, 2014, 5:16 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-134 https://issues.apache.org/jira/browse/AURORA-134 Repository: aurora Description --- Don't unnecessarily invoke write() within LogStorage, and assert that a transaction is open when a mutation is performed. I'm starting to explore a refactor that further cleans this up by extracting the *Store implementations out of LogStorage, which should simplify things by separating transaction management from delegation. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 36e4082acceb3045ef92a5957b500e407bfc1247 src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 005bad2c6b9f13e3438f3136e63fe777c6b42507 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/18241/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/#review35454 --- Ship it! Ship It! src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java https://reviews.apache.org/r/18240/#comment65978 reads better statically imported (here and elsewhere). - Kevin Sweeney On Feb. 18, 2014, 1:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/ --- (Updated Feb. 18, 2014, 1:55 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-135 https://issues.apache.org/jira/browse/AURORA-135 Repository: aurora Description --- I've also done some tidying of the storage interfaces here, which make code simpler in several places: - Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock possible - Introduced StorageOperation as a base interface for Work and MutateWork. - Moved Storage#snapshot() to NonVolatileStorage Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java a02991453def78bbf6a00c8946d2079fdc4539e9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 9cc1d1e871bc34fd244565a692215b9657e164a8 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 36e4082acceb3045ef92a5957b500e407bfc1247 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 30d77cc86fba569cfaa35ae69d97726072660aed src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f7e34d1cf379168be6fffab0faaf450151a10bc src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 5dc7df18325f9a637ef9009197555e8d53c3b498 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 656e44eb51508c7ab05af8b91e9dcec216d48984 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d Diff: https://reviews.apache.org/r/18240/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.
On Feb. 19, 2014, 4:33 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/Storage.java, line 69 https://reviews.apache.org/r/18240/diff/1/?file=497126#file497126line69 typo Fixed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/#review34866 --- On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/ --- (Updated Feb. 18, 2014, 9:55 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-135 https://issues.apache.org/jira/browse/AURORA-135 Repository: aurora Description --- I've also done some tidying of the storage interfaces here, which make code simpler in several places: - Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock possible - Introduced StorageOperation as a base interface for Work and MutateWork. - Moved Storage#snapshot() to NonVolatileStorage Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java a02991453def78bbf6a00c8946d2079fdc4539e9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 9cc1d1e871bc34fd244565a692215b9657e164a8 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 36e4082acceb3045ef92a5957b500e407bfc1247 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 30d77cc86fba569cfaa35ae69d97726072660aed src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f7e34d1cf379168be6fffab0faaf450151a10bc src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 5dc7df18325f9a637ef9009197555e8d53c3b498 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 656e44eb51508c7ab05af8b91e9dcec216d48984 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d Diff: https://reviews.apache.org/r/18240/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.
On Feb. 25, 2014, 8:35 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java, line 113 https://reviews.apache.org/r/18240/diff/1/?file=497125#file497125line113 reads better statically imported (here and elsewhere). Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/#review35454 --- On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/ --- (Updated Feb. 18, 2014, 9:55 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-135 https://issues.apache.org/jira/browse/AURORA-135 Repository: aurora Description --- I've also done some tidying of the storage interfaces here, which make code simpler in several places: - Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock possible - Introduced StorageOperation as a base interface for Work and MutateWork. - Moved Storage#snapshot() to NonVolatileStorage Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java a02991453def78bbf6a00c8946d2079fdc4539e9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 9cc1d1e871bc34fd244565a692215b9657e164a8 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 36e4082acceb3045ef92a5957b500e407bfc1247 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 30d77cc86fba569cfaa35ae69d97726072660aed src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f7e34d1cf379168be6fffab0faaf450151a10bc src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 5dc7df18325f9a637ef9009197555e8d53c3b498 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 656e44eb51508c7ab05af8b91e9dcec216d48984 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d Diff: https://reviews.apache.org/r/18240/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.
On Feb. 25, 2014, 8:35 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java, line 113 https://reviews.apache.org/r/18240/diff/1/?file=497125#file497125line113 reads better statically imported (here and elsewhere). Bill Farner wrote: Done. Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/#review35454 --- On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18240/ --- (Updated Feb. 18, 2014, 9:55 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-135 https://issues.apache.org/jira/browse/AURORA-135 Repository: aurora Description --- I've also done some tidying of the storage interfaces here, which make code simpler in several places: - Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock possible - Introduced StorageOperation as a base interface for Work and MutateWork. - Moved Storage#snapshot() to NonVolatileStorage Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java a02991453def78bbf6a00c8946d2079fdc4539e9 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 9cc1d1e871bc34fd244565a692215b9657e164a8 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 36e4082acceb3045ef92a5957b500e407bfc1247 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 30d77cc86fba569cfaa35ae69d97726072660aed src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f7e34d1cf379168be6fffab0faaf450151a10bc src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 5dc7df18325f9a637ef9009197555e8d53c3b498 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 656e44eb51508c7ab05af8b91e9dcec216d48984 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d Diff: https://reviews.apache.org/r/18240/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35461 --- Fix committed at https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=commitdiff;h=6e7acbfb7a8b4cb9694fbc510fc67e07c1b34454 - Kevin Sweeney On Feb. 24, 2014, 6:45 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/ --- (Updated Feb. 24, 2014, 6:45 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf build-support/virtualenv d7a99e0c3934afba55e131850a202b6e706cec8a pants 4dc17fd365d8fd120c162905c41f29d92788011f rbt c03c4c4b61fb49fecd7e3bbff89581ca91c58a74 Diff: https://reviews.apache.org/r/18345/diff/ Testing --- Submitted this review with the following command: ../rbt post -o -g (from inside of build-support directory) Thanks, Dan Norris
Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
On Feb. 25, 2014, 2:07 p.m., Mark Chu-Carroll wrote: Ship It! Mark, as the last shipper with commit access — can you commit this? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17877/#review35400 --- On Feb. 25, 2014, 2:53 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17877/ --- (Updated Feb. 25, 2014, 2:53 a.m.) Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll. Bugs: AURORA-200 https://issues.apache.org/jira/browse/AURORA-200 Repository: aurora Description --- AURORA-200: set_quota should die if given invalid arguments Diffs - src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823 Diff: https://reviews.apache.org/r/17877/diff/ Testing --- ./gradlew clean build ./pants src/test/python:all -vxs along with manual testing w/ bad arguments. Thanks, Dan Norris
Re: Review Request 18485: Improving sla_list_safe_domain performance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18485/#review35484 --- Ship it! Ship It! - Brian Wickman On Feb. 25, 2014, 10:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18485/ --- (Updated Feb. 25, 2014, 10:26 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-233 https://issues.apache.org/jira/browse/AURORA-233 Repository: aurora Description --- - Replaced ACTIVE_STATES with a union of LIVE_STATES and STARTING. - Changed _simulate_host_down to avoid constructing JobUpTimeSlaVector in order to calculate total tasks. Before: ncalls tottime percall cumtime percall 1 0.0000.00063.549 63.549 After: ncalls tottime percall cumtime percall 1 0.0000.00044.857 44.857 Diffs - src/main/python/apache/aurora/client/api/sla.py 4fcc07534dc3fb7a7c967c0b98ee8675123a56c7 src/test/python/apache/aurora/client/api/test_sla.py 4f0a2c07fbed975a43438f32b6a576e6b85da4f8 Diff: https://reviews.apache.org/r/18485/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:sla Thanks, Maxim Khutornenko
Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- There are a few nice things falling out of this refactor: - New methods on mutable store interfaces are not implicitly forwarded (ForwardingStore does not implement mutable stores). - Write ahead/behind behavior is more obvious in LogStorage (i found the delegation by calling super tough to catch mistakes.) - Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of a transaction (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation) - the boolean recovered flag disappears, making LogStorage.write() easier to reason about (CallOrderEnforcingStorage helps bolster this.) Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 Diff: https://reviews.apache.org/r/18487/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated Feb. 26, 2014, 12:12 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Changes --- Decided to backpedal on the removal of LogStorage.recovered flag, since it has a bigger ripple than i'd like to add here. Repository: aurora Description (updated) --- There are a few nice things falling out of this refactor: - New methods on mutable store interfaces are not implicitly forwarded (ForwardingStore does not implement mutable stores). - Write ahead/behind behavior is more obvious in LogStorage (i found the delegation by calling super tough to catch mistakes.) - Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of a transaction (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation) Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 Diff: https://reviews.apache.org/r/18487/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Review Request 18490: Generate cron predictions using -Duser.timezone=GMT.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18490/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-132 https://issues.apache.org/jira/browse/AURORA-132 Repository: aurora Description --- Test data was generated with a system timezone of PST - regenerate it with GMT. Diffs - src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json 0f71f70b5aec7646375f775fde6e1eceae038a9e Diff: https://reviews.apache.org/r/18490/diff/ Testing --- Manual testing against internal implementation - test against quartz coming in a later review. Thanks, Kevin Sweeney
Re: Review Request 18490: Generate cron predictions using -Duser.timezone=GMT.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18490/#review35503 --- Ship it! Ship It! - Bill Farner On Feb. 26, 2014, 12:19 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18490/ --- (Updated Feb. 26, 2014, 12:19 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-132 https://issues.apache.org/jira/browse/AURORA-132 Repository: aurora Description --- Test data was generated with a system timezone of PST - regenerate it with GMT. Diffs - src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json 0f71f70b5aec7646375f775fde6e1eceae038a9e Diff: https://reviews.apache.org/r/18490/diff/ Testing --- Manual testing against internal implementation - test against quartz coming in a later review. Thanks, Kevin Sweeney
Re: Review Request 17303: Updated getJobs API to return task stats and latest task config
On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 48 https://reviews.apache.org/r/17303/diff/1/?file=447775#file447775line48 This uses time so it should take a Clock instance for testing. Since we got rid of mostRecentFailures logic, this code is dropped now. On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19 https://reviews.apache.org/r/17303/diff/1/?file=447781#file447781line19 How would you feel about naming this TaskFixtures or TaskTestUtil? Done. On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 192 https://reviews.apache.org/r/17303/diff/1/?file=447776#file447776line192 explicit orderings will throw RuntimeExceptions if they encounter a value not in the explicit set. It doesn't seem to me that STATUSES is exhaustive and I don't see test coverage to guarantee that in the future. Good catch. Updated the list to be exhaustive. Added a test case to test the same. On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 191 https://reviews.apache.org/r/17303/diff/1/?file=447776#file447776line191 Why the indirection? Why not call this latestActiveTask? Updated comment to make this clear. Can't use latestActiveTask since a job may have just finished but it's taskConfig is not a representative task config for the job. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/#review33465 --- On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated Jan. 24, 2014, 7:13 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-64 https://issues.apache.org/jira/browse/AURORA-64 Repository: aurora Description --- Added task stats to getJobs API so it can be used by the role page in the UI. Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant classes so it can be used by the UI and the thrift API. Added tests for new code. Moved populateJobConfig call into ReadOnlyScheduler. Diffs - src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/base/Tasks.java 06a19d80483b6949c9851b5d38fe34ac712aa75e src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b0caca73b46fba928fb718ab45a608dad4685a2f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 912be189583419e7201e45650d18cd24a6a5a35b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17303/diff/ Testing --- gradle clean build gradle run to test local UI. Thanks, Suman Karumuri
Re: Review Request 17303: Added getJobSummary API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated Feb. 26, 2014, 4:18 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-64 https://issues.apache.org/jira/browse/AURORA-64 Repository: aurora Description --- Added getJobSummary API so it can be used by the role and role/environment page in the UI. Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant classes so it can be used by the UI and the thrift API. Added tests for new code. Moved populateJobConfig call into ReadOnlyScheduler. Diffs - src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/base/Tasks.java d9cb886ef333e108d5d5f86043ac80e450689894 src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 25ba7da5f8bbe5416f41bb0b14850beb84392cc7 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TasksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 912be189583419e7201e45650d18cd24a6a5a35b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/17303/diff/ Testing --- gradle clean build gradle run to test local UI. Thanks, Suman Karumuri
Re: Review Request 17303: Added getJobSummary API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated Feb. 26, 2014, 4:18 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Added getJobSummary API per code review. Addressed review feedback. Summary (updated) - Added getJobSummary API Bugs: AURORA-64 https://issues.apache.org/jira/browse/AURORA-64 Repository: aurora Description (updated) --- Added getJobSummary API so it can be used by the role and role/environment page in the UI. Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant classes so it can be used by the UI and the thrift API. Added tests for new code. Moved populateJobConfig call into ReadOnlyScheduler. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/base/Tasks.java d9cb886ef333e108d5d5f86043ac80e450689894 src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 25ba7da5f8bbe5416f41bb0b14850beb84392cc7 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/base/TasksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 912be189583419e7201e45650d18cd24a6a5a35b src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/17303/diff/ Testing --- gradle clean build gradle run to test local UI. Thanks, Suman Karumuri
