Re: Review Request 24573: Fix bug in aurora job inspect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50583 --- src/test/python/apache/aurora/client/cli/BUILD https://reviews.apache.org/r/24573/#comment88445 -2 indent, remove extra newline after src/test/python/apache/aurora/client/cli/test_inspect.py https://reviews.apache.org/r/24573/#comment88450 missing license header src/test/python/apache/aurora/client/cli/test_inspect.py https://reviews.apache.org/r/24573/#comment88446 Leave no TODO unassigned: TODO(markcc) src/test/python/apache/aurora/client/cli/test_inspect.py https://reviews.apache.org/r/24573/#comment88447 remove? src/test/python/apache/aurora/client/cli/test_inspect.py https://reviews.apache.org/r/24573/#comment88448 remove comment? src/test/python/apache/aurora/client/cli/test_kill.py https://reviews.apache.org/r/24573/#comment88449 revert? shouldn't classes be separated by 2 blank lines? - Bill Farner On Aug. 13, 2014, 7:27 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/ --- (Updated Aug. 13, 2014, 7:27 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: aurora-642 https://issues.apache.org/jira/browse/aurora-642 Repository: aurora Description --- Inspect was using context.print_out() to add blank lines, but the print_out method takes a mandatory string parameter. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 08590d0895a2b4082c6929a261b36c8a1a82ac97 src/main/python/apache/aurora/client/cli/jobs.py 3cb39b232648d69615bbdfedc4d81eaf7ece7938 src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 src/test/python/apache/aurora/client/cli/test_inspect.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_kill.py ee64908855a4960f44ce96c810e69dd105d2ce5d src/test/python/apache/aurora/client/cli/util.py 5d2e72d9a475cbb7821ca466d13c195d5eb942c1 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh ea5ae8d0004aea42b7e750eb52c34a636e3a7998 Diff: https://reviews.apache.org/r/24573/diff/ Testing --- Thanks, Mark Chu-Carroll
Review Request 24702: Implementing client job lock and start update APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/ --- Review request for Aurora, Mark Chu-Carroll and Bill Farner. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Implementing client job lock and start update APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 371137e469fd65935f4048eaafdcf9b702e8c947 src/main/python/apache/aurora/client/api/updater_util.py cbb93e4d64a334dba9d091b68cf6d3594930fa31 src/test/python/apache/aurora/client/api/BUILD db5c22375378566f58ade5d6a0b7fcce75ad8394 src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION Diff: https://reviews.apache.org/r/24702/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 24702: Implementing client job lock and start update APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/#review50593 --- src/main/python/apache/aurora/client/api/__init__.py https://reviews.apache.org/r/24702/#comment88457 Can you add a more specific error type - maybe InvalidConfigError? That way, in the client, I can generate better error messages. src/main/python/apache/aurora/client/api/updater_util.py https://reviews.apache.org/r/24702/#comment88462 This is a bit magical for me. It's relying on subtleties of methods that a typical python programmer will need to look up, which means that it's going to be really easy for it to be wrong in a hard-to-recognize way. Can you move it up, so that it's a classmethod, and then add a couple of tests? Tests will both check that it works, and provide demonstrations for readers to see how it works. (I know you've already got some tests of this, but they're indirect, htrough the surrounding method; for clarity, it would be better to be able to test get_ranges directly.) - Mark Chu-Carroll On Aug. 14, 2014, 12:08 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/ --- (Updated Aug. 14, 2014, 12:08 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Implementing client job lock and start update APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 371137e469fd65935f4048eaafdcf9b702e8c947 src/main/python/apache/aurora/client/api/updater_util.py cbb93e4d64a334dba9d091b68cf6d3594930fa31 src/test/python/apache/aurora/client/api/BUILD db5c22375378566f58ade5d6a0b7fcce75ad8394 src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION Diff: https://reviews.apache.org/r/24702/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 24662: Implementing job update get thrift APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/#review50597 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/24662/#comment88466 Would an error response make more sense in this case? Drawing a parallel to HTTP, this would probably be a 404. - Bill Farner On Aug. 13, 2014, 7:05 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/ --- (Updated Aug. 13, 2014, 7:05 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing job update get thrift APIs. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java ebcb9103d75909080f5b6a69db3a1bf46cfd9780 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 4bad83963b98002f42b470d03e58f832bd96d568 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 Diff: https://reviews.apache.org/r/24662/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24702: Implementing client job lock and start update APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/#review50598 --- LGTM, would like to reconcile the populateJobConfig situation before proceeding. src/main/python/apache/aurora/client/api/__init__.py https://reviews.apache.org/r/24702/#comment88467 previously-acquired src/main/python/apache/aurora/client/api/__init__.py https://reviews.apache.org/r/24702/#comment88468 Seems like the scheduler should automatically do this within startJobUpdate. Is there anything preventing that behavior? - Bill Farner On Aug. 14, 2014, 4:08 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/ --- (Updated Aug. 14, 2014, 4:08 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Implementing client job lock and start update APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 371137e469fd65935f4048eaafdcf9b702e8c947 src/main/python/apache/aurora/client/api/updater_util.py cbb93e4d64a334dba9d091b68cf6d3594930fa31 src/test/python/apache/aurora/client/api/BUILD db5c22375378566f58ade5d6a0b7fcce75ad8394 src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION Diff: https://reviews.apache.org/r/24702/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 24702: Implementing client job lock and start update APIs.
On Aug. 14, 2014, 5:21 p.m., Bill Farner wrote: src/main/python/apache/aurora/client/api/__init__.py, line 181 https://reviews.apache.org/r/24702/diff/1/?file=660624#file660624line181 Seems like the scheduler should automatically do this within startJobUpdate. Is there anything preventing that behavior? That's actually a great idea! The startJobUpdate already does ConfigurationManager.populateAndValidate() on the TaskConfig making this call effectively redundant. Will drop it entirely. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/#review50598 --- On Aug. 14, 2014, 4:08 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/ --- (Updated Aug. 14, 2014, 4:08 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Implementing client job lock and start update APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 371137e469fd65935f4048eaafdcf9b702e8c947 src/main/python/apache/aurora/client/api/updater_util.py cbb93e4d64a334dba9d091b68cf6d3594930fa31 src/test/python/apache/aurora/client/api/BUILD db5c22375378566f58ade5d6a0b7fcce75ad8394 src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION Diff: https://reviews.apache.org/r/24702/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 24702: Implementing client job lock and start update APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/#review50619 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 14, 2014, 2:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/ --- (Updated Aug. 14, 2014, 2:26 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Bugs: AURORA-615 https://issues.apache.org/jira/browse/AURORA-615 Repository: aurora Description --- Implementing client job lock and start update APIs. Diffs - src/main/python/apache/aurora/client/api/__init__.py 371137e469fd65935f4048eaafdcf9b702e8c947 src/main/python/apache/aurora/client/api/updater_util.py cbb93e4d64a334dba9d091b68cf6d3594930fa31 src/test/python/apache/aurora/client/api/BUILD db5c22375378566f58ade5d6a0b7fcce75ad8394 src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION src/test/python/apache/aurora/client/api/test_updater_util.py PRE-CREATION Diff: https://reviews.apache.org/r/24702/diff/ Testing --- ./pants src/test/python/apache/aurora/client/api:api Thanks, Maxim Khutornenko
Re: Review Request 24655: Implementing startJobUpdate thrift API.
On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java, line 27 https://reviews.apache.org/r/24655/diff/1/?file=659429#file659429line27 s/User/User who/ Done. On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java, line 96 https://reviews.apache.org/r/24655/diff/1/?file=659430#file659430line96 requireNonNull for all 3 Done. On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java, line 42 https://reviews.apache.org/r/24655/diff/1/?file=659429#file659429line42 I tend to prefer the String, Throwable signature, allowing (read: encouraging) layers in the stack to add context. Done. On Aug. 14, 2014, 5:13 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1259 https://reviews.apache.org/r/24655/diff/1/?file=659432#file659432line1259 TODO: input validation. It might not happen here, but good to leave a reminder. Thanks for reminding. Added. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/#review50594 --- On Aug. 13, 2014, 5:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/ --- (Updated Aug. 13, 2014, 5:32 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing startJobUpdate thrift API. Diffs - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/StateModule.java 2c712eff097c3334bfcf2559a52214367748d08a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/24655/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24655: Implementing startJobUpdate thrift API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/ --- (Updated Aug. 14, 2014, 8:07 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Changes --- CR comments. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing startJobUpdate thrift API. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/StateModule.java 2c712eff097c3334bfcf2559a52214367748d08a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/24655/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24712: Improve coverage in the end-to-end test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24712/#review50630 --- Ship it! Ship It! - David McLaughlin On Aug. 14, 2014, 8:09 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24712/ --- (Updated Aug. 14, 2014, 8:09 p.m.) Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Bugs: aurora-646 https://issues.apache.org/jira/browse/aurora-646 Repository: aurora Description --- Adds the following to the end-to-end: - config list - job status - job list with partial key - job kill, both failing with no instance list, and killing a specific instance - job restart Diffs - src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8e18e52d9d55e42e39683b43c4cfdd784cf8dbde Diff: https://reviews.apache.org/r/24712/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 24662: Implementing job update get thrift APIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/#review50631 --- Ship it! Ship It! - David McLaughlin On Aug. 14, 2014, 8:20 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/ --- (Updated Aug. 14, 2014, 8:20 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing job update get thrift APIs. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java ebcb9103d75909080f5b6a69db3a1bf46cfd9780 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 4bad83963b98002f42b470d03e58f832bd96d568 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 Diff: https://reviews.apache.org/r/24662/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24655: Implementing startJobUpdate thrift API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/#review50661 --- Ship it! Ship It! - David McLaughlin On Aug. 14, 2014, 8:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24655/ --- (Updated Aug. 14, 2014, 8:07 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Implementing startJobUpdate thrift API. Diffs - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/state/StateModule.java 2c712eff097c3334bfcf2559a52214367748d08a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d34bd6f5fedddb8d70996dc0806b4158f4136874 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/24655/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Review Request 24720: Expand actions in JobUpdateAction
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Added some more items to the JobUpdateAction enum. Not married to the labels I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into finer-grained actions. Diffs - src/main/thrift/org/apache/aurora/gen/api.thrift af9f02ed1de487bc5cc2967d2edcece5b21e0be5 Diff: https://reviews.apache.org/r/24720/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 24720: Expand actions in JobUpdateAction
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50679 --- Ship it! src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/24720/#comment88542 Your call, but you might benefit from an INSTANCE_ROLLING_BACK value as well. - Bill Farner On Aug. 14, 2014, 11:21 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 14, 2014, 11:21 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Added some more items to the JobUpdateAction enum. Not married to the labels I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into finer-grained actions. Diffs - src/main/thrift/org/apache/aurora/gen/api.thrift af9f02ed1de487bc5cc2967d2edcece5b21e0be5 Diff: https://reviews.apache.org/r/24720/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 24720: Expand actions in JobUpdateAction
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50692 --- Also, while it might seem tedious, can you include in the description the events you would expect for the success and failure (revert) cases of: 1. instance update 2. instance remove 3. instance add 4. noop This will help prove the enum is complete, and help me follow the same policy when implementing the backend. - Bill Farner On Aug. 14, 2014, 11:21 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 14, 2014, 11:21 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description --- Added some more items to the JobUpdateAction enum. Not married to the labels I've chosen, and I wasn't sure if we want to break out INSTANCE_UPDATING into finer-grained actions. Diffs - src/main/thrift/org/apache/aurora/gen/api.thrift af9f02ed1de487bc5cc2967d2edcece5b21e0be5 Diff: https://reviews.apache.org/r/24720/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 24727: Store a lock association with job updates.
On Aug. 15, 2014, 1:54 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/storage.thrift, line 77 https://reviews.apache.org/r/24727/diff/1/?file=661129#file661129line77 The SaveJobUpdate could also benefit from this comment. Done. On Aug. 15, 2014, 1:54 a.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, line 329 https://reviews.apache.org/r/24727/diff/1/?file=661127#file661127line329 This data is only needed when saving snapshots (fetchAllJobUpdateDetails). Should we rather move this join into selectAllDetails and keep selectDetails as is for the perf reasons? It would require splitting this sql block into a few refs though, so up to you. I'll take the reduced complexity over the performance for now. If this join poses a performance problem, we've got bigger issues here :-) On Aug. 15, 2014, 1:54 a.m., Maxim Khutornenko wrote: src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java, line 372 https://reviews.apache.org/r/24727/diff/1/?file=661132#file661132line372 Should be easier to read with '\n' after every test case here. Good call, done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24727/#review50691 --- On Aug. 15, 2014, 1:11 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24727/ --- (Updated Aug. 15, 2014, 1:11 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Store a lock association with job updates. Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 3f083d60a882c6665d9891172edb9a5aeddade9b src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java c05833f30eaf79527599a7223791a6f4f5309388 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d659aa124bd702589952da1b19854a00862b0c86 src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java d590219e9ff873bc7b9b740759b024c463c523cf src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 342bab0426ebeeab0b3d2d038d98dba1de836231 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 3d291dd21892c20a8eb9388744c8b2f10a811554 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 2915ff00f3a2e3602414cedebbb0270e07dc869a src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 17c58b1a07f2fcef7fe8502540b347542b603e60 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 1cf803fe019290c042e5a73824e39a12072b2431 src/main/thrift/org/apache/aurora/gen/storage.thrift 9f8378ea3f5d386c3177207296bf4b436b730b45 src/main/thrift/org/apache/aurora/gen/storage_local.thrift becfd7528610a32af907489d021319d9b371c332 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 2f2c3e12657e9af1edf819ff95d0da5db0c5de4b src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java f695b85514bcc5cedb16e962124af3db052cb17a src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ae4cef42d67556a22ea45eaa6d7542915924ffd1 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java ebcb9103d75909080f5b6a69db3a1bf46cfd9780 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5 Diff: https://reviews.apache.org/r/24727/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 24727: Store a lock association with job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24727/ --- (Updated Aug. 15, 2014, 3:19 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description --- Store a lock association with job updates. Diffs - src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java f15344417f52fe5e909abfbba636c48277404fb4 src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java 6bcdf620c993091999c6cccaeae023cb061cbd50 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 3f083d60a882c6665d9891172edb9a5aeddade9b src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java c05833f30eaf79527599a7223791a6f4f5309388 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d659aa124bd702589952da1b19854a00862b0c86 src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java d590219e9ff873bc7b9b740759b024c463c523cf src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 342bab0426ebeeab0b3d2d038d98dba1de836231 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 3d291dd21892c20a8eb9388744c8b2f10a811554 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 2915ff00f3a2e3602414cedebbb0270e07dc869a src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0802ee08601f5b9747f99823679d92af59a76cbc src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 17c58b1a07f2fcef7fe8502540b347542b603e60 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 1cf803fe019290c042e5a73824e39a12072b2431 src/main/thrift/org/apache/aurora/gen/storage.thrift 9f8378ea3f5d386c3177207296bf4b436b730b45 src/main/thrift/org/apache/aurora/gen/storage_local.thrift becfd7528610a32af907489d021319d9b371c332 src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java 1f985fb75cff7e120bce9e60b91a19c7e19b9c2a src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 2f2c3e12657e9af1edf819ff95d0da5db0c5de4b src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java f695b85514bcc5cedb16e962124af3db052cb17a src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ae4cef42d67556a22ea45eaa6d7542915924ffd1 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java ebcb9103d75909080f5b6a69db3a1bf46cfd9780 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 7dbf97a6cecef928f563e76d37488816ca91872a Diff: https://reviews.apache.org/r/24727/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
