Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review71760 --- Master (68aa285) is red with this patch.

Re: Review Request 30710: add mesos role feature

2015-02-09 Thread Zameer Manji
On Feb. 9, 2015, 4:56 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, line 117 https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117 I don't think we can safely do this right now. I know the

Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-696

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/#review71762 --- Master (68aa285) is green with this patch.

Re: Review Request 30710: add mesos role feature

2015-02-09 Thread lozh...@ebay.com zhang
On Feb. 10, 2015, 12:56 a.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, line 117 https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117 I don't think we can safely do this right now. I know the

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71741 --- Ship it! Ship It! - Zameer Manji On Feb. 9, 2015, 3:16 p.m.,

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71730 --- This patch does not apply cleanly on master (68aa285), do you need

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review71729 --- Ship it! Pulse logic LGTM. - David McLaughlin On Feb. 7, 2015,

Re: Review Request 30710: add mesos role feature

2015-02-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71754 ---

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 6:45 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30768: Reject None values for TaskPath

2015-02-09 Thread Zameer Manji
On Feb. 8, 2015, 3:20 p.m., Bill Farner wrote: src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 42 https://reviews.apache.org/r/30768/diff/2/?file=857983#file857983line42 This source now has 3 styles for continued lines: -

Review Request 30804: Fixing test coverage in startJobUpdate RPC

2015-02-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30804/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 30804: Fixing test coverage in startJobUpdate RPC

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30804/#review71691 --- Ship it! Master (dcae1e8) is green with this patch.

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71678 --- Ship it! There is a lot of churn because of interface changes but

Re: Review Request 30768: Reject None values for TaskPath

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30768/#review71649 --- Ship it! Ship It! - Brian Wickman On Feb. 8, 2015, 9:34 p.m.,

Re: Review Request 30768: Reject None values for TaskPath

2015-02-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30768/ --- (Updated Feb. 9, 2015, 10:47 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 6:56 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Brian Wickman
On Feb. 8, 2015, 2:20 a.m., Zameer Manji wrote: src/main/python/apache/aurora/executor/gc_executor.py, line 73 https://reviews.apache.org/r/30749/diff/4/?file=853457#file853457line73 What's the benefit of using a namedtuple here? As opposed to? This means we don't have to change

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71671 --- This patch does not apply cleanly on master (dcae1e8), do you need

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Feb. 10, 2015, 12:53 a.m.) Review request for Aurora, David

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-09 Thread Maxim Khutornenko
On Feb. 3, 2015, 12:16 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1388 https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1388 You can check whether the primitive field is set, which will

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Feb. 10, 2015, 12:53 a.m.) Review request for Aurora, David

Re: Review Request 30710: add mesos role feature

2015-02-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71727 ---

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/ --- (Updated Feb. 10, 2015, 6:01 a.m.) Review request for Aurora and David

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 8:24 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Brian Wickman
and Zameer Manji. Changes --- Adds entry point tests for gc/thermos executors, since I got some of the import wiring wrong: vagrant@192:/var/lib/mesos/slaves/20150209-182237-119646400-5050-15827-S0/frameworks/20150209-182237-119646400-5050-15827-/executors/aurora.gc/runs/latest$ cat stderr

Re: Review Request 30804: Fixing test coverage in startJobUpdate RPC

2015-02-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30804/#review71707 --- Ship it!

Re: Review Request 30804: Fixing test coverage in startJobUpdate RPC

2015-02-09 Thread Maxim Khutornenko
On Feb. 9, 2015, 9:54 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 2690 https://reviews.apache.org/r/30804/diff/1/?file=858871#file858871line2690 Consider collapsing these all to one test case related to input

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71705 --- Master (dcae1e8) is red with this patch.

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71711 --- ping. - Brian Wickman On Feb. 6, 2015, 11:13 p.m., Brian Wickman

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/ --- (Updated Feb. 9, 2015, 11:16 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71720 --- Ship it! Master (68aa285) is green with this patch.

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30818/ --- (Updated Feb. 10, 2015, 6:01 a.m.) Review request for Aurora and David

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71676 --- Ship it! Master (dcae1e8) is green with this patch.