---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76807
---
Master (4b39d26) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/
---
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-1187
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32164/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/
---
(Updated March 17, 2015, 11:55 a.m.)
Review request for Aurora, Joshua Cohen
On March 17, 2015, 7:49 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/executor/common/path_detector.py, line 34
https://reviews.apache.org/r/32013/diff/3/?file=896451#file896451line34
What's the rationale behind this change? I think the callers should be
doing the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/#review76825
---
Master (a419863) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/
---
(Updated March 17, 2015, 2:59 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/#review76827
---
Ship it!
Master (a419863) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32164/#review76747
---
Ship it!
Master (b847bbf) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32164/#review76753
---
I actually meant this should be outside the preemptor altogether.
On March 17, 2015, 6:05 p.m., Bill Farner wrote:
I actually meant this should be outside the preemptor altogether. The
preemptor is being called, and then internally deciding the caller should
have not called in the first place. I claim this is odd behavior.
I think it would make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76774
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76844
---
Ship it!
Ship It!
- Zameer Manji
On March 17, 2015, 1:50 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32181/#review76839
---
Ship it!
Master (a419863) is green with this patch.
On March 17, 2015, 11:36 p.m., Aurora ReviewBot wrote:
Master (a419863) is red with this patch.
./build-support/jenkins/build.sh
Installing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
---
(Updated March 17, 2015, 11:30 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/#review76828
---
Ship it!
Ship It!
- Joshua Cohen
On March 17, 2015, 9:59 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32181/
---
Review request for Aurora.
Repository: aurora
Description
---
Only warn
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32181/
---
(Updated March 17, 2015, 11:50 p.m.)
Review request for Aurora.
Summary
On March 17, 2015, 11:12 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 208
https://reviews.apache.org/r/32181/diff/1/?file=898407#file898407line208
This reordering will result in pulsing the hostname even when an
On March 17, 2015, 11:12 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 208
https://reviews.apache.org/r/32181/diff/1/?file=898407#file898407line208
This reordering will result in pulsing the hostname even when an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76853
---
src/test/python/apache/aurora/client/cli/test_supdate.py
On March 18, 2015, 12:04 a.m., Kevin Sweeney wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, lines 404-406
https://reviews.apache.org/r/32171/diff/3/?file=898440#file898440line404
How would you feel about including all of the currently available data
with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76855
---
Master (a419863) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/
---
(Updated March 17, 2015, 12:18 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76787
---
Ship it!
On March 17, 2015, 7:56 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java,
line 39
https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39
Can you add a corresponding comment to api.thrift that any new methods
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/#review76800
---
Ship it!
Master (4b39d26) is green with this patch.
On March 17, 2015, 6:05 p.m., Bill Farner wrote:
I actually meant this should be outside the preemptor altogether. The
preemptor is being called, and then internally deciding the caller should
have not called in the first place. I claim this is odd behavior.
I think it would make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32164/#review76766
---
Ship it!
Ship It!
- Bill Farner
On March 17, 2015, 5:19 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/
---
(Updated March 17, 2015, 12:16 p.m.)
Review request for Aurora, Joshua Cohen
On March 17, 2015, 12:56 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java,
line 39
https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39
Can you add a corresponding comment to api.thrift that any new
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/
---
(Updated March 17, 2015, 1:03 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76790
---
Ship it!
Master (38d0a6c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/
---
(Updated March 17, 2015, 8:24 p.m.)
Review request for Aurora, Joe Smith and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/
---
(Updated March 17, 2015, 12:41 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76782
---
Ship it!
- Joe Smith
On March 13, 2015, 12:38 p.m., Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76783
---
Master (38d0a6c) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32161/#review76786
---
I tried this out locally and `vagrant up` wall time went from 5m24s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/#review76794
---
Ship it!
Ship It!
- Joe Smith
On March 17, 2015, 1:24 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31380/#review76736
---
Is this review stale? If so, discard?
- Bill Farner
On Feb. 24,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76735
---
Ship it!
LGTM mod nits below and satisfying the build bot.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30818/#review76737
---
Update or discard?
- Bill Farner
On Feb. 10, 2015, 6:01 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76741
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32161/#review76743
---
Ship it!
Master (b847bbf) is green with this patch.
45 matches
Mail list logo
