---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16797/#review31548
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 10, 2014, 10:08 p.m
. FAILURE
mba=aurora=;
Thanks,
Brian Wickman
going to defer to jon
b's thoroughness for the rest.
- Brian Wickman
On Jan. 27, 2014, 6:21 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17185
---
Fix noisy status checker debug log.
Diffs
-
src/main/python/apache/aurora/executor/common/status_checker.py
48e7a442cfb6bda1a6b3891c25f61f0c9003b8a4
Diff: https://reviews.apache.org/r/17412/diff/
Testing
---
Thanks,
Brian Wickman
://reviews.apache.org/r/17412/diff/
Testing
---
Thanks,
Brian Wickman
resolve as 3rdparty/python:argparse,
3rdparty/python:bottle, etc.
- Brian Wickman
On Jan. 27, 2014, 8:54 p.m., Jake Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32938
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2014, 12:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17419/#review32937
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2014, 12:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17293/#review33014
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 24, 2014, 1:28 a.m
(updated)
-
KEYS 0313277754679da0e5e1d2075654eac9006ce448
build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
Diff: https://reviews.apache.org/r/17063/diff/
Testing
---
Nope
Thanks,
Brian Wickman
build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
Diff: https://reviews.apache.org/r/17063/diff/
Testing
---
Nope
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17559/#review33254
---
On Jan. 30, 2014, 9:31 p.m., Brian Wickman wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17475/#review33257
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 29, 2014, 12:40 a.m
',
'slaves/*/frameworks/*/executors/%(executor_name)s/runs',
'%(slave_run_directory)s'
) % parameters
- Brian Wickman
On Jan. 30, 2014, 9:09 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated
(.-prefixed) deps
- third party deps
Testing Done:
./gradlew build ./pants src/test/python:all -vxs
Bugs closed: AURORA-157
Reviewed at https://reviews.apache.org/r/17734/
- Brian Wickman
On Feb. 5, 2014, 8:42 p.m., Dan Norris wrote
=== 5 passed in 0.07 seconds
===
src.test.python.apache.aurora.executor.common.directory_sandbox
. SUCCESS
Thanks,
Brian Wickman
,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/#review34508
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 13, 2014, 10:59 p.m
/17752/#comment64613
any reason why '-t' short form is removed? for me '-t50' is almost muscle
memory.
- Brian Wickman
On Feb. 12, 2014, 2:16 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply
.)
At the end of the day, if you end up on smaller or larger terminals, you'll
probably end up using the textwrap module to change the line breaks here
programmatically anyway.
- Brian Wickman
On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18163/#review34600
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 15, 2014, 2:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17752/#review34706
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 18, 2014, 1:47 p.m
/aurora/client/bin:aurora_admin
Thanks,
Brian Wickman
On Feb. 18, 2014, 6:57 p.m., Kevin Sweeney wrote:
Can you verify this fixes the e2e test?
Brian Wickman wrote:
give me an hour and i'll get back to you
***
+ echo 'OK (all tests passed)'
OK (all tests passed)
+ echo '***'
***
+ exit 0
- Brian
tests. ./pants src/test/python/apache/aurora/executor:executor-large
-v passes for me locally. running e2e now.
Thanks,
Brian Wickman
/
---
(Updated Feb. 18, 2014, 8:46 p.m.)
Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
Bugs: AURORA-207
https://issues.apache.org/jira/browse/AURORA-207
Repository: aurora
Description
---
Added sla
else None
- Brian Wickman
On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153
.')
src/main/python/apache/aurora/client/cli/options.py
https://reviews.apache.org/r/18267/#comment65451
don't forget to import Compatibility :-)
- Brian Wickman
On Feb. 20, 2014, 7:33 p.m., Mark Chu-Carroll wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18267/#review35120
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 20, 2014, 9:33 p.m
this was never updated. safe_hosts[host] = safe_limits !=
self_hosts[host].append(safe_limits)
do you mean .extend()?
- Brian Wickman
On Feb. 21, 2014, 7:49 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18440/#review35437
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 25, 2014, 6:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18485/#review35484
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 25, 2014, 10:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18602/#review35816
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 28, 2014, 2:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review35819
---
have you run the executor:long tests?
- Brian Wickman
On Feb. 28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18580/#review36050
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 28, 2014, 11:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18819/#review36323
---
Ship it!
Ship It!
- Brian Wickman
On March 5, 2014, 11:20 p.m
request for Aurora, David Robinson and Brian Wickman.
Bugs: AURORA-247
https://issues.apache.org/jira/browse/AURORA-247
Repository: aurora
Description
---
Removing rollback_on_failure from restart options.
Diffs
-
src/main/python/apache/aurora/client/api
len(tasks) will always be true if tasks
- Brian Wickman
On March 4, 2014, 1:20 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18720
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19143/#review37392
---
Ship it!
Ship It!
- Brian Wickman
On March 12, 2014, 10:59 p.m
https://reviews.apache.org/r/19426/#comment69574
yes
- Brian Wickman
On March 19, 2014, 10:55 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19426
://reviews.apache.org/r/19411/#comment69621
you'll want GlobalHookRegistry.get_hooks() to return cls.HOOKS[:],
otherwise 'hooks += config.hooks' will actually mutate the global registry
- Brian Wickman
On March 19, 2014, 5:09 p.m., Mark Chu-Carroll wrote
/#comment70121
it's unclear to me as a developer when i would use print_out vs print_err
vs print_log.
also, why make print_out and print_err abstract?
- Brian Wickman
On March 19, 2014, 1:20 p.m., Mark Chu-Carroll wrote
kill it while you're in the
neighborhood.)
- Brian Wickman
On March 18, 2014, 12:55 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19078
, and with batching as the default, should be
safe to interoperate.
- Brian Wickman
On March 20, 2014, 6:48 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19431
covered.
- Brian Wickman
On Jan. 8, 2014, 12:45 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16710
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19362/#review38167
---
Ship it!
Ship It!
- Brian Wickman
On March 18, 2014, 6:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19411/#review38169
---
Ship it!
Ship It!
- Brian Wickman
On March 21, 2014, 6:21 p.m
://reviews.apache.org/r/19431/#comment70194
metavar should be something like CLUSTER/ROLE/ENV/NAME[/INSTANCES]
- Brian Wickman
On March 21, 2014, 7:56 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail
/options.py
https://reviews.apache.org/r/19431/#comment70403
passing all here will result in a ValueError from the int(x[0]), so that
should probably be caught and signaled to the user as a human-readable error
message.
- Brian Wickman
On March 22, 2014, 2:14 p.m., Mark Chu-Carroll wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17056/#review38378
---
crap, i missed this. will merge/repost/submit.
- Brian Wickman
://reviews.apache.org/r/17056/diff/
Testing
---
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19396/#review38390
---
Ship it!
Ship It!
- Brian Wickman
On March 21, 2014, 7:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19466/#review38543
---
Ship it!
Ship It!
- Brian Wickman
On March 24, 2014, 11:21 p.m
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19431/
---
(Updated March 24, 2014, 6:58 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Bugs: aurora-268
https://issues.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19550/#review38787
---
Ship it!
Ship It!
- Brian Wickman
On March 21, 2014, 9:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19431/#review38788
---
Ship it!
Ship It!
- Brian Wickman
On March 26, 2014, 6:08 p.m
://reviews.apache.org/r/19895/#comment71637
fix comment
- Brian Wickman
On April 2, 2014, 1:52 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19895
, in module
TypeError: 'NoneType' object is not iterable
- Brian Wickman
On March 27, 2014, 10:58 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19756
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19756/#review39329
---
Ship it!
Ship It!
- Brian Wickman
On April 2, 2014, 5:18 p.m
://reviews.apache.org/r/19955/diff/
Testing
---
still running the build
Thanks,
Brian Wickman
src.test.python.apache.aurora.executor.gc_executor
. SUCCESS
src.test.python.apache.aurora.executor.thermos_executor
. SUCCESS
Thanks,
Brian Wickman
---
On April 2, 2014, 7:37 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19955/
---
(Updated April 2, 2014, 7
/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/util.py,
line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
These are bugs in the stdlib that are fixed in 2.7 and are harmless. Just FYI.
Thanks,
Brian
---
On April 22, 2014, 10:42 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review41149
---
Ship it!
Ship It!
- Brian Wickman
On April 22, 2014, 7:59 p.m
---
End to end test should not look at the number of html lines.
Diffs
-
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
f0f2ab53c1f484a480eb2ea8766c5d299e3b8c99
Diff: https://reviews.apache.org/r/20629/diff/
Testing
---
end-to-end test
Thanks,
Brian Wickman
/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/util.py,
line 258, in _exit_function
info('process shutting down')
TypeError: 'NoneType' object is not callable
These are bugs in the stdlib that are fixed in 2.7 and are harmless. Just FYI.
Thanks,
Brian Wickman
---
On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/
---
(Updated April 24, 2014, 1
0
- Brian Wickman
On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583
the directory
wrapper stuff. if it merges before r/20583, i will have to kill the directory
wrapper stuff :-) since this goes away in twitter.common.python =0.4.0.
- Brian Wickman
On April 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote
0
- Brian Wickman
On April 24, 2014, 1:33 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583
changes.
src/main/python/apache/thermos/observer/http/templates/task.tpl
https://reviews.apache.org/r/20394/#comment74754
kill trailing ws
- Brian Wickman
On April 16, 2014, 9:38 p.m., David McLaughlin wrote
Make sure to close the reviewboard, otherwise it will continue to show up
in review dashboards.
On Thu, Apr 24, 2014 at 10:20 AM, Mark Chu-Carroll
mchucarr...@apache.orgwrote:
It's already pushed.
On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman wick...@apache.org wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20678/#review41368
---
Ship it!
Ship It!
- Brian Wickman
On April 24, 2014, 6:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20726/#review41671
---
Ship it!
Ship It!
- Brian Wickman
On April 25, 2014, 7:41 p.m
---
./pants src/test/python:all -v
Thanks,
Brian Wickman
/dist/thermos_observer.pex
Thanks,
Brian Wickman
, i.e. with_timeout=True
src/main/python/apache/aurora/client/commands/core.py
https://reviews.apache.org/r/20950/#comment75615
weird indent.
also this should use die('Tasks were not killed in time.')
- Brian Wickman
On May 1, 2014, 8:42 p.m., Maxim Khutornenko wrote
On May 1, 2014, 8:59 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/job_monitor.py, line 81
https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81
=
Maxim Khutornenko wrote:
It's safe as is but since Mark asked about this too changing
On May 1, 2014, 8:59 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/job_monitor.py, line 81
https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81
=
Maxim Khutornenko wrote:
It's safe as is but since Mark asked about this too changing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20950/#review42025
---
Ship it!
Ship It!
- Brian Wickman
On May 1, 2014, 10:21 p.m
://reviews.apache.org/r/21023/#comment75787
there's an extra newline here.
- Brian Wickman
On May 2, 2014, 7:46 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
https://reviews.apache.org/r/20986/#comment76108
hosts should be passed in as hosts=hosts to differentiate it from
positional args in general. this is mostly just style though.
- Brian Wickman
On May 1, 2014, 9:49 p.m., Maxim Khutornenko wrote
don't have
commit privileges, so i think this is up to me to submit.
- Brian Wickman
On April 28, 2014, 10:48 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20394
= status_checkers
self._status = None
if not all(isinstance(h_i, StatusChecker) for h_i in status_checkers):
raise TypeError('ChainedStatusChecker must take an iterable of
StatusCheckers.')
super(ChainedStatusChecker, self).__init__()
- Brian Wickman
On May 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/#review42338
---
status?
- Brian Wickman
On April 24, 2014, 1:10 a.m., Kevin
On May 6, 2014, 6:59 p.m., Brian Wickman wrote:
src/test/python/apache/aurora/executor/test_thermos_executor.py, line 213
https://reviews.apache.org/r/21055/diff/1/?file=574139#file574139line213
out of curiosity, how does this ever work? checker should always be an
instance
-CREATION
build-support/isort PRE-CREATION
build-support/isort-check PRE-CREATION
build-support/isort-run PRE-CREATION
src/.isort.cfg PRE-CREATION
Diff: https://reviews.apache.org/r/21136/diff/
Testing
---
Ran the isort and ran tests, everything worked.
Thanks,
Brian Wickman
-support/isort-run PRE-CREATION
src/.isort.cfg PRE-CREATION
Diff: https://reviews.apache.org/r/21136/diff/
Testing
---
Ran the isort and ran tests, everything worked.
Thanks,
Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20986/#review42415
---
Ship it!
Ship It!
- Brian Wickman
On May 7, 2014, 1:06 a.m
---
On May 6, 2014, 11:10 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136
-CREATION
build-support/isort-check PRE-CREATION
build-support/isort-run PRE-CREATION
Diff: https://reviews.apache.org/r/21136/diff/
Testing
---
Ran the isort and ran tests, everything worked.
Thanks,
Brian Wickman
PRE-CREATION
Diff: https://reviews.apache.org/r/21136/diff/
Testing
---
Ran the isort and ran tests, everything worked.
Thanks,
Brian Wickman
://reviews.apache.org/r/21333/diff/
Testing
---
Thanks,
Brian Wickman
582fb81860cd55a20893dc4a0c92984dbf14df26
Diff: https://reviews.apache.org/r/21333/diff/
Testing
---
Thanks,
Brian Wickman
,
Brian Wickman
/aurora/client/test_config.py
https://reviews.apache.org/r/21297/#comment76805
2 newlines between top level tests
- Brian Wickman
On May 10, 2014, 1:15 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/21297/#comment76845
make this a named constant somewhere, e.g. STATUS_UPDATE_DELIVERY_WINDOW
just so it's more self documenting to a casual reader. i guess this will
also mean you need to parameterize it in WATCH_SECS_INSUFFICIENT_ERROR
- Brian Wickman
On May
T200:ERROR
2 T100:ERROR
2 T002:ERROR
2 E711:ERROR
2 E201:ERROR
1 E231:ERROR
1 E222:ERROR
1 E122:ERROR
Thanks,
Brian Wickman
/api/updater.py
https://reviews.apache.org/r/21440/#comment77050
it surprises me that this is necessary. will signal.signal() even work
outside of the MainThread? i'm pretty sure OSes will raise an exception if you
try (e.g. Linux)
- Brian Wickman
On May 14, 2014, 6:49 p.m., Maxim
1 - 100 of 352 matches
Mail list logo
