Re: Review Request 26424: Disable requests http connection logging.

> On Oct. 15, 2014, 12:02 a.m., Bill Farner wrote: > > Sorry for the delay on this, i didn't realize i was on the hook to commit. > > > > Now on master: > > $ git log -1 > > commit 72fed752fcdbacf0f29e7eaef56c177f5ec9fcf0 > > Author: Joshu

Re: Review Request 26714: Remove use of the getVersion RPC from the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26714/#review56809 --- Ship it! Ship It! - Joshua Cohen On Oct. 15, 2014, 6:48 p.m

Re: Review Request 26688: Fix errors in help rendering:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56811 --- Ship it! Ship It! - Joshua Cohen On Oct. 15, 2014, 5:57 p.m

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/#review56813 --- Ship it! Ship It! - Joshua Cohen On Oct. 13, 2014, 11:22 p.m

Review Request 26790: Fix redirect loop when accessing rewritten paths.

started up multiple schedulers in vagrant image and confirmed that I'm properly redirected when accessing the non-leading scheduler. Thanks, Joshua Cohen

Re: Review Request 26790: Fix redirect loop when accessing rewritten paths.

53c708866e8abcb1e951265c707ff34e2331a3c4 Diff: https://reviews.apache.org/r/26790/diff/ Testing --- ./gradlew build -Pq Also started up multiple schedulers in vagrant image and confirmed that I'm properly redirected when accessing the non-leading scheduler. Thanks, Joshua Cohen

Re: Review Request 26802: Set a default for the error log dir

> On Oct. 16, 2014, 5 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_aurora_command_line.py, line > > 34 > > > > > > I'm not sure what the right answer is here, and we may be too far down >

Re: Review Request 26790: Fix redirect loop when accessing rewritten paths.

Diff: https://reviews.apache.org/r/26790/diff/ Testing --- ./gradlew build -Pq Also started up multiple schedulers in vagrant image and confirmed that I'm properly redirected when accessing the non-leading scheduler. Thanks, Joshua Cohen

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

> On Oct. 8, 2014, 6:02 p.m., Kevin Sweeney wrote: > > Apologies for the review delay. > > > > Is there a way we can tell checkstyle to avoid this file at all? I'd rather > > not make it a policy to patch each individual bower component we checkin. > >

Re: Review Request 26821: Handle resourceOffers callback asynchronsly.

<https://reviews.apache.org/r/26821/#comment97432> nit, move to previous line. src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java <https://reviews.apache.org/r/26821/#comment97433> s/Augment/augment - Joshua Cohen On Oct. 16, 2014, 8:26 p.m., Zameer

Review Request 26834: Add client cluster configuration docs.

://reviews.apache.org/r/26834/diff/ Testing --- Rendered here: https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md Thanks, Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

7;m wrong), however having this here does protect us against having to redeploy the client in the event that mesos changes its path structure. - Joshua Cohen On Oct. 16, 2014, 10:56 p.m., Joshua Cohen wrote: > > --- > This is an

Re: Review Request 26834: Add client cluster configuration docs.

> On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote: > > docs/client-cluster-configuration.md, line 34 > > <https://reviews.apache.org/r/26834/diff/1/?file=723472#file723472line34> > > > > I think an argument could be made for removing this configuration >

Review Request 26841: Describe how to clone the git repo to contributing docs.

/incubator-aurora/blob/jcohen/docs/howtocontribute-git/docs/contributing.md Thanks, Joshua Cohen

Re: Review Request 26841: Describe how to clone the git repo to contributing docs.

6d63eb01c83b976f7183054afac48010d88558e9 Diff: https://reviews.apache.org/r/26841/diff/ Testing --- https://github.com/jcohen/incubator-aurora/blob/jcohen/docs/howtocontribute-git/docs/contributing.md Thanks, Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

/incubator-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md Thanks, Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

views.apache.org/r/26834/#review57049 --- On Oct. 16, 2014, 11:58 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 26834: Add client cluster configuration docs.

rora-client.md". The > link will _maybe_ go in the outcome of AURORA-834, so not your task. > > Joshua Cohen wrote: > Well, I just added it, want me to kill it? ;) (didn't see your follow up for some reason). - Joshua --

Re: Review Request 26834: Add client cluster configuration docs.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57064 --- On Oct. 17, 2014, 12:37 a.m., Joshua Cohen wrote: > >

Re: Review Request 26834: Add client cluster configuration docs.

-aurora/blob/jcohen/docs/clusters.json/docs/client-cluster-configuration.md Thanks, Joshua Cohen

Re: Review Request 26881: Improve error messages in client commands.

ready seen users having when parsing these error messages, it might be more clear that the indented lines that follow are the message from the server if the previous line ends in a colon? Server reported error restarting job west/bozo/test/hello: Job 'west/bozo/test/hello' not found.

Re: Review Request 26834: Add client cluster configuration docs.

/docs/client-cluster-configuration.md Thanks, Joshua Cohen

Re: Review Request 26834: Add client cluster configuration docs.

roundrobin DNS name. Yep, thanks for reminding me. Updated the description. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57142 ------

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review56991 --- On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote: > > --- &g

Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

--- ./gradlew build -Pq Thanks, Joshua Cohen

Re: Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

1233b258c48eef5ee869126234810ddcef103f44 Diff: https://reviews.apache.org/r/26901/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen

Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

g the bar! (we're at 0.8793488824101069 for instruction coverage, so close to bumping that up). Thanks, Joshua Cohen

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

l. To reply, visit: https://reviews.apache.org/r/26902/#review57256 ------- On Oct. 18, 2014, 12:26 a.m., Joshua Cohen wrote: > > --- > This is an automatically generate

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

exceeds min instruction coverage of 0.86, please raise the threshold! Branch coverage must be greater than 0.83 Thanks, Joshua Cohen

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57416 --- Ship it! Ship It! - Joshua Cohen On Oct. 20, 2014, 7:36 p.m

Re: Review Request 26531: Defining schema for the heartbeat RPC.

be INT not BIGINT. Signed BIGINT is something on the order of 300,000 millenia between heartbeats? ;). - Joshua Cohen On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

hing like "(local time)", or even better, instead of hardcoding "LOCAL" maybe just display their actual time zone identifier (or, since that's a minor hassle from JS, maybe just the offset)? - Joshua Cohen On Oct. 20, 2014, 10:55 p.m., David McLaughlin wrote: > > -

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

> On Oct. 20, 2014, 11:11 p.m., Joshua Cohen wrote: > > It's not entirely clear from the screenshot that "LOCAL" is a reference to > > the timezone. Maybe it's the fact that it's capitalized, but it feels more > > related to the task state

Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26956/#review57540 --- Ship it! Ship It! - Joshua Cohen On Oct. 21, 2014, 12:42 a.m

Re: Review Request 26995: Download thrift from archive.a.o.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57657 --- Ship it! Ship It! - Joshua Cohen On Oct. 21, 2014, 8:54 p.m

Re: Review Request 26998: Building aurora client/admin before running e2 tests.

tps://reviews.apache.org/r/26998/ > --- > > (Updated Oct. 21, 2014, 10:14 p.m.) > > > Review request for Aurora, Joshua Cohen and Kevin Sweeney. > > > Bugs: AURORA-498 > https://issues.apache.org/jira/br

Re: Review Request 26997: Adding quota check into scheduleCronJob RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26997/#review57688 --- Ship it! Ship It! - Joshua Cohen On Oct. 21, 2014, 9:24 p.m

Re: Review Request 26998: Building aurora client/admin before running e2 tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26998/#review57714 --- Ship it! Thanks! - Joshua Cohen On Oct. 21, 2014, 11:22 p.m

Review Request 27045: Add some wiggle room before requiring min coverage thresholds be raised.

/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.8806389838314789 exceeds minimum coverage of 0.87. Branch coverage of 0.825925925925926 exceeds minimum coverage of 0.82. :check :build BUILD SUCCESSFUL Thanks, Joshua Cohen

Re: Review Request 27044: Make executor overhead configurable

://reviews.apache.org/r/27044/#comment98699> Indentation looks off here? - Joshua Cohen On Oct. 22, 2014, 4:57 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 27047: Improve status command output ordering.

tps://reviews.apache.org/r/27047/#comment98726> spec? - Joshua Cohen On Oct. 22, 2014, 5:57 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 27047: Improve status command output ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27047/#review57873 --- Ship it! Ship It! - Joshua Cohen On Oct. 22, 2014, 7:44 p.m

Re: Review Request 27063: Freeze pants requirements.

dependencies? pants <https://reviews.apache.org/r/27063/#comment98868> Did you create the requirements file manually, or is there some easier/better way to update this in the future as pants changes its dependencies? - Joshua Cohen On Oct. 23, 2014, 1:38 a.m., Kevin Sweeney

Re: Review Request 27044: Make executor overhead configurable

> On Oct. 22, 2014, 5:32 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java, > > line 67 > > <https://reviews.apache.org/r/27044/diff/1/?file=728781#file728781line67> > > > > Do we actually need to us

Re: Review Request 27129: Upgrade psutil to 2.1.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27129/#review58237 --- Ship it! Ship It! - Joshua Cohen On Oct. 24, 2014, 2:13 a.m

Re: Review Request 27145: Add a script that publishes build results to review board.

145/#comment99248> Our Python continuation indent style is generally the same as our Java style, so these should be indented 4 past the parent, not aligned? - Joshua Cohen On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: > > ---

Re: Review Request 27145: Add a script that publishes build results to review board.

> On Oct. 24, 2014, 5:57 p.m., Joshua Cohen wrote: > > Does it make sense to use the ReviewBoard Python client from rbtools? > > https://www.reviewboard.org/docs/rbtools/0.5/api/overview/ > > > > What is the plan to actually run this script? Is it safe to assume th

Re: Review Request 27145: Add a script that publishes build results to review board.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58396 --- Ship it! Ship It! - Joshua Cohen On Oct. 24, 2014, 9:42 p.m

Re: Review Request 27188: Use ship-it instead of +/-1.

/ ~ - Joshua Cohen On Oct. 25, 2014, 3:17 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 27188: Use ship-it instead of +/-1.

> On Oct. 25, 2014, 4:39 a.m., Joshua Cohen wrote: > > _~ > >_~)_)_~ > > )_))_))_) > > _!__!__!_ > > __t/ > > ~ Wow did that ever not format properly! https://github.com/reviewboard/rb-extension-pack/blob/master/shipit_as

Re: Review Request 27309: Make executor overhead configurable via CLI.

tps://reviews.apache.org/r/27309/#comment100059> Is there a jira w/ more context? If not can there be? It's not clear to me from looking at this why this should be removed and what it should be replaced with. - Joshua Cohen On Oct. 28, 2014, 8:57 p.m., Zameer

Re: Review Request 27309: Make executor overhead configurable via CLI.

> On Oct. 28, 2014, 10:14 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36 > > <https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36> > > > > Is there a jira w/ more context? If not can th

Re: Review Request 27309: Make executor overhead configurable via CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/#review59044 --- Ship it! Ship It! - Joshua Cohen On Oct. 29, 2014, 7:54 p.m

Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27363/#review59085 --- Ship it! Ship It! - Joshua Cohen On Oct. 30, 2014, 12:14 a.m

Re: Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27365/#review59092 --- Ship it! Ship It! - Joshua Cohen On Oct. 30, 2014, 12:44 a.m

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

? The relative imports I'm fine with, but adding the BadZipFile error handling feels off to me. Not necessarily a -1 on this, but I'm curious if there's an alternative. - Joshua Cohen On Oct. 30, 2014, 12:39 a.m., Kevi

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

> On Oct. 30, 2014, 12:56 a.m., Joshua Cohen wrote: > > It feels a bit strange to change actual code for the sake of an IDE? The > > relative imports I'm fine with, but adding the BadZipFile error handling > > feels off to me. Not necessarily a -1 on this, but I&#x

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

It's pip installable for linux, right? Can we do skipif platform != linux? - Joshua Cohen On Oct. 30, 2014, 1:06 a.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 27375: Remove dependency on application-http.

llback with a real Lifecycle that's given a mock Command, just set it up with a mock Lifecycle and assert that shutdown is called? The former relies on knowledge of what Lifecycle does on shutdown which seems out of scope for this test. - Joshua Cohen On Oct. 30, 2014, 6:02 a.m., Bill F

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

/AsyncModuleTest.java <https://reviews.apache.org/r/27371/#comment100502> Each test is invoking this method, then accessing the injector instance var. Nothing else accesses that var though; can you have this return the injector instead? - Joshua Cohen On Oct. 30, 2014, 5:09 a.m., Bill Farner

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

> On Oct. 30, 2014, 4:41 a.m., Joshua Cohen wrote: > > build-support/python/make-pycharm-virtualenv, line 24 > > <https://reviews.apache.org/r/27364/diff/1/?file=742139#file742139line24> > > > > should we write this under build-support/python? or does pych

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

g/r/27492/#comment100892> We should be able to skip argparse now that we're pinned to python2.7 (it was added to the stdlib). - Joshua Cohen On Nov. 3, 2014, 2:49 p.m., Dan Norris wrote: > > --- > This is an automatica

Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files

d -Pq Thanks, Joshua Cohen

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59812 --- Can you add a test case? - Joshua Cohen On Nov. 4, 2014, 7:39

Re: Review Request 27586: Increase robustness when reading PEX-INFO

<https://reviews.apache.org/r/27586/#comment101122> Asserting on call count here is a pretty weak test. We could call print 4 times for any number of reasons, can we not verify that output matches what we'd expect given the mocked data from build info? - Joshua Cohen On Nov. 4, 201

Review Request 27630: Mark inotify disk collector test as flaky.

--- ./pants build src/test/python/apache/thermos/monitoring:test_disk Thanks, Joshua Cohen

Re: Review Request 27630: Mark inotify disk collector test as flaky.

913f87d90944e2c5359ac0b7c2205ddf7db676ba Diff: https://reviews.apache.org/r/27630/diff/ Testing --- ./pants build src/test/python/apache/thermos/monitoring:test_disk Thanks, Joshua Cohen

Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.

e relevant source: https://code.google.com/p/mock/source/browse/mock.py#2180 It looks like the only usage of spec_set by create_autospec is as a truthy value (confusingly it causes the *spec* to be passed as a kwarg value called `spec_set`. - Joshua Cohen On Nov. 5, 2014, 5:58 p.m.,

Re: Review Request 27650: Remove duplicate call to log handling code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27650/#review60086 --- Ship it! Ship It! - Joshua Cohen On Nov. 6, 2014, 12:02 a.m

Re: Review Request 27657: Print out the job url after scheduling a cron job.

ob url=... src/test/python/apache/aurora/client/cli/test_cron.py <https://reviews.apache.org/r/27657/#comment101522> Fits on one line. - Joshua Cohen On Nov. 6, 2014, 2:14 a.m., Zameer Manji wrote: > > --- > This is an auto

Re: Review Request 27657: Print out the job url after scheduling a cron job.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27657/#review60211 --- Ship it! Ship It! - Joshua Cohen On Nov. 6, 2014, 6:47 p.m

Re: Review Request 27710: Remove stracktrace redirection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60407 --- Ship it! Ship It! - Joshua Cohen On Nov. 6, 2014, 11:40 p.m

Re: Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

pretty slim, so might not be worth the effort for the rare false positive). - Joshua Cohen On Nov. 8, 2014, 4:24 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 27880: Fix missing paren in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27880/#review60810 --- @ReviewBot retry - Joshua Cohen On Nov. 11, 2014, 6:31 p.m

Re: Review Request 27880: Fix missing paren in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27880/#review60815 --- Ship it! Ship It! - Joshua Cohen On Nov. 11, 2014, 6:31 p.m

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

/PubsubEventModule.java <https://reviews.apache.org/r/27889/#comment102297> requireNonNull - Joshua Cohen On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 27892: Fixes for the make pycharm script:

/diff/ Testing --- $ cat .idea/incubator-aurora.iml Thanks, Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review60894 --- @ReviewBot retry - Joshua Cohen On Nov. 11, 2014, 11:11 p.m

Re: Review Request 27894: Bump commons version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27894/#review60904 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2014, 12:26 a.m

Re: Review Request 27892: Fixes for the make pycharm script:

charm-virtualenv 316ead7c92e0510cd53958f419686e902dc34204 Diff: https://reviews.apache.org/r/27892/diff/ Testing --- $ cat .idea/incubator-aurora.iml Thanks, Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

---------- On Nov. 12, 2014, 7:29 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27892/ > ---

Re: Review Request 27934: Remove non-fixed tickets from CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27934/#review61101 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2014, 10:35 p.m

Review Request 27935: Fix coverage epsilon.

3991462113127 exceeds minimum coverage of 0.83. :check UP-TO-DATE :build UP-TO-DATE BUILD SUCCESSFUL Thanks, Joshua Cohen

Re: Review Request 27942: Don't fail builds on exceeded coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27942/#review61136 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2014, 12:01 a.m

Re: Review Request 27941: Fix review bot to use correct latest diff time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27941/#review61137 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2014, 11:54 p.m

Review Request 27949: Don't fail the build when exceeding coverage thresholds.

--- Don't fail the build when exceeding coverage thresholds. Diffs - buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 649c53de222c54c245f0f4c2a665e9e84f8d0e30 Diff: https://reviews.apache.org/r/27949/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 27996: Upgrade to gradle 2.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27996/#review61272 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2014, 5:05 p.m

Re: Review Request 27954: Fix bad review text in review bot.

> On Nov. 13, 2014, 4:29 a.m., Kevin Sweeney wrote: > > build-support/jenkins/review_feedback.py, line 178 > > > > > > prefer interpolation with % review_text > > > > over string concatenation +1 - Joshua

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review61303 --- @ReviewBot retry - Joshua Cohen On Nov. 4, 2014, 3:35 p.m., Dan

Re: Review Request 28021: Remove dependency on commons-lang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28021/#review61564 --- Ship it! Ship It! - Joshua Cohen On Nov. 14, 2014, 1:07 a.m

Review Request 28140: Drop argparse dependency; it's part of python 2.7

BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f Diff: https://reviews.apache.org/r/28140/diff/ Testing --- ./pants build src/test/python:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh Thanks, Joshua Cohen

Re: Review Request 28170: AURORA-933 - python missing license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28170/#review61950 --- Ship it! Ship It! - Joshua Cohen On Nov. 18, 2014, 3:46 p.m

Review Request 28237: Add default pip timeout to pants bootstrapping.

: aurora Description --- Add default pip timeout to pants bootstrapping. Diffs - pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 Diff: https://reviews.apache.org/r/28237/diff/ Testing --- Thanks, Joshua Cohen

Re: Review Request 28237: Add default pip timeout to pants bootstrapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28237/#review62180 --- @ReviewBot retry - Joshua Cohen On Nov. 19, 2014, 5:36 p.m

Re: Review Request 28250: Fix test_version to use explicit injection points.

test execution potentially flaky) other than not running tests concurrently. I'm not sure which is more cumbersome to live with ;). - Joshua Cohen On Nov. 19, 2014, 8:44 p.m., Kevin Sweeney wrote: > > --- > This is an autom

Re: Review Request 28250: Fix test_version to use explicit injection points.

> On Nov. 19, 2014, 11:08 p.m., Joshua Cohen wrote: > > I'm not sold on the idea of adding explicit injection points for > > dependencies rather than mocking them out. I feel like these are a lot of > > hoops to jump through for the sake of testability leading to

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

build.gradle? - Joshua Cohen On Nov. 20, 2014, 11:05 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

> On Nov. 20, 2014, 11:09 p.m., Joshua Cohen wrote: > > Why do we have to do this in buildSrc/build.gradle and not the root > > build.gradle? > > Zameer Manji wrote: > buildSrc is special and run before the build.gradle: > http://www.gradle

<    1   2   3   4   >