---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52318
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 4, 2014, 3:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25356/#review52361
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 4, 2014, 2:19 p.m
: https://reviews.apache.org/r/25366/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
/aurora/scheduler/DriverFactory.java
9cc04a84a37374ffca418e2ff767992ee23b9f3e
Diff: https://reviews.apache.org/r/25366/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
https://reviews.apache.org/r/25337/#comment91167
I don't think this is supposed to be here.
- Zameer Manji
On Sept. 4, 2014, 5:24 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
---
./gradlew build -Pq
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52929
---
Ship it!
Thanks for doing this so quickly.
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25505/#review52930
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 10, 2014, 12:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25543/#review53048
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 11, 2014, 9:13 a.m
/SchedulerThriftInterface.java
https://reviews.apache.org/r/25481/#comment92464
I'm a little unfamilar with JobUpdateRequest and this RPC but it seems we
should update StartJobUpdateResult to have a message field that we can
surface to the user?
- Zameer Manji
On Sept. 9, 2014, 12:46 p.m., Maxim
/JobUpdateControllerImpl.java
https://reviews.apache.org/r/25529/#comment92483
Shouldn't this just be FAILED?
src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java
https://reviews.apache.org/r/25529/#comment92484
How are these errors going to be surfaced to the user?
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/#review53181
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 12, 2014, 7:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25671/#review53435
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 15, 2014, 4:02 p.m
to give a ship to
this change.
- Zameer Manji
On Sept. 15, 2014, 5:39 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25815/#review53989
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 19, 2014, 11:42 a.m
and rebuild the image to see if that cleans
things up.
Thanks,
Joshua Cohen
--
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25914/#review54206
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 22, 2014, 4:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25918/#review54239
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 22, 2014, 6:53 p.m
79a24855b2a68271b7478395dfdadab8755c3af2
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26004/#review54457
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 24, 2014, 1:24 p.m
c466da8d48bbc2aa227c2db157cab84665ad6602
src/test/python/apache/aurora/executor/common/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
Thanks,
Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25481/#review54613
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 25, 2014, 3:02 p.m
/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
Thanks,
Zameer Manji
:
https://reviews.apache.org/r/25974/#review54623
---
On Sept. 25, 2014, 2:39 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
to these classes.
- Zameer Manji
On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26123
On Sept. 27, 2014, 4:38 p.m., Zameer Manji wrote:
Once this is commited, please make tickets for adding tests to these
classes.
Bill Farner wrote:
I'm not sure how to best do this without either creating a ton of tickets
that are bound to be forgotten, or a monster ticket
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review54890
---
Pinging Brian and Kevin to this review.
- Zameer Manji
On Sept
/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26137/#review54894
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 29, 2014, 8:05 a.m
/aurora/executor/common/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review54916
---
On Sept. 29, 2014, 5:54 p.m., Zameer Manji wrote
/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing (updated)
---
./pants src/test/python/apache/aurora/executor:executor-small
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/#review55217
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 2, 2014, 9:07 a.m
---
On Sept. 30, 2014, 5:17 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/
---
(Updated Sept. 30
---
On Sept. 30, 2014, 5:17 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974
/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
/test_announcer.py
4f6e200ecb1a4ea7cb45acd466a57f19d5815326
Diff: https://reviews.apache.org/r/25974/diff/
Testing
---
./pants src/test/python/apache/aurora/executor:executor-small
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
/26324/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
://reviews.apache.org/r/26328/#comment95746
I think we should put an ISO formatted date like
`datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d %H:%M:%S')`.
- Zameer Manji
On Oct. 3, 2014, 1:47 p.m., Mark Chu-Carroll wrote
On Oct. 3, 2014, 1:56 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 434
https://reviews.apache.org/r/26328/diff/1/?file=713687#file713687line434
I think we should put an ISO formatted date like
`datetime.datetime.fromtimestamp(time.time
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review55402
---
Pinging Kevin for final ship it and commit.
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26363/#review55520
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 6, 2014, 7:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55521
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 6, 2014, 9:55 a.m
/build.sh 1a664e266213cff43e956606407f02737db6f051
Diff: https://reviews.apache.org/r/26324/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review3
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 6, 2014, 11:55 a.m
interpreter enforcement.
- Zameer Manji
On Oct. 6, 2014, 12:47 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378
9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2
Diff: https://reviews.apache.org/r/26391/diff/
Testing
---
./gradlew clean build -Pq
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26417/#review55664
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 7, 2014, 10:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26422/#review55700
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 7, 2014, 12:28 p.m
/test_thrift.py
fd28313df2cfd5a9c7d00f6d329518b4caabacb2
Diff: https://reviews.apache.org/r/26430/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26324/#review55750
---
Ping Kevin.
- Zameer Manji
On Oct. 6, 2014, 12:02 p.m., Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26448/#review55838
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 10:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/#review55840
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 8:58 a.m
/test_thrift.py
fd28313df2cfd5a9c7d00f6d329518b4caabacb2
Diff: https://reviews.apache.org/r/26430/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
/config/test_thrift.py
fd28313df2cfd5a9c7d00f6d329518b4caabacb2
Diff: https://reviews.apache.org/r/26430/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
/diff/
Testing
---
./gradlew clean build
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26469/#review55916
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 5:15 p.m
https://reviews.apache.org/r/26383/#comment96297
Why add a default here?
- Zameer Manji
On Oct. 8, 2014, 5:46 p.m., David Pan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On Oct. 8, 2014, 6:09 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 41
https://reviews.apache.org/r/26383/diff/2/?file=716291#file716291line41
Why add a default value here?
David Pan wrote:
The reason why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26478/#review55943
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 7:39 p.m
/
---
(Updated Oct. 8, 2014, 6:56 p.m.)
Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
Repository: aurora
Description
---
The health check disabler allows health checks for a job to be snoozed
temporarily
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26504/#review56012
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 9, 2014, 9:50 a.m
. If the file is there, don't perform health checks. When you want
to re-enable health checks, delete the file. Happy to hear what others
think about that.
Zameer Manji wrote:
Doesn't this mean user error can disable health checks forever? I think
we should treat disabling health checking
the reports directory. Do you see that
one as well?
- Bill
On October 9th, 2014, 12:15 a.m. UTC, Joshua Cohen wrote:
Review request for Aurora, Bill Farner and Zameer Manji.
By Joshua Cohen.
*Updated Oct. 9, 2014, 12:15 a.m.*
*Repository: * aurora
Description
Kill code to serve ApiBeta help
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review56417
---
Pinging Mark and Wickman to this review.
- Zameer Manji
On Oct
---
Thanks,
Zameer Manji
/thrift/SchedulerThriftInterfaceTest.java
0d51f7dc367081f72090736e36605bf363f3395e
Diff: https://reviews.apache.org/r/26716/diff/
Testing (updated)
---
./gradlew clean test
Thanks,
Zameer Manji
https://reviews.apache.org/r/26688/#comment97118
Is this a python standard for log levels? Could the help show all possible
values?
- Zameer Manji
On Oct. 15, 2014, 9:46 a.m., Mark Chu-Carroll wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/#review56750
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 15, 2014, 10:57 a.m
src/test/python/apache/aurora/config/test_thrift.py
fd28313df2cfd5a9c7d00f6d329518b4caabacb2
Diff: https://reviews.apache.org/r/26430/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
.
- Zameer Manji
On Oct. 16, 2014, 10:51 a.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/
---
(Updated Oct. 16
/
Testing
---
./gradlew clean build
Thanks,
Zameer Manji
901c3378ed59c44b7e2dea239f186193f1f66355
src/test/python/apache/aurora/config/test_thrift.py
fd28313df2cfd5a9c7d00f6d329518b4caabacb2
Diff: https://reviews.apache.org/r/26430/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
/diff/
Testing
---
./gradlew clean build
Thanks,
Zameer Manji
---
./gradlew clean build
Thanks,
Zameer Manji
/
Testing
---
./gradlew clean build
Thanks,
Zameer Manji
On Oct. 16, 2014, 1:11 p.m., Kevin Sweeney wrote:
Is this still needed? I thought the checkstyle check was updated
I was under this impression as well.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57019
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 16, 2014, 3:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26852/#review57098
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 16, 2014, 6:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26881/#review57399
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 17, 2014, 10:58 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57614
---
Ship it!
Thanks for also using the term instance.
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26995/#review57655
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 21, 2014, 1:54 p.m
,
Zameer Manji
we need to do this?
- Zameer Manji
On Oct. 22, 2014, 10:31 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27009
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27047/#review57841
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 22, 2014, 10:57 a.m
as well.
- Zameer Manji
On Oct. 22, 2014, 11:05 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27009
, 2014, 4:36 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/
---
(Updated Sept. 4, 2014, 4:36 p.m
/#review57825
---
On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044
. To reply, visit:
https://reviews.apache.org/r/27044/#review57917
---
On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57819
---
On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote
/diff/
Testing
---
./gradlew clean build
Thanks,
Zameer Manji
---
On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044
---
On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044
/diff/
Testing
---
./gradlew clean build
Thanks,
Zameer Manji
/SchedulingFilterImplTest.java
6a9c4ee278ed3ee8222404504e571f20991c2ae2
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
c48cbae4864127e7799917182439f7670285b0d3
Diff: https://reviews.apache.org/r/27100/diff/
Testing
---
./gradlew clean build -Pq
Thanks,
Zameer Manji
6a9c4ee278ed3ee8222404504e571f20991c2ae2
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
c48cbae4864127e7799917182439f7670285b0d3
Diff: https://reviews.apache.org/r/27100/diff/
Testing
---
./gradlew clean build -Pq
Thanks,
Zameer Manji
/SchedulingFilter.java
https://reviews.apache.org/r/27100/#comment99292
I don't understand what you mean by matches what we do for dedicated host
mismatches as well.
- Zameer Manji
On Oct. 23, 2014, 6:50 p.m., Zameer Manji wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58376
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 24, 2014, 1:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27084/#review58377
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 23, 2014, 9:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58374
---
On Oct. 24, 2014, 12:59 p.m., Zameer Manji wrote:
---
This is an automatically
1 - 100 of 356 matches
Mail list logo