Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 --- Ship it! lgtm! src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java https://reviews.apache.org/r/31820/#comment123255 Maybe move this to the ticket and kill the commented out code here? src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java https://reviews.apache.org/r/31820/#comment123256 nit: probably preferable to move ImmutableSortedSet.of down to the next line. src/main/python/apache/aurora/common/clusters.py https://reviews.apache.org/r/31820/#comment123258 Is this change related? src/test/python/apache/aurora/common/test_clusters.py https://reviews.apache.org/r/31820/#comment123260 Same here, seems unrelated? Does this just need to be rebased? - Joshua Cohen On March 10, 2015, 1:18 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 1:18 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/python/apache/aurora/common/test_clusters.py 1bd696e9cd28d87d0cac68b33ab043407d796b61 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 12:45 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Josh's feedback. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs (updated) - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
On March 10, 2015, 11:48 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, lines 59-62 https://reviews.apache.org/r/31820/diff/3/?file=889978#file889978line59 Maybe move this to the ticket and kill the commented out code here? Done. On March 10, 2015, 11:48 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java, lines 38-39 https://reviews.apache.org/r/31820/diff/3/?file=889979#file889979line38 nit: probably preferable to move ImmutableSortedSet.of down to the next line. Fixed. On March 10, 2015, 11:48 a.m., Joshua Cohen wrote: src/main/python/apache/aurora/common/clusters.py, line 92 https://reviews.apache.org/r/31820/diff/3/?file=889983#file889983line92 Is this change related? Not sure what happened, rebased. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 --- On March 10, 2015, 12:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 12:45 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75959 --- Ship it! Master (48dc4c7) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 10, 2015, 7:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 7:45 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75954 --- Ship it! Ship It! - Bill Farner On March 10, 2015, 7:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 7:45 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75723 --- Should we add tests for the full scheduler API as well as the admin interface? Also, worth adding a unit test for the interceptor? src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java https://reviews.apache.org/r/31820/#comment122948 Seems like most of our guice modules have javadoc. Mind adding one here? Or has our style changed in this regard w/ the switch to Google's checkstyle rules? src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java https://reviews.apache.org/r/31820/#comment122950 @CanRead @Exists src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java https://reviews.apache.org/r/31820/#comment122956 javadoc. src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java https://reviews.apache.org/r/31820/#comment122962 What does the last part of these entries represent? The role? Might be worth commenting? - Joshua Cohen On March 7, 2015, 12:54 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 7, 2015, 12:54 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/app/local/shiro.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
On March 9, 2015, 6:36 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 50 https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line50 Would it be possible to create a Ini parser for Args instead of just holding the path? +1, this would make for more natural error output in some trivial misconfiguration cases. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75736 --- On March 7, 2015, 12:54 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 7, 2015, 12:54 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/app/local/shiro.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 9, 2015, 5:37 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Address review feedback. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs (updated) - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/python/apache/aurora/common/test_clusters.py 1bd696e9cd28d87d0cac68b33ab043407d796b61 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75827 --- Master (e55113d) is red with this patch. ./build-support/jenkins/build.sh :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJava Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-guice/1.2.3/shiro-guice-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-root/1.2.3/shiro-root-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-web/1.2.3/shiro-web-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-core/1.2.3/shiro-core-1.2.3.pom Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-guice/1.2.3/shiro-guice-1.2.3.jar Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-web/1.2.3/shiro-web-1.2.3.jar Download https://repo1.maven.org/maven2/org/apache/shiro/shiro-core/1.2.3/shiro-core-1.2.3.jar Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :compileJmhJava :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java:1: Line does not match expected header line of '^\/\*\*$'. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java:1: Line does not match expected header line of '^\/\*\*$'. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java:23: Line is longer than 100 characters (found 101). [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java:63:37: 'subjectProvider' hides a field. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleMain'. Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 48.698 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 10, 2015, 12:37 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 12:37 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
On March 9, 2015, 11:36 a.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 50 https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line50 Would it be possible to create a Ini parser for Args instead of just holding the path? Bill Farner wrote: +1, this would make for more natural error output in some trivial misconfiguration cases. Done. On March 9, 2015, 11:36 a.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java, line 63 https://reviews.apache.org/r/31820/diff/1/?file=888082#file888082line63 Can you increment a stat here? It seems these failures would be of interest to an operator. Added. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75736 --- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 6, 2015, 4:54 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/app/local/shiro.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
On March 9, 2015, 1:47 p.m., Bill Farner wrote: build.gradle, line 260 https://reviews.apache.org/r/31820/diff/1/?file=888077#file888077line260 Holy cow, they're on guava 9!? Hopefully this doesn't burn us, but a quick grep through their code suggests they only have minimal use of guava. Perhaps include a TODO to commit a patch bumping their version? Added common. On March 9, 2015, 1:47 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 49 https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line49 s/info/configuration/ Fixed. On March 9, 2015, 1:47 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 107 https://reviews.apache.org/r/31820/diff/1/?file=888084#file888084line107 Please rephrase and possibly add context. As written, this sounds like it could be a TODO. Added. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75638 --- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 6, 2015, 4:54 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/app/local/shiro.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: Should we add tests for the full scheduler API as well as the admin interface? Also, worth adding a unit test for the interceptor? Added ShiroThriftInterceptorTest. Not sure what you mean by test the full scheduler API - I check methods on ReadOnlyScheduler, AuroraSchedulerManager, and AuroraAdmin in the integration test. On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 41 https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line41 Seems like most of our guice modules have javadoc. Mind adding one here? Or has our style changed in this regard w/ the switch to Google's checkstyle rules? Added. On March 9, 2015, 11:27 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 50 https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line50 @CanRead @Exists Implemented in an ArgParser. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75723 --- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 6, 2015, 4:54 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/resources/org/apache/aurora/scheduler/app/local/shiro.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 9, 2015, 6:18 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Fix checkstyle. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs (updated) - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/python/apache/aurora/common/test_clusters.py 1bd696e9cd28d87d0cac68b33ab043407d796b61 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75839 --- Ship it! Master (1b1931c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 10, 2015, 1:18 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ --- (Updated March 10, 2015, 1:18 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description --- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/python/apache/aurora/common/test_clusters.py 1bd696e9cd28d87d0cac68b33ab043407d796b61 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney
