[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 5: Verified-1 Build

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 21: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading

2018-06-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading .. Patch Set 4: seems like this may have broken

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build failed:

[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. IMPALA-7106: Print rewritten SQL correctly when

[Impala-ASF-CR] IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans

2018-06-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10704 Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans .. IMPALA-6625: Skip computing parquet

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: Actually after chatting with Hao Hao over this and

[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading

2018-06-12 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10631 to look at the new patch set (#5). Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-12 Thread Todd Lipcon (Code Review)
Hello Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10629 to look at the new patch set (#5). Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-12 Thread Todd Lipcon (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10630 to look at the new patch set (#5). Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-12 Thread Todd Lipcon (Code Review)
Hello Mostafa Mokhtar, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10627 to look at the new patch set (#5). Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. IMPALA-6929: Support multi-column range

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 21: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. IMPALA-7157: Avoid

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Verified+1

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: I filed https://issues.apache.org/jira/browse/KUDU-2473 --

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 4: (12 comments)

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: Thomas and I chatted offline and it seems these errors

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10703 Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. IMPALA-7165: [DOCS] Correct example for dynamic

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 7: Code-Review+1 (1 comment) Approach looks

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 20: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. IMPALA-2746: part 1: enable LSAN for many backend tests This

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 20: Dan, it's probably worth looking at PS19->20. It's

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#20) to the change originally created by Bikramjeet Vig. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. IMPALA-5216:

[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 19: So it turns out the test was already broken - the

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: When you say playing around, you on a private branch?

[native-toolchain-CR] WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 4: I need to re-run tests but I don't

[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. IMPALA-6394: Disable

[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. IMPALA-7145: fix leak of OpenSSL context

[native-toolchain-CR] WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 ) Change subject: WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-12 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 3: Code-Review+1 (6 comments) updated. carry +1

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: > I think we can run the script in a standalone

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Change variables to make the code easier to read Change-Id:

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: I think we can run the script in a standalone

[Impala-ASF-CR](2.x) IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10692 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 1: Code-Review+2 I looked at the diff between

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Bharath, do we have an easy way to test this? -- To

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 14: Code-Review+2 Seems like we're loosening things

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. IMPALA-7158: Fix HdfsScanNodeBase::progress_'s

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7102: Disable support of erasure coding by default

2018-06-12 Thread Anonymous Coward (Code Review)
Anonymous Coward #389 has posted comments on this change. ( http://gerrit.cloudera.org:8080/10646 ) Change subject: IMPALA-7102: Disable support of erasure coding by default .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 19: Another clang-tidy error in promise-test and a

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6929: Support multi-column range partitions for Kudu

2018-06-12 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10441 ) Change subject: IMPALA-6929: Support multi-column range partitions for Kudu .. Patch Set 2: This change is small and low risk, so I

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. IMPALA-7144: Re-enable TestDescribeTableResults

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10541 ) Change subject: IMPALA-2751: Matching quotes are not required in comments .. Patch Set 6: We could go ahead with this one I think, if

[Impala-ASF-CR] IMPALA-2751: Matching quotes are not required in comments

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-2751: Matching quotes are not required in comments .. Removed Code-Review-2 by Tim Armstrong -- To view, visit http://gerrit.cloudera.org:8080/10541 To

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Optimize dependencies for Codegen

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 ) Change subject: Optimize dependencies for Codegen .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare()

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10680 ) Change subject: IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() .. IMPALA-3816, IMPALA-4065: Remove the

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 8: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Tim Armstrong (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10666 to look at the new patch set (#8). Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling

[Impala-ASF-CR] IMPALA-7145: fix leak of OpenSSL context when spilling

2018-06-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 ) Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc To inline

[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: Build started:

[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad

2018-06-12 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 4: The failure is IMPALA-7156 -- To view,

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 4: Code-Review+2 Rebase. Carry +2. --

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10699 Change subject: Change variables to make the code easier to read .. Change variables to make the code easier to read Change-Id:

[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10671 ) Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors .. IMPALA-6835: Add table name and node id to Kudu

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7158: Fix HdfsScanNodeBase::progress 's init

2018-06-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10672 ) Change subject: IMPALA-7158: Fix HdfsScanNodeBase::progress_'s init .. Patch Set 3: Build started:

  1   2   >