[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. IMPALA-7881: Visualize AST for easier debugging

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Code-Review+1 (2 comments) I had a look because I was

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 5: Verified+1 --

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Pretty cool, thanks for doing this. -- To

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. IMPALA-7852: Fix some flakiness in

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 1: Code-Review+2 I'm inclined to go ahead and merge this

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11980 Change subject: IMPALA-7881: Visualize AST for easier debugging .. IMPALA-7881: Visualize AST for easier debugging Provides a debug-time

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7851: fix underflow in ReserveSpace()

2018-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11976 ) Change subject: IMPALA-7851: fix underflow in ReserveSpace() .. IMPALA-7851: fix underflow in ReserveSpace() The (num_rows -

[Impala-ASF-CR] IMPALA-7851: fix underflow in ReserveSpace()

2018-11-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11976 ) Change subject: IMPALA-7851: fix underflow in ReserveSpace() .. Patch Set 4: Verified+1 Carry +2 since it was just a commit message

[Impala-ASF-CR] IMPALA-7851: fix underflow in ReserveSpace()

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11976 ) Change subject: IMPALA-7851: fix underflow in ReserveSpace() .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-21 Thread Thomas Marshall (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11977 to look at the new patch set (#2). Change subject: IMPALA-6924: Add child queries to profile in compute stats

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11977 Change subject: IMPALA-6924: Add child queries to profile in compute stats .. IMPALA-6924: Add child queries to profile in compute

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-7851: fix underflow in ReserveSpace()

2018-11-21 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11976 to look at the new patch set (#4). Change subject: IMPALA-7851: fix underflow in ReserveSpace()

[Impala-ASF-CR] IMPALA-7851: fix underflow in ReserveSpace()

2018-11-21 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11976 to look at the new patch set (#3). Change subject: IMPALA-7851: fix underflow in ReserveSpace()

[Impala-ASF-CR] IMPALA-7851: fix overflow in ReserveSpace()

2018-11-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11976 ) Change subject: IMPALA-7851: fix overflow in ReserveSpace() .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 4: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7852: Fix some flakiness in test hash join timer.py

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11964 ) Change subject: IMPALA-7852: Fix some flakiness in test_hash_join_timer.py .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 4: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7851: fix overflow in ReserveSpace()

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11976 ) Change subject: IMPALA-7851: fix overflow in ReserveSpace() .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-21 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-21 Thread Alex Rodoni (Code Review)
Hello Attila Jeges, Zoltan Ivanfi, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11946 to look at the new patch set (#4). Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 4: Build Started

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 5: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-21 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 4: (2 comments) Zoltan, Please make the url of the changelog to

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-21 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11922 to look at the new patch set (#5). Change subject: IMPALA-7815: [DOCS] Release notes for 3.1

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 5: Build Started

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 3: Looks like this slipped

[Impala-ASF-CR] IMPALA-7851: fix overflow in ReserveSpace()

2018-11-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11976 ) Change subject: IMPALA-7851: fix overflow in ReserveSpace() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7851: fix overflow in ReserveSpace()

2018-11-21 Thread Tim Armstrong (Code Review)
Hello Thomas Marshall, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11976 to look at the new patch set (#2). Change subject: IMPALA-7851: fix overflow in ReserveSpace() ..

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 8: Code-Review+1 (1 comment) Carry Csaba's +1.

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 7: Code-Review+1 (1 comment) lgtm, but I am

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7869: break up parquet-column-readers.cc

2018-11-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11949 ) Change subject: IMPALA-7869: break up parquet-column-readers.cc .. Patch Set 8: Code-Review+1 (1 comment) lgtm Do you plan to fix

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11959 ) Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-21 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 1: (1 comment)