[Impala-ASF-CR](2.x) IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12807 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 ) Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12829 ) Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. IMPALA-8202: Add more logging to

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Remove setting of

[Impala-ASF-CR](2.x) IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2019-03-21 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12807 to look at the new patch set (#3). Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 18: Code-Review+2 Apparently Iterables.getOnlyElement()

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 4: Verified+1 -- To

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. IMPALA-8328: Add missing

[Impala-ASF-CR] Add extra TRACE calls for cancellation code path

2019-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12832 ) Change subject: Add extra TRACE calls for cancellation code path .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 ) Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. IMPALA-8330: Impala shell config file should use flag

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 3: Build Successful

[Impala-ASF-CR] Add extra TRACE calls for cancellation code path

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12832 ) Change subject: Add extra TRACE calls for cancellation code path .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 ) Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 ) Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 ) Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 3: (3 comments)

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: Code-Review+2 Thanks for fixing

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: Build started:

[Impala-ASF-CR] Add extra TRACE calls for cancellation code path

2019-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12832 ) Change subject: Add extra TRACE calls for cancellation code path .. Patch Set 1: > Patch Set 1: > > Thanks for working on this. Taking

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 ) Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

2019-03-21 Thread Anonymous Coward (Code Review)
fan...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12831 Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

[Impala-ASF-CR] Add extra TRACE calls for cancellation code path

2019-03-21 Thread Todd Lipcon (Code Review)
Hello Joe McDonnell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12832 to review the following change. Change subject: Add extra TRACE calls for cancellation code path .. Add extra

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 1: I'm running the private build

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12830 Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. IMPALA-8337: Fix OrderedDict Python

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Thomas Marshall (Code Review)
Hello David Knupp, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12827 to look at the new patch set (#2). Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 ) Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 4: Code-Review+1 Rebased, carry +1 --

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12829 Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. IMPALA-8202: Add more logging to

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 5: (1 comment)

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk usage to profile .. Patch Set 2: Build Successful

[Impala-ASF-CR] Add CREATE KUDU section for table 'nullrows'

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12826 ) Change subject: Add CREATE_KUDU section for table 'nullrows' .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk usage to profile .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Add CREATE KUDU section for table 'nullrows'

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/12826 ) Change subject: Add CREATE_KUDU section for table 'nullrows' .. Abandoned A better solution: https://gerrit.cloudera.org/#/c/12827/ -- To

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-03-21 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12822 Change subject: IMPALA-7981: Add host disk usage to profile .. IMPALA-7981: Add host disk usage to profile This change adds host disk

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12827 Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Remove setting of 'kudu.master_addresses' from

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 17: Build Successful

[Impala-ASF-CR] Add CREATE KUDU section for table 'nullrows'

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12826 Change subject: Add CREATE_KUDU section for table 'nullrows' .. Add CREATE_KUDU section for table 'nullrows' A recent patch

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12819 ) Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 17: Code-Review+2 Rebased. Carry Todd's +2. -- To

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate

2019-03-21 Thread Anonymous Coward (Code Review)
fangyu@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12819 Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate .. IMPALA-4865: Reject Expr Rewrite When Appropriate

[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate

2019-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12819 ) Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate

2019-03-21 Thread Anonymous Coward (Code Review)
fangyu@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/12819 ) Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate .. Abandoned Duplicate -- To view, visit

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 5: This touches some of the same code as the big DATE

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 4: Build Successful

[native-toolchain-CR] Add documentation for docker-based toolchain builds

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 ) Change subject: Add documentation for docker-based toolchain builds .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 13: > I don't think we should bundle a wholesale

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 13: I don't think we should bundle a wholesale reformatting

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. IMPALA-8328: Add missing ToSql test cases for

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 13: > Uploaded patch set 13. This patch-set contains the

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Hector Acosta (Code Review)
Hello Laszlo Gaal, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12727 to look at the new patch set (#4). Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 12: Build Successful

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 20: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: Also, some additional

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. IMPALA-7368: Add initial support for DATE type DATE values describe a

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-03-21 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 12: (32 comments)

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: Code-Review+2 lgtm. Did you

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12824 ) Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Patch Set 1: I was working with the

[Impala-ASF-CR] Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8

2019-03-21 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12824 Change subject: Bump toolchain version to 8430101a-b65f-4e4d-921e-767771649ae4-713afc77a8 .. Bump toolchain version to

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12823 Change subject: IMPALA-8330: Impala shell config file should use flag names .. IMPALA-8330: Impala shell config file should use flag

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: Code-Review+1 Carry +1 --

[Impala-ASF-CR](2.x) IMPALA-6031: Fix executor node count in distributed plans

2019-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12801 ) Change subject: IMPALA-6031: Fix executor node count in distributed plans .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py

2019-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 ) Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) Fix zsh issue in set-pythonpath.sh

2019-03-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12806 ) Change subject: Fix zsh issue in set-pythonpath.sh .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 19: Code-Review+2 Trivial rebase fix due to CR that recently

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 20: Build started:

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 20: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 3: Build Successful

[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. IMPALA-8328: Add missing ToSql test cases for

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Austin Nobis (Code Review)
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 2: (1 comment)

  1   2   >