[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#2). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. ..

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-09 Thread Bharath Krishna (Code Review)
Bharath Krishna has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch Set

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. ..

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-09 Thread Bharath Krishna (Code Review)
Bharath Krishna has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. IMPALA-8338

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: The latest kudu client is required, otherwise the

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12977 Change subject: IMPALA-5351: Support storing column comment of kudu table .. IMPALA-5351: Support storing column comment of kudu table This

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. IMPALA-8227: Add support for WITH GRANT

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 6: (18 comments)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#2). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12975 ) Change subject: IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE .. Patch Set 1: Verified+1

[Impala-ASF-CR] IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12975 ) Change subject: IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-8401: SIGQUIT initiates the graceful shutdown process

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGQUIT initiates the graceful shutdown process .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE

2019-04-09 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12975 Change subject: IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE .. IMPALA-8391: [DOCS] ALTER TABLE RENAME

[Impala-ASF-CR] IMPALA-8401: SIGQUIT initiates the graceful shutdown process

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGQUIT initiates the graceful shutdown process .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 8: Build Successful

[Impala-ASF-CR] WIP: Refactor file descriptor loading code

2019-04-09 Thread Anonymous Coward (Code Review)
Anonymous Coward (486) has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: WIP: Refactor file descriptor loading code .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8401: SIGQUIT initiates the graceful shutdown process

2019-04-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12973 Change subject: IMPALA-8401: SIGQUIT initiates the graceful shutdown process .. IMPALA-8401: SIGQUIT initiates the graceful shutdown

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 6: (3 comments) Michael is the obvious person to +2

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-09 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12797 to look at the new patch set (#8). Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query

2019-04-09 Thread Alice Fan (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12926 to look at the new patch set (#5). Change subject: IMPALA-7031: Cancel action of debug page should not unregister query

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 9: (21 comments)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 6: Code-Review+2 (2 comments) LGTM

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. Patch Set 1: That would work for me -- To view, visit

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 4: (5 comments) I'm re-running the

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12282 to look at the new patch set (#6). Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12282 to look at the new patch set (#5). Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 6: (15 comments) Thanks for making

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 6: (1 comment) Rebased the change and made the overall

[Impala-ASF-CR] IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12962 ) Change subject: IMPALA-8227: Add support for WITH GRANT OPTION with Ranger .. IMPALA-8227: Add support for WITH GRANT OPTION with Ranger

[Impala-ASF-CR] IMPALA-8363: fix e2e start with impala log dir

2019-04-09 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 ) Change subject: IMPALA-8363: fix e2e start with impala_log_dir .. Patch Set 1: > Patch Set 1: > > (1 comment) I think the kwargs

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 7: Build Successful

[Impala-ASF-CR] [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME of databases in event processor to avoid incorrect/redundant invalidates

2019-04-09 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME of databases in event processor to avoid incorrect/redundant invalidates ..

[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query

2019-04-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 4: (10 comments)

[Impala-ASF-CR] [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12962 ) Change subject: [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This patch moves the

[Impala-ASF-CR] [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12962 Change subject: [IMPALA-8227] Add support for WITH GRANT OPTION with Ranger .. [IMPALA-8227] Add support for WITH GRANT OPTION with

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 6: Build

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for the

[Impala-ASF-CR] This change bumps the CDH BUILD VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed for t

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12965 ) Change subject: This change bumps the CDH_BUILD_VERSION to a version that includes the change to have full-thrift object for DropDatabaseMessage in Metastore notifications. This change is needed

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 6: Code-Review+2 (2 comments) lgtm.

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. IMPALA-8385: Refactor Sentry admin user check This patch moves the

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 6: (7 comments) The

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. IMPALA-8363: Deny access when

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-04-09 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12282 to look at the new patch set (#4). Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12968 Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. IMPALA-8322: Add periodic dirty check of

[Impala-ASF-CR] IMPALA-8385: Refactor Sentry admin user check

2019-04-09 Thread Austin Nobis (Code Review)
Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 ) Change subject: IMPALA-8385: Refactor Sentry admin user check .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. IMPALA-8371: Return appropriate error

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-04-09 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 3: (4 comments) Will fix the names, please see my

[Impala-ASF-CR] Add impala group.json to .gitignore

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12964 ) Change subject: Add impala_group.json to .gitignore .. Add impala_group.json to .gitignore This patch adds

[Impala-ASF-CR] Add impala group.json to .gitignore

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12964 ) Change subject: Add impala_group.json to .gitignore .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. IMPALA-8395: Parse older formats of

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12961 ) Change subject: IMPALA-8336: fix flaky ORC memory limit test .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8336: fix flaky ORC memory limit test

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12961 ) Change subject: IMPALA-8336: fix flaky ORC memory limit test .. IMPALA-8336: fix flaky ORC memory limit test Reduces

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 18: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. IMPALA-5051: Add INT64 timestamp write support

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME of databases in event processor to avoid incorrect/redundant invalidates

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME of databases in event processor to avoid incorrect/redundant invalidates ..

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME of databases in event processor to avoid incorrect/redundant invalidates

2019-04-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME of databases in event processor to avoid incorrect/redundant invalidates ..

  1   2   >