[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Yongzhi Chen (Code Review)
Hello Vihang Karajgaonkar, Sudhanshu Arora, Zoltan Borok-Nagy, Todd Lipcon, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13215 to look at the new patch set (#10). Change subject: IMPALA-8438: Store WriteId and

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 8: (13 comments) Will submit

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Yongzhi Chen (Code Review)
Hello Vihang Karajgaonkar, Sudhanshu Arora, Zoltan Borok-Nagy, Todd Lipcon, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13215 to look at the new patch set (#9). Change subject: IMPALA-8438: Store WriteId and

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 7: Verified+1 --

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 10: Verified-1

[Impala-ASF-CR] IMPALA-8497: dealing with query ends with '\n'

2019-05-13 Thread wangsheng (Code Review)
Hello Quanlong Huang, Austin Nobis, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13293 to look at the new patch set (#5). Change subject: IMPALA-8497: dealing with query ends with '\n'

[Impala-ASF-CR] IMPALA-8515: port shell tests to use shell build

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13267 ) Change subject: IMPALA-8515: port shell tests to use shell build .. IMPALA-8515: port shell tests to use shell build

[Impala-ASF-CR] IMPALA-8515: port shell tests to use shell build

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13267 ) Change subject: IMPALA-8515: port shell tests to use shell build .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8537: Negative values reported for tmp-file-mgr.scratch-space-bytes-used under heavy spilling load

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13326 ) Change subject: IMPALA-8537: Negative values reported for tmp-file-mgr.scratch-space-bytes-used under heavy spilling load ..

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: Build Successful

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Build Successful

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-8503: add option to start Kudu cluster with HMS integration

2019-05-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 ) Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration .. Patch Set 1: (6 comments) I don't have enough

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 2: Code-Review+2 Rebased and carry Todd's +2. -- To

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Exclude kafka dependency from ranger-plugins-audit This patch

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: Code-Review+2 (1 comment) This

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 4: Build started:

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (3 comments)

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Code-Review+2 (1 comment) Looks good

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 4: Code-Review+2 Thanks, looks good -- To

[Impala-ASF-CR] IMPALA-8537: Negative values reported for tmp-file-mgr.scratch-space-bytes-used under heavy spilling load

2019-05-13 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13326 Change subject: IMPALA-8537: Negative values reported for tmp-file-mgr.scratch-space-bytes-used under heavy spilling load ..

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment) This looks good to

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13252 to look at the new patch set (#4). Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13251 to look at the new patch set (#4). Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13259 to look at the new patch set (#3). Change subject: Improve output for generate-schema-statements.py

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin

2019-05-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13319 ) Change subject: IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8072: addendum: don't require fe rebuild for config

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13288 ) Change subject: IMPALA-8072: addendum: don't require fe rebuild for config .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 7: Code-Review+2 -- To view, visit

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: I don't think that's right. Looking at the CMakeLists.txt file, it has:

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: The cmake tweak symbol should be KWSYSPE_USE_SELECT instead of

[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13295 ) Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL .. IMPALA-8530: Return more

[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 ) Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL .. Patch Set 5: Verified+1 -- To

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Laszlo Gaal, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13286 to look at the new patch set (#2). Change subject: Update cmake to 3.14.3 .. Update cmake to 3.14.3

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: Oh, looks like maybe it's a bug in the CMakeLists.txt. the if() statement uses

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 1: Merged that one, guess we can rebase this one and

[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13276 ) Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3 .. IMPALA-8369 [Test fixes] More test

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. IMPALA-8369 : Fix for tests failing

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. Patch Set 6: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 7: Build Successful

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. IMPALA-8528: Refactor authorization check in

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 8: (13 comments)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 7: (2 comments) > Patch Set 6: > > (2

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8428: Add support for caching file handles on s3

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13221 ) Change subject: IMPALA-8428: Add support for caching file handles on s3 .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 1: Will run a GVO until this is merged:

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8428: Add support for caching file handles on s3

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13221 ) Change subject: IMPALA-8428: Add support for caching file handles on s3 .. IMPALA-8428: Add support for caching file

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 6: (2 comments) Not quite following the

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 7: Build started:

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13322 Change subject: Exclude kafka dependency from ranger-plugins-audit .. Exclude kafka dependency from ranger-plugins-audit This patch

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Laszlo Gaal, Philip Zeyliger, David Knupp, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#4). Change subject: IMPALA-8344: Add support for running the minicluster

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Laszlo Gaal, Philip Zeyliger, David Knupp, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#3). Change subject: IMPALA-8344: Add support for running the minicluster

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 3: > We can include information about

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Ethan Xue (Code Review)
Hello Fredy Wijaya, Todd Lipcon, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13313 to look at the new patch set (#3). Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-13 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 9: Code-Review+2 --

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 10:

[Impala-ASF-CR] IMPALA-966: Attribute type error to the right expression in an insert statement

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Attribute type error to the right expression in an insert statement .. Patch Set 10: Build

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Ethan Xue (Code Review)
Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Ethan Xue (Code Review)
Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 2: > One question about the usability of

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Ethan Xue (Code Review)
Hello Fredy Wijaya, Todd Lipcon, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13313 to look at the new patch set (#2). Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config

[Impala-ASF-CR] IMPALA-8515: port shell tests to use shell build

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13267 ) Change subject: IMPALA-8515: port shell tests to use shell build .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8515: port shell tests to use shell build

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13267 ) Change subject: IMPALA-8515: port shell tests to use shell build .. Patch Set 4: Build started:

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8515: port shell tests to use shell build

2019-05-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/13267 ) Change subject: IMPALA-8515: port shell tests to use shell build .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Build started:

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: fe: set classpath using maven dependency resolution .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13185 To

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 5: Verified+1 Test failure was an unrelated apparent

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Ethan Xue (Code Review)
Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Ethan Xue (Code Review)
Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 1: (5 comments)

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: For those watching at home, it looks like this hit a build failure when

[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 ) Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL .. Patch Set 4: Build Successful

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. WIP IMPALA-8536: Add Scalable Pool

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 1: (6 comments) Thanks for

[Impala-ASF-CR] IMPALA-8072: addendum: don't require fe rebuild for config

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13288 ) Change subject: IMPALA-8072: addendum: don't require fe rebuild for config .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8072: addendum: don't require fe rebuild for config

2019-05-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13288 ) Change subject: IMPALA-8072: addendum: don't require fe rebuild for config .. Patch Set 3: Code-Review+2 -- To view, visit

  1   2   >