[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

2019-05-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 17: > Patch Set 17: > > > Patch

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 17: > Patch Set 17: Verified-1

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 17: Verified-1 Build

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8541: Remove existing roles in order to not interfere with a test.

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13349 ) Change subject: IMPALA-8541: Remove existing roles in order to not interfere with a test. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13300 ) Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation .. Patch Set 2: Build Started

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-05-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. IMPALA-7608: Estimate row count from file size

[Impala-ASF-CR] IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13300 ) Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation .. Patch Set 2: Verified+1 Build

[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

2019-05-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check

[Impala-ASF-CR] IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation

2019-05-15 Thread Alex Rodoni (Code Review)
Hello Vihang Karajgaonkar, Bharath Krishna, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13300 to look at the new patch set (#2). Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation

[Impala-ASF-CR] IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation

2019-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13300 ) Change subject: IMPALA-8447: [DOCS] INSERT event is supported in automatic invalidation .. Patch Set 1: (10 comments)

[Impala-ASF-CR] [DOCS] Added back the note about Deflate not supported for text files.

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13350 ) Change subject: [DOCS] Added back the note about Deflate not supported for text files. .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Fix condition for starting YARN on

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-8541: Remove existing roles in order to not interfere with a test.

2019-05-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13349 Change subject: IMPALA-8541: Remove existing roles in order to not interfere with a test. .. IMPALA-8541: Remove existing roles in order

[Impala-ASF-CR] [DOCS] Added back the note about Deflate not supported for text files.

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13350 ) Change subject: [DOCS] Added back the note about Deflate not supported for text files. .. Patch Set 1: Build Started

[Impala-ASF-CR] [DOCS] Added back the note about Deflate not supported for text files.

2019-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13350 Change subject: [DOCS] Added back the note about Deflate not supported for text files. .. [DOCS] Added back the note about Deflate not

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13330 ) Change subject: Enable data cache by default for all S3 builds .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8369 : Skip test owner privileges test when running against Hive-3

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13339 ) Change subject: IMPALA-8369 : Skip test_owner_privileges test when running against Hive-3 .. Patch Set 3: Verified-1 Build

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 17: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 17: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 16: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-05-15 Thread Tim Armstrong (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12884 to look at the new patch set (#16). Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 16: submit patch-16, run core

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Yongzhi Chen (Code Review)
Hello Vihang Karajgaonkar, Sudhanshu Arora, Zoltan Borok-Nagy, Todd Lipcon, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13215 to look at the new patch set (#16). Change subject: IMPALA-8438: Store WriteId and

[Impala-ASF-CR] DWX-124: Prometheus metrics support in Impala

2019-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: DWX-124: Prometheus metrics support in Impala .. Patch Set 1: (3 comments) Didn't look at code yet but a couple of

[Impala-ASF-CR] DWX-124: Prometheus metrics support in Impala

2019-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: DWX-124: Prometheus metrics support in Impala .. Patch Set 1: (17 comments) Did a pass over it. Mainly style and

[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13346 ) Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. IMPALA-8424: [DOCS] Support for

[Impala-ASF-CR] WIP try to build thrift with no default operators

2019-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13312 ) Change subject: WIP try to build thrift with no_default_operators .. Patch Set 1: (1 comment) Thanks for having a look. I addressed

[Impala-ASF-CR] IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API

2019-05-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13346 Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API .. IMPALA-8476: Replace Sentry admin check

[Impala-ASF-CR] DWX-124: Prometheus metrics support in Impala

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: DWX-124: Prometheus metrics support in Impala .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin

2019-05-15 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13319 ) Change subject: IMPALA-8503: allow the Hive Metastore to start with kudu-hive plugin .. Patch Set 1: While this is of course fine

[Impala-ASF-CR] DWX-124: Prometheus metrics support in Impala

2019-05-15 Thread Anonymous Coward (Code Review)
hars...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13345 Change subject: DWX-124: Prometheus metrics support in Impala .. DWX-124: Prometheus metrics support in Impala -- This change

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: Build Successful

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 ) Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Patch Set 1: Build started:

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: > Do we have the same bug in run-hive-server.sh?

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13343 to look at the new patch set (#3). Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true

[Impala-ASF-CR] wip

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: wip .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/3239/ : Initial

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 3: Verified+1 --

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 2: Build Successful

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 1: Build Successful

[Impala-ASF-CR] wip

2019-05-15 Thread Sudhanshu Arora (Code Review)
Sudhanshu Arora has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13334 Change subject: wip .. wip To show the approach that I am following. This needs more work based on AcidUtils#getAcidState

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 3: Verified+1 Build

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 2: Verified+1 Build

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 ) Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 3: Build Started

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13310 to look at the new patch set (#3). Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 2: (1 comment) > Patch Set 2: > > >

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 2: > (4 comments) > > Do we have a

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13310 to look at the new patch set (#2). Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 2: Build Started

[Impala-ASF-CR] IMPALA-8424: [DOCS] Support for column-level permissions on views

2019-05-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13310 ) Change subject: IMPALA-8424: [DOCS] Support for column-level permissions on views .. Patch Set 1: (4 comments)

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 2: Do we have the same bug in run-hive-server.sh? if

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13343 to look at the new patch set (#2). Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true ..

[Impala-ASF-CR] IMPALA-8369 : Skip test owner privileges test when running against Hive-3

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13339 ) Change subject: IMPALA-8369 : Skip test_owner_privileges test when running against Hive-3 .. Patch Set 3: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8369 : Skip test owner privileges test when running against Hive-3

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13339 ) Change subject: IMPALA-8369 : Skip test_owner_privileges test when running against Hive-3 .. Patch Set 3: Build started:

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13343 Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Fix condition for starting YARN on USE_CDP_HIVE=true Dataload

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 17: Build started:

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13335 Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Add USE_CDP_HIVE=true case to

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 ) Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Patch Set 1: The job that calls

[Impala-ASF-CR] IMPALA-8545: Test Ldap authentication

2019-05-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13337 ) Change subject: IMPALA-8545: Test Ldap authentication .. Patch Set 2: (7 comments) Thanks for fixing this. I think this fills a

[Impala-ASF-CR] IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration

2019-05-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13318 ) Change subject: IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 1: (15 comments)

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 15: Verified-1 Build

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 3: I do not understand

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. IMPALA-8369 (part 4): Hive 3:

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 7: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8138: Remove FAULT INJECTION RPC DELAY

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13060 ) Change subject: IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8138: Remove FAULT INJECTION RPC DELAY

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13060 ) Change subject: IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY .. IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY This

[Impala-ASF-CR] IMPALA-8121: part 3: invalidate on memory pressure

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13302 ) Change subject: IMPALA-8121: part 3: invalidate on memory pressure .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] WIP: temporal query support for Kudu tables

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13342 ) Change subject: WIP: temporal query support for Kudu tables .. Patch Set 1: Build Successful

[Impala-ASF-CR] WIP: temporal query support for Kudu tables

2019-05-15 Thread Nong Li (Code Review)
Nong Li has posted comments on this change. ( http://gerrit.cloudera.org:8080/13342 ) Change subject: WIP: temporal query support for Kudu tables .. Patch Set 1: This is great! -- To view, visit

[Impala-ASF-CR] WIP: temporal query support for Kudu tables

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13342 ) Change subject: WIP: temporal query support for Kudu tables .. Patch Set 1: (4 comments)

[Impala-ASF-CR] WIP: temporal query support for Kudu tables

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13342 Change subject: WIP: temporal query support for Kudu tables .. WIP: temporal query support for Kudu tables This adds support for 'table

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 15: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 14: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 7: Code-Review+2 -- To