[Impala-ASF-CR] IMPALA-8891 concat ws() null handling is non-standard This patch is for IMPALA-8891,in the original implementation of function concat ws, any null string element in array ar

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14885 ) Change subject:IMPALA-8891 concat_ws() null handling is non-standard This patch is for IMPALA-8891,in the original implementation of function concat_ws, any null string element in

[Impala-ASF-CR] IMPALA-8974: Fixed a bug when create kudu managed table without HMS config

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14398 ) Change subject: IMPALA-8974: Fixed a bug when create kudu managed table without HMS config .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-8974: Fixed a bug when create kudu managed table without HMS config

2019-12-10 Thread wangsheng (Code Review)
Hello Quanlong Huang, Hao Hao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14398 to look at the new patch set (#15). Change subject: IMPALA-8974: Fixed a bug when create kudu managed table without HMS config

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 11: Verified+1

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes .. Patch Set

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 1: There has been some back on forth on whether this is

[Impala-ASF-CR] IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes .. Patch Set 1:

[Impala-ASF-CR] IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes .. Patch Set

[Impala-ASF-CR] IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases'

2019-12-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 ) Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 10: Build

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14744 to look at the new patch set (#10). Change subject: IMPALA-6894: Use an internal representation of query states in

[Impala-ASF-CR] [DOCS] Copy edits in impala conversion functions.xml

2019-12-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14876 ) Change subject: [DOCS] Copy edits in impala_conversion_functions.xml .. [DOCS] Copy edits in impala_conversion_functions.xml

[Impala-ASF-CR] [DOCS] Copy edits in impala conversion functions.xml

2019-12-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14876 ) Change subject: [DOCS] Copy edits in impala_conversion_functions.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. IMPALA-9092: Add support for creating external Kudu

[Impala-ASF-CR] IMPALA-9092: Add support for creating external Kudu table

2019-12-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 ) Change subject: IMPALA-9092: Add support for creating external Kudu table .. Patch Set 6: (14 comments)

[Impala-ASF-CR] [DOCS] Copy edits in impala conversion functions.xml

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14876 ) Change subject: [DOCS] Copy edits in impala_conversion_functions.xml .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 9: Code-Review+2 (1

[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info

2019-12-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14857 ) Change subject: [DOCS] Update impala_proxy.xml with the latest info .. [DOCS] Update impala_proxy.xml with the latest info

[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info

2019-12-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 ) Change subject: [DOCS] Update impala_proxy.xml with the latest info .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Copy edits in impala conversion functions.xml

2019-12-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14876 Change subject: [DOCS] Copy edits in impala_conversion_functions.xml .. [DOCS] Copy edits in impala_conversion_functions.xml Change-Id:

[Impala-ASF-CR] [DOCS] Copy edits in impala conversion functions.xml

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14876 ) Change subject: [DOCS] Copy edits in impala_conversion_functions.xml .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. IMPALA-9209: Fix flakiness in

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 ) Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table .. Patch Set 3: Build Successful

[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info

2019-12-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 ) Change subject: [DOCS] Update impala_proxy.xml with the latest info .. Patch Set 2: Can someone give +2? -- To view, visit

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

2019-12-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14806 ) Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table .. IMPALA-9122 : Ignore FileNotFoundException when

[Impala-ASF-CR] IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server

2019-12-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 ) Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9149: part 1: Re-enabe Ranger-related FE tests

2019-12-10 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/14798 ) Change subject: IMPALA-9149: part 1: Re-enabe Ranger-related FE tests .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14870 to look at the new patch set (#2). Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14852 ) Change subject: IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4 .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

2019-12-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14852 ) Change subject: IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4 .. Patch Set 4: > Uploaded patch set 4. This renames

[Impala-ASF-CR] IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

2019-12-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14852 ) Change subject: IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4 .. IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 1: Code-Review+2 (3 comments) Minor comments,

[Impala-ASF-CR] IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

2019-12-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14852 ) Change subject: IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4 .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14852 ) Change subject: IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4 .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

2019-12-10 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14852 ) Change subject: IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4 .. IMPALA-8706: ISO:SQL:2016 datetime patterns - Milestone 4

[Impala-ASF-CR] IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server

2019-12-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 ) Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server

2019-12-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 ) Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server

2019-12-10 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14867 to look at the new patch set (#5). Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server

[Impala-ASF-CR] IMPALA-9174: Speedup allocations of ORC Scanner

2019-12-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 ) Change subject: IMPALA-9174: Speedup allocations of ORC Scanner .. Patch Set 4: Code-Review+2 (2 comments) I am ok with the