[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

2020-06-24 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 ) Change subject: IMPALA-2658: Extend the NDV function to accept a precision .. Patch Set 39: Code-Review+1 (3 comments) Looks good to

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-24 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. IMPALA-9697: Support priority based scratch

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-24 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 8: (10 comments) Some more style comment.

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-06-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9697: Support priority based scratch directory selection

2020-06-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16091 ) Change subject: IMPALA-9697: Support priority based scratch directory selection .. Patch Set 2: (4 comments) I think this basically

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 11: Verified-1 Build

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-06-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 41: (2 comments)

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-06-24 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-06-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 41: (6 comments) LGTM once the specific issues I mentioned

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9294: Support DATE for min-max runtime filter

2020-06-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 ) Change subject: IMPALA-9294: Support DATE for min-max runtime filter .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-24 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. IMPALA-9829: Add Write Metrics for Spilling Three types of metrics are added

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2020-06-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 1: Yeah, I think we should probably be

[Impala-ASF-CR] IMPALA-9692 (part 3): Model QuerySchedule as a protobuf

2020-06-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15961 ) Change subject: IMPALA-9692 (part 3): Model QuerySchedule as a protobuf .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-24 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 ) Change subject: IMPALA-2658: Extend the NDV function to accept a precision .. Patch Set 39: > Uploaded patch set 39. -- To view, visit

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2020-06-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 6: (1 comment) I fixed most of the TODOs. I

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2020-06-24 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Grant Henke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15966 to look at the new patch set (#8). Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 11: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15997 ) Change subject: IMPALA-2658: Extend the NDV function to accept a precision .. Patch Set 39: Build Successful

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 10: Verified-1 Build

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-2658: Extend the NDV function to accept a precision

2020-06-24 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#39). ( http://gerrit.cloudera.org:8080/15997 ) Change subject: IMPALA-2658: Extend the NDV function to accept a precision .. IMPALA-2658: Extend the NDV function to accept a precision

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

2020-06-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16073 ) Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7020: fix costing of non-trivial CAST expressions

2020-06-24 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16073 to look at the new patch set (#4). Change subject: IMPALA-7020: fix costing of non-trivial CAST expressions

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. IMPALA-9747: More fine-grained

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 13: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-24 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16000 to look at the new patch set (#8). Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate()

[Impala-ASF-CR] IMPALA-8738: "show extended tables" to return more than the table name

2020-06-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/14422 ) Change subject: IMPALA-8738: "show extended tables" to return more than the table name .. Abandoned This hasn't had any activity in

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2020-06-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Abandoned We can re-open a new review if we decide

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-24 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16000 to look at the new patch set (#7). Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate()

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-24 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 6: (11 comments)

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 41: Build Successful

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. Patch Set 41: (1 comment)

[Impala-ASF-CR] IMPALA-5444: Asynchronous code generation

2020-06-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#41). ( http://gerrit.cloudera.org:8080/15105 ) Change subject: IMPALA-5444: Asynchronous code generation .. IMPALA-5444: Asynchronous code generation This commit introduces optional

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 10: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 9: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 13: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. IMPALA-9747: More fine-grained codegen for text file

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-9747: More fine-grained codegen for text file scanners

2020-06-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/16059 ) Change subject: IMPALA-9747: More fine-grained codegen for text file scanners .. IMPALA-9747: More fine-grained codegen for text file

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-06-24 Thread Zoltan Borok-Nagy (Code Review)
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16001 to look at the new patch set (#8). Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

2020-06-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 ) Change subject: IMPALA-8755: Unlock Z-ordering by default .. Patch Set 4: No worries, it wasn't too important. It's good that

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

2020-06-24 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 ) Change subject: IMPALA-8755: Unlock Z-ordering by default .. Patch Set 4: Sorry, didn't notice your comment, Zoltán. Will move the

[Impala-ASF-CR] IMPALA-9569: Show progress bar and live summary of the retried query

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16096 ) Change subject: IMPALA-9569: Show progress bar and live_summary of the retried query .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9213: Add query retry info to GetLog result

2020-06-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16093 ) Change subject: IMPALA-9213: Add query retry info to GetLog result .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-9569: Show progress bar and live summary of the retried query

2020-06-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16096 ) Change subject: IMPALA-9569: Show progress bar and live_summary of the retried query .. Patch Set 5: Fixed an issue that the retry

[Impala-ASF-CR] IMPALA-9213: Add query retry info to GetLog result

2020-06-24 Thread Quanlong Huang (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16093 to look at the new patch set (#6). Change subject: IMPALA-9213: Add query retry info to GetLog result

[Impala-ASF-CR] IMPALA-9569: Show progress bar and live summary of the retried query

2020-06-24 Thread Quanlong Huang (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16096 to look at the new patch set (#5). Change subject: IMPALA-9569: Show progress bar and live_summary of the retried query