[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-10198: Unify Java code under the $IMPALA HOME/java directory

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16500 ) Change subject: IMPALA-10198: Unify Java code under the $IMPALA_HOME/java directory .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-29 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

[Impala-ASF-CR] IMPALA-9711: incrementally update aggregate profile

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15931 ) Change subject: IMPALA-9711: incrementally update aggregate profile .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-9711: incrementally update aggregate profile

2020-09-29 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15931 to look at the new patch set (#10). Change subject: IMPALA-9711: incrementally update aggregate profile

[Impala-ASF-CR] IMPALA-9711: incrementally update aggregate profile

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15931 ) Change subject: IMPALA-9711: incrementally update aggregate profile .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-9180 (part 2): Refactor executor list map of ExecuterBlacklist

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16506 ) Change subject: IMPALA-9180 (part 2): Refactor executor_list_ map of ExecuterBlacklist .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 20: gerrit-verify-dryrun failed, I got some message

[Impala-ASF-CR] IMPALA-9180 (part 2): Refactor executor list map of ExecuterBlacklist

2020-09-29 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16506 ) Change subject: IMPALA-9180 (part 2): Refactor executor_list_ map of ExecuterBlacklist .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 33: Build Successful

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 32: Build Successful

[Impala-ASF-CR] IMPALA-10198: Unify Java code under the $IMPALA HOME/java directory

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16500 ) Change subject: IMPALA-10198: Unify Java code under the $IMPALA_HOME/java directory .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-10198: Unify Java code under the $IMPALA HOME/java directory

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16500 ) Change subject: IMPALA-10198: Unify Java code under the $IMPALA_HOME/java directory .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-29 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#33). ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. IMPALA-10178 Run-time profile shall report skews This fix addresses

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-29 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#32). ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. IMPALA-10178 Run-time profile shall report skews This fix addresses

[Impala-ASF-CR] IMPALA-10198: Unify Java code under the $IMPALA HOME/java directory

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16500 ) Change subject: IMPALA-10198: Unify Java code under the $IMPALA_HOME/java directory .. Patch Set 3: (87 comments)

[Impala-ASF-CR] IMPALA-10198: Unify Java code under the $IMPALA HOME/java directory

2020-09-29 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16500 to look at the new patch set (#3). Change subject: IMPALA-10198: Unify Java code under the $IMPALA_HOME/java directory

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 6: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. IMPALA-9930 (part 1): Initial

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 1: The code change looks good, i think looping

[Impala-ASF-CR] IMPALA-9180 (part 2): Refactor executor list map of ExecuterBlacklist

2020-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16506 ) Change subject: IMPALA-9180 (part 2): Refactor executor_list_ map of ExecuterBlacklist .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 1: I would tentatively assume that it's fixed. I

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 12: Verified-1 Build failed:

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Fix extra semicolon in LocalIcebergTable This caused

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 1: @Tim - do you remember the source of the hangs

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16521 Change subject: IMPALA-3335: Allow single-node optimization with joins .. IMPALA-3335: Allow single-node optimization with joins Enable

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. IMPALA-10196: Remove

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9711: incrementally update aggregate profile

2020-09-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15931 ) Change subject: IMPALA-9711: incrementally update aggregate profile .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 31: (2 comments)

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 19: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 5: Code-Review+2 Sahil already

[Impala-ASF-CR] IMPALA-9180 (part 1): Remove legacy ImpalaInternalService

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16291 ) Change subject: IMPALA-9180 (part 1): Remove legacy ImpalaInternalService .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-10189: don't reload partitions for stat operations

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 1: (2 comments) I had a suggested alternative

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10062: TestCompressedNonText.test insensitivity to extension can fail due to wrong filename

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16518 ) Change subject: IMPALA-10062: TestCompressedNonText.test_insensitivity_to_extension can fail due to wrong filename .. Patch Set 1:

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10189: don't reload partitions for stat operations

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 2: Ah I missed the comments, I had pushed out

[Impala-ASF-CR] IMPALA-10189: don't reload partitions for stat operations

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 2: This is ready for review now -- To view,

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16519 Change subject: Fix extra semicolon in LocalIcebergTable .. Fix extra semicolon in LocalIcebergTable This caused errors in my Eclipse

[Impala-ASF-CR] Fix extra semicolon in LocalIcebergTable

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed Kurt Deschler from this change. ( http://gerrit.cloudera.org:8080/16519 ) Change subject: Fix extra semicolon in LocalIcebergTable .. Removed reviewer Kurt Deschler. -- To view, visit

[Impala-ASF-CR] IMPALA-10189: don't reload partitions for stat operations

2020-09-29 Thread Tim Armstrong (Code Review)
Hello Kurt Deschler, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16516 to look at the new patch set (#2). Change subject: IMPALA-10189: don't reload partitions for stat operations

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP: IMPALA-10189: don't reload partitions for stat operations

2020-09-29 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 ) Change subject: WIP: IMPALA-10189: don't reload partitions for stat operations .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#2). Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 19: Build started:

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 4: Verified+1 --

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. IMPALA-9923: Load ORC

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 18: Code-Review+2 Thanks for applying the

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 18: (6 comments) Thanks for review, Zoltan. I

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-29 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. IMPALA-10164: Supporting HadoopCatalog for Iceberg table This

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

[Impala-ASF-CR] IMPALA-10062: TestCompressedNonText.test insensitivity to extension can fail due to wrong filename

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16518 ) Change subject: IMPALA-10062: TestCompressedNonText.test_insensitivity_to_extension can fail due to wrong filename .. Patch

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10062: TestCompressedNonText.test insensitivity to extension can fail due to wrong filename

2020-09-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16518 Change subject: IMPALA-10062: TestCompressedNonText.test_insensitivity_to_extension can fail due to wrong filename ..

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 3: Code-Review+2 Carry

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 ) Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query' .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

2020-09-29 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16511 to look at the new patch set (#3). Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'

[Impala-ASF-CR] IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr

2020-09-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 ) Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 1: (3 comments) Hi Gabor,