[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 6: Code-Review+2

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 6: Build started

[Impala-ASF-CR] IMPALA-10652: Optimize the checking of the size of incremental stats

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17299 ) Change subject: IMPALA-10652: Optimize the checking of the size of incremental stats .. Patch Set 4: Build Successful https:

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 5: retest -- To view, vis

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 21: retest -- To view, visit http

[Impala-ASF-CR] IMPALA-10652: Optimize the checking of the size of incremental stats

2021-04-14 Thread liuyao (Code Review)
liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17299 ) Change subject: IMPALA-10652: Optimize the checking of the size of incremental stats .. Patch Set 4: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-10652: Optimize the checking of the size of incremental stats

2021-04-14 Thread liuyao (Code Review)
Hello Aman Sinha, Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17299 to look at the new patch set (#4). Change subject: IMPALA-10652: Optimize the checking of the size of incremental stats ...

[Impala-ASF-CR] IMPALA-10631: Upgrade DataSketches to version 3.0.0

2021-04-14 Thread Fucun Chu (Code Review)
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17294 ) Change subject: IMPALA-10631: Upgrade DataSketches to version 3.0.0 .. Patch Set 4: All tests run with the pre-review-test job passed, see

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 7: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. IMPALA-10645: Log catalogd HMS API metrics Expose rpc duration, cach

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1728

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Sourabh Goyal (Code Review)
Hello Quanlong Huang, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17298 to look at the new patch set (#5). Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 ) Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. Patch Set 5: Verified-1 Build failed: https://jenkins.imp

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Se

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Sourabh Goyal (Code Review)
Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch Set 4: (2

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-14 Thread Sourabh Goyal (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17298 to look at the new patch set (#4). Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: > Patch Set 6: > > (8 comments) >

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: Build Successful https:/

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: (8 comments) Patch set 5 change t

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 4: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17195 to look at the new patch set (#6). Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pa

[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has abandoned this change. ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9287: Add support for embedded metastore mode .. Abandoned I am not actively working on this patch anymore. -- To

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has abandoned this change. ( http://gerrit.cloudera.org:8080/13922 ) Change subject: IMPALA-8795 : Enable event polling by default in tests .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/1392

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has abandoned this change. ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. Abandoned I don't think this patch is actively bei

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. IMPALA-10645: Log catalogd HMS API metrics Expose rpc duration, cach

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/172

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 2: (26 comments) Sorry for the formatting errors. Hopef

[Impala-ASF-CR] IMPALA-10502: Handle CREATE/DROP events correctly

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 ) Change subject: IMPALA-10502: Handle CREATE/DROP events correctly .. Patch Set 3: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-10502: Handle CREATE/DROP events correctly

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17308 ) Change subject: IMPALA-10502: Handle CREATE/DROP events correctly .. Patch Set 3: (33 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-10502: Handle CREATE/DROP events correctly

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17308 Change subject: IMPALA-10502: Handle CREATE/DROP events correctly .. IMPALA-10502: Handle CREATE/DROP events correctly The curren

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: (1 comment) s http://gerrit.cloud

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 1: Verified+1 -- To v

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 ) Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. Patch Set 4: Build Failed https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 21: Verified-1 Build fai

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 ) Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. Patch Set 3: Build Failed https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 5: Verified-1 Bu

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 ) Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. Patch Set 5: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17170 to look at the new patch set (#4). Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. WI

[Impala-ASF-CR] IMPALA-10657: Remove accidental usage of shaded imports

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17314 ) Change subject: IMPALA-10657: Remove accidental usage of shaded imports .. Patch Set 2: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-10657: Remove accidental usage of shaded imports

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17314 ) Change subject: IMPALA-10657: Remove accidental usage of shaded imports .. IMPALA-10657: Remove accidental usage of sha

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 ) Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. Patch Set 3: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] WIP IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17170 ) Change subject: WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 .. WIP IMPALA-7825: Upgrade Thrift version to 0.11.0 Before this pat

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 1: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-10654: Fix precision loss in DecimalValue to double conversion.

2021-04-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17303 ) Change subject: IMPALA-10654: Fix precision loss in DecimalValue to double conversion. .. Patch Set 5: (4 comments) The change l

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 6: Code-Review+1 (4 comments) Looked at the backend,

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 15: Resolved assert problem in newly added unit tests.

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 15: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 14: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 14: (4 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 13: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: (8 comments) http://gerrit.cloud

[Impala-ASF-CR] WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types

2021-04-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17262 ) Change subject: WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types .. Patch Set 3: (7 comments) http:

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 13: (7 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 6: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-10652: Optimize the checking of the size of incremental stats

2021-04-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17299 ) Change subject: IMPALA-10652: Optimize the checking of the size of incremental stats .. Patch Set 3: Code-Review+1 (2 comments) Looks g

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17313 to look at the new patch set (#6). Change subject: IMPALA-10656: Fire insert events before commit .

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 1: Build Successful h

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 12: Code-Review+1 Looks good! -- To view, visit http://

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: Code-Review+1 (1 comment) Looks good

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 1: Build started: http

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17316 Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. IMPALA-10658: LOAD DATA INPATH silentl

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 21: Build started: https

[Impala-ASF-CR] IMPALA-10657: Remove accidental usage of shaded imports

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17314 ) Change subject: IMPALA-10657: Remove accidental usage of shaded imports .. Patch Set 2: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 5: Build started

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 21: > Patch Set 21: > > Build sta

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 5: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 4: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17313 to look at the new patch set (#5). Change subject: IMPALA-10656: Fire insert events before commit .

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. Patch Set 4: PS 4 fixes the issue found during the jenkins tests.

[Impala-ASF-CR] IMPALA-10656: Fire insert events before commit

2021-04-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17313 ) Change subject: IMPALA-10656: Fire insert events before commit .. IMPALA-10656: Fire insert events before commit Before this fix Impal

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-04-14 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. Patch Set 25: Code-Review+1 Thanks everyone,

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 11: Build Failed https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-10645: Log catalogd HMS API metrics

2021-04-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 ) Change subject: IMPALA-10645: Log catalogd HMS API metrics .. Patch Set 2: (25 comments) http://gerrit.cloudera.org:8080/#/c/17284/2